From patchwork Wed Apr 5 09:43:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 125796 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBE17428D1; Wed, 5 Apr 2023 11:43:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7002941153; Wed, 5 Apr 2023 11:43:41 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id C654C41151 for ; Wed, 5 Apr 2023 11:43:39 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3359NKfQ027597; Wed, 5 Apr 2023 02:43:39 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=xNIIdBTxKtsS/0TLKkHoJhgb0jZHb4m4R02WnyVYK9Y=; b=NrvUzf5Yy+LJBNBuxOo5jEZ6OMegb3TMib/0iQNbVz4XIAZcJgu9Pz2QfK1KyIYNLrVJ HByKDYcVcUnaN8NXuJQEvzQx3Z/4yO1iNezzuz+ran5J5S26QMQTN3L5vbWJ1ZB5Jo7n K6zJQ3RbspI/uTrWGeMNOKvZDmF5C7qMxHQfas2HGDbOmvVahat1ihHU3trEs73UNcIR o64yWtRDNJonE80tuio9RbAN6AvCjcZDO6J+d1cACuG9HZkcYyd0Kec46MCwkn7xH58l m19mkJYSYKzTVpie/eOAHLV8DFpbZcrrSSPcJb8HQPLUnIPPdJ83ZoypPuktiHyoY/6N VQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3prpnd491f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 05 Apr 2023 02:43:39 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 5 Apr 2023 02:43:37 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Wed, 5 Apr 2023 02:43:37 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.23.86]) by maili.marvell.com (Postfix) with ESMTP id 858A43F707F; Wed, 5 Apr 2023 02:43:35 -0700 (PDT) From: To: , Naga Harish K S V CC: , Pavan Nikhilesh Subject: [PATCH v2] eventdev/eth_rx: fix invalid memory access Date: Wed, 5 Apr 2023 15:13:32 +0530 Message-ID: <20230405094332.2862-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230405093959.2052-1-pbhagavatula@marvell.com> References: <20230405093959.2052-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: re8Npm1aQriV23pKy5cPNXAg3Uc7n8K6 X-Proofpoint-GUID: re8Npm1aQriV23pKy5cPNXAg3Uc7n8K6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-05_06,2023-04-04_05,2023-02-09_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Rx adapter internal service structures are only initialized when non-internal port is added to the adapter. Check if Rx adapter service is initialized to determine if runtime set/get parameters are supported. Fixes: 3716f52186af ("eventdev/eth_rx: support runtime set/get parameters") Signed-off-by: Pavan Nikhilesh --- v2 Changes: ---------- - Remove unused variables. - Fix spell check. app/test/test_event_eth_rx_adapter.c | 2 ++ lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++++-------------------- 2 files changed, 6 insertions(+), 20 deletions(-) -- 2.25.1 diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c index cfe6052d7e..b1775e6af1 100644 --- a/app/test/test_event_eth_rx_adapter.c +++ b/app/test/test_event_eth_rx_adapter.c @@ -1230,6 +1230,8 @@ adapter_get_set_params(void) /* Case 1: Get the default value of mbufs processed by Rx adapter */ err = rte_event_eth_rx_adapter_runtime_params_get(TEST_INST_ID, &out_params); + if (err == -ENOTSUP) + return TEST_SKIPPED; TEST_ASSERT(err == 0, "Expected 0 got %d", err); /* Case 2: Set max_nb_rx = 32 (=BATCH_SEIZE) */ diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index c1cd124002..a8a5564b65 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -3466,30 +3466,14 @@ rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id, static int rxa_caps_check(struct event_eth_rx_adapter *rxa) { - uint16_t eth_dev_id; - uint32_t caps = 0; - int ret; - if (!rxa->nb_queues) return -EINVAL; - /* The eth_dev used is always of same type. - * Hence eth_dev_id is taken from first entry of poll array. - */ - eth_dev_id = rxa->eth_rx_poll[0].eth_dev_id; - ret = rte_event_eth_rx_adapter_caps_get(rxa->eventdev_id, - eth_dev_id, - &caps); - if (ret) { - RTE_EDEV_LOG_ERR("Failed to get adapter caps edev %" PRIu8 - "eth port %" PRIu16, rxa->eventdev_id, eth_dev_id); - return ret; - } - - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) - return -ENOTSUP; + /* Check if there is at least one non-internal ethernet port. */ + if (rxa->service_inited) + return 0; - return 0; + return -ENOTSUP; } int