From patchwork Tue Dec 11 13:14:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 48635 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2A20D4CC7; Tue, 11 Dec 2018 14:14:36 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 868B54CAB for ; Tue, 11 Dec 2018 14:14:34 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id wBBDA31H006483; Tue, 11 Dec 2018 05:14:33 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=fYhRyx7qkiAGMlptx+NkbtieucP9XVD3tMcoSk8d2c4=; b=npGCSf5VWcClu4Yz5idapEgcsJbBtWihWU3PaM8Mg3+ec5gD7UqjDucXYPQUzNgZgAjx YgL4W7WgnyY2DowPa4w+OpdNkFjfhpLRvR4pE4GgfsZ9xQ3qwYT2vUwedX2Uc9SWYYn/ jgTT0TgiGy9h1YtrmLuvABDZSYiS68VIWWtos75f2VI6aNO8nByUSEWigFZdWGLHmH8N fO1qLzz0RJixwIa8laX/Jz3iOqZLEgXnL83vIE47+bJv5S+epk7E3RE4v05KYgI5pf4O QFacHRzmgpw5SimQDjppnJFup8lCL8PfWGVJyXt9g+ehSXQiujcMX5681cL+yyu7GHpd SA== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 2pa8b39fq3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 11 Dec 2018 05:14:33 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 11 Dec 2018 05:14:32 -0800 Received: from NAM05-BY2-obe.outbound.protection.outlook.com (104.47.50.58) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 11 Dec 2018 05:14:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYhRyx7qkiAGMlptx+NkbtieucP9XVD3tMcoSk8d2c4=; b=LsRX8Umoh6Mu4hh4ui+LTFX8TEiNpfbrOfOCYzOtdE4X+o5cr1XQoE4TotJVUDUB8nSGpz6RbEM3WevaO07gvCB8kYUISMPwqasVhGt9nS8KY9uZSa3TnrCNikr2rgt76c6pdeDDDz+jSqITwckmo7cocNxtKhq3TCkM23SV8U0= Received: from DM5PR18MB2230.namprd18.prod.outlook.com (52.132.143.153) by DM5SPR00MB79.namprd18.prod.outlook.com (10.168.199.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.18; Tue, 11 Dec 2018 13:14:30 +0000 Received: from DM5PR18MB2230.namprd18.prod.outlook.com ([fe80::d03e:1daa:3be9:6e4b]) by DM5PR18MB2230.namprd18.prod.outlook.com ([fe80::d03e:1daa:3be9:6e4b%4]) with mapi id 15.20.1425.016; Tue, 11 Dec 2018 13:14:30 +0000 From: Harman Kalra To: "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" CC: "dev@dpdk.org" , Jerin Jacob Kollanukkaran , "marko.kallio@cavium.com" , Harman Kalra , Kallio Marko Thread-Topic: [PATCH] raw/skeleton: fix segmentation fault on rawdev_autotest Thread-Index: AQHUkVNzn/AOuz7Xf0+3RU1X3s9c/A== Date: Tue, 11 Dec 2018 13:14:30 +0000 Message-ID: <20181211131412.14232-1-hkalra@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: PN1PR0101CA0005.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00:e::15) To DM5PR18MB2230.namprd18.prod.outlook.com (2603:10b6:4:b9::25) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5SPR00MB79; 20:1spDAPkJQa67Bz0sZkteXaDccaiUtP/iqHtaFUOPGiIAHRip59AyK+LGxhlXjjQvXfQVpw4rXwEdN+dDDY45XzyfeLQKwXvuJ+EnWzP9zReVUVkHXqAci7fb/sanx6fNlbt85A8YJE+S7V25/9EtR0Sbd1y9+Fbhj4lXzkw+z8Y= x-ms-office365-filtering-correlation-id: 08ea2eb3-a5f3-4aef-86bc-08d65f6a9589 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM5SPR00MB79; x-ms-traffictypediagnostic: DM5SPR00MB79: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231455)(999002)(944501520)(52105112)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123560045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:DM5SPR00MB79; BCL:0; PCL:0; RULEID:; SRVR:DM5SPR00MB79; x-forefront-prvs: 08831F51DC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(136003)(366004)(376002)(39840400004)(396003)(189003)(199004)(36756003)(86362001)(256004)(2501003)(14454004)(66066001)(97736004)(110136005)(316002)(102836004)(186003)(55236004)(6506007)(26005)(386003)(54906003)(99286004)(476003)(52116002)(486006)(2616005)(71190400001)(5660300001)(8936002)(81156014)(8676002)(81166006)(71200400001)(6486002)(6436002)(4326008)(305945005)(105586002)(106356001)(478600001)(6116002)(1076002)(3846002)(53936002)(6512007)(7736002)(68736007)(25786009)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5SPR00MB79; H:DM5PR18MB2230.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: V5aZapSHpzjCHi675tOr10WycM7RYHh9DXHupZqqwSLJpegJDR0fU1SltDX2Rg+/BEgcym/xk2ZWJnRGXXOOTWUVpaELEPsFeKGZK6EUb3kqOBme4kPCr0NuDOGgXYqGMd/kHbNrBqOMaMZPOGhfEjn/Yb2PbM/FSTrAQ2LOj/h/6tUacpeavYQhxIVj4svX//R5LyKSQt4H2oDmD3p6cgbzmt0zNuGjs1efkQWhUKDCX76QkRGxj86u++dpsUMGNa7ukmMEKnsZY/kEhXZ4xr3btrc/DGtiInju+fAOSxomboDnd7ErZL/db/8a8WQ/ spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 08ea2eb3-a5f3-4aef-86bc-08d65f6a9589 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2018 13:14:30.2306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5SPR00MB79 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-12-11_04:, , signatures=0 X-Proofpoint-Details: safe Subject: [dpdk-dev] [PATCH] raw/skeleton: fix segmentation fault on rawdev_autotest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" segmentation fault ocured as vdev->device.driver->name did not return correct value. Test2 failed as dummy_value was freed before it was used. Signed-off-by: Kallio Marko Signed-off-by: Harman Kalra --- drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 3 ++- drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c index d7630fc69..c957ced11 100644 --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c @@ -585,7 +585,8 @@ skeleton_rawdev_create(const char *name, rawdev->dev_ops = &skeleton_rawdev_ops; rawdev->device = &vdev->device; - rawdev->driver_name = vdev->device.driver->name; + + rawdev->driver_name = rawdev->name; skeldev = skeleton_rawdev_get_priv(rawdev); diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c index 359c9e296..788c3f1b9 100644 --- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c +++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c @@ -294,14 +294,14 @@ test_rawdev_attr_set_get(void) "Attribute (Test1) not set correctly (%" PRIu64 ")", ret_value); - free(dummy_value); - ret_value = 0; ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value); RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200, "Attribute (Test2) not set correctly (%" PRIu64 ")", ret_value); + free(dummy_value); + return TEST_SUCCESS; }