From patchwork Tue Feb 21 10:35:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124288 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E0C841CFC; Tue, 21 Feb 2023 11:35:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F801431C1; Tue, 21 Feb 2023 11:35:38 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2116.outbound.protection.outlook.com [40.107.95.116]) by mails.dpdk.org (Postfix) with ESMTP id 48CA4431BA; Tue, 21 Feb 2023 11:35:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AjKow+62754CIR7rPCgbJsK4kUjeqZioRpIASaNCGD4E1ikpbNQHlAKtMQ0YPxPDRSsHB/sM3I5PHo9x8z4yvZYALmNHMfXuEzmltI26HOBh3+mImozp/nUTQsuUfW6ptKtZSkBoLOTaBlZxPPwppQsYY7Hux6dY9H+Ohv5BPN3yJNOUHeFg6xNu/bieTrYtFQEZGPtbN0TYjeO8EUHk2evQTn44Wla0P5D5Zp7lDD6DZww2nxOVjY+jQiCY2z0Fy7wFv1zX1cgHxgqkli/GqeTPwz3eFLKJ5BK8TdnDPMQinF/w5nULu6ns/pmob2cW1i6d+TR4eQcRPr75jing7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pr3Uu3+nnFy1Bw7famyLt7Po46TSxwTd3aayVNWvKlI=; b=Dd9ww7Za3y/d70zmWcmyd6+tqwUHoXedBDahAsJsxleva5yVh5IzXDSbhi/Z5YZYVgNZl4zjpmYdkvHfF0hfvuuwpaP0/j0PI8Jl/jZ+/qvLgCWhndyXlpF1D3Mzg9Je8zIY8lpqldS+0ZIWqhMxFk0BpLB+LPIqkRA9+/LlphzlVBj30o8xuVfoDlJL+fXAUBo5ma0GHfrWGQkZxclnbjQdRsg5w+QgQRQYr4pvL4f2qw7J/uuTiULwJ7Rj8UEB/yQRG+W9ixn8tihoZsUAPYY1YNoGTd8cmNtB9zOCzWcKVe8V0FjTO84tbxzoryJxQuSby96eazcxWvGjjZBC/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pr3Uu3+nnFy1Bw7famyLt7Po46TSxwTd3aayVNWvKlI=; b=OSQl77EEJDiBfit0dz1whAGYEgQ5gxBVui5OXl/WTZzNF6cajoqyMXiP4ySq0lnTjdJtLMS4PyOKgZH/a335BVj8WQl2juA++Yk8MCKKlJALf+GaYq71aVxe4sNhiuA/IGQwgbcQZVYxa6eBPkb1kZ9zgCpDjOJkVyiYGB9VB1U= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:32 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:32 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 1/6] net/nfp: fix the set MAC flow action Date: Tue, 21 Feb 2023 18:35:08 +0800 Message-Id: <20230221103513.412-2-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 97e25a94-f45d-46ec-a016-08db13f75bf9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Lh3fZwtfNJAkLyCplzzB/kgYDB8ed6rYGS79xcVU6RZCs5K3YF79DAKLlLjwtvrbOhonAql9z/z1rsfxtnbBdaQC9Wus/JVltLLYzAczQFuoTg0/gmbb5Wrsd8cwPX+wvTpCu55HOcU5Y9yOY8d8Mn+B4FAW6WjtTkmBfpaCS1jmDpTe9zvLC97q8OmKqKrL6/QB7Q8DNZ/L33ko1J6GSk0buLETDTRVdxKRntv7HpXScyJVtGH8SU2H8+05TkxKkVxaNtGxeojUVidz2qKw5m3E47cLP04TBsp7cnUh8LEgbqo6dOap8vvATTqQLE7g76xyplfgeaqP1W8YFJnUGB2IGN8yxK0n91TQsmxuE2+DkKa2PgAYKWcPFmc6uatxjBN1vvoCxBMYFX/rAlEn3KPYNnltOrWpzroYqE5IGop7qm0T9eSRn8+NNK6Evn5qepDRolJShvAPET3am3HJf53/AFkvjsz43R2wUnZuXD+EGrFS/hj8IxukLRMR7x1nlOUZJPuqTY0f/Jn0qQTcHeZuJf4DvjlzHhs01I0Y34hu46D59QGVh4P9k93Xk/MglA+jpSGzBpvCNgGJbsLP6lbngG3gIRt2DaPvjiTY2PYf9oGw7rRTsUgg1D/huDqjDL8CmyqOfhBq2aP7UxtUVg7da1osbx6U2yDWEU4cbm6d/FKY0YnrDUIoiRBTGIfFhum9G87/Wbg3TSQ8XLDRDA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?sVqOA3YHjIXjdTyUe1+sgfcLjaHz?= =?utf-8?q?0JK7oSBP9SB6bnYax0gyLgPY+nvyKHkHPUlYoE5MDkmY/au25hQ6rFwzZOl5quCrx?= =?utf-8?q?poZVMowc6ozVuy4dMshl9ib+3cuIQji3ceH/OKhgPxF9A/P8v8UpAs+2JKMvbmw1F?= =?utf-8?q?2J5hS4ChgHEDF08OEup+XoHYFEanb+6utPSByB3VSMnTrYZydDvNCswaJ33Lx0wPF?= =?utf-8?q?XbOXORDUQw2fyvYSgDde2Ph3/R5b4jde7ZvMBIsyEBDHb0hyu8T1W5Ur0FSc5oEaL?= =?utf-8?q?FX4QBuTAUO5VAadvZIQK0Inmj1TgCk3jWPPbA8lOinlscxNjq9/HmZZGcZUAicWw6?= =?utf-8?q?Aj8Y1jrxI8iWgAankfTFfYgkYUxZeWehOuCKXSY7i68ZgoRWwcFJhjMGav4LmsLw3?= =?utf-8?q?gBVpNClYwh3PlHc8wV9e1TairCvwUIrTFg0H3q829pSkEpj4uTDCoKsVNwOOoqwuP?= =?utf-8?q?U0pNGSD2HIeLZZECbpnFt6t027y/mPetNnvU19GUHDjyZia7kNUizJp6TCslQ8zYF?= =?utf-8?q?QMi7C1rRkTV7QhssJgEhQIqUQmNp+f/F9fnZ7OdGB949nZzFOS0vGvOoOddHHkuD1?= =?utf-8?q?iETV1KBUJqZ31g8qsDpAD89ZbfUlaYObpuklL4sJtHpJViXTB1xiEFL0Md/1nZGuT?= =?utf-8?q?wOsZ3IvEHvX/3y1WPfaN88SHMVXHNlFdz9M0bEtkaerGTK6p+rZrQqnDnNDltqxLs?= =?utf-8?q?YiZm9b93tgWVceIj78gVI1oinr5UWntTZp1EGa0mi3BIXU2Y2f4bBab/bp0UB+X/X?= =?utf-8?q?wzfnwR9ypJcmBnTe2McLH9kofSpfbGPVcLimmJhhbAr02UjYPBIR18AvPprAA+0K+?= =?utf-8?q?OORQEsisJrnYBpZRVTeKUZvyKfsIVs+PO0qKMu1ZEPMcxudkHsaX0MzB3lKnV7lty?= =?utf-8?q?H+Ea3/S05DFGLDrJOgEaVNmXpce/E0WB2rXjU+NxDsTEIquK7zIpdk+/E50d5Jj5E?= =?utf-8?q?TzzAEnJr0Xj+X5Vml/hD5nx6y9HKgCVIk94oU3hIH+HjnAapnEi0EypWwQ9djAhTg?= =?utf-8?q?9aPA81sSLULw4QmaUf49HPVicPJCD5B+y2W68FVLRjiJlSH4JcLuoNLwOHDE3V2Ta?= =?utf-8?q?bM5Dhq6OnoKIZCOrVrVlJRlBKtZ39noE5pOMnzPm8DhVYPto+u9fzy0ux4kXy1gOf?= =?utf-8?q?yEUtUSzipniegwckeeDB7NsGFuq9Wq9T1FOlmLBgsM8tiZoWavLGE6eFgQcy2fcTV?= =?utf-8?q?+F4DsFIXIB561YQN5fVKU2+Dk+hgiVBLvC+Rdsmk2CsGMnUadR+dmtoF5pRPLcWVI?= =?utf-8?q?wI6NS+ecMS5DxcP6Qh6BLRBrnN+VQu/oNZacPXYsZyruCr1526GJwIk7Ogdy+sfPq?= =?utf-8?q?QigPSbdXg/HwqTCreyhCL5/i7Txr93ffyEQMwX7PhnE9SIuoNegx6+mHh+2Y+3B6n?= =?utf-8?q?KE/pmraXYeZ77fNU3cNju+9ACJX3DA1ynOCar/Ji/1lsspUlJ2ZRVSDoxGnKwgr7V?= =?utf-8?q?5sBGHQka3TiouBHEnCVz5HnKGJtMZnQO1ly2ehsB7ZqCY09OMTpYiskmRdn9QcJ1c?= =?utf-8?q?t7bWCvpKkJ84sadzO4V2cnDj9240Xyx09w=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97e25a94-f45d-46ec-a016-08db13f75bf9 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:32.6805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jmwB00GrGcBCGs1hbOaYT4mYlvhdiHI7rgzbkbJRmxX3DvgZLY5YxZtddhGlbT3LyPOpjfPGBZqR2VgxF2KkchcYrjiqBzl9c0TRHzRsaKs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set MAC source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right MAC address as expected. Fixes: 4f6983154570 ("net/nfp: support MAC source flow action") Fixes: eecc7ca3088a ("net/nfp: support MAC destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 0c38925701..f373171d7e 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2066,6 +2066,7 @@ nfp_flow_action_set_mac(char *act_data, bool mac_src_flag, bool mac_set_flag) { + uint8_t i; size_t act_size; struct nfp_fl_act_set_eth *set_eth; const struct rte_flow_action_set_mac *set_mac; @@ -2084,9 +2085,13 @@ nfp_flow_action_set_mac(char *act_data, if (mac_src_flag) { rte_memcpy(&set_eth->eth_addr[RTE_ETHER_ADDR_LEN], set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) + set_eth->eth_addr_mask[RTE_ETHER_ADDR_LEN + i] = 0xff; } else { rte_memcpy(&set_eth->eth_addr[0], set_mac->mac_addr, RTE_ETHER_ADDR_LEN); + for (i = 0; i < RTE_ETHER_ADDR_LEN; i++) + set_eth->eth_addr_mask[i] = 0xff; } } From patchwork Tue Feb 21 10:35:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124289 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B16A241CFC; Tue, 21 Feb 2023 11:35:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8B364431C4; Tue, 21 Feb 2023 11:35:39 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2093.outbound.protection.outlook.com [40.107.95.93]) by mails.dpdk.org (Postfix) with ESMTP id A75E0431BF; Tue, 21 Feb 2023 11:35:36 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VgRcAhx/vXSTZcqr/8KKvyievnqeUzBCyK2ZRy7Go+oNw3aOr2sNuMvGx4iKAKZ6BbyrM3owgr4jB8z30Vq5DwQSPqI5rhErIDNAprPgfIUjvwBBENaXNbWRrSELevhJXYtDl2k0RuZODSt5C95jx7/K3kHBLwi4DSstHntxFV5G/2jh/d6xK62s5HDKFqyxNL7praD899Dn5EZojHyfFzQUITvJcKRMyQZKCb2ScUMSsyAm5TtCZa/qzdmDJVroSJlD4U2xDC6yIGthJw0nDb91An9vvmbzUj/IawvjTCHM7+X3Z7ZWfAmsjffiWCN0iiMeBev6xU6J6uiz/MjNfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wspGSCkYs5t536mMdZWzrpuZxnz0X1pOXyGsHWpIElU=; b=ZZdQGPYE7lqiz9d7Jp7p9p822JSvTdJTm6WUBl17vLbCHaQuMx3b85fmznpKnlULeTbnazyyq9eXLlXlw/8tPG1lDPPIMdrlKczBQc325Lc+kjc5llzphmXB1io2HksDNatJcBC6JJUV0slkV3Hg6Yfu/s0OuglLDeiWWhXfNwrXbn1B0ynsWYo2dvdyl/gnPcBgNZgLDF4MaooWb3yjp/epZLgUVMI7wibrBBjgXf4qWlJBvte0xgzTuWTLrihRXAfNGTci8HfINKmRwXkcxNRZy0nUZhCkpL6gpeOhbeVParJjM8OVr/PI5YPSCjBFEfLBVEe+MUlabhTZMdFypQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wspGSCkYs5t536mMdZWzrpuZxnz0X1pOXyGsHWpIElU=; b=ZWcaL7B5BQ/vjrkjrA0ElBWvPzg+I6CUpYKGBfMPvty8fjWtBCaDmcyF2sF7avveyK2H4BdIawJwHS9rdZ19yj47uk4ZBdv/bZ8CEASc/YrcDT8N0Pt65UpPx6ujcIsUGsqS5sGuizMZArlMbPhG56AwJ0YOE2SvyKpv78oBiz8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:35 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:35 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 2/6] net/nfp: fix the set IPv4 flow action Date: Tue, 21 Feb 2023 18:35:09 +0800 Message-Id: <20230221103513.412-3-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 19bbeea5-3555-43a5-73c4-08db13f75d53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sbY1yBokdEvOUa8te0zSIYM8waMBTaAAaJnAr8+b+5KNDz2RjsC7lFF6CgIIbAONqu+PB0Ed75VytcbQv6+mNM07ImgKv4LvTgabLUrrVk0Zp/G7U6c54+HXJqzmx1neQILbMO8vWS89GF9kZA50tMDHVXL0OTz1Gs2QNdAStSJLHeU3UAcekrna2oP/KqeNeGnMhGElztQjsFjlDs885v4/fX+gg8zJFlA3LLftcakXuJpfYr3qpJdnIOEszxKu047pfcSfKvl4GqzE5dq4nw7tjiuV7qXhREE+UvaQtYaluGk+YnxppeJtxzl6ubLdFIZYvQDRdxGbVjcWNuGVN4pxnKSYj3ROX7KHpP0WeZviOImretVaB7if28Awsc1dgp2aATrn88ECotX5jn3mwR9JatD2swNG5SXJZpC1PoEXZBFixXHzdmHjjSEmvvNaf/2Msw2w0+Ud7it4QszdDLQDblL2UAzzM2iFgl5bf1QGJdXrDveMlF809O7ZBDhNrdiVGRSk+FPvxqkoUiphFkZKf7tdu31Jeyg0u99Qx82Rah4g5Nj5T9MHH5GICqEB1R6DJQaVp/2n07nAlkWrxj54G68SHWRCPmY/LR6uQIGzTQqiF1mMm6GjRSgBa+T686kE+a1Tqql9ATCfB+fjbeU5mDYmiv9uJAcGKZC3WlWjfso+TL42TDSjBjO4RvDBKESevgM/97DeV3fGJUfiDQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?hVKrKoi85LSpUkJdbke80nP2YEd8?= =?utf-8?q?ZxzWfDbPFBbOcGlB+l+QtPLgPVTWhsKSKthGjBZK4vk2i+zzPQ3okRo7AGL3EmEA3?= =?utf-8?q?Cv/wJGLGrSd/EJSuYyzV+T4A02JYXfjAw11CcdsB/5zwBSALBOwD84G+V+uzjeJ4K?= =?utf-8?q?qgUoNjS1aTQV6JLkhvDAyHQfqjNXxnuMrVqRM1Zy0iQXUejc1C/sbL2tr8+C6QeL9?= =?utf-8?q?UtG1NKo9yYOSww5EjNQwlaJjhXZvTS1liZEzC2CJT0EAEojC6lNdAgFEnDwHoABgl?= =?utf-8?q?D8YHCtP6koMCmKMzh5JGUdqFg/1iTNxIHS89A7gT2BICow7g3VQtxlmxcNqFuJL5D?= =?utf-8?q?Vhtjvw7+samlRzD7yb06UydRdSTGOHhRh6/ItXxuRgmdhZznkB+f/Qi40NlxkPpLX?= =?utf-8?q?pv9qJbuMsHLIG5eHu/ln4q7G+CDn8ikC2rjMcpKctB4t/68s/DontovGQZXM8MAxa?= =?utf-8?q?XQEnu5gWh+wEwFz1MLDxib0gibUQJ/kNoSEEJU85bbJEX3evpa3wMXFMLcinMJ9I8?= =?utf-8?q?4/ersYQPz2u309sXEOu9BSmXRkMA5/ioShAh16mDN2KY1WsGEUty1c772ZQv24RJD?= =?utf-8?q?ThCr7xbTsx8BCizH4ZTtc7CxYcnIC3b6gyi0/Jz/02Un5Nc1bJLHXOQyOkFNcG+M9?= =?utf-8?q?YHCaYzFSL2eNKehh5TK9xa0aFlnOKSFQpL4u7p+ZgvXQ9qXp1tHvzpq3oowdJft5g?= =?utf-8?q?eOqXoV4D2gaqa9jo0PCH7kW9Tu3HqLP9XRfWrrU6yV/kmHYPJ7VmhtiQt/1Yobslh?= =?utf-8?q?xkvNAIO8CenJK6AfSuR2uZjeepTHd3WhHqr8eoVyVdNcHyC86Wa29pIZH7cIRbgxy?= =?utf-8?q?rkdWyeL8jY9wce0sXTn4B9AuoZYRPS00kBLi4L6NsmCshTJmgFl6enstewxAlIpWR?= =?utf-8?q?UO7W1rVYepJ+IZcp/6KnJTaCKOrvuBbVX9zNzaDWuqiKGqsq1n9ZnLp8WHaBAEZNr?= =?utf-8?q?/TU2WMRGiyXKG5Cz4ykZdwB1F1Vz7bkdm1qYpKHCbhyFXvIgoxE+xTAKo9dq5KIcJ?= =?utf-8?q?+WDDPwU2g9GgoqbQ4qwBuRTxhopLYkMJGIdJL8WWDaB78libZw6m2r3YQr179lDeu?= =?utf-8?q?dK2O4WPgDH7F9ioUIcvkLH1TLQJOXiXpjOpr9g1g1z4uyhl+mD/IB/1sYVqRgrj4J?= =?utf-8?q?LrNAR9ny1yLvzTIFgu1RC96FIPc0j/A2COq8PJ+dH3s9PdwSFnPamskj3YfFLOmEw?= =?utf-8?q?Du/iN4DiNHjHXZMvqtk/WGuX8tsNgUqKzBYiYheQH+3Php4P5CpTLsbiwgnqzavbr?= =?utf-8?q?vfVHMoBfhkJ5dEQp8/wknGrh8PPdMuWJOyTb37i9o/8+4s5LK5Wtl+2+N73TZUwvh?= =?utf-8?q?4fIQAGeFPHIBx8YqO4tkVZma7Cuqh4uhKRRdI6sqXKVvF3maqyI/l6sxHBhAu7ugz?= =?utf-8?q?Q4/jQoTBIe2K/dnvRgH/kUnggN9Yc/1xVOaDGicDuis8wL6Bn2FL6A5QYdGdsW6nT?= =?utf-8?q?VQammnEgZzbWpVW4eOQKI5PKXNYFJ6XJMD9j7w0ENMqiZAqWHp05QJqzJH8rlAezC?= =?utf-8?q?wqdi3fkt7D+ViNRSQ/8LkjZI9eOGJhdonw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19bbeea5-3555-43a5-73c4-08db13f75d53 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:35.0718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KU9lfInodlAKAcp+oVmDgHigXXu5OoVMLACNtla1M0UMA7LGgVwdy9Q3GFUezCL5egyZxTsZnM9ONpq84gzBIxPkvtzXbFdjxwRnlE5mgX0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv4 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4 address as expected. Fixes: ab80975b0a14 ("net/nfp: support IPv4 source flow action") Fixes: f85c1e05bff3 ("net/nfp: support IPv4 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index f373171d7e..39493ce98d 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2132,10 +2132,13 @@ nfp_flow_action_set_ip(char *act_data, set_ip->reserved = 0; set_ipv4 = (const struct rte_flow_action_set_ipv4 *)action->conf; - if (ip_src_flag) + if (ip_src_flag) { set_ip->ipv4_src = set_ipv4->ipv4_addr; - else + set_ip->ipv4_src_mask = RTE_BE32(0xffffffff); + } else { set_ip->ipv4_dst = set_ipv4->ipv4_addr; + set_ip->ipv4_dst_mask = RTE_BE32(0xffffffff); + } } static void From patchwork Tue Feb 21 10:35:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124290 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D92F41CFC; Tue, 21 Feb 2023 11:35:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 405A8431D3; Tue, 21 Feb 2023 11:35:43 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2110.outbound.protection.outlook.com [40.107.243.110]) by mails.dpdk.org (Postfix) with ESMTP id 2F4DD431C7; Tue, 21 Feb 2023 11:35:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PRmBTAEuRqlDWmc8MBLVHXRdAc+HnYbGezIGRbhks47bHwumnHw5OptUYus55eRF0+DHKk/1yHtDC0ufyVz0/USCFrwy1PWt7IYEagVgLutXOQAA5+xoC9VFWTKMuI1b/CkzbSSA19ksduYmiC3P5MFRjkhqpOzb/mHCBb0fvQ8rFd07lsnMKLnvQk4qV3iVBCHvGfXQPPQIVEceXXoirTzvF9cezWRV+dlu9/z9mC4R0RdlMQhvtNVurO0tqaVFxIpvDJ2uIq51XRchUfe3N81O7qVx2/SvcDqnavYYiNihVie4G78dFvha6KC26RXHiadZBXr6OrGCluTpuCq2rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rs7EInAabFq6ZS36rWbINsALrv6WMj1PatupA7HA6BQ=; b=LBpmq7ZZoM5LvF7f8RBd0O2FrNaJjfKc8mstNI3e7kRXVWy6Knd1ErqtUjuQ2WxynJHf8uhNeidGvOpg1d4nzFOed29QsJ2lppSFXrSKC2hWbJixYzd05ya8D4QQa5ARR9iBZ4iKInzPGYzkYO338t1og+sfVUTS/QdzUYfCcOZ7gQqCpJZJeqlVWwCp/Dc9YBQXSXjZ8HDzDVzeqotwyjOjMIeOAa0h+gVS0MViW6Rxnrh4ZVmpdXBTzJFXdvVIECplIA8VZZtJvs+Jo/sDiXgLCMofJUIR6SfeJzIS/MBLbMbghpCuhEB79zGDYCxNTM9GE76+RwYtVjJS+0fExg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Rs7EInAabFq6ZS36rWbINsALrv6WMj1PatupA7HA6BQ=; b=nt/fLn7Q/wMJIU35eCQ4QatQlHS9j9qE2aBxJs7aTtKgXzM2d61SEIPFGQhVM+rMnC5sBU6NtNtQ5JHjOo7t0cyfgOjXtoz+MXd8u7p4C4XGm+VCXu/cU/755jfVgBFCOmjQdoWS1PMsftUTlhkZj03JdnZwStgW1yxTsfLr64w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:37 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:37 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 3/6] net/nfp: fix the set IPv6 flow action Date: Tue, 21 Feb 2023 18:35:10 +0800 Message-Id: <20230221103513.412-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 463a3fa0-e06e-48b0-9b14-08db13f75ec2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GyFS2rR46a5uP9SIZF89+PSwmtnIzjFOiITPzV8dyqn6wjDBus/1tREmeo2rD3JiQxT39YTYlRz3bgOMDX+/rPn/J+49BCmA52iaBcZIAnK3Bht67rZlEDjGEIim70n2g8EkcW6QPFCROIGCOS2ijpJXiBMTGYnTSzPz2XzcQL8he4QBNPODihk1/adFbHu2di1sQTZMgsNlD7nyslgwivMoorDCiklcoAFbPHe3BVbdN0srsmSgckZvJUaH4GCEtXJq8/8Ho61ZRs2UcxhG1gX+PN22YmeB+QdIP+7pZ6Kwg1qJ8B6COKCEaWJO0rJyQbZ8r9cyWdHmkl8rpovJnB2Y0y42D2EvvcKLWZo+TCjLxh/dGtm6gcxhtW/TXymqI1ZaUd5ckJoYrJXdhqxCNeeJD4FCd8TllQIShp5m3S0KsJWUs8UXGyvogZwt1qjgXeEzWdPTErjcmvFhuHQELoMcaognzq1YLXYmDCWfzisQ499FL/imPW97G9MT8N+FdJhNgGIr42l2Bvbab+GTnG+q6dt866sM8ktN95Ul9lXnb7it8xv8nieM/RhlJH5CcNIhA6ipX8otTEI9cIKxUA1ciU43nDAhxbgsdrWfIChpnXquXymeDT1/8WzHonas3uc6vbnru/sHLIQU6mYO8bB4yY8KUzwJhI7ssytZUjuA8sqQ+HAbYYG0F1+2zstG5lLp6vnZfC+jzbRSyXqB3w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?N93x4bHCJF8C9QiZ8wKaAYGokvA1?= =?utf-8?q?yMlxRFLO5W+bHp/V3CR+2/QOExTakM8a2GAMM6dO/sua4iHrDrQAt1ovtUuzWTivm?= =?utf-8?q?1YHQq4K1An8Z+O06GELPJWD34JT1F+rsFDT+KPGaADpli2SCyByFYX+wy30tQiI43?= =?utf-8?q?CLuO8q+i3rXs5Plmg0x+milD9VLIyo0haFWkWwyXgHRukkKf4tw9uY4J7fHfPWjld?= =?utf-8?q?VItGIkxhpptGClP7IyA9UDgloI8cZRhsAV6uKRQrUoimPOIEDHm1KsQ0B0KTpwDr7?= =?utf-8?q?G2qwjbAQjVt+3ST2Pd9OH0cNM4tpm+Nc+LOQ3VF9alVjf+PwwJm1RXJ2IbHgwaqoi?= =?utf-8?q?/Vh7HzZhQtoQIWngwmhIay8l8moUdYMAZJrcBOfLNOulfSLnlnjI6DuP7Q91Qxi7g?= =?utf-8?q?KMbBI/oKjNnkn1BDGSj7Bu5JnL+nIGMwk40j492FjQENWhPUnpDaFqzs3vCdx+UuK?= =?utf-8?q?l4X5swKMQQN/2IawADOK2knWYVzgzWxlPTztGHTOwFZgQ4lXp0If09dZtiYuQN0//?= =?utf-8?q?4feUnLVgDuqsjVa2tjri1vFJQq0piaPdEtlxgLCZEtLLfiwV1ZBr8CpFQbRkI48tq?= =?utf-8?q?TZy6zf9BM2yYLwLwI8Vzid6la8GlY7ZcjDRvEx1t7kMhsziDFLYa9TtuRqS1La9YZ?= =?utf-8?q?GdLU3iiJ8dU660bkQL2AxnN/q7/CswqW3bGpxUG1YmKyRVMFGfKVjBKMh5L3JcOEg?= =?utf-8?q?qBId8uQZdcxbTo02T0SgcnkGcPjy9u5YKcfDVoyX35V2dIerAWwtKwagP+KEyf75p?= =?utf-8?q?vMsLoQokXa+vEYPua8h7rNqngJOrO/rMk+etXtdlLX+BLRJgl3U+freIPBilJ/Lmi?= =?utf-8?q?+6DuaHU+rxHzMBa+uKHyPbs1wIX7yI7ugsluS+NU5jK2dq4tX/iy/P8xafc1JpRr3?= =?utf-8?q?CCBf3w/ZNBoQ5AKST+OreIwGVQsux1ncL1nV7VfdcfuHcU1Erh+aoaLZQ1eYh8okp?= =?utf-8?q?RWv7yR1//gcRh2VxE0fl7GCIM7zXY5hR9SnARAk8jKALFH9cq0AHJTGinPKuy+Ke1?= =?utf-8?q?NcRGPqWgt+0PoPTf1ib4V/x6ZRuw2nBunQ41cuQ8K+TUryzB010ZlF0q9M7z9HG0w?= =?utf-8?q?YlVBoeuGviOuCaTQ+oPFaKSCiWUPRsBraQYtxIvZfk2D7J/0Ed8xXGGqUnGDa/+QF?= =?utf-8?q?7daYvpOD0PYIiseoL8bmA3IHjWHiU8/bwnJMZLQ2O8bSn+vyHz+N9uuikATTBwBDU?= =?utf-8?q?ZZhsox/UALQAd3IyoV5IPvu4cpLbcUfv7lkb/TwTjaoF7ojrg7U6GumZjsfq8WeQj?= =?utf-8?q?njOW4bSjqlGrrAmqrYtacJvP7gseGVgiJRu+6SO/WLrK+QgruzjCV8SZ8ErkxwVL8?= =?utf-8?q?HuuG78t/6mCCDJKuhhbVw3YgDlGIluAL2cAPVDKs5mWiViPyt0MV4f1HqoVigT094?= =?utf-8?q?7Ee4GBFj6IuJySsOzn1KEh0k8bA94KpgLsXHhOd4xK9mNsr6lxua4itTADNeEf7NK?= =?utf-8?q?vAEZjUti+WVuIVNKslmNiE09jNIAr1+hd1zOpRg2E5SkLSP3+CDhI3inqhaK8doK9?= =?utf-8?q?bO3k6ZFKqHcQtGt16wJjmy77FvohaiIDHA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463a3fa0-e06e-48b0-9b14-08db13f75ec2 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:37.4949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YQ04i3K5YOSzeIYo46fC2/9q4wsFifZfcCr+Xg3TnYg+OAwTAL8qsFXTVnvlqZKUMLOgKQTFiPfFlaNxZCkWKOSjydggo6xvDdXOgHDawKg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv6 source/destination address flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv6 address as expected. Fixes: 596ae2217214 ("net/nfp: support IPv6 source flow action") Fixes: 51384f79b264 ("net/nfp: support IPv6 destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 39493ce98d..d1fe744758 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2163,8 +2163,10 @@ nfp_flow_action_set_ipv6(char *act_data, set_ip->head.len_lw = act_size >> NFP_FL_LW_SIZ; set_ip->reserved = 0; - for (i = 0; i < 4; i++) - set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i]; + for (i = 0; i < 4; i++) { + set_ip->ipv6[i].exact = set_ipv6->ipv6_addr[i * 4]; + set_ip->ipv6[i].mask = RTE_BE32(0xffffffff); + } } static void From patchwork Tue Feb 21 10:35:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124291 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1444F41CFC; Tue, 21 Feb 2023 11:36:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6CA5431DA; Tue, 21 Feb 2023 11:35:44 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2111.outbound.protection.outlook.com [40.107.243.111]) by mails.dpdk.org (Postfix) with ESMTP id 6933B431C2; Tue, 21 Feb 2023 11:35:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lq+xO0PGXGd5f+eYA5sio4qcQ3MxrOvvg8/Z3d70JGgwyv6fF+VwB92RzIeU12m8qJSB11L8gMpHvc0KkamKXpOcC8VDnv4DNZR4I27nTaWxqJ6xQSUiRgAUoVm/MNdrwiyIWCVJyVoht7MInR5UeLsmh5g0bMXIgKLizERK9iZJ7DGUvxo4pFLbcOV2+3CKATAaGJFzYOXUMg0ROpzPvsf0bYc5DsXon6Nq/k4wIX2x6NI0H/lDwI7y3hLxZsqWrc6QUkmulMdPL0aQTgRGmnC2UDTaB2jdOXpUsEbtG1wL41Z/W/pqq9RCpRnl8TB5MejC7T0b79/8vLS+mNgtSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/jgaCiGD9TWzWEhGdO5TqaxXplruiQmbK3qr6S1w4oo=; b=WMB0AZNaBihhd9mQCAhXgHrgiYFWKHFP4yVBb/QrFjioe4Bq4dZA9siLl8L9yfIHCCd5r48w83Anq5mDMG84xgjQoK/GBjvNPRCIra22nC/RfbVi+xNVxCuZyKfY8/OtlaJGafxm2VAVWnzRVu6/6U9JG+/ABEcCMow+aDzzsjYLqrqwAUwRdBr13oRlPDks/I6LboWYe7x/OhBrYKQLf7WgorMtMOPgNSu8aqIQ1t92CpGxJt7bv0/yMUuebO3oNtjVYxAR4Dy+uLg62CtPXsT9+1TysUICoxolv+Qh9fki06+qM8pfN4YwkTZuVmwcYtTIcvHxziui4OjMWFrCuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/jgaCiGD9TWzWEhGdO5TqaxXplruiQmbK3qr6S1w4oo=; b=RuE57VWMAQNTdMzlweh0QtjmxDP4EKAGPFqy4ObJuIMi71C0bXu9ceNhXC4jwVd2WcVLp3G8nv76GltSYM/3HebOt2T37mWTHkayus9X1ACJJyZiXvBlP/9hSE0fX26QRODojWktsu/oyEFm7KBk+2i/7vhzob1HZW2kx7PeVZg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:40 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:40 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 4/6] net/nfp: fix the set TP flow action Date: Tue, 21 Feb 2023 18:35:11 +0800 Message-Id: <20230221103513.412-5-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 84d13bb9-6b76-4398-e487-08db13f76031 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODSZ9j/M24d8/iM/CvrKHz1dmwgxjJgUPVNs6zGCfg1x/HVQkHg7fltJJTvkvbuaXgIfDF6jYsLA+7NQtuQ/lsuRNaBv9BLXNL14WDitE/BB1hETu7Tz5Tffi/r/etcAxozr67vbe2y+ixDyPvVw+dtRqo8XSLYzgGe+MPR5yJPtyF+ZB0/6GCYaHjE59ot6GGLFSqkNUjLGONDAgkEvvrG0ZWEeLSDbhS59VlfVN7a0cvqVkvxlZ3c49/mlZaAxCcXuaplyE4Cf726SdIEsTsVZKwDq+XaVjUwL+7/KB0bS/f+WSUvUN18KQhxxgLuG3Bp6fTeiWql7eJfJZszHT1N12yfM9+ktTol3fWvPSttSd+i1xxc/Twj78U0BUfGLDWbKALGCQBqp2v0j+Qh0YGqhKmpvuC5Barw+aLZUu4t5t1DY3fBBO5hi9IFO0rJPocTsux1q93lEYvIGGfCzVuMT8G1S5ncmrBC8W33IeLHz7i7z/YA1wqPkO9Brc0p6jDou43zj+szWVyH67lViiOkA0JdBUVyUZqHxQHkqZnaIWK5iebiPaFWnGO17B2kF5HLQfte1wRmfxucbU47QRuzBlHYcYTOUhhMt2/v8QD2iWrSUaNro4x77MCSsEbLVX9ANTevt24U5RlYAcuQUzN6oMCzITXgoPXK+fqMx/6m+IwqGfMwvArdnrYDUHqO2T/rgM2/YqmIJK4izkVGM9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?J4m+AIkbPMK8rQ2tnC2I1nw+EHAX?= =?utf-8?q?qYGYVd5mVx+eusBrLe/5k8HShxRESxZSj+6+kM2iRog1cgrmG7Xh/2+1MINnTgNPU?= =?utf-8?q?Y+tkNzPB+zLS18nN749tGkHa9BZngTo+yr6oUjn11sCFHDcvLKkHjuSkzubPUCpub?= =?utf-8?q?bD3ezi6cSg3Hd/h/Vrilf0kzHAw9gu8O/MgkwzM0mYMBfv4PLwlnWx4sO6ae+txZl?= =?utf-8?q?P/Qbsw5/cyU6VMCIVZjKY+5VbxV3enkl7iJBqNLqTqdyZiIX6vw7GLAE5i5WbWIv4?= =?utf-8?q?TCn0KAb0GeI/+CG/hfeDGr1r3U3fAZ3ykloWZz51enxjEU8XJtPwvriFzfMeFtXIP?= =?utf-8?q?Zuh/NTRYMLIgEGLZkrVe1f1wOB6yKuIingOkUU7feEc60bK0tutb5KF3L2zg9gVie?= =?utf-8?q?6116v/og4rzdyHNqjOx1nUvixpBxJQFeqXZlhqOQicmMyKqUh1FBVkMMxVhM6perp?= =?utf-8?q?WHxsUNIot+wnvySBPYE2/7j/lIOPbomOkKxJ11DW1hWzzAl5/eTs9K1UZThMVwf1T?= =?utf-8?q?urIAoecAcOECh6bqlTi3Exr4ob7kFiJdy8sPjYl83SN9lXZJiTsIOUot4t9EN3Adt?= =?utf-8?q?Wg3RLAzVrPkh7QVDwYw07qSzO5OjamcEhlDXbkXZZUG0c9H3MCPYo9qMOzhk5ynqt?= =?utf-8?q?vXQ7DY9BqrOBO61GfAiwlS7gkxGKvzQ7AFAiFqe/tKzzXabwsZ1lOuujIV20udz0w?= =?utf-8?q?dmiqA/iDyI42bMeiBYZVKXw9KUIDF0YhAc5YNgKsWFtUMPtymTAkbXFQvt8T30zLp?= =?utf-8?q?D9hZCdHUuL/tbOSf5DZId9xPEbLFC31AM6Nmv/dO7bShd1/9pWz3WR0DhRsq4peSj?= =?utf-8?q?wu3z3cHD+UN7xfCmUAoChSmhN7X3tYBmAj9vwTWPsUmu0WCp4HtfJ6jIKAwcJFad7?= =?utf-8?q?NSboMtT+Jhv93woeik2wco/xaa45gd+ovyDh8DHWaaWcXfg1ZUyaxOKxSWOURyDnu?= =?utf-8?q?AV7buxw/sqxnX+DwXYU30X2u6ArbdQVZSrbDnmC/IoxToYivhiYLLfiEas5rFhRgn?= =?utf-8?q?cOR3/N7V+kcbEWLlVlLd3B9cO/KhFOOCgk+00tU9eEAGDwcwo0trM7aqVdGe1IW+L?= =?utf-8?q?PS1Hk2PEUvj1voMkfnout+QylurcaG7wg5qSsFNVZQEN8MulDrhZ71cu2xCryI6WI?= =?utf-8?q?prSsTnKYYAOChKnxKEkTLC6yquZXriw9h2xl8ywpGdbTACUesYZ1R8vl0yaFmX2kk?= =?utf-8?q?OwTlBA4CgEvEBSvr5oJIT4AotEBMoPkeF2uavUme+02M7xOENE4CzLeajSpn6rYOz?= =?utf-8?q?4bw2leu9pg0tdaM9dZ03Gz65dkOPlGnbXUy1Vzg9w5NGbPesvJmaOeTcsQfcBn8lF?= =?utf-8?q?/cAPR56cEk+5lbnNqU7+Aw+KRasa5z4plKsdm7xhH8445sONp3C+fdmpVnp1b1RAt?= =?utf-8?q?QNLMRO03KqCUuw3UjQjNHS1R5QQpVQIzh6zIvQbWpP0XUK0DJaOyLhaP/T4YSm6TP?= =?utf-8?q?rZfo7iUffHCEisQ7kbzpbOAtur2u/ocpCSkjz75Wtv4a3mQqVG5sVfkN9C5gOIhkM?= =?utf-8?q?aQHx7ZcaDyrUl+ux2LthqN9bEBlj1Z7wZA=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84d13bb9-6b76-4398-e487-08db13f76031 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:39.9007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yp6IOX9Hn+AINULhKPhHG1osslYaf0W0cMbj5imTKY03cHqTaLVGxtaoco3P+BjNNMVn86xEpXAYb9BcebBwtEX/KQqZZhZx2Wf2zcvylpY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set TP source/destination flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TP as expected. Fixes: fc185097bbe6 ("net/nfp: support TP source flow action") Fixes: 87986df09d75 ("net/nfp: support TP destination flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index d1fe744758..5be4c4f18a 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2190,10 +2190,13 @@ nfp_flow_action_set_tp(char *act_data, set_tp->reserved = 0; set_tp_conf = (const struct rte_flow_action_set_tp *)action->conf; - if (tp_src_flag) + if (tp_src_flag) { set_tp->src_port = set_tp_conf->port; - else + set_tp->src_port_mask = RTE_BE16(0xffff); + } else { set_tp->dst_port = set_tp_conf->port; + set_tp->dst_port_mask = RTE_BE16(0xffff); + } } static int From patchwork Tue Feb 21 10:35:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124292 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3832641CFC; Tue, 21 Feb 2023 11:36:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88195431E7; Tue, 21 Feb 2023 11:35:46 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2122.outbound.protection.outlook.com [40.107.243.122]) by mails.dpdk.org (Postfix) with ESMTP id E3673431D6; Tue, 21 Feb 2023 11:35:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N2cZOZK35jR5EsOPTn28CRB04fRJLvN98uqAgm9VHIeGff/QA1MZF2vWGooRIqmSrmPU/9ja7+z7q3aveaKhWFQx6TD8AeyR7rdOZEvTjnq7c9de60aiFxK2eCsynxFdebR4CIMIo1Jzn5F3ZMdFdvumAXV5bbzeKY/mqjlNWvsvSUISiPheWetRoz3rRkcICHlIFv0hlsq/CqaeO+wRe3Y5xVozZ7Oc+z1QSHPlZ+LJARrAioRERpxmMLjHPoa4yaJRRWqqb/LGN5s9jvdh4CVO4pUaTQyBeoQQNHCYirqPMq1OIu3XkKIWMHf4UQOa0fN8wUDV/EaASbQZsiC7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hJyhCUku5/fiHGanEDtAIsIXOUOZLksPpdDuFcxIkEc=; b=ObWXq2NZAsPAE4eXXI4QsjMkf+ehYCf/vBiSL1QNf/1LHIxU/9ibWEJh9aOdSNVDAf0YEyFLqAuRHjhgtb5qHR+xIdkgY5R8sLticWy6uZEvld/MGkYBep/KoDBKW0EK/TSqrsGVFMM+8FGX9k40k/UtjTYLWJxFGqTmr8GH03pUjeivqYUABHhZtDrcR30YxZG1DNPU7Xoaqx5jd75fxSCOdvdWsGmmMBVeSKtKWODN9B/Lg1PIH1ciT/I2Te7caANFSrciTdneBVNM9I1iGhRhvr35zvdvY8LnW9kRCCiCcOJp5KeWZLzt9JEj0jUyPGHmxENAc+BC6+3NSZUo3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hJyhCUku5/fiHGanEDtAIsIXOUOZLksPpdDuFcxIkEc=; b=YFwD03FmXLkBSeT9TQ555GRwqvsvbjaswUknJAImSEiwfkc0lC63CNhDPlm2v8vD3oxHtQOEwf8CWAJQIHlSXuO11h/laGXiDCX2DoWUIJ3NhBBunQNXVxoQni7nYrWK/6RxlKHIXEb8tYtJSYnhiie97Zbm1XyvYs8EFj29is0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:42 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:42 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 5/6] net/nfp: fix the set TTL flow action Date: Tue, 21 Feb 2023 18:35:12 +0800 Message-Id: <20230221103513.412-6-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a9aad8d-3895-4201-3da9-08db13f761a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R5eNGwURvToQ9G6itlmEp9FFZ3h4IhxjV+uovNETNYG5kDgbk/NHuP98CGhZgOIfCBtzBkmXZkBdP7lYcDaS37iIUjujPGAJYzKcwOj/CefqqIPwXk/S4Tol9wcOo56krx5JGIedI4ldw78FJCg6J2fdFHp3ejT0Dhksyv+Yqc5xUi0ZEFC7AzvGX9q/4eNXAiEMEQTecDg2/W/jeQxSi7iKP2hCQ4ykxFUgtAXI1/to4cfGg0h2sGnLjR8s5Er5rCACGmSvoHUipLhZTtzLG+6u9YDlUgv6H3PpHJ4p0hbsCQaX0TMEq/XqAfNmsIdclAUTIhuyT2DkUV5WkuY9Q6i+l4bTOhTK0TITCcLZCkLZudBa7hR8gJj1PtdwJgVeHv+QWBL0qLNTEdhLw8XgAtzpeIcKVWqCbM+unHYYqrqGo7vI5FWTDwmelusnnzK/O7o4hfm7Lwxac/F6FgUdPPVvu/gYLCDsyNhkV8brfUEIiQgIAGWkCbhOi7RcCfB/XCHFuGcNa+aBPyYkf3cjtnNEeUeZpuYU18aHlTzJQbfweXxFAtgbSXU5zKWbwSR2R9tUQPseKWfWuReWzE2Eu2XPM+3pA6cCg2ZIWImYziqultIOxhyICQGn2MKmBo1a8PffBYpHIw2gLneu46qZOVTMCOgNk6bJpP3GJdzjLx6j1I1BjBUtO9VJo+kgRM36hK7OQZR0BIOv1aB4NukVRg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(66574015)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?En3iRWnSx9Qv6dFUEdP6LdJ1u3fc?= =?utf-8?q?CA4MSdrF0+ckZEKYPeKD79vVL5V6vfW8UyQD//cj1xby3e0KAwgJP2V8GFPoo79Fh?= =?utf-8?q?T/oQDccawwVNbDiiDxSGtSIUmp8GUPSvy9xRTne5I1UQnawd30bf29enuyBTFIPPD?= =?utf-8?q?CY+QXIl3vBWf/YqC7n5w4Kq1NFiVgVECe4gNqtm9Jzt3rRjNpsPIOgafy79CFja9U?= =?utf-8?q?knOD/+IIKeeneB+Du0oKP5xRZ+0XrTuaO8JT+y2v/a4tw8NWhtyltQZtT/jGnVr7W?= =?utf-8?q?6lSBjr6FEIu7hdXWlBG93h7xI93Z1PepubUCgj2TvlYJsuGTKCQhAsYZ3R+/SzYGC?= =?utf-8?q?BPX3Dw6olM/bpZcjn3cRBAwlduXJZCSroMgAUemP/YhxVmSD2jSZAyTq/m+oVeWV4?= =?utf-8?q?3VHbU3kvLUWqCWR2hlV6JxCDdZNxH0ZYx7W6mlRPJx3hVHVb4QUu9mp3IfMo1Ee7a?= =?utf-8?q?t4HpcjGi6K8t4B21e2yZ0Sh/3hDb6GytPEKzS36bDkoVHdmNNQNGpBW/Zqm3zJ7+K?= =?utf-8?q?TTHbTtToNQolYPAiR2fr4Q7SEVinkN+Bv4DhFHxDYdbGm6th1x9L0QR/EkF3GGwy0?= =?utf-8?q?3toCht4UHEYZ/snMLdfmiVjq69Zt/XCV0rEy7E8Tb2qGlchejPurtjaPiK3vj5Su6?= =?utf-8?q?uHWDOT7/rM1FJeMurVTDfyMYf3q7BFpHOK3x04YdBnYc+XfTB6Rhcj/LYCVt1In6T?= =?utf-8?q?+KsX7heIAIyNR7Nft/lWch8ndmmuVQRgxmJyd9RtRdgIcd7sDDtrRUm5d1uYds+fg?= =?utf-8?q?h3EBMmzWp2h+IKIClkZ3Qd4teTK6XmCoPWxIX9VHhiLalovdk/RK9hS2dKVcA0H/L?= =?utf-8?q?BXZoIhXr39U4pZohkLYhIyuU0uK8L53q5k++bNSmJJwp6JsQ6YFDBtRd7wykGmZ0Y?= =?utf-8?q?6fluzoFIs2S4PuiHMacMfiZB/L+8r7zjZeYBlswY+Reu/QJyaj0Rt0OF687aVe6q1?= =?utf-8?q?OoTynxHjqtGZp4Invmlp2akY73LjJCzCYznHRGQo/+vpx/hVVERiCG5uYNBMqNLBy?= =?utf-8?q?L/TrrokKosuQry/9Ri0jyPUPsD6SYrrmkremnOr9hyi1IjkYVeIwzCDGv+5bJrdom?= =?utf-8?q?UhwlPPpnYi1V0QSN8NhiZlPqKv4PSSH2AAemjjvd5zDefAIGclw0ChNBX9tjfVi+F?= =?utf-8?q?XSJdRCF2Sc4nd2+UIMR5+wMipDM4d/D62TJ4AYnlszI+OEgcTj7rO4P+mSGZue+W6?= =?utf-8?q?j0BFWYgQOH6Nbby+3/4gV3LRfC3iLvmTQEiugW/EucjoYd0RAqG7RhqVWKDveN2q+?= =?utf-8?q?gqDPgZRyEz6krqFUsfLcwOwAxuv7pckiwKZNJQop6HX38/FCZ494vgm0NE2itzfyF?= =?utf-8?q?1uwoqVm17vbz2trKZe5iEvleqbvY8HSaCS/Nmek3iJkipX0PLevVi7uKgcaJa9d58?= =?utf-8?q?tVJ7ea4S7yjShY8n+q64/AeWk4yDlVtry71YXR0sdZQcWRzNPTTpwnDphiqlM22R1?= =?utf-8?q?y5dccodbNMBXwUAemU8BTzPgsQGXy9u136oS61A6SCRlkiQ4iJLUreH30PiTqz1AT?= =?utf-8?q?BHc0LrWSq9bXX8Wmi9pIKJ5DHN+NcAxudw=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3a9aad8d-3895-4201-3da9-08db13f761a3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:42.3213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 44NlFGcAdF7bMbgpBtQBsEYOcEdCTqTDR1LfbYeADx5EGU+tWvQncpO4MJtsT4J7pgFP5+zY3hPExso0hDT392vNY8ptNcSvXGSdPvv7y2w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set TTL flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right TTL as expected. Fixes: ac12e126c482 ("net/nfp: support TTL flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 5be4c4f18a..77f249e2b9 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2252,6 +2252,7 @@ nfp_flow_action_set_ttl(char *act_data, ttl_conf = (const struct rte_flow_action_set_ttl *)action->conf; ttl_tos->ipv4_ttl = ttl_conf->ttl_value; + ttl_tos->ipv4_ttl_mask = 0xff; ttl_tos->reserved = 0; } @@ -2275,6 +2276,7 @@ nfp_flow_action_set_hl(char *act_data, ttl_conf = (const struct rte_flow_action_set_ttl *)action->conf; tc_hl->ipv6_hop_limit = ttl_conf->ttl_value; + tc_hl->ipv6_hop_limit_mask = 0xff; tc_hl->reserved = 0; } From patchwork Tue Feb 21 10:35:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 124293 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1726741CFC; Tue, 21 Feb 2023 11:36:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2322D431E9; Tue, 21 Feb 2023 11:35:48 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2094.outbound.protection.outlook.com [40.107.243.94]) by mails.dpdk.org (Postfix) with ESMTP id 40E0A431E0; Tue, 21 Feb 2023 11:35:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vp6Mfg396UmRKCV4YXZm8rojxt6XRX7wfjhHT2o+Ex0r0K5MICjUCXBUuiQO9Amj3LIqRYEQ32cdu5eT4Zd2MOR3zhhnztAi716NtHWr/w/WOfvEKU7PB3SZ4J0cKeDBoLE6u1+TGyHKDnBCnSJ3Obj55Z8zrijUjRV2L40fE1n4cvkzYP5OtNX5b70mz8E6BOnnwrL8J6xvSvFMd+sNFZgaYRIjxcnAAVBeII1GLrf3txHBMbhLoF9jKZyxL7HP96t9GUbICSU+va1HCIdE19BfeSYeBb+HA0zc5r00rMsXjY2whdyr8y+u2kcgurkM4/2nQCaXVx4FRbkccucw2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PSdG+zMtvBw1QSCbMdO4i2NCbip8FKQbHO2mg9QJj1E=; b=g6hrJKG69CgkVwtXtKATD5vneBXHer2UfXaRW1SCtlZci9s7x4ITjBqp1FHEuKOPHc1LQAXVuB8A3/94NbENiHjBHB71GkU3zKc+VJnoDv+0IyU91qjpS0Su0uP8A+BHcNbfwE2wGwvzuSkPhT0NWevVWA3DoJ+VTqED7/OZsggBQoJmo3qKy/7qql23ey4iGBfupGvHnJjJRwyDu00REflg1wDDnneaWXGvhbdiuF/2ipVhCfrj7i/jVjGdQy3b54d+Frvzj1pKi81q+ioxU47n47jd+22R1tQBiYjfOSQxgqVOr9oUOX/JpzgHeCB5eLieOFaHvxNS/TuHbcKEQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSdG+zMtvBw1QSCbMdO4i2NCbip8FKQbHO2mg9QJj1E=; b=KlFoTYZSE/ct5mbX5zeRiLrI3PwEiYVLx507EFaV2YSWGdH3k0cdAMmJySMt55X4Fvb5kYsltoknlcOAe8COaXGzFqhwdf0WLYM9ezkVwygm0QYuqfEBeFsJI8AC1Dgv0OcC6lrA37JnntdReUPzdvW97uQ32OzLW6Ls/AX9eMA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH0PR13MB5616.namprd13.prod.outlook.com (2603:10b6:510:12b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.21; Tue, 21 Feb 2023 10:35:44 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::7ea4:e421:5dd5:9f4d%7]) with mapi id 15.20.6111.021; Tue, 21 Feb 2023 10:35:44 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He , stable@dpdk.org Subject: [PATCH v2 6/6] net/nfp: fix the set IPv4/v6 DSCP flow action Date: Tue, 21 Feb 2023 18:35:13 +0800 Message-Id: <20230221103513.412-7-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 In-Reply-To: <20230221103513.412-1-chaoyong.he@corigine.com> References: <20230221064930.3399-1-chaoyong.he@corigine.com> <20230221103513.412-1-chaoyong.he@corigine.com> X-ClientProxiedBy: SG2P153CA0038.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::7) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH0PR13MB5616:EE_ X-MS-Office365-Filtering-Correlation-Id: b1df11a5-3ac0-4b2e-e749-08db13f76314 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DKsAcjXe8vxwsJpmwfwOPItQKAYcwV4hRY6HFDwI4ynvGLw/CGYPpJXGQU2zsiIAoGaSyi+kLQlLigwU2BfLPEp/VVBPJowvv73Xz1M3OHzhGCP9TKMJSk+swlAP6lpDivHYQbLbhe9708sVX5McgxBFkWE3pxzZKrVuYnRFdhFc6oX2yMMgLcnJ29cl5+PV5Z4a3H67bMuPvPHPZeN9gXY8ddXInHlc9/gHEA4M9qsSn73BzhErqoUayNPjBiVIzMQwGRvu3GPn45cVQa/f99buQvfg8F/zXb+B3F0mQLhGJCmkfEQX2mm5NH/FBt2/0vA2mIJCSgaNS7OQkOQrsc8kHAqXLd0DSjtBj0FZ6ravO4RHmx/OgDxB/HUPiteenv+cReqSbLZVkRD2ir1Wmz72dIC9JpHhtie+gK6FerKEhNK9vK8pINhhb6+p2bWhgucQkKvXpimuMmKSGkGGWY9uVucb1g3G5luM2PHpC2EcZBnLfa18xPcNMiyE6gDw3+Sym3gXOV8ZDPF8pV0yhCqLaKeQBBAzMiZBNX5a/PeNRA3vOnqowlUC7AyCskra9vO5/gC9rSXrixHMYeHpc3CxwsvKzfuKdJGMbE2hJS5KN97xziP7kjkRgiqPMU+Ug0MOh4d5iUpcxcH1hAkUujXpi1aYmB3fdP5WarjOU08LEni3AJA1PItnJcOdszpTMwNc+qHRALSFFC+bln5Xlw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(366004)(39840400004)(136003)(451199018)(83380400001)(450100002)(66476007)(66556008)(26005)(8676002)(66946007)(478600001)(316002)(4326008)(6916009)(6506007)(6666004)(6512007)(186003)(1076003)(36756003)(38100700002)(38350700002)(86362001)(6486002)(2906002)(41300700001)(8936002)(44832011)(5660300002)(52116002)(2616005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?WQ6EY6K2lw0uCd3nKAT/3+waQKZ2?= =?utf-8?q?rKjEYW1Ic+DCAthYNtdcMtLmKo8I1bh116hS5RfJNb7/eIqBsUNHDT6ehKjG1rISG?= =?utf-8?q?N6pVdsz7deuzr0E3vgQe6hXpm0K/a6WYqdalYFuK0jbcbRXk1w0anmGlBzAfoft/p?= =?utf-8?q?reS86z/ovqBxgGSixUdQHexnBqAxs90NT0JEdQIrtmY0+/cPUUMmtSVPOGA55zg2r?= =?utf-8?q?/g36ukqVshieCUgJwPX4+HGxoU6bIEiT+t3tE7k16Pe37LWXtaided0i59nYxeGvD?= =?utf-8?q?QAwrOktTH2gFMMBTbBQ6OUqT3G8nboBPIkLR3OI/mEFQKXA+c35GIaNHu8yd3btbl?= =?utf-8?q?xC8yMmqFpLQ506p2KZvpE6zAOqrbD3weIInjWFVG6QQ6tJMjt6KcqL1QFUOoy0qaw?= =?utf-8?q?ot2cNwNyL5gv6/Kh/v0C7N3Co43QTP3bCOkuzU2YJKaYK62y4vYU1WtGlXaexbwX+?= =?utf-8?q?ijfN6gTsOHBy6S7apCsNKreMV3MFWfcD4kWeWqybpLCHWA4tdUhTfRyBLMyQi3xmM?= =?utf-8?q?DlOwsPS6YsHaXz4aqbRTJsfTPnjY/WQ5LURu/eImQo+88gdrpoW+I9Yx5pyklPKc6?= =?utf-8?q?tGMAhnVMAAVb/Iz+/1OoSRTIWZ5J55WD+pyoUCpwwotFKblGqR2ARZQf1SfKJUbZB?= =?utf-8?q?kxQMmilh/irdUDJjrkWHr76L82Hy0/C0o2DxXkxBv9DwckHJbYBldi/KaHltIRtfU?= =?utf-8?q?CktD1uYmCG3JsmoKdwBj7IFWkWTvAXIDpzcWsjiUZj2qriK1OfWDTKmIwZIhC6P7y?= =?utf-8?q?PoJVw5wd1/cO+a0vV7xzpDysHIA5UsZVQAjxtbW0lmWIS+WC5DvW7Sm1PMRPI9u7z?= =?utf-8?q?GKtDaGXBUxu7ooRDYa7Nt1Ygksrl4ljthiug1zeMeoIZxx4u+Je2VSbOWlazik6Gk?= =?utf-8?q?H9yinbi/kP4fWNk5vsh9nk/b5LCVJhbxVM+JLJ2MLlINUOvuYpCBD2yD4j2lAZQJ5?= =?utf-8?q?xFmaMbcJzn+1FvAt3DJdfM5tZdjz1ggP6V3FL+kV1o9lbaEz1A6BP1iHun5lozFqw?= =?utf-8?q?50FtuIpC4Q7cxwo9OaX6+I8LMsUPJ4jVlJLA93rY3A4yetlH6uS7FJ/d7tOpwqDLm?= =?utf-8?q?R2e9+wHyEbTW8yzORvHMi7N06oUliqsm9tYRnvOO52uozqV6DXQnhvn8WodI01Ubs?= =?utf-8?q?plXGyfNmPPyJBNBS/tFivshrfmXuql3UmSNSWMPnSeFeGbYVmjYQ9+aHqVAfyd7xG?= =?utf-8?q?bHN6xjlb1sMGCydZcpvrSO6LMIfaB4dHUnmlYKSAT4ETb4r/YznFmaQumcmD/N0EW?= =?utf-8?q?2ogcWD8513R/ArGSXSIYfWzW7hRM/DCUEb/EEGlfYm63xoXv1dHJ18c4UMnSLvNNC?= =?utf-8?q?imQJDYZxyO1ZVR8ZC5eP8DdY/OTHJKieQMGEafmaoDu/oMqNov97PAHr4OSoCKvD6?= =?utf-8?q?QaAw24dVEz+O31Z8asT2S1eDKpynt4WnalX0bxy5BgvKr63Ry6z/Q30fHSMmhVmQY?= =?utf-8?q?a1u81+KXoLxF+bABiVBjqwY/PC1So7cHKEkpt+z7vDCtcIerHEBfgYnue/OB1ZdMD?= =?utf-8?q?2nM+Q1M5nCVlBEXzYibMNveMILG4jezT1A=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1df11a5-3ac0-4b2e-e749-08db13f76314 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2023 10:35:44.7283 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0HNLnwsWX+69vZReFAfxZBmgh3cZz2YFR1lk81DxzD/EJs732NUuas2zcFX2VAHn1vyTRk1sjk3J/zwtumOrX2bASFjzqr2ALqwxiGjSIio= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR13MB5616 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The former logic of set IPv4/v6 DSCP flow action don't consider the mask filed of control message passed to the firmware. This caused the firmware skip the set action logic, and the offloaded packets don't have the right IPv4/v6 DSCP as expected. Fixes: 9c665d70f7a7 ("net/nfp: support IPv4 DSCP flow action") Fixes: 3202b003bec1 ("net/nfp: support IPv6 DSCP flow action") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 77f249e2b9..53029d00c9 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -2300,6 +2300,7 @@ nfp_flow_action_set_tos(char *act_data, tos_conf = (const struct rte_flow_action_set_dscp *)action->conf; ttl_tos->ipv4_tos = tos_conf->dscp; + ttl_tos->ipv4_tos_mask = 0xff; ttl_tos->reserved = 0; } @@ -2323,6 +2324,7 @@ nfp_flow_action_set_tc(char *act_data, tos_conf = (const struct rte_flow_action_set_dscp *)action->conf; tc_hl->ipv6_tc = tos_conf->dscp; + tc_hl->ipv6_tc_mask = 0xff; tc_hl->reserved = 0; }