From patchwork Wed Feb 8 02:00:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 123405 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6EB1341C35; Wed, 8 Feb 2023 03:00:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1C6F427E9; Wed, 8 Feb 2023 02:59:58 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9AD9840DDB; Wed, 8 Feb 2023 02:59:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675821596; x=1707357596; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FsZf/4FD8oIVc4FUCfMjFPVxdI8rMJOFJN/1w2p6bxM=; b=nOi410whWjw3svinBJ8Fqi1wJpDiA8SU8xX9/YycacymqtC1dYKSlLkD Bk8Ej6k9G0yq0rp3bjCk4dicZ2xtN5OFZbDuKBZF8FCJ0i9tBCErXdCWc B4sCyj2TIWHGjXEE2qZQcGCF+8UCYMHkoREeU2SwZlatJkiK4bh6pqzA6 ODqnwRDmzSFYSRS9L3gN4+ZjhBDnPS/mb7OUvt/KJ5nPxJYcM0cMre+2i sCrWy2RUFDV6FU9qmVZYWpGHSeyPM3cZa6VtuMP2KWvkOAgce9ZCSOv1d ZfV2LatiQv5eEvjOmTW7GU5v938++dqoItYzV/hrSWXXeofLKtgi46pYk g==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="392081216" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="392081216" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 17:59:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="697487409" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="697487409" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga008.jf.intel.com with ESMTP; 07 Feb 2023 17:59:54 -0800 From: Hernan Vargas To: dev@dpdk.org, maxime.coquelin@redhat.com, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, Hernan Vargas , stable@dpdk.org Subject: [PATCH v2 1/2] baseband/acc: fix check after deref and dead code Date: Tue, 7 Feb 2023 18:00:00 -0800 Message-Id: <20230208020001.181055-2-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230208020001.181055-1-hernan.vargas@intel.com> References: <20230208020001.181055-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix potential issue of dereferencing a pointer before null check. Remove null check for value that could never be null. Coverity issue: 381646, 381631 Fixes: 989dec301a9 ("baseband/acc100: add ring companion address") Cc: stable@dpdk.org Signed-off-by: Hernan Vargas Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc100_pmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index 36f6fec5ad..baab459436 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -4106,8 +4106,6 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, int ret, cbm; struct rte_bbdev_enc_op *op; - if (q == NULL) - return 0; #ifdef RTE_LIBRTE_BBDEV_DEBUG if (unlikely(ops == 0)) return 0; From patchwork Wed Feb 8 02:00:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hernan Vargas X-Patchwork-Id: 123406 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C2CF41C35; Wed, 8 Feb 2023 03:00:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20FC442C4D; Wed, 8 Feb 2023 03:00:00 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8367B40DDB for ; Wed, 8 Feb 2023 02:59:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675821597; x=1707357597; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WEb46RLZqesuHsSAHnj31iBhQp2SdDQVmH686k0Iz3c=; b=IiZEhxqqd5K+3V/TQNsRP7ppFjKp63j2oL9htDEgUEkVfoH9v+2/0xDc /1d0b8atVyGQ+Eq5LkePwYiul5EM7DhcI72s7XtJ66BDO1JfWf5LaPk6y UvrxhvTjjpw/fVHo90VWWkbzuPZ0k2Gd8wu9gJi+KoQebQN35NtDVhRCs uCGAD29QMrEe+SXLgvu+jHtc1pf9ZLCY7sOeF2x9FwFsyj41qIEphdFG6 3hDC8dapeZQomvJKXoT+T4D450X4as3BOqX24hrlK+q76zY3zbHpmPrIH zCSIFh5HreZeFSGb8qL20LobUIL4HqqmZDky8ryfspH6z1H7go9gqb/tF g==; X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="392081231" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="392081231" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2023 17:59:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10614"; a="697487414" X-IronPort-AV: E=Sophos;i="5.97,279,1669104000"; d="scan'208";a="697487414" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga008.jf.intel.com with ESMTP; 07 Feb 2023 17:59:55 -0800 From: Hernan Vargas To: dev@dpdk.org, maxime.coquelin@redhat.com, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com, Hernan Vargas Subject: [PATCH v2 2/2] baseband/acc: add check for empty queue Date: Tue, 7 Feb 2023 18:00:01 -0800 Message-Id: <20230208020001.181055-3-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230208020001.181055-1-hernan.vargas@intel.com> References: <20230208020001.181055-1-hernan.vargas@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add optimization to return early if there are no available descriptors in ring to dequeue. Signed-off-by: Hernan Vargas --- drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c index baab459436..9941754aa0 100644 --- a/drivers/baseband/acc/rte_acc100_pmd.c +++ b/drivers/baseband/acc/rte_acc100_pmd.c @@ -4106,10 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, int ret, cbm; struct rte_bbdev_enc_op *op; -#ifdef RTE_LIBRTE_BBDEV_DEBUG - if (unlikely(ops == 0)) + if (avail == 0) return 0; -#endif + op = acc_op_tail(q, 0); if (unlikely(ops == NULL || op == NULL)) return 0;