From patchwork Fri Jan 13 13:19:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vipin P R X-Patchwork-Id: 122079 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D5EA423E6; Sun, 15 Jan 2023 21:12:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D41742D38; Sun, 15 Jan 2023 21:11:49 +0100 (CET) Received: from CO1PR02CU002-vft-obe.outbound.protection.outlook.com (mail-westus2azon11010012.outbound.protection.outlook.com [52.101.46.12]) by mails.dpdk.org (Postfix) with ESMTP id DD0D440E03; Fri, 13 Jan 2023 14:19:40 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=beiwpKWqE1EVWCkH0bqbMCFL0BWrCGv/Y0XpF1BcFT3RUI/foGN9x3ywbFlq/cjGjNIAB+M26UAGI6oU2FEF6SIKuZczkyTUnZ/GzvluwHDiUfPO7Rga4bcDi0i15Nl+lCv8XvDzJHNnahAe4UPbOpW0g1ufb7HjB1bDkaKx24bDNmqF5MKuR3bgsJeLLvjailrppnKg/IY6lBkeFeoj+Q7TdBhq2ijftuFEowiMU5l27bVDJxPDmC1xPJrEjPBey0fkQ4mb0RAB3rNQIUZStnER94pQgy2vDZ6UY8OdIh+ZgjGB31RBhnkkYIVOv3RuCkhoTClAa3xF6s9hclx2Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dUUyfzCjOo9J8fKgmlo4RWXGsu/aZzQV+bAIzelD0K8=; b=ebWR8A6aKgr78zl2Pq4oasze2s/mAzLFv5glmyt1jssb9P1GLAM7PqdDUkiPmknJWDDG41Mamfe/fJaaNWWd3ird/XMW4hi+N/vefAfRUkko9W9/Dh6T/HSFOi33loHdnSTpk4/gS7E+ORJhAFKuBNHBZZ+y9Cs17sk3sr075OBDzLpFgP7N0erNidsnnj4dXC1pKP9Rqf71beiL+Q1tmSt4XDmnmI92OOwPoMZfBfaHQqb0AASMEanUMvczaFUNIfRHZQI7giwEWNoTq7MzEslCV0rToEIa0tDaYyqIeOW4drSwov3qIuPdfL9t9fU+s/BXIns3t7lofMEBC9jE8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vmware.com; dmarc=pass action=none header.from=vmware.com; dkim=pass header.d=vmware.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dUUyfzCjOo9J8fKgmlo4RWXGsu/aZzQV+bAIzelD0K8=; b=QcRlDL30ZwAoOKIQ04jwPdlVPYqrvhz5L5xR9scsmKQlXWDaBS1ZISWguqs075XLay8W5qZp3NHWyOty+YM7mRUnD7GapwzYRCf3pnkNG2ttDosTUS10DjJVZZSb2GjMuY6hi+SHeFPqJvPAmJ8P8GgqAbM8sxxX14wx23vs01E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vmware.com; Received: from DM6PR05MB5577.namprd05.prod.outlook.com (2603:10b6:5:c::16) by CH2PR05MB7015.namprd05.prod.outlook.com (2603:10b6:610:3b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Fri, 13 Jan 2023 13:19:39 +0000 Received: from DM6PR05MB5577.namprd05.prod.outlook.com ([fe80::4cbc:cca6:3a16:5023]) by DM6PR05MB5577.namprd05.prod.outlook.com ([fe80::4cbc:cca6:3a16:5023%4]) with mapi id 15.20.5986.018; Fri, 13 Jan 2023 13:19:39 +0000 From: Vipin P R To: jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Vipin P R , stable@dpdk.org Subject: [PATCH] Intel iavf: Return in the case of ADD/DEL ETH address Date: Fri, 13 Jan 2023 13:19:23 +0000 Message-Id: <1673615963-21216-2-git-send-email-vipinp@vmware.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1673615963-21216-1-git-send-email-vipinp@vmware.com> References: <1673615963-21216-1-git-send-email-vipinp@vmware.com> X-ClientProxiedBy: SJ0PR03CA0046.namprd03.prod.outlook.com (2603:10b6:a03:33e::21) To DM6PR05MB5577.namprd05.prod.outlook.com (2603:10b6:5:c::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR05MB5577:EE_|CH2PR05MB7015:EE_ X-MS-Office365-Filtering-Correlation-Id: 1dee0401-1c49-450a-fdfa-08daf568d2dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 54fyG5dXDBjx5zRUuQTpt3aIACsC/lSCmXUV0HB4jdxiQdDCzgtZlA6N4wniDBBlYos3+s/v7BHxrI1M8Iqhvg7URy1dnVZHoze49l98HIY10H4Y2erSoxba73BS3JLAiZqhARYIfjyylrQNazZO+Bja03IMh0v8Pg6x5DPo29OAND2af9cpYjdRbOarU2I5rwg+gjH5z2zWeGvxmEooBz6W/5T8DC8mR/PUjpU43L2z9+stq/HH0wRnlsFe3ZKqMnmWbnXzQ4cPWXP++0OvSbrGKJMLF6dqyWslJ/03LRmO21GjCBEUFqrL169ASpn2RM7RGmW3ljVv8DseWlZxGQy5FdH20F6JeyS9Um0BD5YiltVJh/bzeSy2mdh1wsW8hNy9OaK4JK8zxHEFypxkYb0ZZiJdN2dMkZ7XEE36w3t/zwlRJJML56b4lGwCVZtZnwP68XSkzER7PuLeP5kLBMpV962j+0B+GPdUuqigZBkDdsYXLfTicMAUZi9272KaP3uY9kIo4sCHUkjVJiR98ovtwSJ54hacIII+5kB3v9Rn+nv9K0guymz12UTHioAJw5ZSTH+ludmEhYXcYZAM9hfixcDIkOBIp5w6GKLEMt7rfNOuprdA1x72/LbiEjwkMwwE3P6nlCyujPjhZLZKcz878cN3qCUizef7QrOUAqcztvfZCdLFopE/GFKEz5x5QlrmCXASpkVf7AAMTOR1NiEYjpke9wqslzUCfncEMJqS9lisC0SalR4x4o9DwAEp X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR05MB5577.namprd05.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(366004)(376002)(136003)(346002)(396003)(451199015)(86362001)(316002)(26005)(52116002)(6512007)(186003)(478600001)(6486002)(5660300002)(2616005)(41300700001)(66476007)(4326008)(66556008)(66946007)(36756003)(8936002)(8676002)(83380400001)(6666004)(38350700002)(6506007)(38100700002)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e/yygSxHxMzlUSrMOrB1ayYKORhorcox8sCccEVQxO9qRSP0GEj4E+lHyqAI4Cn78ErTgN7JDDlTWly4DQOz59PJs0wewKiBLH4QYtLU1HugHu4LJc0LdGzxNFlcUNJdiTOvFMHdCx7jFYInkTsXgFNgjtqECSRFYuVBL4sDbXsUznhIlWKPY7sBFMg52OzzXHX6D5P6RJ5j4mLexSNRDjKuRi3jTbz/FMEpJr0Mff0G6JTxFh1vRF9E9u8NRw5U19KhLXAs25+QUZHPTorUzzTXXUDn6Y/1tRp6VFqurVoXxmqorGePgu9hwcLyNGn6N+F5rNaxoeQUr/sBvEOQrA3yMb5HidY+ViJ28UTjcEYln4Pk2PHfVGa0Y3rPTIjsdIycmD/WBnAxTm8ke3jDO8uwX3s2TIFZXyPrxXyHjO3ACJhthkeoeEzCN1oNHUpueK3UqeenfY0434/GbtpETa/F7SIU35cEU/aQIfuX6ogWxjqRZMB21mEDExUqkS5rijV9sdr7xFD5I8BebhmqH0aZ+Zd76yTnoLb2dxa/Y6jYE8UhSeQaOrZpiPe0A9cQhilrCdkhvDw/C3cYI/b6wFeBejz5RReMnuBvY/4LGAid+lEXDNM+v9QRj3BWxYKpdkhXeZm7f/e+WtE96QuBxp/ZT7a+XQbWKJKBcXJrBFjbN9DtkQKXuFQlZ8QG0rqgc7kvyaDLI2bqoL7qHKreT7LC8jx+g7xN8JJjaXxsSo1nt/g4dBErdF4bhH1verjiYYADcRMTHElz91+vKmESzPlOKueBEkKxT/rbu53RFJIuttTrDtSYxdbTFzoJyZiQfiV/L4M2LJD8G9zg61O3mcZq5Kis/KFsM+WZ0s1mo3HY9FRtJaytYVBi4EwDibb2JtB59OXbBCDplE5YjeOO6NTvXPQ21ehenPvzUYHgqQdJMTKF942HVhTrgZGLFT+25OIb1ZQWfFgwB/BuCHrV1HBJwYhXkfaRDYtWsnF7elFbxFHC4kKeJd40MdQ3Nx97E0MOLA5MP1gfEqddQVUVVaGNSUopYUv8x2XXhimKG6Gd+uVH7ycS7hksfZ9+j2QwLE4+LKf52jfGnVpgv7fewKjDFCn2bt5B5MzkV+/VtAginTu4ntljYzyFiVfSzj5I0fVcIQFclR7NQ8E8qIzfwQD0lVhfPhgGC7EUPJvu6gLYo/xwoLbKYktfsgf68uXdGrP5p3QvT/fA6aXmgzvPAGgFxgeP3UnD/eILBi2MjmhlOCyLsR/5wP9k0kc1I0ilYhXIzn65W8HomIxXcHkJQymnHBMT6VtztpdhYEIBjSry6WTV6+WrbtLCaamLqysWnslh3wGeBdraGNNnlwmCVrwTINN/fBI0qpMQne2IFMCjYzzJneDLvve2pAG0TuRBW2ZSwhUYB2uAH7zBxqSQVFE9KBnUqJY8rSzx5jDGoE49DP4Q7ffB5tpPcmFJAinIdH6aCVBCnfDwdS8jwR6e+xDPw/0yI0S52aaZto7JPWGumZ0CWyyLaXPm1r/9TB568Ue8WDenxEgfMLkzKZwpmS7BoMpnV7KdTHqXgiHmUei05FKXRE/MP0iC+xLUHwL2 X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dee0401-1c49-450a-fdfa-08daf568d2dd X-MS-Exchange-CrossTenant-AuthSource: DM6PR05MB5577.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jan 2023 13:19:39.0764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sAkqcNy0O558eeHhmOk1cWbgs/S4QTHLRdIeEvBl2ZqNiXLzH1rRjf11975KVXTE0MXhuyh7DYYdnkXwS0UMOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR05MB7015 X-Mailman-Approved-At: Sun, 15 Jan 2023 21:11:39 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case of i40vf, VIRTCHNL_OP_DEL_ETH_ADDR and VIRTCHNL_OP_ADD_ETH_ADDR are unsupported. i40evf_execute_vf_cmd is invoked with these operations as part of i40evf_set_mc_addr_list() The cases are not handled in i40evf_execute_vf_cmd() thus hitting the default case. There is a retry logic of upto 200 times (2000 in iavf) with a delay of 10ms (1ms in iavf). This results in a needless delay of 2s in the init phase for each VNIC. The patch aims to rectify that delay. In fe2a571c70cc397f2ad4e280f8d084148fea5d62, i40e_ethdev_vf.c was deleted. Hence adding this in iavf_vchnl.c. Cc: stable@dpdk.org Signed-off-by: Vipin P R --- drivers/net/iavf/iavf_vchnl.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index f92daf9..e2f65f5 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -367,6 +367,14 @@ iavf_execute_vf_cmd(struct iavf_adapter *adapter, struct iavf_cmd_info *args, } _clear_cmd(vf); break; + + case VIRTCHNL_OP_ADD_ETH_ADDR: + case VIRTCHNL_OP_DEL_ETH_ADDR: + PMD_DRV_LOG(WARNING, "OP_{ADD/DEL}_ETH_ADDR unsupported"); + err = 0; + _clear_cmd(vf); + break; + default: /* For other virtchnl ops in running time, * wait for the cmd done flag.