From patchwork Thu Jan 5 13:57:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 121624 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F739A00C2; Thu, 5 Jan 2023 14:57:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9233D42D1A; Thu, 5 Jan 2023 14:57:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1FFE840DFF for ; Thu, 5 Jan 2023 14:57:44 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672927063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/zIY88FREZdc8YUBlVJCm9nUXh5nieE19ub9BT4yigI=; b=DngAiixBBDAjRt1T5Gtqs7FqHrm2xjNc4Lwa8ZjQKO9PGKZvI8WA+hSC/7BFX91YYPV5oS BQiAfeMzNlFgzha0LBOIheVAXNcE4FYDU8Vv09qlDVYyuoHRgUt+U5iKZ1WuGNwimEOo9Z WPAl2gUBIycemb3+1UgR8XQzBs331Ks= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-77--AfXQDp7NE6Rn8JgH511nA-1; Thu, 05 Jan 2023 08:57:38 -0500 X-MC-Unique: -AfXQDp7NE6Rn8JgH511nA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D6DA5280BCA3; Thu, 5 Jan 2023 13:57:37 +0000 (UTC) Received: from dmarchan.redhat.com (ovpn-193-12.brq.redhat.com [10.40.193.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 314DFC15BA0; Thu, 5 Jan 2023 13:57:36 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: stable@dpdk.org, Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Stanislaw Kardach , Dawid Gorecki Subject: [PATCH] net/ena: fix deadlock in RSS reta update Date: Thu, 5 Jan 2023 14:57:33 +0100 Message-Id: <20230105135733.4162954-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add missing lock release in case of internal failure. Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Fan Zhang --- drivers/net/ena/ena_rss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c index b682d01c20..d0ba9d5c0a 100644 --- a/drivers/net/ena/ena_rss.c +++ b/drivers/net/ena/ena_rss.c @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev, if (unlikely(rc != 0)) { PMD_DRV_LOG(ERR, "Cannot fill indirection table\n"); + rte_spinlock_unlock(&adapter->admin_lock); return rc; } }