From patchwork Fri Dec 9 06:22:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 120685 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02D8EA0540; Fri, 9 Dec 2022 07:23:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94ACC40E0F; Fri, 9 Dec 2022 07:23:30 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2099.outbound.protection.outlook.com [40.107.220.99]) by mails.dpdk.org (Postfix) with ESMTP id E98B140E03 for ; Fri, 9 Dec 2022 07:23:28 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gapRUR6ILmcPoycP6X+MUwkr1bJ5NdZ+401OzB6P3xL2dpSZiazrU/SE8o7fH8AS4/XZFXrV6133uNcEHZm3GM+muNigsyVWFcc5QSVvgEwEi8m9Vey7nChn0hm9g4wcoFcj/qYwlMpLcl1M7STIXrzgygN9KB/dztwvJWA9aAbgK2pqCMfv++TDY4NPCXyI3S41v6V7iRRES+5PGWTL9WhuHXwgVTO1Zx3AjqDUWqmhK08ku3N40CF6r4LyitFuNp6c3UwcdvEWGnJ8PPqK5yxrYg0njghn4wR/uGZot5NuvyWfaGiIwv2CvxKi9Ymew0iNFSmAN2exafNWo6i0Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Or197YcnYU5Xsw07O9h8yTWROrUMtGh78Gdf75pCjKo=; b=Q//WkEuTJwJlkemUxmnHzPgP89k1SqclMIRCgA4UgHma01VdyR7Y7oa3mVDt0Tpw9x7R4kRkMWsOo87rkDov6xG6sBj0OQgifdix4HwC3PCHOwBagp2S+pXk0KH+m8CIoH0G1t9VQvPoaZt5DuAcoem96ja4tDpU1/MAfI8eBrSxpR1EyrpPrZ5zUdzb4/JkDWEJOC6jE99ASao3lazgsZtPkrFlZ+nOtjz6EnV4ZwN7nzl5vGwynB2FrZwstV1LJ0CVoUNw2ZEyl2ri4tXz1glewAinHPgsoFpT2kk9eB5dZpYjdOVwGI8EP+zjnyfS1Xcv3lX+WZTqEaWl4HHmSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Or197YcnYU5Xsw07O9h8yTWROrUMtGh78Gdf75pCjKo=; b=tg1FJVuKVXYiOO45OHvZ3pvJqca/uVMXtGRl5IpTT62e9VkmW7ZhfUWvchLU9g3qEcAlwZvtYNyGoCjUWyw6QpWOmuDUNgK2oVeesMjPwEyiJCHZ8Pakvsi4wYf5toW03YBDX1T3mHN8nhM8GJXeO/R7TifsyAGzv3RzN4UrPkI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by SA1PR13MB5564.namprd13.prod.outlook.com (2603:10b6:806:233::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Fri, 9 Dec 2022 06:23:25 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::5122:8c31:51f3:4ee7%5]) with mapi id 15.20.5880.016; Fri, 9 Dec 2022 06:23:25 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Chaoyong He Subject: [PATCH] net/nfp: store counter reset before zeroing flow query Date: Fri, 9 Dec 2022 14:22:59 +0800 Message-Id: <20221209062259.22341-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.29.3 X-ClientProxiedBy: LO2P265CA0151.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::19) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|SA1PR13MB5564:EE_ X-MS-Office365-Filtering-Correlation-Id: 918d9c53-d79f-4a66-e56c-08dad9ade0c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xrFgMDcSAIhLSQKa2Vq8jXjZoSAD3atsH418sldLOLB5b1qfYUQsBJFrO/KCQ48KEvTC04WPnWMzj4uu5YNN4Hrog0VcP97BSULhla6H1TMHdgaJgOytUff0nxwjbOFsxKEWZOXAvInCj4NSD+K7LoNgoPjRr6kDnabQz+O0Xif2bOZV6GphHchLMZW1EA2e+VZRZTLAjiv+WMgRi9q1ZG0VyH5K9P+NNVeMTG69BytP6ItJr1jFdjYGVy18iTgeesE7TrMvXdZeklnHccxrEFlFu5WMBhV/27p6bdmI3Hzc5QeJ/gmdIYTl0lz74/kLLBRuQ/kCEOWvGinkFjYC3drfVNJILNGnxmHN0dAF26+N5nj03Avrf1bHROF6uRatUSpJNsP4KlCEfikDhCoXGaKH1zYx0AWUrrEk5FHmPTxW9bLw+xqUX9mqa++LXPQik+hDQVhozR25nml/rFenzXurf1FyXblZiqZ7ooIpkr8fb6uXkxRX1L90mS9sIGq/Xoiq0JEDBG4906iHYAbT6FSiTFGYOa6ABt6SwYoZSd9qS7GgufoH5F3sFjQnhxiDm2HuL66siSaN/+qVCuGWwLF2mLpxqKsuTG6ZSZnnpt+Zn6q8q7P4L1859ckRpRkWf5EMO2DArMrPFApCnnejsCBLHf17GnWfmwTftZogWVju7retjnLnReic/etyGk927iNF7EKH+lDQ+o7UJD3A+jQPsL3lkYNqYs5W/Kwba7KPo99nMF1inFZ6aRugLTJO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(346002)(39830400003)(376002)(136003)(396003)(451199015)(83380400001)(6486002)(66574015)(38100700002)(478600001)(6506007)(36756003)(86362001)(6916009)(52116002)(1076003)(2616005)(38350700002)(4326008)(107886003)(44832011)(6666004)(26005)(186003)(6512007)(8676002)(66946007)(8936002)(66556008)(41300700001)(2906002)(316002)(66476007)(5660300002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?bqohIm9o7+REACmbS3idi+5Ca0zR?= =?utf-8?q?sNZyw9+LInZ7bl129KqU2IWotRAYDvGTfuXv8mDzsQON1Dh36Jr7FcRT6A/Hn6Bug?= =?utf-8?q?GBXrCCCCBAQBIAg9y/jmErz0nla0SVq8FIF96MVtAjHCZ+PeeC1MO2/HX5B6sT3IB?= =?utf-8?q?HnMvuGOJueSLsJA8baMPW7GO3vtEnaCyojNNOf7U5ulztTgMh8umtcCRrn8FlOp0u?= =?utf-8?q?XoArVrbe8QA0vNva8+5Qyj9tKyEjIZXlfRr/lTjx4jrrG7dRVyeykInWSXDvgzxPS?= =?utf-8?q?TU3M7+ExpiDdlNz9CWe18No21nCQ3Dl5agGS8pgW9P1VLhWxOoZtfqct+UI5tyBix?= =?utf-8?q?+cDcf4M+8ShAl4HrhvtWLFWgK9wfl/Xn4YUxscRCtX4zhfhSDsdtIXMio8W4GExFb?= =?utf-8?q?s8oASGu/+7xCVpvB4AQIYW9AJVr309Q2zQEdwAM5l40v0Ros1sbiXg42Ob+pJS92s?= =?utf-8?q?z/u44Iqte42l6vtxiunctrqEdWvpWHggsxfU+9mreFvEcMAphqwxg+a4OMrMVfFMm?= =?utf-8?q?wbMhZ4cAg9Vi7PXjTuAfABWnuajO1ePXPcnDtD7V88lfr0qDUlmNlP4cWw0MQ9yDP?= =?utf-8?q?4eWlNBDDJJEA0ffbEGSGNWCPn7urmw0QJAIcovpH4YdcUw6FVqK2csgyAad9xc8Jv?= =?utf-8?q?SqDHX+iSOL3fFT5nxshJSgyDjyhluwdb15kSX0rslaXmqMU8zdBtnTV1TlfQ6qPPz?= =?utf-8?q?7CRUWLpl3k/6WnaV6btThInimwBZjnD9gCo74IEv40d6f/ii3CIl4elIjjl1KS4u0?= =?utf-8?q?X6wXRr+q4UPBHwyh+aiTyaV6frLXpd2KOc4bJ4z/KBpW1o6ZPvkmvfOcrHLJRMYIm?= =?utf-8?q?OfFbrrVZlWK0Zsdcex02ed2idrWPANL/QOY0xrtFVZlUXBsT9nBpn+x0vLlWolHiw?= =?utf-8?q?9l7vH2Ox3eccN/HVtIiqasAy/TiVPqiAjeQ/KhJpkAXwB6Q5M7q0EFMNsVOa44Vz0?= =?utf-8?q?Rz1m5RZ5/0/hpcZoYb68zBvRtQNF51y1BnDBaIbgLG9zvHTgcsDWOyi/lcMESzx+I?= =?utf-8?q?8f1KUblbDOkC2U+lLyNm4uH4tLk/KHe3TNryJPnOsZferAFUaTN/zgz9gORsQkOIV?= =?utf-8?q?mfn787r7df4orG7QomFq2TDhfyMM964QjqDck9CcVuxqa/YYfF4VAmXkjnfVWQatC?= =?utf-8?q?7xLY/NjPWyWTzNiCmqCORDFKvbOCSZWjLGH2YoUx+vCK7Rq7/rderKV3651It0RN/?= =?utf-8?q?N4YyAMx4drugH+VxWPEOUna/p4lz+W9fULCSjc2zQSXQBZE9qPa1wyCyREDiITMi3?= =?utf-8?q?/x3gQaCTW73/tkZKqgBKp1Li3yX20CAVnNViJEF26OOkDr147Kf2VOu54NcNPwZsJ?= =?utf-8?q?U7N0H29kYxCozZjCD+nxPLDPzcEEGZ6bIMfiRNpbnziG9LVCgk2CRRQ+cXfin4mEk?= =?utf-8?q?a3lVn5f4th58tSzv69pnLBvYoeWyhv/qBmRA1FN7ZHDclLr+XjrsujMrrVqm0aUFF?= =?utf-8?q?LbxRcIpFYYeTHhi127N6WybwAdlBSv2hJfcQP0bEN+o9+fvKbSSdBtt2/VOLn2B5v?= =?utf-8?q?QkXC8StYZnGXMCRKVrjQ1KrIPPtbyXY6aQ=3D=3D?= X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 918d9c53-d79f-4a66-e56c-08dad9ade0c3 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 06:23:25.4068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 32BiGlqAkv3S7obtDssjVw6WZlVgZpIbS9KmgTZesWPcYYwxuqvE5NYiimWuMl2gCTxige9CZdXpxYMPU4E7OYTQVZ22mkTLwrkS+9iOoXM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR13MB5564 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The reset flag in the query structure are cleared by mistake, cause the flow count never be reset, so the query API will always has count value even the flow has stopped, and this will cause the flow never been aged. Fixes: 30ecce522732 ("net/nfp: support flow API") Cc: chaoyong.he@corigine.com Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_flow.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 6f79d950db..e177e75ff8 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -3809,6 +3809,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, struct rte_flow *nfp_flow, void *data) { + bool reset; uint32_t ctx_id; struct rte_flow *flow; struct nfp_flow_priv *priv; @@ -3823,6 +3824,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, } query = (struct rte_flow_query_count *)data; + reset = query->reset; memset(query, 0, sizeof(*query)); ctx_id = rte_be_to_cpu_32(nfp_flow->payload.meta->host_ctx_id); @@ -3834,7 +3836,7 @@ nfp_flow_stats_get(struct rte_eth_dev *dev, query->bytes = stats->bytes; query->hits_set = 1; query->bytes_set = 1; - if (query->reset != 0) { + if (reset != 0) { stats->pkts = 0; stats->bytes = 0; }