From patchwork Wed Nov 28 10:28:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 48380 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B16301B29A; Wed, 28 Nov 2018 11:29:14 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8EF681B127 for ; Wed, 28 Nov 2018 11:29:13 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 99095300159A; Wed, 28 Nov 2018 10:29:07 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-117-158.ams2.redhat.com [10.36.117.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A6B864436; Wed, 28 Nov 2018 10:29:02 +0000 (UTC) From: David Marchand To: nhorman@tuxdriver.com, dev@dpdk.org Cc: thomas@monjalon.net, echaudro@redhat.com Date: Wed, 28 Nov 2018 11:28:52 +0100 Message-Id: <1543400933-1723-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 28 Nov 2018 10:29:12 +0000 (UTC) Subject: [dpdk-dev] [PATCH 1/2] devtools: report the incorrect section when complaining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It does not hurt reporting the incriminated section. Before: ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in a section other than the EXPERIMENTAL section of the version map After: ERROR: symbol rte_meter_trtcm_rfc4115_color_aware_check is added in +EXPERIMENTAL section other than the EXPERIMENTAL section of the version map Signed-off-by: David Marchand --- Used http://patchwork.dpdk.org/patch/48354/ to test. --- devtools/check-symbol-change.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 1d21e91..66741be 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -115,7 +115,7 @@ check_for_rule_violations() if [ $? -ne 0 ] then echo -n "ERROR: symbol $symname " - echo -n "is added in a section " + echo -n "is added in $secname section " echo -n "other than the EXPERIMENTAL " echo "section of the version map" ret=1 From patchwork Wed Nov 28 10:28:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 48381 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7DC01B465; Wed, 28 Nov 2018 11:29:29 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 078BC1B465 for ; Wed, 28 Nov 2018 11:29:28 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5ED5C9D798; Wed, 28 Nov 2018 10:29:22 +0000 (UTC) Received: from dmarchan.remote.csb (ovpn-117-158.ams2.redhat.com [10.36.117.158]) by smtp.corp.redhat.com (Postfix) with ESMTP id B0FFF63BAC; Wed, 28 Nov 2018 10:29:08 +0000 (UTC) From: David Marchand To: nhorman@tuxdriver.com, dev@dpdk.org Cc: thomas@monjalon.net, echaudro@redhat.com Date: Wed, 28 Nov 2018 11:28:53 +0100 Message-Id: <1543400933-1723-2-git-send-email-david.marchand@redhat.com> In-Reply-To: <1543400933-1723-1-git-send-email-david.marchand@redhat.com> References: <1543400933-1723-1-git-send-email-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 28 Nov 2018 10:29:27 +0000 (UTC) Subject: [dpdk-dev] [PATCH 2/2] devtools: drop '+' from the section name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The incriminated commit did relax the condition to catch all sections but dropped the + removal which can trigger false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section") Signed-off-by: David Marchand --- Used http://patchwork.dpdk.org/patch/48354/ to test. --- devtools/check-symbol-change.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 66741be..8b36ccd 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -31,6 +31,7 @@ build_map_changes() # Triggering this rule sets in_sec to 1, which actives the # symbol rule below /^.*{/ { + gsub("+", ""); if (in_map == 1) { sec=$(NF-1); in_sec=1; }