From patchwork Wed Nov 9 19:06:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 119633 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C29DA034C; Wed, 9 Nov 2022 20:08:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1989F40687; Wed, 9 Nov 2022 20:08:03 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2066.outbound.protection.outlook.com [40.107.94.66]) by mails.dpdk.org (Postfix) with ESMTP id 1825440151 for ; Wed, 9 Nov 2022 20:08:01 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eD9DGSudJQe1TFKJCDLevcRNR8JIyYpDsbth8X+blRRt2zSVLeKnafF5LHq6eiWGUVQOxwTcoQNvA+mYsQGrsgPnQUSKWWwecMYxRJE+FdXO5GGOfzovlzT7Jq8bSkkSIDXBGb3BlqUQYU4Y6+VBprZVtdywUlVlMIsN4ib9INvAQXtVHtKXEaDVPkqd5ncJhxT9WYgfF8J+b22KXerB/Sf8F4ZFLc3ndBUiNDgrdKmKJHLF0+SeG0ZmB0NVB+4BRlYFubt4V3Ry+8lPLsEhgwQd9qSpwucS6N59Dg9wGSCFag8BvHAAfi/Yt/IMNL164390XZVbAQNVMWKJofuDKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BBvUmiFyW+Rllnrj4qD/j/pmmPg7ZAPoqkfSZnCLZvw=; b=I1lOMh9K2od+ihjtdiKlGF3HI2KT6ObmqaRynOhJL7du9+faPXq/q0Gzxg1iVe8zniwN6Ia1e3/DOnFFp+P7caEqHQ/ZTWmFNllBiM+IR4//cQvyqN+fQc+owg1uPjx4+FbqYU1yHLrmzr8froZz8v//5oMwA7jgJDPS4eWaqRgW0uKsYSYLVqIo/mX5aLMmMWcE6UsUEqvAsQUw8pkk5qC8+oYq8tpoJGN5Q1Lkbhupzxp5VmPMV3lLyM2ztnPpkq4fDxK+mVgxr5nrPOMJhMETMS68MONB1l6CqHHMxPMpa+KwDb5DN00vH5Y38N6a6VGQfmOpPFPhHgj4vfA7SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBvUmiFyW+Rllnrj4qD/j/pmmPg7ZAPoqkfSZnCLZvw=; b=GjCMlSk21eTeTLwgy8qlITY12/WvtbCEXIF3OegCkgT8X/N79/X/Q2FKrAu8FFD+4RB8duPKvok5/njX6jePafcz4yz3gmqyOrVF1Q1npDW2I/hpF3hoF9wrMF3RYb7tF4tPS7I+6LIBl8yJuHZCEl6yE/C1ooXHo2uYxHtwh5J68aKgcRvqRSIRzYN3CK6LDiAzjkhB7E/7p45brZ6Rah8OHhcXG7rChbzQS3gknfrfqUtyg+ZU5tM6hu4K3lXtGo++044GAZgTZaHlfEPGdIjzsJOb/qbKR7HKFozlhdHEPwvYspEPZfblix6Sv1UwRRYNm2CC2DetGU3PkV55Fg== Received: from MW4PR04CA0310.namprd04.prod.outlook.com (2603:10b6:303:82::15) by CH2PR12MB4103.namprd12.prod.outlook.com (2603:10b6:610:7e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 19:07:59 +0000 Received: from CO1NAM11FT006.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::ce) by MW4PR04CA0310.outlook.office365.com (2603:10b6:303:82::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 19:07:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT006.mail.protection.outlook.com (10.13.174.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 19:07:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 9 Nov 2022 11:07:48 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 9 Nov 2022 11:07:47 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko CC: Subject: [PATCH v2 1/3] net/mlx5: fix log level on failed transfer proxy stop Date: Wed, 9 Nov 2022 19:06:37 +0000 Message-ID: <20221109190639.886457-2-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221109190639.886457-1-dsosnowski@nvidia.com> References: <20221109190639.886457-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT006:EE_|CH2PR12MB4103:EE_ X-MS-Office365-Filtering-Correlation-Id: f19be30e-dd2b-4be4-7d20-08dac285b754 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JfEylq7gNoT6LWja8TAN0OhCmA5EPgEJmMxnNqGPvpsirbwaGxxe3FStwX2azrKkVzXITh3EPWC6gRCj11K8Wk28lKD0z8CZ6od1OG+vnBZAjxixcSK98HxrHUsxG+bAOC3xoLh7f1Rc2OPPkLCP2+Bo304X8MONfXGloJqantp0uMhHR2vaZcm3F/sLn5zGHHqxUQNj16h4zczIdrJjZmKoP2dlzyfNQJ+/Qct768pJRTZQYsrR+UdX1+AnLNLVDj8HL3Mj1vsawU5fksBqR5+JqtFvbWItl1U/SMX6dA5JraGez+azyXHeWhvVvrUu+UJwV8mvoA5p6QXiBbd/RSX25KrsVUDI9V6X6uXedUHNTvzQ81RvifP1JTD0IbQVzg062nwQoZ4oLKY4SeZKRVzWnVf/HXlblApQ1QaW2nlso22y6lJYMFAQZBj31HYHRJA4io8KipAsPSK8ebRcski7wQESlVGrrqQ90Dq40A2dNzwSYMxgpRfY39AktU5Q5FRa291mZgtBXP/xBgPgdHmrf0ZZSxLf6Ey8AEs9yoamqPNYri9IeU56mnUGE45TE13e1Sg9B8B0//rJRr5I9KSc9t7l/GkctNarUD2DCXM/63D9MH58Jc6yn8MmmubkTjOXnK/I7t58OBQEZzoR7Hawd5qmgkWE+HZnJxCVS6AdY1kbATcsweEJUIYoFIP8E0+VzKKIIXQEBZhRxwqUt7MLpVkOMnEHcTnEOOfb3XHEkdJ6ql75QlGl3wLAhQwEJ8l2FRHVlnFiNmDaRsVcHQ== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(346002)(136003)(376002)(451199015)(46966006)(36840700001)(40470700004)(82740400003)(316002)(7696005)(36860700001)(336012)(1076003)(47076005)(16526019)(186003)(5660300002)(40480700001)(83380400001)(40460700003)(2906002)(55016003)(426003)(70586007)(26005)(6286002)(4326008)(8676002)(86362001)(41300700001)(8936002)(70206006)(36756003)(2616005)(82310400005)(478600001)(356005)(6636002)(110136005)(6666004)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 19:07:58.7615 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f19be30e-dd2b-4be4-7d20-08dac285b754 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT006.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4103 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patches increases log level for error reporting when stopping the transfer proxy port failed. Stopping can fail with EBUSY when related representor ports are still running. Fixes: 483181f7b6dd ("net/mlx5: support device control of representor matching") Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_trigger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index 4b821a1076..310a84729e 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -1361,9 +1361,9 @@ mlx5_hw_proxy_port_allowed_stop(struct rte_eth_dev *dev) representor_started = true; } if (representor_started) { - DRV_LOG(INFO, "Failed to stop port %u: attached representor ports" - " must be stopped before stopping transfer proxy port", - dev->data->port_id); + DRV_LOG(ERR, "Failed to stop port %u: attached representor ports" + " must be stopped before stopping transfer proxy port", + dev->data->port_id); rte_errno = EBUSY; return -rte_errno; } From patchwork Wed Nov 9 19:06:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 119634 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70DC7A034C; Wed, 9 Nov 2022 20:08:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2512410EF; Wed, 9 Nov 2022 20:08:06 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2059.outbound.protection.outlook.com [40.107.237.59]) by mails.dpdk.org (Postfix) with ESMTP id 54F6C400D4 for ; Wed, 9 Nov 2022 20:08:05 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iY4BN/modFQcHCAkDKITQtkYkHVTsyerCNMdb1Hk3qcjd7VliikYG3IylPrNNucw7xRlHIam2hY3ZJdY8HcfpqDKpwaocNG13c9os7qS4Cf/GozNkS268OFbNZdKXwyRJ7rfQ4BGjPR4dmYTKUu1b31z1JGV5/o9DAloiq2vi/hscu19hrj8LoHyLlUd0awIFSJj279aKdfYEtUm8y63EH2ntP1aF592fqHS3kiLcQYM4I3s9E26lRC0/pNPPbDQOHGwUuknAmQn1qNWoMieAo5plskjiBsWQuLCUUs6lzZXjKElCdmUCzsHuDrrtsD/916M+CKxfAGerx1OfwjIow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u3Wg0xlVS8Ymue5eSf0jZxh2aPF51PTccSJ04XMtnOE=; b=T5rrXFYhUTd8ebgOZQQIyEOQoEeAuKZzXvjHcGTjUxN3WRA5IM+AVNz67SyMwvsC4yav/WFodKd79fGIN+vCQCsQKdkGsHk1tuKpyjNbldDbjjm41pLKDkD7kykZReUMwIdD5P1y/nUACtaoV7jerehGcMQOYx9KIZMB+0LIzAfssmKlW/R8KjP5AVAyjWTacgwrWwcv0Sn7r+aVz0OZtLBGh4lMtcf3Xm6x2+3qAYBV7TrgLmOEDkl3dSXQGS++Pp/cTrbjDdUrGW8khI9dEfO82ZUDVRdJzP+Qr4C6D2+GF16eUImay29uszpHv5Col15UCNtvR6pZwM4g0MZNvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u3Wg0xlVS8Ymue5eSf0jZxh2aPF51PTccSJ04XMtnOE=; b=ESEW0mc+PW2oZgxCljg66v9mBnwTuUDnosxs4Sle0oHO6EBW9ErMM4tS6qGA0L22HGRGm0BCQm8xCkggUB+0xVMl7sBKSIK0wKGAWGE2euXqhuNIu3uZ1saKh1xQx3uRqK/sr48I63Qp9v9KWCV87Axazm4d0i5fvBitfQudrEXiQGxfvdKeGQddTBdXZfInpwpTMG4aMiz0pZKGtIHU3blErs0ZWEiLRS1bt1qjmmgsXpU8zJ2YVMGsUlT8+oZ/rwz5vjF9ShpV8g7CF+5LYTwXPdnKfcLfL2KXPiVBG65YjuSM6xhLE8gwxTB2ZxQupjZ2hHowLlcfbHNfEhg0EQ== Received: from MW4PR03CA0228.namprd03.prod.outlook.com (2603:10b6:303:b9::23) by CH2PR12MB4277.namprd12.prod.outlook.com (2603:10b6:610:ae::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Wed, 9 Nov 2022 19:08:02 +0000 Received: from CO1NAM11FT067.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b9:cafe::80) by MW4PR03CA0228.outlook.office365.com (2603:10b6:303:b9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 19:08:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT067.mail.protection.outlook.com (10.13.174.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 19:08:01 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 9 Nov 2022 11:07:51 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 9 Nov 2022 11:07:50 -0800 From: Dariusz Sosnowski To: Matan Azrad , Viacheslav Ovsiienko CC: Subject: [PATCH v2 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD Date: Wed, 9 Nov 2022 19:06:38 +0000 Message-ID: <20221109190639.886457-3-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221109190639.886457-1-dsosnowski@nvidia.com> References: <20221109190639.886457-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT067:EE_|CH2PR12MB4277:EE_ X-MS-Office365-Filtering-Correlation-Id: c42635f0-e48e-453e-bb7f-08dac285b93e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sEumboZ8f0Bbj76L+xdqDnbzRsP7cpe8Csc/9b5TnWqVgNshytF5ckJapOZiTwNVtC1CYHPxbT959c2QLCh6wR8CqtvUUBn/VJr/XUe/p/XhhuKV4mFkZ0qH3S4Kh9Cq8IvA/lnswREXyUYiGyLF2iyHwpdRHiMt2bw4cszESGOYGE+OGV5jTM+71pSBaHuCW3ePH0hY+grlhj1R9NaF3HWgwoxObYKKtWa4bE80kFlXBVlKjCw8befJ3nkW9yMWkxAOC/P47q+OUV50YSCZ9IRTlNaArGTxQt7XuvHvjHLH3nL2BgEPHOx+04QTt+E0kt1/ALzAQ/dIADXllOGHvWAsdtlMP5VQyiW5htbHu7oNLJ2Ne2LJjOeYoZYOlZZvpFW77d0VpxixeH7fIXdLV+xLYR9jAfIxpQsMWk3v8qTUAC1m9irG7K0Cc1aMN+m9p3l56qC21xXl8BGa/QjwMUGXKzqmg+FCrMX2zm02UwQeLw5NxBGcUPu9GJPXq3Msfd264D19LNbXXZ8wnZ3Un3W8FyPkW9xI8EKPSr53dY1K7gtikUfTGcPlNT95Epsx2S7VcGN0vU+5ACGKhNUKVLO8SiOiVjuOszBuOul9tit/KAWw0tnvmmPzY+G67mNzVQHkW+9VkziDLBKBzjinaaKAvrK/iycvKRbhCIJ3S+vPS7ApVnMWq3zZPR2BFKmQXZTWVMSgiFc+lhon3jRV+aJmfrHHPmal24cimW99aEwYErAc1LejXobgNZfOo8EqPgtcZcBU4qfhkWHaHU/0gw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(376002)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(6286002)(26005)(186003)(2616005)(47076005)(82740400003)(426003)(83380400001)(5660300002)(40460700003)(36860700001)(55016003)(1076003)(2906002)(82310400005)(478600001)(40480700001)(6666004)(7696005)(6636002)(4326008)(8676002)(70586007)(8936002)(41300700001)(110136005)(316002)(70206006)(336012)(16526019)(86362001)(36756003)(356005)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 19:08:01.9587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c42635f0-e48e-453e-bb7f-08dac285b93e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT067.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4277 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch adds the following limitations to the mlx5 PMD guide: - With HW Steering and E-Switch enabled, transfer proxy port must be started before any port representor. - With HW Steering and E-Switch enabled, all representors must be stopped before transfer proxy port is stopped. Signed-off-by: Dariusz Sosnowski Acked-by: Viacheslav Ovsiienko --- doc/guides/nics/mlx5.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index d5f9375a4e..ca555e7ca7 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -161,6 +161,19 @@ Limitations - NIC ConnectX-5 and before are not supported. - Partial match with item template is not supported. - IPv6 5-tuple matching is not supported. + - With E-Switch enabled, ports which share the E-Switch domain + should be started and stopped in a specific order: + + - When starting ports, the transfer proxy port should be started first + and port representors should follow. + - When stopping ports, all of the port representors + should be stopped before stopping the transfer proxy port. + + If ports are started/stopped in an incorrect order, + ``rte_eth_dev_start()``/``rte_eth_dev_stop()`` will return an appropriate error code: + + - ``-EAGAIN`` for ``rte_eth_dev_start()``. + - ``-EBUSY`` for ``rte_eth_dev_stop()``. - When using Verbs flow engine (``dv_flow_en`` = 0), flow pattern without any specific VLAN will match for VLAN packets as well: From patchwork Wed Nov 9 19:06:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 119635 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE95BA034C; Wed, 9 Nov 2022 20:08:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3432942D1F; Wed, 9 Nov 2022 20:08:13 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2050.outbound.protection.outlook.com [40.107.95.50]) by mails.dpdk.org (Postfix) with ESMTP id C790842D0D for ; Wed, 9 Nov 2022 20:08:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b2wYcxJmO5+tyQgnfMBK40abSfFq7ttHKLOZY5s4niPUBoCII626kgAA6Y+CrJb1fjm82Wyj1R4gN6HzKXFPLtaoUx82HYzLjWjONN+gxZGUaWM5A4Srl1EdT/HT/C7/ZN/aw4sfgeutKn452T5m4vK6L3IElCUZ7Uvu7SpRH4xl973sicQzcY1peonBYWwqYnTJGYT2v6kbwIT830HXeE1J9fxsVAN3pI1DXR+T05kxt8yl+PrxuIcujzwl2o1zalpZjglkQfWuKnElUFS24G2ZYwVJ2zs/p/cuE/RV43ssB3K7nYDlc58ss+Zr9Jb/BNNDRLuRfpSn7yjM1TJBAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YUnI7PoivOnrhyCGRI5fSbvJceMXDChzBUKCnu0ajKs=; b=RY5oL+A+lTq0OUR3n53/PJdtLNwSSNBdJcZkhhlwvzCDXR8t/A+7jN3XGyBKOk4+Q6aarDlqzRNpLbbPGjr/8Vaa/wUNrKXYoxCtJpCdWemqH3Rg9413DhiGczlITXFbGuapW18fnNoHYqxGktF/1Og54q6kwWRv/503agEBXAVgVwnNity1behAqWPNqjXhU4FRASfyjCu6+zPgr4mUyJNwr7UCQ68Jaat4kTvq6ME5kTRqeeRfe3ylwWnl5SwVe8H03OLMsOJU+GECuG+rKJrkh/lTSY7FlYYFKfR68CGwezYjrcXG+K1/8EnafDoSC0fGaIORQdRR2+XfEuQ0XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YUnI7PoivOnrhyCGRI5fSbvJceMXDChzBUKCnu0ajKs=; b=l8mUXlPP/yWufgZowmAxUPymNgsNX9rZGpPfylaA+vLv6HD050v0H3rGRsLwFte5YZ2121dnnKxwEvKJmss++NB/Rv0Vgg62PdMWRbrKRykyyqetvXOMtHQlTihU+KzcNOq3H88xwXTmqGmxwHYXdyjhW88u3bhgvAGflr7TjxmzdpPrl5OP0VNz1MSngi6OS7j/RgiAwKiHOJE0cXNw7IglNVzI9GOv+6J3SbtOApYO9j5/m2pX/mX+FBIiqTRjLaXrnWBm2hAnzwOitBt51mfLjXh93m4XzkwhMALEIAgTVIT7ipexB/Otuwp/HEFl02N324pcsYisWIYlg4OSlQ== Received: from BN9PR03CA0442.namprd03.prod.outlook.com (2603:10b6:408:113::27) by SA0PR12MB7074.namprd12.prod.outlook.com (2603:10b6:806:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 19:08:09 +0000 Received: from BN8NAM11FT092.eop-nam11.prod.protection.outlook.com (2603:10b6:408:113:cafe::e5) by BN9PR03CA0442.outlook.office365.com (2603:10b6:408:113::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 19:08:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT092.mail.protection.outlook.com (10.13.176.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 19:08:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 9 Nov 2022 11:07:56 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Wed, 9 Nov 2022 11:07:54 -0800 From: Dariusz Sosnowski To: Aman Singh , Yuying Zhang , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko CC: Subject: [PATCH v2 3/3] ethdev: document special cases of port start and stop Date: Wed, 9 Nov 2022 19:06:39 +0000 Message-ID: <20221109190639.886457-4-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221109190639.886457-1-dsosnowski@nvidia.com> References: <20221109190639.886457-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT092:EE_|SA0PR12MB7074:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e6a8f2f-d478-4cf0-881a-08dac285bd66 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VyL6l7VAnLBkQX37p+cvMr9dn1cIC5zvFGl/MCVG3myZ4G15gc5a0TgVAjPY4IFzVePCOb/DuIwMlYBeQdkRA6uZvPy3WbboCbhzHs01BwZWOdsyE+yfAHcdWlbai1cK11T37D+6MzQY5sCgOERqQU+EKsXPIJ2xz1K73ON8vLXlHDj/Nc/sFHNjYDZSW+52FPrTPvJLqEqqHyvwMX9Fea2+oh5eiu1iC60LCe1G/I7ygiOtHEk5jymkhd+2DIvjRAYyzc1/oTXV/Ywb/wEzpecjryzsg8F97kud/f6+Uv8XQueiOHjzz/vJ8GatREmggpcwGDtG+eoCCDy6s1/0sJh/n2buOJOFM65m4lC44vdlxAHXSWI+og9KPl2sQ+B7cmyMLHkbpZ5uUCAuS3qjJi+j8iuQqbPJFmYBIia1zaISy3rYwMg6Uz7hXx0YEQ9uAW0nGw1jkq/VEr3UeLaXqCB2JMmR1cdDFBkPnddCjbkAUigTrxfrlUnREVTB1RaC5SCsu9zmJybTQES3ATNykiB/2hr3gGB3CI4pacImfp72wEz3NuBtrPSIFH3hdKF7fD4nd/5ubNZmidBsk0Vsty+d4WaBzt75JAJ6GXUA0J0v8gjeCGvot/xDxvZUQlp0u4Bfyi6NFYubnFTnFNLZ5004Y77c1HM5uzjvf7vKLO5Mccolgtlz9PzixT9sRBCW2treyYk/93r7OsK/8UZqV46qAC0qZg145dUTpKRHo/uSxCla4OKQcvYH4qeWtaqwT2O8ZXN7W9TKw4pe+tHHmQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(356005)(7636003)(110136005)(316002)(82310400005)(82740400003)(36860700001)(6666004)(40460700003)(478600001)(2906002)(41300700001)(6286002)(36756003)(26005)(70586007)(2616005)(40480700001)(70206006)(55016003)(83380400001)(7696005)(47076005)(426003)(16526019)(1076003)(5660300002)(8676002)(336012)(4326008)(8936002)(186003)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 19:08:08.8367 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6a8f2f-d478-4cf0-881a-08dac285bd66 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT092.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7074 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch clarifies the handling of following cases in the ethdev API docs: - If rte_eth_dev_start() returns (-EAGAIN) for some port, it cannot be started until other port is started. - If rte_eth_dev_stop() returns (-EBUSY) for some port, it cannot be stopped until other port is stopped. When stopping the port in testpmd fails due to (-EBUSY), port's state is switched back to STARTED to allow users to manually retry stopping the port. No additional changes in testpmd are required to handle failure to start port with (-EAGAIN). If rte_eth_dev_start() fails, port's state is switched to STOPPED and users are allowed to retry the operation. Signed-off-by: Dariusz Sosnowski --- app/test-pmd/testpmd.c | 10 +++++++++- lib/ethdev/rte_ethdev.h | 9 +++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index aa7ea29f15..5a69e3c77a 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3118,6 +3118,7 @@ stop_port(portid_t pid) int need_check_link_status = 0; portid_t peer_pl[RTE_MAX_ETHPORTS]; int peer_pi; + int ret; if (port_id_is_invalid(pid, ENABLED_WARN)) return; @@ -3167,9 +3168,16 @@ stop_port(portid_t pid) if (port->flow_list) port_flow_flush(pi); - if (eth_dev_stop_mp(pi) != 0) + ret = eth_dev_stop_mp(pi); + if (ret != 0) { RTE_LOG(ERR, EAL, "rte_eth_dev_stop failed for port %u\n", pi); + if (ret == -EBUSY) { + /* Allow to retry stopping the port. */ + port->port_status = RTE_PORT_STARTED; + continue; + } + } if (port->port_status == RTE_PORT_HANDLING) port->port_status = RTE_PORT_STOPPED; diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 13fe73d5a3..abf5a24f92 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -2701,10 +2701,14 @@ int rte_eth_dev_tx_queue_stop(uint16_t port_id, uint16_t tx_queue_id); * On success, all basic functions exported by the Ethernet API (link status, * receive/transmit, and so on) can be invoked. * + * If the port depends on another one being started, + * PMDs might return (-EAGAIN) to notify about such requirement. + * * @param port_id * The port identifier of the Ethernet device. * @return * - 0: Success, Ethernet device started. + * - -EAGAIN: If it depends on another port to be started first. * - <0: Error code of the driver device start function. */ int rte_eth_dev_start(uint16_t port_id); @@ -2713,10 +2717,15 @@ int rte_eth_dev_start(uint16_t port_id); * Stop an Ethernet device. The device can be restarted with a call to * rte_eth_dev_start() * + * If the port provides some resources for other ports + * and it cannot be stopped before them, + * PMDs might return (-EBUSY) to notify about such requirement. + * * @param port_id * The port identifier of the Ethernet device. * @return * - 0: Success, Ethernet device stopped. + * - -EBUSY: If it depends on another port to be stopped first. * - <0: Error code of the driver device stop function. */ int rte_eth_dev_stop(uint16_t port_id);