From patchwork Wed Nov 9 05:17:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Liu, Mingxia" X-Patchwork-Id: 119594 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 043CBA0093; Wed, 9 Nov 2022 07:10:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 833EE410D7; Wed, 9 Nov 2022 07:10:38 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 1AB83400D4; Wed, 9 Nov 2022 07:10:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667974236; x=1699510236; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=NvbybCQCrBslRv2g+wWRXe3Z0K5jw4mDfT3h2chcHnw=; b=FPngKfIQvVKtjJkUmnZfmu5xlfuD2zFec3Gd5NTxXM3xzqxA3QktRAry Minh/rHtYmE64CZChr7Mcos4YIeftUtLiMqK1i2dpU/MJ4Q4miHkDT34c k8zYLIMqLky9hCPHhp3j1IS4VwXkVIvdOhTAnGHDbzWF1JzNds8J/bkPg pKGXpCrB5Gt9ELvWfM6QmwXdKzcjGdn1l0h8hVfrLwpQUnsS3ODeRD5Ob kxS+hbybmLK3oRc3HrhFAlX00tz2uY/hbw8HJdU4yDil9JLuZwEXWDpld uKHTbr7e/1nq5Jxn2pT888KKraY3WoXX/es5q27+RaHfO172BtKv6HNaG w==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="308518544" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="308518544" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 22:10:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="636618152" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="636618152" Received: from dpdk-mingxial-01.sh.intel.com ([10.67.119.112]) by orsmga002.jf.intel.com with ESMTP; 08 Nov 2022 22:10:32 -0800 From: Mingxia Liu To: dev@dpdk.org Cc: jingjing.wu@intel.com, beilei.xing@intel.com, xiao.w.wang@intel.com, junfeng.guo@intel.com, mingxial , stable@dpdk.org Subject: [PATCH v1] common/idpf: fix possible null dereference Date: Wed, 9 Nov 2022 05:17:07 +0000 Message-Id: <20221109051707.395658-1-mingxia.liu@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: mingxial Coverity is reporting FORWARD_NULL issue when msg.ctx.indirect.payload is NULL. Adding NULL check for this. Coverity issue: 381689 Fixes: fb4ac04e9bfa ("common/idpf: introduce common library") Cc: stable@dpdk.org Signed-off-by: mingxial Acked-by: Qi Zhang --- drivers/common/idpf/base/idpf_common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c index bcc0c11ae8..3a9fdb1878 100644 --- a/drivers/common/idpf/base/idpf_common.c +++ b/drivers/common/idpf/base/idpf_common.c @@ -234,6 +234,8 @@ int idpf_clean_arq_element(struct idpf_hw *hw, e->desc.ret_val = msg.status; e->desc.datalen = msg.data_len; if (msg.data_len > 0) { + if (!msg.ctx.indirect.payload) + return -EINVAL; e->buf_len = msg.data_len; msg_data_len = msg.data_len; idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,