From patchwork Wed Nov 9 01:40:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suanming Mou X-Patchwork-Id: 119568 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 308A5A0093; Wed, 9 Nov 2022 02:40:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21B0642D27; Wed, 9 Nov 2022 02:40:47 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2068.outbound.protection.outlook.com [40.107.244.68]) by mails.dpdk.org (Postfix) with ESMTP id CD78D400D4 for ; Wed, 9 Nov 2022 02:40:45 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IVjYVycYyXHZX8677ViJ9vNOfvqwZKz724h3GBs48FHHi8uH/J6gCnEC0r1ABwRH5E05qwPhbOa9Yxso/9wlBf43X2Z6319OE2ZnBFPyqbj4AAB/rr+ya5G+CNzCHpQArlvLAetCBx+dFw/b9GAs1HrhaE2K4n/+28tBeLxtuKiokSKqrNadobMOZ+O/9OOVRREw6cBgKMGeTK4WHXZl0nVPyG7bLVXYvMonZlxvumOatxwqIlwPZQVGbrm9UYOueOCHxdP6Xc1mtNvJIdXqBN0S0xQ9fnVDmws8Mge/rIuSFYfLICdOFBfaaU0XX31D+FmWFeXDEN32IfKbmwwDRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ad1COHPQc9IKY80CIOJrtVZ0GI63fFQdF5gxZG5j8ZY=; b=FnNmQ4+nT+YTJpPCgReSOkLRPxTKQzRAQUYeNlW6jF5dVsadyEupPNfcOAQQpVGKzuXA4VUwuZSJObiST1TeAhuh0HQ/kqUd0AJrXywoxPHdfWD/5WCqgzasaq7sC89sn1qyKZ29rTSEk6XtzIZ/xIbZSsBdtKpNfl7oTbzgBNepfVDokq8gZQBze/KqL2kQOqVGhq3jelv1Aqay6MTZ3YJU4VslLek+UB1w1snX67UAZAd2BFpYAtoIQYYBkK3e9Zu2JZjvH8SLrfZKiKdXrvfV7XXLw6CJz2LL5aqz5gEgPzAjNIdbiZGBXO6ih2hXf8XznzmZ7TcYk+AJuIASgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ad1COHPQc9IKY80CIOJrtVZ0GI63fFQdF5gxZG5j8ZY=; b=QDbrUYbJF7A2R4keYEYijWlhVi5xGHdRqkVcnpW5G/hGzSM72mFqIjWK5votH1QTDuo9LtonCHYO1oznYdsB+Vdl50BTj5v7FKsgejoMtgdmsr/kAp292WsAmjSWkoSgMwhyvelOEIMEpRcvCCXi11UrU/ewoGeDk22JM0js/pQvLJGCN0C87JsFJFTAlVubfyXIRiqR8Iz07UN/fw6znOXv3Go4b8WOmcBebi011GVoJV/d2cQ2N4E4xiaY2Cum/IdqJr4JifdRQ8V056GTf70vG7kluIML5g6EK/pqhBO3JhFT10tbIo1pxuKbVWYzUwYOpP+Zyw04utCyKx338Q== Received: from DS7PR03CA0151.namprd03.prod.outlook.com (2603:10b6:5:3b2::6) by BL1PR12MB5094.namprd12.prod.outlook.com (2603:10b6:208:312::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 01:40:43 +0000 Received: from DS1PEPF0000E656.namprd02.prod.outlook.com (2603:10b6:5:3b2:cafe::da) by DS7PR03CA0151.outlook.office365.com (2603:10b6:5:3b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27 via Frontend Transport; Wed, 9 Nov 2022 01:40:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0000E656.mail.protection.outlook.com (10.167.18.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Wed, 9 Nov 2022 01:40:43 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 8 Nov 2022 17:40:32 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 8 Nov 2022 17:40:31 -0800 From: Suanming Mou To: Matan Azrad , Viacheslav Ovsiienko CC: , Subject: [PATCH] net/mlx5: remove unneeded GENEVE option length assert Date: Wed, 9 Nov 2022 03:40:17 +0200 Message-ID: <20221109014018.23965-1-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0000E656:EE_|BL1PR12MB5094:EE_ X-MS-Office365-Filtering-Correlation-Id: 63f65856-8b1b-44ab-c4ed-08dac1f36a8d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5aGTuz8Yw5w8N+DdkqQc/3XmvSFJwZsJBrfXgQXjj9duF38yzLOVMHxpRBbbgX4zAg/+wllDdD/FmcnDFENDX2gcdFzTvVDFI3FXHEc/T5ynZLP7+OaZquI1VroHM5DIhC1aDUM3VilTcDx5wf3Exq6nI7aPQgzRsrd9W+ZljrAbuMBlfwN/KwIf9gMgbB0GwixoX17/PjAZ88rCNgIhuhS6HM8Zp0QxwWhz5ru/3bk+GUjhR8oiFPlQXG/Po4dYrj5lHJ7k0cuACUEjfUN8nR9su1EeRLp+qVfF3P5M/Jdai3NeuNOw5DahY0PoIpfZHocJ+hCCk2SRI4ynjza4nTQZmRmXL6lA6xDTlkUVwJgoGA3dI9EKyvsuJRmZypoQ9d9mH6PQSDlwqqsImu8/HxUgbGXp6yAbWqHsHMvZCa0ssbLDdLQDQ9cwp7kSv7/JdU9h1pl60MbVbvKfknRAH5uGk3y42h64uTjblqesZJUx+31w/8cssnzLKO89qmW+3/hhqH8uDVvuMmf07rsg95Tl+XOyCAgFvw+a1PACFrLtxpCgIqv+xs1pihYWM8aOAkQppKvPzQrLnAV+12zCKjqGyk/7jTgxPtP7t4M8Za9ZnI9bIjRlymIuXH0q6xzPuvl+SakSD2b+shEGZD/EVi9RLS9EHso2qoJv+vDtt7i59yYRrrUSrq7Zberm9va7qTzYlmk/1fAsOgeqA8bt0ZPj49IUGgp89Sg+DKE3KbsYDZTM1rIacAhLFg0mofLoQ4Fvo5DipxqmS/Vb3tZ1vQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(36840700001)(40470700004)(46966006)(7636003)(356005)(36756003)(86362001)(2906002)(5660300002)(26005)(83380400001)(2616005)(426003)(336012)(6286002)(47076005)(1076003)(186003)(36860700001)(16526019)(40460700003)(82740400003)(316002)(70586007)(4326008)(41300700001)(8676002)(110136005)(54906003)(82310400005)(8936002)(55016003)(40480700001)(6636002)(70206006)(6666004)(107886003)(478600001)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 01:40:43.3673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63f65856-8b1b-44ab-c4ed-08dac1f36a8d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0000E656.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5094 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In order to share flow items translate code, flow items translation of spec and mask was split individually. In that case, the assert for GENEVE option length with mask becomes invalid, since the length in mask is bitmask. And as memcpy around the assert already checks the GENEVE option length, the assert looks redundant. This commit removes the unneeded GENEVE option length assert. Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value translation") Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index acd7ea8b79..7808a28787 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9616,13 +9616,9 @@ flow_dv_translate_item_geneve_opt(struct rte_eth_dev *dev, void *key, memcpy(&opt_data_key, data, RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4), sizeof(opt_data_key))); - MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <= - sizeof(opt_data_key)); memcpy(&opt_data_mask, geneve_opt_m->data, RTE_MIN((uint32_t)(geneve_opt_v->option_len * 4), sizeof(opt_data_mask))); - MLX5_ASSERT((uint32_t)(geneve_opt_v->option_len * 4) <= - sizeof(opt_data_mask)); MLX5_SET(fte_match_set_misc3, misc3_v, geneve_tlv_option_0_data, rte_be_to_cpu_32(opt_data_key & opt_data_mask));