From patchwork Mon Nov 7 11:04:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 119525 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47579A0093; Mon, 7 Nov 2022 12:04:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2B6C40156; Mon, 7 Nov 2022 12:04:54 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2059.outbound.protection.outlook.com [40.107.92.59]) by mails.dpdk.org (Postfix) with ESMTP id 5838C40151 for ; Mon, 7 Nov 2022 12:04:53 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxjU9eEMHOtadtXJ72gl1ZJ7DBkAWC9ZxhQkJXwfGvp24iZ/f1MLwePj2tCDWZtjsK/6OT5oGXV1EGU+0UnHBin8LfxIYe+t+v+5qEhqnqMi1bPfMaTeo9gCGWciycaGMnCUxCiyw1APZen1oGpoZgGhuu/d8hdCUmJ2Hqff7fyp+Jk9MBHJnqADiwfIvIkpeKex2S5y5CWd33Ut8yjz/GK3u1ONa43hqTYe5oOiNoVj1LZAOiax7xCHbDFHdlU+3tt7+dW4nJBF+kp3055haW2Gq+wmSVTmxzjeKdTTjr0Ah0ubMsEowC0YQZLLrkIDj01id/At9J3wY44XNulCWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iPdPuqhZ2i8zYfTuc41hd9/p4dIVICzj+FCAeLC15+I=; b=dEUkynjjRnsteajOCjJr0brL8wPbdl46aAdAzzMma4m/bEyKAQULq4atlFJsaJrRhZlAW6EoJxGIs8dfnpvCeOVFYKjNyf8JixdR0HeB8yjzyLBKqHVXCEDEgF2bGyHvXGkBgCqAg62ryvWBLc3FTIVAxXsJCkKSQdzZ5O9CvnNTMv3Igv3ziNm1enm/9y8xZsNdY8DDw39Cxrxsc39Z7klQs4CRfwj1DnXXPcFHgR9X03+RU+gvMxRv/m8GumC+s08ATEwGzcJUkKGc+Dkueln5G91yp0pbC8BK4fMJbWyoQerhk1EzLpDbTsCypG3Xt14lCOJ6l/iDfJg3r8oYVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iPdPuqhZ2i8zYfTuc41hd9/p4dIVICzj+FCAeLC15+I=; b=SeSUYRt1iFeO/Eiugi8U4UmCOcU/0V0ZSmNTGNMSt9h2SQL1CdzFlML1dhfR4Ioyj9uTdrbhqjC12i/jncKrYd7rJMPKwteyNkU6pgHC+Z7HCHM4/StOnVlw7/zx7ZTstbmXlS1dlAZGFC+T8mqRVmvaqKidenvAEpVpk2hKhbUFGxpDlxxl8HwnBWxNTtTUb8O+bi2D68cma5esnHzv3XnUmoqyzFu/sv1QQ6nW5X53USKxQ+r6AJoiNPfuXCK7iHTLwLMlbM2gaM0HTnE3na3JapgknIFh547Unhtlbnir3tlhaztC3KCNTF5XTlp5C+DZqhWvnWczZdqQoN6Ytw== Received: from BN0PR04CA0100.namprd04.prod.outlook.com (2603:10b6:408:ec::15) by DM4PR12MB6181.namprd12.prod.outlook.com (2603:10b6:8:a9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.25; Mon, 7 Nov 2022 11:04:51 +0000 Received: from BN8NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::f1) by BN0PR04CA0100.outlook.office365.com (2603:10b6:408:ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Mon, 7 Nov 2022 11:04:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN8NAM11FT055.mail.protection.outlook.com (10.13.177.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20 via Frontend Transport; Mon, 7 Nov 2022 11:04:51 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 7 Nov 2022 03:04:38 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 03:04:36 -0800 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH v2] net/mlx5/hws: fix action creation check for HWS support Date: Mon, 7 Nov 2022 13:04:12 +0200 Message-ID: <20221107110413.20416-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221103125041.7123-1-valex@nvidia.com> References: <20221103125041.7123-1-valex@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT055:EE_|DM4PR12MB6181:EE_ X-MS-Office365-Filtering-Correlation-Id: 6462d72e-6271-483a-2629-08dac0afe4c2 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vHza+SP22kXjpi1daOIHX0KCXZNTEWgu3AHj3M5DDpNg1kSF9I69YRQf3eRGZZoHR6NNy6crZZGfUF5pN0pI5zpKqc7CWEY2905LbjeWz5gYHYdttefH+OuULJVNq4HHXo7u6N5XrCzKkXjtMQz66uNcj14LhePX0bhpHUEccq6bhkaOhYpdkGg+Bx0GnoMAHcgMIQBh0/gU752uyHO4t3YEdKEDIFUCGre6u1g9KCQbc0qQGD4YBp7/uPj7n4OxqUr6rbyUGLl4TDvydCifrgQATJXhZ7OXYzppg5b4luVrAZMNKBkLECX4+SE9E0I0npoYjR5zw7rjNqrA7UOr+rzet8kFoa7lJTzLrOVHXe3+bladWm/jliABihimYl0o8V40ViEfs0KZoh7MXCdjBAtmlEWMh/hT3b1Dz0ihXZq8InzmMfl8UF8EoM9Kf1s5Xtocdj1kaNsVjQ2CAtG96aO82Ds8TTp6KGVlevoDe4v0lv/nu6ukSHlzKCnE/P6zenW71iwole64w67pPTYbV6eA5C070nliJiGks4NL1P+lAn2JytbOYHoCqMfCNNRYgQAfsPyUJPIc7QjvXEiSIfS6DpLkxLghLTLNEwmKZZWIYlJ0YyG7ZfEx580UN/2dW26hr+oxI5XPp+xUmeW7OZoYYb302rhMIhpWBWbQ5aGQzf6SMZrLgz6smKJBqI6zHmq0e49wCqGtvpF9I+pd6n7GOuCGata/oNGM2FWkyLhkMeKxC00WAzPLUxD5PKW4W1DOug73KxMVdfs07d66IQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(36840700001)(46966006)(40470700004)(70586007)(70206006)(55016003)(6636002)(4326008)(8676002)(36860700001)(110136005)(54906003)(5660300002)(316002)(40480700001)(41300700001)(2906002)(107886003)(7696005)(6666004)(16526019)(336012)(47076005)(426003)(186003)(1076003)(83380400001)(2616005)(26005)(6286002)(40460700003)(86362001)(478600001)(82740400003)(356005)(7636003)(8936002)(36756003)(82310400005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 11:04:51.3897 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6462d72e-6271-483a-2629-08dac0afe4c2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix segmentation fault when a user will request to allocate a HWS action while current device doesn't support HWS. Fixes: f8c8a6d ("net/mlx5/hws: add action object") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index a9e12aa1f5..b0ae4e7693 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -697,6 +697,13 @@ mlx5dr_action_create_generic(struct mlx5dr_context *ctx, return NULL; } + if (mlx5dr_action_is_hws_flags(flags) && + !(ctx->flags & MLX5DR_CONTEXT_FLAG_HWS_SUPPORT)) { + DR_LOG(ERR, "Cannot create HWS action since HWS is not supported"); + rte_errno = ENOTSUP; + return NULL; + } + action = simple_calloc(1, sizeof(*action)); if (!action) { DR_LOG(ERR, "Failed to allocate memory for action [%d]", action_type);