From patchwork Mon Nov 7 10:18:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Vesker X-Patchwork-Id: 119522 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC694A0093; Mon, 7 Nov 2022 11:19:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C12C40156; Mon, 7 Nov 2022 11:19:36 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2053.outbound.protection.outlook.com [40.107.223.53]) by mails.dpdk.org (Postfix) with ESMTP id 4136540151 for ; Mon, 7 Nov 2022 11:19:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mvNQ14CsjTmFhc5VbAKOsqiYp/3COUQp7WIy/pAwep3bfFcklya2o2r+8rbDCkiWBVxHGD/8zY6ejFjyQaumIsv8MrLm4IsA8lgE761mGQoUXVa0BJeeY2FIJvMQR6LcwqKFTB4gqzPZ/7vI397kutxKg4GiewPfFaP6uXBpednmihqMUuCWwp2oKeuLXbEw4/j41IFPqkXT74Q6j+ROzfZYwleUKpjjVcOlV2qZsbTl8q8/nKCt7vOzsXEFiaVKsMsxjeWIlrXFkzWvGlhA+qjSN7sp4YifVKleXzfmCUzc4G+p8Oii6W+xHCzVh6R2Fm9TPf/TwXGdjgj8lD/aog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ikvifrNzU86WVFAfmJsr2Wgh5kOUvLe7KyCclfxL35Q=; b=jb5B57dEY4mvacfRrW/IQ+853+bkFC4qUvowv6djz6RQvRhYkZri/WBZ5aZVF9WtJRdRi8/PLrlLcKcbHNxeQlIgPM0YsmgofxVi2NvNk/ITxOpu6W9JegAHQlRwOCYLqOj7ovS5ZOeKOGOzFVtC9YGKeuPRTTiM5CiGcZrpaMcMO6TYcwGeVWnbsUR/fjG0M4xJq5LPpmnKCr9JyBU0VZZJbk412ge/Boo4TaP1qIpD5IMLFAF0uUmjiGRZFeDvyQUVG2HFoMebW8SY1yvl9Y48nw+TkUgBZif0/47CGa8ghgugUJU7At/EFg+7t+8ZK+6CzaXVkXTXA8l1uovUtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ikvifrNzU86WVFAfmJsr2Wgh5kOUvLe7KyCclfxL35Q=; b=nICfXMBnsVbQQLaTMr6WMBTV/K8WlGm/LJwt38FdyVGao9K1N341dkMawzj7ozCd8wIEHmhczONApgq07AwfibITAskJkRW9xiJ3qLfSZnQj6Z50oMbqnetyIt3Ahh6Uj8FIzDkLJw0k00gZ9KNp1J3yFYCUIrxbwwtiw+5bKJpuoTdG9WyN34KcUJefi84AzNMUq5fm5BmdZoDFplTb+9nZ4Q4V+3R5DgOBTH+xaGlhWdPbWAtrK/LMpJ3V0Eu0tOd9igEPMe809gd09OoUOQU5S+EJBga4/wQXp1zy6Rumj9uWtmR1joZJHpx8AiNQ09aLJpldmOiIseeNPNs87A== Received: from CY5PR15CA0194.namprd15.prod.outlook.com (2603:10b6:930:82::12) by PH7PR12MB5655.namprd12.prod.outlook.com (2603:10b6:510:138::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Mon, 7 Nov 2022 10:19:32 +0000 Received: from CY4PEPF0000B8EC.namprd05.prod.outlook.com (2603:10b6:930:82:cafe::dd) by CY5PR15CA0194.outlook.office365.com (2603:10b6:930:82::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22 via Frontend Transport; Mon, 7 Nov 2022 10:19:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000B8EC.mail.protection.outlook.com (10.167.241.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.11 via Frontend Transport; Mon, 7 Nov 2022 10:19:31 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Mon, 7 Nov 2022 02:19:16 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Mon, 7 Nov 2022 02:19:13 -0800 From: Alex Vesker To: , , , , Matan Azrad CC: , Subject: [PATCH v2] net/mlx5/hws: fix possible action setter segmenation fault Date: Mon, 7 Nov 2022 12:18:24 +0200 Message-ID: <20221107101824.16288-1-valex@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221103125108.7203-1-valex@nvidia.com> References: <20221103125108.7203-1-valex@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000B8EC:EE_|PH7PR12MB5655:EE_ X-MS-Office365-Filtering-Correlation-Id: b11151ad-b557-43bf-597e-08dac0a98f56 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MB3I8eFXxhp54y7QSKA71Q6zSWGas3DFfGeVe6IPZ492D5j720vRG+EJKuEXUGM6izcU6rTyvYeLb5uvwsJxbsejRDC+/NwAL3Dt/LHceCxPpwnfPl3RaUUT7pGMqHR/zk0Zfqo2qIy4MeSpo8Z9Mf4juFLJ+AoK+pgoUngl3l7uUCCmD8bO6gdxbGV1Z4FzrvTZJd7ERDaKBNxz7VaJqFJoeSPlUfjzpw2uWZdLG22sO4+XZqFJSIlpCSSF5GU+qapGeeVwlEi0yvZonjS/59/ADmgUrTLlOaOtFH/NE1na7d5y62Bspb0MgPByHheAOUdLO9msweXwEm0kwdBaNLZdldSiLpqKAz6cVa67PhwdrPMnZ9rPrtbmQBaI/DaeL/uCRscj6VYzlbAOO4hS982htQuzrrHcuwIBPi6tdhsYAxwjRnIQm/g9+6Sp1AZ5RcwIBbzXGMWR2XS2P5dHUtGbpnKRVtvJ7QKOdZqFeEmwfJLZKvJ1tYoKO3E5QFCoxAcw75gCGV4JITJt6n6Ek2giq7lGIr6LUTLuScROkvxdv8HmImMmil1ikw6nDnkfeSfId6rvPI/TfzFotloqnO3jZ8nFSgrlwT+NEzutsDNtIvq+M3CvECfNAyUk6MTErVlvquhTRbfOTxkZ3NQCID7evemXmTGy5TciWhWMJXbO6uCMIlyzD4x9INNED4mKy75yjycStmVzLiG9S2SE6BxwAf9TrJFm6wzpL6WfRlMvZLZXTspyFwqM2O5vzDgKGeagXcSPB6M79soGlNV6qQ== X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(136003)(346002)(396003)(376002)(451199015)(46966006)(40470700004)(36840700001)(110136005)(478600001)(6636002)(336012)(70206006)(7696005)(70586007)(8936002)(47076005)(26005)(4744005)(6286002)(4326008)(1076003)(426003)(2906002)(41300700001)(5660300002)(2616005)(83380400001)(186003)(16526019)(55016003)(40480700001)(82310400005)(54906003)(107886003)(36860700001)(86362001)(82740400003)(356005)(6666004)(316002)(8676002)(36756003)(40460700003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Nov 2022 10:19:31.1590 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b11151ad-b557-43bf-597e-08dac0a98f56 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000B8EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5655 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When the maximum action combination in RX is used we can get a segfault due to an incorrecrt max array size define. This bug can happen on RX/TX or FDB in the most complex cases. Current max was set to 7, but actual max is: Max TX: 8, Max RX: 10, Max FDB: 9 Fixes: f8c8a6d ("net/mlx5/hws: add action object") Signed-off-by: Alex Vesker Reviewed-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.h b/drivers/net/mlx5/hws/mlx5dr_action.h index 3b31ffc90e..9a4827481a 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.h +++ b/drivers/net/mlx5/hws/mlx5dr_action.h @@ -6,7 +6,7 @@ #define MLX5DR_ACTION_H_ /* Max number of STEs needed for a rule (including match) */ -#define MLX5DR_ACTION_MAX_STE 7 +#define MLX5DR_ACTION_MAX_STE 10 enum mlx5dr_action_stc_idx { MLX5DR_ACTION_STC_IDX_CTRL = 0,