From patchwork Tue Nov 20 22:09:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rao, Nikhil" X-Patchwork-Id: 48215 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 332825B38; Wed, 21 Nov 2018 11:11:53 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EC3415B32; Wed, 21 Nov 2018 11:11:50 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2018 02:11:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,260,1539673200"; d="scan'208";a="87592531" Received: from unknown (HELO localhost.localdomain) ([10.224.122.195]) by fmsmga007.fm.intel.com with ESMTP; 21 Nov 2018 02:11:48 -0800 From: nikhil.rao@intel.com To: dev@dpdk.org Cc: Nikhil Rao , stable@dpdk.org Date: Wed, 21 Nov 2018 03:39:15 +0530 Message-Id: <20181120220915.75201-1-nikhil.rao@intel.com> X-Mailer: git-send-email 2.14.1.145.gb3622a4 Subject: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Nikhil Rao In the eth Rx adapter SW service function, move the return to after the spinlock unlock. Coverity issue: 302857 Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop") CC: stable@dpdk.org Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index 71d008cd1..8831bc35f 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -1165,8 +1165,8 @@ rxa_service_func(void *args) if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0) return 0; if (!rx_adapter->rxa_started) { - return 0; rte_spinlock_unlock(&rx_adapter->rx_lock); + return 0; } stats = &rx_adapter->stats;