From patchwork Sun Oct 9 13:53:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 117749 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A8C4A0542; Sun, 9 Oct 2022 15:55:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 477E1400D5; Sun, 9 Oct 2022 15:55:13 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by mails.dpdk.org (Postfix) with ESMTP id 037F740042 for ; Sun, 9 Oct 2022 15:55:11 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A1C4D3200583; Sun, 9 Oct 2022 09:55:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 09 Oct 2022 09:55:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1665323709; x=1665410109; bh=W7lQ6rkyR55utOMy/Bjq6WB2c /vQW5aoaidkgg8EnT8=; b=cr6G8c03l8qJ8tS8kAwXULvodVoT9QQDAvov4bJjj ux/IPI0ObpUJpLPbpa+k5ns7JOOdrC9AkJuyDI9XCyAgAMp9gEpD+GFMneHyS9+B jhN+OBtYKtmFUTLhyB6EaiRuGdKE48UdJ50nQd7F+FP9kHkLN3qGsTJfy0crnI6m 92Is7NO5GguNtzt2rJhoD9KVTKsRow6Hnn1jO0VIsxbXhwU9naCBQb0DSonHr7+9 7jsoBwx3LpvhsdAxVx4fWDABqHROE7PIl51FWHxupJ7EMRCPqRo6DD14okFdLjuO Gqn7bot85NL1MR60zM06OKASWJIfUemJTomITlTXxruTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1665323709; x=1665410109; bh=W7lQ6rkyR55utOMy/Bjq6WB2c/vQW5aoaid kgg8EnT8=; b=SN6sZkMrBZBG6T1EHKtqnHXXSOgDvjuja4vNE+pdjsXeOe0fWBh gVIYBpgE9lvo/50J46CPg/wZi0gLI6KDu6iUi+J7bN/fSFXdRT33N+GbVTKJt7UK j+1Tdp/ZKvt+PogtqW3LAGYrqSeXF05uQqo/55iSa1i1f1lv6A8bToGQxwpUni4N guBU1Gy84o85UFxRZEpHoUDoJ6TOaVJZt3QdWCrKC0De+3L01Z4pKckRBc14/jU3 qQZebCPbCiqz6ytX+v1hchgL4QXoYsDvZlGAIXcoUpyM6V6pT2vUzo9NmfvmE51b /kYoLLcV2rL3RClnFq+WCJl/y+tBvYcaOIw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeejuddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeevveefveeiiefhtedukeegkeelieegffeukeevudetueffieduveet iedukeefleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Oct 2022 09:55:08 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, Long Li Subject: [PATCH] net/mana: fix dependencies Date: Sun, 9 Oct 2022 15:53:37 +0200 Message-Id: <20221009135337.1317477-1-thomas@monjalon.net> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The reason for not building is updated to be consistent with other drivers. The libibverbs was not detected through pkg-config. The method dependency() needs to be used first. The support in rdma-core and Linux is not released yet, so the documentation is updated. Signed-off-by: Thomas Monjalon --- doc/guides/nics/mana.rst | 6 ++++-- drivers/net/mana/meson.build | 9 ++++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/doc/guides/nics/mana.rst b/doc/guides/nics/mana.rst index 30e3fd1cb6..005c0b2ca7 100644 --- a/doc/guides/nics/mana.rst +++ b/doc/guides/nics/mana.rst @@ -29,7 +29,6 @@ and must be installed separately: It allows slow and privileged operations (context initialization, hardware resources allocations) to be managed by the kernel and fast operations to never leave user space. - The minimum required rdma-core version is v43. In most cases, rdma-core is shipped as a package with an OS distribution. User can also install the upstream version of the rdma-core from @@ -40,7 +39,8 @@ and must be installed separately: Low-level user space driver library for Microsoft Azure Network Adapter devices, it is automatically loaded by libibverbs. - The minimum required version of rdma-core with libmana is v43. + + The support of MANA is not merged in rdma-core 42. - **Kernel modules** @@ -56,6 +56,8 @@ and must be installed separately: - mana_ib: InifiniBand device driver. - ib_uverbs: user space driver for verbs (entry point for libibverbs). + The support of MANA is planned in Linux 6.2. + Driver compilation and testing ------------------------------ diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build index bdf526e846..493f0d26d4 100644 --- a/drivers/net/mana/meson.build +++ b/drivers/net/mana/meson.build @@ -3,7 +3,7 @@ if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64') build = false - reason = 'mana is supported on Linux X86_64' + reason = 'only supported on x86_64 Linux' subdir_done() endif @@ -18,9 +18,12 @@ sources += files( 'tx.c', ) -libnames = ['ibverbs', 'mana' ] +libnames = ['ibverbs', 'mana'] foreach libname:libnames - lib = cc.find_library(libname, required:false) + lib = dependency('lib' + libname, required:false) + if not lib.found() + lib = cc.find_library(libname, required:false) + endif if lib.found() ext_deps += lib else