From patchwork Mon Nov 19 08:38:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leah Tekoa X-Patchwork-Id: 48180 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8288A3237; Mon, 19 Nov 2018 09:38:46 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60106.outbound.protection.outlook.com [40.107.6.106]) by dpdk.org (Postfix) with ESMTP id E5B57322C for ; Mon, 19 Nov 2018 09:38:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ethernitynet.onmicrosoft.com; s=selector1-Ethernitynet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BkKEwtC3NZ92uEcL8/45I2iWuwwoXIiv8/glpY7W040=; b=mJnbzVBzd8YzWkd58OSlsNSbwzZSk1X+PWmfo7du0wyRx09rt5PE0otQ37eEqy+W4ZS7shuDwMnUJvEx/6nIapDWIpnul4NYhmSCBO6AQbH44YAL24TjZNLwmw/IQV3rs7SARvv/I2+J09wgs0VonytjJyK5MJrs9XVGODyRd8c= Received: from AM6PR04MB4215.eurprd04.prod.outlook.com (52.135.168.141) by AM6PR04MB4312.eurprd04.prod.outlook.com (52.135.169.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.26; Mon, 19 Nov 2018 08:38:44 +0000 Received: from AM6PR04MB4215.eurprd04.prod.outlook.com ([fe80::8918:8163:c64b:6cb7]) by AM6PR04MB4215.eurprd04.prod.outlook.com ([fe80::8918:8163:c64b:6cb7%3]) with mapi id 15.20.1294.048; Mon, 19 Nov 2018 08:38:44 +0000 From: Leah Tekoa To: "dev@dpdk.org" CC: Leah Tekoa , Ouyang Changchun Thread-Topic: [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit Thread-Index: AQHUf+NIntGHFIVaPUmsRk5Q5VOkWg== Date: Mon, 19 Nov 2018 08:38:44 +0000 Message-ID: <9f22d89841c440c32235117e1a4fe223f97c7f8e.1542616118.git.leah@ethernitynet.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CWLP265CA0219.GBRP265.PROD.OUTLOOK.COM (2603:10a6:401:4f::15) To AM6PR04MB4215.eurprd04.prod.outlook.com (2603:10a6:209:4f::13) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Leah@Ethernitynet.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [82.80.86.46] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM6PR04MB4312; 6:Q9pj+5MxJHlwYvgWCmnk8hpkXJMsUL91bKGjQvGe28b2ZuAu3/Wew/RNar6K451EJkp4SYOctmABfC9fHl0iZLL2dhEX7qZsPbW6qBW4WaNhzC5fLuUgirk1XnOo1JdTcUi69JvJKBQpTviQiGkNre7U0fRVLhyxbCsfbyEO5QOvCBLa9v3hHuYdblb4KlU1LyJXo6VeoxWsLnXoFCnW0qIhfAxbInBu8ZkvihLBEx9mmuDmScGKY6Wv5GS+1THN4r8YXE0uBxpbNRLMQec6bEHPBjmrak3SEgCwKPZhDIII/VD5sAeyX9A0cilbhDwxNNFLiHPUWTVeFN9BVoWCkTE2nVS8SOVWB4MYdYnq6IM3nZZsSj0ArMT5uAi9yaqjAGQY2V7U8Zf5Sy6c8UcJHwPyv3QyKsEsdLawuE8TbA6fQ6HxzwF3xnsof/hVTK3xEm6cUkk+6UC/9BxdAUk5zg==; 5:QX8JnYsRM8z4hHzWKvFsiaxzdGJrkvtE5uil0LAsbNfK6WiH6B/ncFZh/PPlg4o4ZtpWhdiFmi0vSMs+Q/h5Mdkg91O9WYUVibQ+IZlce+QMNU4gmaFmwA7Ks9Rw88J/WN6Yc7+gfTlmcPtJI1mp3SCVL3/L9+FgdRr7Zl4yy5A=; 7:JLIRjHQRHLYjd7HL6S8ZX3qZ/xQiuljzgD/jSrm7zCpahq+zcv0UlxTJGCcRSDwvqhWrn0mMb+BOsZpAgIg4HHWJwbJaLeafcs/c+MkzJlgQvekJpK/0tlOQxJ2kqKyZSmAdYosphfF7hnqe/Z8hJA== x-ms-office365-filtering-correlation-id: 16cc3540-0d94-4dfc-d87a-08d64dfa6a9f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(7021145)(8989299)(5600074)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM6PR04MB4312; x-ms-traffictypediagnostic: AM6PR04MB4312: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231415)(944501410)(52105112)(148016)(149066)(150057)(6041310)(2016111802025)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM6PR04MB4312; BCL:0; PCL:0; RULEID:; SRVR:AM6PR04MB4312; x-forefront-prvs: 08617F610C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39830400003)(136003)(366004)(346002)(396003)(376002)(189003)(199004)(102836004)(68736007)(80792005)(36756003)(25786009)(2900100001)(106356001)(7736002)(105586002)(8676002)(99286004)(66066001)(186003)(6506007)(386003)(81166006)(508600001)(6486002)(486006)(6436002)(305945005)(86362001)(2906002)(1730700003)(1857600001)(2351001)(72206003)(81156014)(14454004)(5640700003)(8936002)(71190400001)(71200400001)(476003)(53936002)(5660300001)(118296001)(316002)(256004)(14444005)(4326008)(2616005)(3846002)(6116002)(97736004)(2501003)(54906003)(26005)(52116002)(6916009)(6512007); DIR:OUT; SFP:1102; SCL:1; SRVR:AM6PR04MB4312; H:AM6PR04MB4215.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: Ethernitynet.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: e7WgLM94wLTZOliTN352rqn9UaLyD3yr9Fr4k6VJoFnLO31oSZQlmLMG1S0RHvHQAOFYAjwWvY2lMtOgejscpboxgNpeWc8KJ5UMaVLGEYfh5t4ruxMcJBuk4AtSjFrddMdRbzYqTciiuA2EKUlb/Hf/FissyWPN57Z6Wc7Fbh6Kadjj2+TDUOFAu/wp1NdrkCkYFt11bLcT530YfS38nSdDMW55wbE5CHNzJ7ztqe5alMQ2DP6NcSseAVa0AJ4cfVjw5P/r/ZwWCaJf06PcRT0iboKRw32Gy5ZnDMNq4ZFEPT9Ftdyfw1kPCQ5RwPV0wczUgu1PoFQR9eEckkS9E5QGms0Yi0kYicbL6oUf23s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Ethernitynet.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16cc3540-0d94-4dfc-d87a-08d64dfa6a9f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Nov 2018 08:38:44.9069 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 186d842f-2f7b-4cb5-a499-ed7992b54e77 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4312 Subject: [dpdk-dev] [PATCH] ethdev: fix copying bug in rte_eth_set_queue_rate_limit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Leah Tekoa memcpy should be used for copying rte_eth_link structure Fixes: 8dbe82b0 ("ethdev: Tx rate limitation for queue and VF") Signed-off-by: Leah Tekoa --- lib/librte_ethdev/rte_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 5f85817..c187690 100644 --- a/lib/librte_ethdev/rte_ethdev.c +++ b/lib/librte_ethdev/rte_ethdev.c @@ -3266,7 +3266,7 @@ int rte_eth_set_queue_rate_limit(uint16_t port_id, uint16_t queue_idx, dev = &rte_eth_devices[port_id]; rte_eth_dev_info_get(port_id, &dev_info); - link = dev->data->dev_link; + memcpy(&link, &dev->data->dev_link, sizeof(struct rte_eth_link)); if (queue_idx > dev_info.max_tx_queues) { RTE_ETHDEV_LOG(ERR,