From patchwork Tue Nov 6 19:30:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 47902 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4820A3195; Tue, 6 Nov 2018 20:30:12 +0100 (CET) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id C2E492BE2 for ; Tue, 6 Nov 2018 20:30:09 +0100 (CET) Received: by mail-pf1-f193.google.com with SMTP id u10-v6so818289pfn.9 for ; Tue, 06 Nov 2018 11:30:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jL/gnuK/he83iilyD+bKa4/D434yY1ekNNaaXuYFzj8=; b=eykQ9sWP7PuQ02uCnCCjh9ZKatYFgAB6ojPfnu1jy5hcyZ8N2Lfqc3vOnv9sHqXDrd mvi/UZv3vq1ECTV2oxMnCMasPapEGwoGnyVtwN5beDCK79ZkLe9c0HGOMaZf4rXxzM/I YYyc5H78dmliL3kHurWmn1OjEO2gNOn6c4cuD5wlxNmgyWnNeqT5L84GuSN5h+E4e3LT xYOjAKx2Av+if63fusqADd74S8lN7h5UJbyx0ucPLV4075OtoIzBZU4cdxWorVWKg6gw E9KlCNvxbzUtAF5i4wUcA8PrnyGEL7vglrTVOwvYFHW7iliMC7MrN53FxgKWMiEgXyo0 PsLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jL/gnuK/he83iilyD+bKa4/D434yY1ekNNaaXuYFzj8=; b=tmjScXZRrfNBlssvkJ5YgRPEE7zBRJ2yEi9s+9Rz9S0xkUZ1e+a8tOBObTHnVm4lIb rsMtZTUdhmTy8j0wok9cd1hBoCdW9sYEhmeObPr/PMZ4u2jnY1ca+uJpWNKmYpi0in+2 9qAzrSo6EnF1g6/NnBUoW5vxdcwH5LgW84CjWaopgzhB8rrhdi386L901tVuvjHgUKlk 54W4ToYw30R1jGeY5T5/uOg6hByvVkWQcSSe3/PZroE1kaaL8WOnvVIGmga5vkwjQao6 1rQVDYb1e4MWv34qMoA+iNXccH7f4oxLnexiXV+MlodeHCrowRtkVyTAjAi6BQpzKdzg tNiQ== X-Gm-Message-State: AGRZ1gIa4c3PS7o8b3oJ927+G18hoAhAEr4Pj/XbWApgTlqiVnaVvu+k pQdqoCRFCD/fSgJ0/qL34pqTK0AbdiY= X-Google-Smtp-Source: AJdET5c0tWDxGiMUcOyhHNoTOr/f3EM8oCLmOqHhExdEHTfjJ/X4bKnOclDwT6IOEC0Jl+pTjdyDag== X-Received: by 2002:a62:8c93:: with SMTP id m141-v6mr27088637pfd.239.1541532608566; Tue, 06 Nov 2018 11:30:08 -0800 (PST) Received: from localhost.localdomain ([167.220.105.115]) by smtp.gmail.com with ESMTPSA id a18sm9638633pgj.30.2018.11.06.11.30.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:30:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:02 -0800 Message-Id: <20181106193005.5383-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106193005.5383-1-stephen@networkplumber.org> References: <20181106193005.5383-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/4] net/failsafe: avoid rte_memcpy if rte_realloc fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is a potential issue seen by static tools if number of multicast addresses is zero, and rte_realloc of zero size fails (ie returns NULL). This won't happen in real world for a couple of reasons: Azure doesn't support multicast (ie this is dead code); and rte_realloc of zero size will never fail, but safe to just always return -ENOMEM of realloc fails. Coverity issue: 323487 Fixes: 901efc0da925 ("net/failsafe: support multicast address list set") Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/failsafe/failsafe_ops.c b/drivers/net/failsafe/failsafe_ops.c index 7f8bcd4c69f4..a20953a662e1 100644 --- a/drivers/net/failsafe/failsafe_ops.c +++ b/drivers/net/failsafe/failsafe_ops.c @@ -1155,7 +1155,7 @@ fs_set_mc_addr_list(struct rte_eth_dev *dev, mcast_addrs = rte_realloc(PRIV(dev)->mcast_addrs, nb_mc_addr * sizeof(PRIV(dev)->mcast_addrs[0]), 0); - if (mcast_addrs == NULL && nb_mc_addr > 0) { + if (mcast_addrs == NULL) { ret = -ENOMEM; goto rollback; } From patchwork Tue Nov 6 19:30:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 47903 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 418F74C80; Tue, 6 Nov 2018 20:30:14 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id EA1582C52 for ; Tue, 6 Nov 2018 20:30:10 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id c10-v6so6254605pgq.4 for ; Tue, 06 Nov 2018 11:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FiP8fEOMwEYXV3ynB5vs09VgJcAWxxg7hYsDdibfxjw=; b=sMQhNELLBjMt2fpDu0T+DGLm6pGiXBr0Fti2oIBk1brUIuFswZpaB3zFVnbwch1G1B db1CAPECrMGqou9B0YjJmk8Q5YvyTbLWg6NgcHrmddRfvseMtvViHjDNZK06XNWAN8kn 7SGo7hjzcdk3VeQ8zTVcaOovG4TX3sUOE8dAPQucNaig5BZv9k6TrMfvlciURyZ3sYvg PZ+ciEVDrtLaIhn+UT6o5PZdIrPj/BioxK/Rft8/q9O7nNpuZ5He/t8qPwYZp4pnAd7+ /2eLYzEPomqM1TlSt5KzsPZLtKwQ3tTbGy7qORdSs4QsPY19m8wJNDufck7pSl1pHlxN 6S1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FiP8fEOMwEYXV3ynB5vs09VgJcAWxxg7hYsDdibfxjw=; b=fjSKIm2AEMEQ8rgNGhUUHMC/mAuKdqk/ZPjHfR2mUfOZiat/xnQUHK4r78PAKi2vtQ qkGdU7TMDXfW8imtdAHgO29+wFOPAdST7tV6wF8bBFj5kpVsxANKaMS1Bkqc+WP5Oxxi YVSiH/0Zlj18LJV1/s21v73I+D7eOt9X21LUjYQn9iY9y048DmWikrDGfpCpQV6BprFI dIBA7bqTppKdsGZhyqVZ4uBIOcPk2vmIm1sT3I+JZYXXGXRQUSHPbQpJF19QRmlSYkPJ Q8yKMokhS2868SfOlE7MVmm2P+KdEeAuU20xzChbMyUmJW+umUPrNNGY9cTrhlGofyRI YMWQ== X-Gm-Message-State: AGRZ1gJR0DNni3DuQonkgwxkVqt5a8H3mtm383zHbzU8MkhDOuVY6h/4 0habyhvmnD2kuoeTKQCPqkfZrtDQKeU= X-Google-Smtp-Source: AJdET5d8Pb0oZ/B5s0wtTgjy6B4spSLZ+yLPEedHqeZrEQ5+Q/e5nYtR6DskelZyJp00MivXStYAoA== X-Received: by 2002:a62:9702:: with SMTP id n2-v6mr27379665pfe.222.1541532609430; Tue, 06 Nov 2018 11:30:09 -0800 (PST) Received: from localhost.localdomain ([167.220.105.115]) by smtp.gmail.com with ESMTPSA id a18sm9638633pgj.30.2018.11.06.11.30.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:30:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:03 -0800 Message-Id: <20181106193005.5383-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106193005.5383-1-stephen@networkplumber.org> References: <20181106193005.5383-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 2/4] bus/vmbus: fix directory handle leak on error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If sysfs directory was incorrectly formatted then the vmbus setup code would leak a directory handle in the error path. Coverity issue: 302848 Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c index 856c6d66785d..12e97e3a420a 100644 --- a/drivers/bus/vmbus/linux/vmbus_uio.c +++ b/drivers/bus/vmbus/linux/vmbus_uio.c @@ -329,6 +329,7 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, char chan_path[PATH_MAX], subchan_path[PATH_MAX]; struct dirent *ent; DIR *chan_dir; + int err; snprintf(chan_path, sizeof(chan_path), "%s/%s/channels", @@ -344,7 +345,6 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, while ((ent = readdir(chan_dir))) { unsigned long relid, subid, monid; char *endp; - int err; if (ent->d_name[0] == '.') continue; @@ -364,8 +364,7 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, if (err) { VMBUS_LOG(NOTICE, "invalid subchannel id %lu", subid); - closedir(chan_dir); - return err; + goto fail; } if (subid == 0) @@ -382,17 +381,20 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary, if (err) { VMBUS_LOG(NOTICE, "invalid monitor id %lu", monid); - return err; + goto fail; } err = vmbus_chan_create(dev, relid, subid, monid, subchan); if (err) { VMBUS_LOG(NOTICE, "subchannel setup failed"); - return err; + goto fail; } break; } closedir(chan_dir); return (ent == NULL) ? -ENOENT : 0; +fail: + closedir(chan_dir); + return err; } From patchwork Tue Nov 6 19:30:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 47904 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E777B4CA2; Tue, 6 Nov 2018 20:30:15 +0100 (CET) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id B0A5B2C52 for ; Tue, 6 Nov 2018 20:30:11 +0100 (CET) Received: by mail-pg1-f195.google.com with SMTP id 32-v6so6259745pgu.2 for ; Tue, 06 Nov 2018 11:30:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SnVbfOOs81D3X9Pr0bY0M2EFZpVp0/4RNXCCiEDZPVM=; b=l+p3OYeTo/50tbqdSa12SZBR7J35JixslQQVS2AO5wIf7laxXVXTnbyqNyP2Ea1MoT l0qDXLQ8+8+tAKZsAHKoEND6srvzR48mu3FVSTorOE/rL1gB++OYj3e4lTO925qhqrz9 XS+HArtMcZvMiVfoZx/XLfcSayvFtAA6vIybtBC4g5J1XphPt/QWRSwxfhj8UT36tXoX 6GpVeejQL/yodFUyrnCmNXKC8ybukReF8oq3yDAueNCJ8wEb7H9dRv+EzgX1fZqXg/YX R2UcVZqkSPiACaCLY8YOsr5eSGdY5ozdzBu0axhKZBm1GJ4eWc41EjvXRLTjLzQMI/QW PZhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SnVbfOOs81D3X9Pr0bY0M2EFZpVp0/4RNXCCiEDZPVM=; b=o7/z0SAn15dPP6SMHXd0gz2+XwgnzCx5uYD5rYSoSXcWNnmKFYnHOS8zI+cG3gCVVm 440CriipprKiB+q67SCG27ZJesLTlJkM+TgoO9kQVPhFEljfUSeaWpYAzwlpj9ZhslOk enL60o+Xo/jK2WBGvjFjmCGcZgn3I6OHu6DdFuCEu0NRL/U9DtIowHVevWD/WPRGjFge YnuxcRIeu5orpHLQ37LpGjtnEihj21AjDM5YRGi3Lw32BiKnX835+dC4KDV5ISiT+1eu w2ECSib9f4rG4TEORQZOny47cyIVZ+AiRryhwSs64KkxBOgSMe+FwItXlBUm7VIpCkiN SaoA== X-Gm-Message-State: AGRZ1gKyPdWu7M+RdbF7c4DlL0DtK4k+36tth4XYytgQU3U/sRKrPDY3 9FxFvLJ5xl/afjx12kEZ6Cn+TojES0s= X-Google-Smtp-Source: AJdET5dBG10M/6iVNGOTuYzpf3EzP/bzt+fzroxJP5Ddcd7fvi2tzM3LCBH9DAbNVCqW1fxrAF6JEA== X-Received: by 2002:aa7:83c2:: with SMTP id j2-v6mr27501216pfn.91.1541532610275; Tue, 06 Nov 2018 11:30:10 -0800 (PST) Received: from localhost.localdomain ([167.220.105.115]) by smtp.gmail.com with ESMTPSA id a18sm9638633pgj.30.2018.11.06.11.30.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:30:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:04 -0800 Message-Id: <20181106193005.5383-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106193005.5383-1-stephen@networkplumber.org> References: <20181106193005.5383-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 3/4] net/tap: fix file descriptor leak on error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If netlink socket setup fails the file descriptor was leaked. Coverity issue: 257040 Fixes: 7c25284e30c2 ("net/tap: add netlink back-end for flow API") Signed-off-by: Stephen Hemminger Acked-by: Keith Wiles --- drivers/net/tap/tap_netlink.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/tap_netlink.c b/drivers/net/tap/tap_netlink.c index 6cb510092218..14bbbec754f6 100644 --- a/drivers/net/tap/tap_netlink.c +++ b/drivers/net/tap/tap_netlink.c @@ -51,14 +51,17 @@ tap_nl_init(uint32_t nl_groups) } if (setsockopt(fd, SOL_SOCKET, SO_SNDBUF, &sndbuf_size, sizeof(int))) { TAP_LOG(ERR, "Unable to set socket buffer send size"); + close(fd); return -1; } if (setsockopt(fd, SOL_SOCKET, SO_RCVBUF, &rcvbuf_size, sizeof(int))) { TAP_LOG(ERR, "Unable to set socket buffer receive size"); + close(fd); return -1; } if (bind(fd, (struct sockaddr *)&local, sizeof(local)) < 0) { TAP_LOG(ERR, "Unable to bind to the netlink socket"); + close(fd); return -1; } return fd; From patchwork Tue Nov 6 19:30:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 47905 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F84F4CE4; Tue, 6 Nov 2018 20:30:17 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 695FA3238 for ; Tue, 6 Nov 2018 20:30:12 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id 32-v6so6259758pgu.2 for ; Tue, 06 Nov 2018 11:30:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6oBUCv7+phmIrDPpenUTh9zTN/opx5QeamKgnOqn6Ys=; b=cJLT08XP0VIStdikPSak071xLx0CHbTR0/3TIfM2yuSHBfAtrgjObPIeAa8NGDGZzP tgBt00YbnIHN5CfqKhpeyG+L7V3FOcXuZI5nEtAXdtIcR0MjX7Ru+9a602rOcofEeZUM V9c1J6cNKX69WP/ay5nJUKtKFeYH0YRYvjx0+yt3CLD9bghlcmUj8AL+0blfGahZhRi3 xkpTHvV06xMcOREfRFqnzpFCgzCc3/LomWbkWM5LbuzasspDIAl6YLcSdFgnNlNxCkEH fVk18Z0y8H9rQqKkZxwFwAzQK1HXdHPMc8BLu09Iv9wfIV//AeXlpdmciLwIq4IuFewj 5NLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6oBUCv7+phmIrDPpenUTh9zTN/opx5QeamKgnOqn6Ys=; b=ZhHxoqXZ05fWyIj0ol4rhM8lczycP70IQgZytQUzDPEc56JAxNwkYyIHNWhWUtm02G 4tWZ1cNGuL7ymfsmuBY6dT5Gbcc6ZYVrHTdhmgcQf0xJnqqxMNKzacHLkeVhu7EDjrha w39HEzz8RE21kMmH0wKts4vSPKMkMqqi8gaMe0dteX01fL9gjrcLufmQN+p3+Rq3rbKT 4JVWIg1Hi4I/tzBPQKNqxCu4xjSU9Ie6U4p89IKWIaoHJ5RTGvmy5mGisodqp0tjljJN g9t0qYutaCP5sZZ/x8lKSXlbvPuGQemLwl/O3Idhl/jgB9XlLY6Kp1t7JPt4wTM2E5IA EdwQ== X-Gm-Message-State: AGRZ1gKvXQa8IqyI/eOT8wcd6Fbftd8lb9LVnAfZWIDJzEtNKLJCVacr 2U89nqIc5Eiyq8Zeu1jtovxHHMFKNdE= X-Google-Smtp-Source: AJdET5fGUm1Do8xV1K/it+gGfI0WKyFmh/w5GtkJVZTBJmUd33Cf2hYuwcMwY9ltgv5/we6hs3MF0A== X-Received: by 2002:a63:fd09:: with SMTP id d9-v6mr25288789pgh.164.1541532611165; Tue, 06 Nov 2018 11:30:11 -0800 (PST) Received: from localhost.localdomain ([167.220.105.115]) by smtp.gmail.com with ESMTPSA id a18sm9638633pgj.30.2018.11.06.11.30.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Nov 2018 11:30:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:05 -0800 Message-Id: <20181106193005.5383-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181106193005.5383-1-stephen@networkplumber.org> References: <20181106193005.5383-1-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 4/4] net/tap: fix warning about comparison of fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Static analysis tools don't like the fact that fd could be zero in the error path. This won't happen in real world because stdin would have to be closed, then other error occurring. Coverity issue: 14079 Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Signed-off-by: Stephen Hemminger Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 84aaf241019a..f7087222b319 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -231,7 +231,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive) return fd; error: - if (fd > 0) + if (fd >= 0) close(fd); return -1; }