From patchwork Wed May 18 06:58:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 111273 X-Patchwork-Delegate: andrew.rybchenko@oktetlabs.ru Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DB149A0503; Wed, 18 May 2022 09:06:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EBE040156; Wed, 18 May 2022 09:06:47 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 9D827400D6 for ; Wed, 18 May 2022 09:06:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652857606; x=1684393606; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n0SsckE9q3qnviwNGruLmrY22HZZraXWHgh7NgLVoZE=; b=GUePonbRibNmhEd8SHFH655t+eGgeJj3L2TOoFEiwVCQBNEU7qXmsE+T bgc/IrnQk0Ofs22LAw6fgpw/LpYDthBSB4FzO8vE8Wcv/GmtoirPs/bAG q8hAw5cFTavppqqju7eX7KtWgdDlLpMUmU80kOBYypQKK4clUHILsl+2l dr6GHeHVwQYmZ6aA1fm94BK4S532IlrzQVIuzh35fmGr+XNn/KPfvUIKZ qzRoK+0xnWvwQuFi1faBww8Rpkk6U8ZA7ee9SlJkAy5F/PF7tzZ7rNEJ+ ioUoYtBNIyXOdY2NT+DeUVRWgBT09EDse67PTgV8m7QvaQyWMTukEqePx Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10350"; a="271649436" X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="271649436" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 00:06:45 -0700 X-IronPort-AV: E=Sophos;i="5.91,234,1647327600"; d="scan'208";a="569303462" Received: from intel-cd-odc-steve.cd.intel.com ([10.240.178.191]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2022 00:06:43 -0700 From: Steve Yang To: dev@dpdk.org Cc: yuying.zhang@intel.com, qi.z.zhang@intel.com, Steve Yang Subject: [PATCH v3] app/testpmd: support ddp dump command for ice Date: Wed, 18 May 2022 06:58:06 +0000 Message-Id: <20220518065806.1005694-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220512020618.474816-1-stevex.yang@intel.com> References: <20220512020618.474816-1-stevex.yang@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Dump DDP runtime configure into a binary(package) file from ice PF port. Add command line: ddp dump Parameters: the PF Port ID dumped runtime configure file, if not a absolute path, it will be dumped to testpmd running directory. For example: testpmd> ddp dump 0 current.pkg If you want to dump ice VF DDP runtime configure, you need bind other unused PF port of the NIC first, and then dump the PF's runtime configure as target output. Signed-off-by: Steve Yang --- v3: change git commit log --- app/test-pmd/cmdline.c | 76 ++++++++++++++++++++++++++++++++++++++++ app/test-pmd/meson.build | 3 ++ 2 files changed, 79 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 6ffea8e21a..6282981ee9 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -60,6 +60,9 @@ #ifdef RTE_NET_I40E #include #endif +#ifdef RTE_NET_ICE +#include +#endif #ifdef RTE_NET_BNXT #include #endif @@ -654,6 +657,9 @@ static void cmd_help_long_parsed(void *parsed_result, "set link-down port (port_id)\n" " Set link down for a port.\n\n" + "ddp dump (port_id) (config_path)\n" + " Dump a runtime configure on a port\n\n" + "ddp add (port_id) (profile_path[,backup_profile_path])\n" " Load a profile package on a port\n\n" @@ -14471,6 +14477,75 @@ cmdline_parse_inst_t cmd_strict_link_prio = { }, }; +/* Dump device ddp package, only for ice PF */ +struct cmd_ddp_dump_result { + cmdline_fixed_string_t ddp; + cmdline_fixed_string_t add; + portid_t port_id; + char filepath[]; +}; + +cmdline_parse_token_string_t cmd_ddp_dump_ddp = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_dump_result, ddp, "ddp"); +cmdline_parse_token_string_t cmd_ddp_dump_dump = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_dump_result, add, "dump"); +cmdline_parse_token_num_t cmd_ddp_dump_port_id = + TOKEN_NUM_INITIALIZER(struct cmd_ddp_dump_result, port_id, RTE_UINT16); +cmdline_parse_token_string_t cmd_ddp_dump_filepath = + TOKEN_STRING_INITIALIZER(struct cmd_ddp_dump_result, filepath, NULL); + +static void +cmd_ddp_dump_parsed( + void *parsed_result, + __rte_unused struct cmdline *cl, + __rte_unused void *data) +{ + struct cmd_ddp_dump_result *res = parsed_result; + uint8_t *buff; + uint32_t size; + int ret = -ENOTSUP; + +#define ICE_BUFF_SIZE 0x000c9000 + size = ICE_BUFF_SIZE; + buff = (uint8_t *)malloc(ICE_BUFF_SIZE); + if (buff) { +#ifdef RTE_NET_ICE + ret = rte_pmd_ice_dump_package(res->port_id, &buff, &size); +#endif + switch (ret) { + case 0: + save_file(res->filepath, buff, size); + break; + case -EINVAL: + fprintf(stderr, "Invalid buffer size\n"); + break; + case -ENOTSUP: + fprintf(stderr, + "Device doesn't support " + "dump DDP runtime configure.\n"); + break; + default: + fprintf(stderr, + "Failed to dump DDP runtime configure," + " error: (%s)\n", strerror(-ret)); + } + } + free(buff); +} + +cmdline_parse_inst_t cmd_ddp_dump = { + .f = cmd_ddp_dump_parsed, + .data = NULL, + .help_str = "ddp dump ", + .tokens = { + (void *)&cmd_ddp_dump_ddp, + (void *)&cmd_ddp_dump_dump, + (void *)&cmd_ddp_dump_port_id, + (void *)&cmd_ddp_dump_filepath, + NULL, + }, +}; + /* Load dynamic device personalization*/ struct cmd_ddp_add_result { cmdline_fixed_string_t ddp; @@ -18025,6 +18100,7 @@ cmdline_parse_ctx_t main_ctx[] = { (cmdline_parse_inst_t *)&cmd_ddp_del, (cmdline_parse_inst_t *)&cmd_ddp_get_list, (cmdline_parse_inst_t *)&cmd_ddp_get_info, + (cmdline_parse_inst_t *)&cmd_ddp_dump, (cmdline_parse_inst_t *)&cmd_cfg_input_set, (cmdline_parse_inst_t *)&cmd_clear_input_set, (cmdline_parse_inst_t *)&cmd_show_vf_stats, diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index 43130c8856..569e039bf7 100644 --- a/app/test-pmd/meson.build +++ b/app/test-pmd/meson.build @@ -67,6 +67,9 @@ endif if dpdk_conf.has('RTE_NET_I40E') deps += 'net_i40e' endif +if dpdk_conf.has('RTE_NET_ICE') + deps += 'net_ice' +endif if dpdk_conf.has('RTE_NET_IXGBE') deps += 'net_ixgbe' endif