From patchwork Fri May 13 07:20:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, WenxuanX" X-Patchwork-Id: 111118 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3A6AA00C3; Fri, 13 May 2022 09:43:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A21AE410EE; Fri, 13 May 2022 09:43:57 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 6D53540DDE; Fri, 13 May 2022 09:43:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652427835; x=1683963835; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=p2eHNR22qdqXPG5vgO8OxuBuJRPFVfKEE6MY+1m1lGs=; b=L3wVmxf0+Jixxw1tDLDRUv6qnVPgdNei1ISgVtBTPYFYN6POaljnsgjk yI+lvgr+ND8uFjnbyMoV2TAkB7jR6QUFuirFvflrMThpnr5ELNU44BTvH kGe4lPcfK/1mhm6bWafSkpI/J2+8qijAllxW2eSU+WJjvfNreDEnfAgEq 3EaWPJRJcQm4V1e3MsBLjkSjNYM//9wQFBCs6RgsDYaqLsg/XZtjFp48z E09Bz6MPmpjmlUR3rZZEI24euMa6jWU1rRv7ih1qGLMzWBRMgng+06JBA OPd9rHkfjfG9HA9EQl/GVaD8Zaw8mHovULLjlta5yy2DeEckAIiodW1IW Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10345"; a="270179336" X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="270179336" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 00:43:54 -0700 X-IronPort-AV: E=Sophos;i="5.91,221,1647327600"; d="scan'208";a="712298412" Received: from unknown (HELO localhost.localdomain) ([10.239.251.3]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2022 00:43:51 -0700 From: wenxuanx.wu@intel.com To: beilei.xing@intel.com, yuying.zhang@intel.com, dev@dpdk.org Cc: wenxuanx.wu@intel.com, yidingx.zhou@intel.com, stable@dpdk.org Subject: [PATCH v3] net/i40e: fix max frame size config at port level Date: Fri, 13 May 2022 07:20:49 +0000 Message-Id: <20220513072049.149333-1-wenxuanx.wu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220428111224.57705-1-wenxuanx.wu@intel.com> References: <20220428111224.57705-1-wenxuanx.wu@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Wenxuan Wu Previously, max frame size can only be set when link is up, and the wait time is 1 sec. Startup time of 10G_BASET longer than 1s would result in failure. Acctually, max frame size of media type I40E_MEDIA_TYPE_BASET can be set regardless of link status. This patch omitted the link status check of 10G_MEDIA_TYPE_BASET. Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") Cc: stable@dpdk.org Signed-off-by: Wenxuan Wu Acked-by: Yuying Zhang --- drivers/net/i40e/i40e_ethdev.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 755786dc10..12d3cd9b0c 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -12102,17 +12102,21 @@ i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size) struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private); uint32_t rep_cnt = MAX_REPEAT_TIME; struct rte_eth_link link; - enum i40e_status_code status; - - do { - update_link_reg(hw, &link); - if (link.link_status) - break; - - rte_delay_ms(CHECK_INTERVAL); - } while (--rep_cnt); + enum i40e_status_code status = I40E_ERR_DEVICE_NOT_SUPPORTED; + bool can_be_set = true; + + /* I40E_MEDIA_TYPE_BASET link up can be ignored */ + if (hw->phy.media_type != I40E_MEDIA_TYPE_BASET) { + do { + update_link_reg(hw, &link); + if (link.link_status) + break; + rte_delay_ms(CHECK_INTERVAL); + } while (--rep_cnt); + can_be_set = link.link_status != 0; + } - if (link.link_status) { + if (can_be_set) { status = i40e_aq_set_mac_config(hw, size, TRUE, 0, false, NULL); if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to set max frame size at port level");