From patchwork Tue Mar 1 22:53:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 108457 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEBD3A0350; Tue, 1 Mar 2022 23:53:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF7B840696; Tue, 1 Mar 2022 23:53:19 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 139A740040 for ; Tue, 1 Mar 2022 23:53:18 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 221Hvolw005167 for ; Tue, 1 Mar 2022 14:53:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=t0C4vPdUbC9ENsE6JA3P6+xTeADf/Dg0BVo5RNBRVjo=; b=fPWycUhQQXBpn8tqUiQWgkyAZd9hkMu8sQbIXeDym7sIfh8s914htSl5E6qvcxy2uRXs zduXU2JeLhVoDLAbOGjoxxeV48FfY231n38AZ7AC24WB+Ee3LYi+nE6uWMmbwPwHCA3x 7jcTVhSamMAGZtEb/F8bCtVY5VvMQ3PHgvVTnvadFS73ZRvwu9GP4boR65j18JLCAM6L gYwM96IlVbMzAZzK8Ygm+RyiavGRwIx2d/sl9Gmt95u6ga76u0Mz5ipXrGYgdOgdAkt+ nstKCRBlho++6ciAa77d61COoJ2RsB6daH4X0YGHdIAgOonyJtZlv0z0tTmw8qcxcK9R AQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3ehgf43mqc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 01 Mar 2022 14:53:15 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 1 Mar 2022 14:53:14 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Tue, 1 Mar 2022 14:53:14 -0800 Received: from BG-LT7430.marvell.com (BG-LT7430.marvell.com [10.28.177.176]) by maili.marvell.com (Postfix) with ESMTP id 438AA67385; Tue, 1 Mar 2022 14:53:11 -0800 (PST) From: To: , Pavan Nikhilesh , "Shijith Thotton" CC: Subject: [PATCH 1/2] event/cnxk: fix incorrect mask length Date: Wed, 2 Mar 2022 04:23:08 +0530 Message-ID: <20220301225309.8126-1-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Proofpoint-GUID: EB4tkelV7QSyS6gRUH9u6vNAKeyANvUR X-Proofpoint-ORIG-GUID: EB4tkelV7QSyS6gRUH9u6vNAKeyANvUR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-01_07,2022-02-26_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Fix incorrect mask used when clearing subevent type masking out useful data. Fixes: e239e0d3faf7 ("event/cnxk: add SSO HW device operations") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h index b157fef096..5564746e6d 100644 --- a/drivers/event/cnxk/cnxk_eventdev.h +++ b/drivers/event/cnxk/cnxk_eventdev.h @@ -43,7 +43,7 @@ #define CNXK_TT_FROM_EVENT(x) (((x) >> 38) & SSO_TT_EMPTY) #define CNXK_EVENT_TYPE_FROM_TAG(x) (((x) >> 28) & 0xf) #define CNXK_SUB_EVENT_FROM_TAG(x) (((x) >> 20) & 0xff) -#define CNXK_CLR_SUB_EVENT(x) (~(0xffu << 20) & x) +#define CNXK_CLR_SUB_EVENT(x) (~(0xffull << 20) & x) #define CNXK_GRP_FROM_TAG(x) (((x) >> 36) & 0x3ff) #define CNXK_SWTAG_PEND(x) (BIT_ULL(62) & x) #define CNXK_TAG_IS_HEAD(x) (BIT_ULL(35) & x) From patchwork Tue Mar 1 22:53:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 108458 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4A24A0350; Tue, 1 Mar 2022 23:53:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A45BA40DF6; Tue, 1 Mar 2022 23:53:42 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 0F6C640040 for ; Tue, 1 Mar 2022 23:53:40 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 221JfpQi003204 for ; Tue, 1 Mar 2022 14:53:39 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=Al9Q7PXNUMY+SftCrOB1uhEpR8PZhL7/qH/PLJlIr2s=; b=VKR7bhTtUV4S1BXUvZ332MpKOQe/Ygqh4CI5boI6SG2W0BcNnecZ2KOELmQvvn2LnWE/ 1z52WG/d5qbRyPT7eyio/z2VOAbgetqz+wL1nc20py6bNOL7v4uVzFWTA8adftS31xBc 5jF9s7neQWQz/MmfAzDu4Yg/X2MQHMjSc3n1d5n9jbLoTI5QjwLXO4/WUo4BfLZsMwMu G56PNKYxMxbj53/CWhjOLxvb6aPlEns4KII3AEUfdhqe9PRvSMF64XwMY0GctotDcFXl aG0I3NvBYSwbIYuTRrWErsQAsHgqoMbSbiYuZaEn4c6LHia5eoqF+7B8xoUNU8MFgBNO ZQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3ehj9du3n9-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 01 Mar 2022 14:53:39 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 1 Mar 2022 14:53:18 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Mar 2022 14:53:18 -0800 Received: from BG-LT7430.marvell.com (BG-LT7430.marvell.com [10.28.177.176]) by maili.marvell.com (Postfix) with ESMTP id 87C6667389; Tue, 1 Mar 2022 14:53:15 -0800 (PST) From: To: , Pavan Nikhilesh , "Shijith Thotton" CC: Subject: [PATCH 2/2] event/cnxk: fix incorrect Rx adapter config checks Date: Wed, 2 Mar 2022 04:23:09 +0530 Message-ID: <20220301225309.8126-2-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220301225309.8126-1-pbhagavatula@marvell.com> References: <20220301225309.8126-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: pN6rU1YkBrg1HTA4aclCvsZb7zdSdo2m X-Proofpoint-GUID: pN6rU1YkBrg1HTA4aclCvsZb7zdSdo2m X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514 definitions=2022-03-01_07,2022-02-26_01,2022-02-23_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh The rx_queue_flags should be checked against RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID flag. Fixes: cb4bfd6e7bdf ("event/cnxk: support Rx adapter") Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cnxk_eventdev_adptr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c index 7b580ca98f..bfc89a1368 100644 --- a/drivers/event/cnxk/cnxk_eventdev_adptr.c +++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c @@ -230,7 +230,7 @@ cnxk_sso_rx_adapter_queue_add( cnxk_eth_dev, (uint16_t)rx_queue_id, port, &queue_conf->ev, !!(queue_conf->rx_queue_flags & - RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID)); + RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID)); if (queue_conf->rx_queue_flags & RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR) { cnxk_sso_updt_xae_cnt(dev, queue_conf->vector_mp,