From patchwork Wed Feb 9 07:27:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 107097 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7EA8A034F; Wed, 9 Feb 2022 08:27:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A1BA410FD; Wed, 9 Feb 2022 08:27:39 +0100 (CET) Received: from out203-205-251-73.mail.qq.com (out203-205-251-73.mail.qq.com [203.205.251.73]) by mails.dpdk.org (Postfix) with ESMTP id 7AE02410F3 for ; Wed, 9 Feb 2022 08:27:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1644391655; bh=sToY7/3AzidanvbD348V3b0C/NxRFydyMPR25CFv5Mg=; h=From:To:Cc:Subject:Date; b=URGcigSdubprEO1Z6Vzz/RtsTvJYQElrLfNZyMdWAhnCYXK7vBvpkAo9e3CZv075Y JSMXzliS2fcWe/dO+go/VGdPUmeyDCwEB9dRoqcC42iiOr8KGEhFVBsaMPNv5Gln88 4G6ogSzHbp0yUs/LNNDL6mBP4WsuYhLgOqo3wjbg= Received: from liwg-ubuntu.lan ([111.193.130.237]) by newxmesmtplogicsvrszc6.qq.com (NewEsmtp) with SMTP id 6DB07E85; Wed, 09 Feb 2022 15:27:27 +0800 X-QQ-mid: xmsmtpt1644391647tany9jcuj Message-ID: X-QQ-XMAILINFO: NhDhJCJPIfnT/SaQttjdlmDITUekjjJclKDwdoP3Mx7OOlY8cPJkrRmZd2PBCV 7fQiXJy9ZYbTl352i4Iw9JrU8aGl2r1qGjny3MerTtp8Ko4oUR44bP3tHP3HOyAK2mp/8IkcEh86 fiHNBtI+itSg8xVyAijA20tvVsPKhD6e3y4fw+ppeM7oZZ7W2U/4Q+zNLusZm5J7T5DLtnY1AgI1 MHxpg0gu+zMxnvxHaus3ilNb8DEX3F9SKxLJ5p+n7EF6tuE35qIxHanQ2YXT0kehcdaJEs0NGF8R PicHG2FJ9KutM/XqOXElDpyMirWVCc6CfoQ/T0G9J4mUlP6uOs+v+fiLx3kFs2cprz4Wr459Q6MR JbjWLlm4sQ5to6Pf74Co4MTHnJwCLjewQyak/HfHki4ix1zNhn0cjBZEgSfPNJZZ9JO22VSNmLOb GIyLKnM0vMEEmVIvCPxjBTqlbU5B3VwKsppegHf9UMwMRcUUOkbyk9EF9zQtlppjqSSolTSQbZgY s0RQFBOtqs5zOZVigTqBcT47DarTnYc6U34B7vDsKXNurGX6BzUUx+ki+ax5+gKHryGxqN+tjMwH TdCmkiZlSZ9S1/vmDBzMjLauXo7/O15Lo0jqzLi9C3zmk736YJrLeieDQWMGvXoS/02x/Y15F3sO +NgqgLL7Gxa94z0MHfRD1VJZfQE3L0oPTsEfILzHjinXKiq+6BOXxfrEzL4Rg0ETOJ/s7Z+yflCK dSBiS4rVQ6OxoSrG/2FXQm1fXsV0RMjc4ZncxcD/IAUHTf5S2dFGCxljX8LTWEhGo/4S7CiUz0KE 7+j9ObJ2PLH9nSu+K9bcdiyPEgIQW3CdqZ3BB//7C2BrnaK6IHYqFTQIpQrxfjcYf2duLI3F8+Wk 3ihdRSiVhlwSM6CnpkeioDoYPkI/dl2Q== From: Weiguo Li To: jgrajcia@cisco.com Cc: dev@dpdk.org Subject: [PATCH] net/memif: remove pointer deference before null check Date: Wed, 9 Feb 2022 15:27:26 +0800 X-OQ-MSGID: <20220209072726.3832858-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There are duplicates of asignment here, the one before null check may cause a null pointer deference, so remove the previous one. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Signed-off-by: Weiguo Li --- drivers/net/memif/memif_socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c index 42f48a68a1..7886644412 100644 --- a/drivers/net/memif/memif_socket.c +++ b/drivers/net/memif/memif_socket.c @@ -402,11 +402,10 @@ memif_msg_enq_init(struct rte_eth_dev *dev) { struct pmd_internals *pmd = dev->data->dev_private; struct memif_msg_queue_elt *e = memif_msg_enq(pmd->cc); - memif_msg_init_t *i = &e->msg.init; + memif_msg_init_t *i; if (e == NULL) return -1; - i = &e->msg.init; e->msg.type = MEMIF_MSG_TYPE_INIT; i->version = MEMIF_VERSION;