From patchwork Fri Oct 22 06:55:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 102616 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE79AA0C43; Fri, 22 Oct 2021 08:55:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81D394069D; Fri, 22 Oct 2021 08:55:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D68414068C for ; Fri, 22 Oct 2021 08:55:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634885745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x03N1QHHiK5qqEEsTYWTtOe9ZU+xqecqrYTfkJ+7/rw=; b=WXqnRUgpatlCWgf/uu7Xld/R16UGogFrX71JCMynF1LxDv4mCTCo4TuumW5uULuNuf3frf JvxUAKiPKMTehPonZxI8uPGN4e3dXiJrjtMwy2nRY9qy6ndO+9BsZxwVp9+/TL6gDu90CD ACPi5paTd9tQ5mixiloiDOKDKDme2Gc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-vdhttTraObma5__2RfGprA-1; Fri, 22 Oct 2021 02:55:41 -0400 X-MC-Unique: vdhttTraObma5__2RfGprA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A64B9801B0C; Fri, 22 Oct 2021 06:55:40 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.101]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E71A60862; Fri, 22 Oct 2021 06:55:36 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: ktraynor@redhat.com, ian.stokes@intel.com, i.maximets@ovn.org, Ray Kinsella Date: Fri, 22 Oct 2021 08:55:28 +0200 Message-Id: <20211022065528.25178-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This API has been around for more than a year (and is in LTS 20.11). It did not receive negative feedback and will be used in a next OVS release. Mark it stable. Signed-off-by: David Marchand Acked-by: Kevin Traynor Acked-by: Thomas Monjalon --- lib/eal/include/rte_eal.h | 1 - lib/eal/include/rte_lcore.h | 6 ------ lib/eal/version.map | 14 +++++++------- 3 files changed, 7 insertions(+), 14 deletions(-) diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h index a959f8c6d4..5a34a6acd9 100644 --- a/lib/eal/include/rte_eal.h +++ b/lib/eal/include/rte_eal.h @@ -155,7 +155,6 @@ int rte_eal_primary_proc_alive(const char *config_file_path); * attached, * - false, otherwise. */ -__rte_experimental bool rte_mp_disable(void); #define RTE_MP_MAX_FD_NUM 8 /* The max amount of fds */ diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h index 0458d233de..d6e56f6000 100644 --- a/lib/eal/include/rte_lcore.h +++ b/lib/eal/include/rte_lcore.h @@ -285,7 +285,6 @@ typedef void (*rte_lcore_uninit_cb)(unsigned int lcore_id, void *arg); * On failure (either memory allocation issue in the function itself or an * error is returned by the init callback itself), returns NULL. */ -__rte_experimental void * rte_lcore_callback_register(const char *name, rte_lcore_init_cb init, rte_lcore_uninit_cb uninit, void *arg); @@ -300,7 +299,6 @@ rte_lcore_callback_register(const char *name, rte_lcore_init_cb init, * The handle pointer returned by a former successful call to * rte_lcore_callback_register. */ -__rte_experimental void rte_lcore_callback_unregister(void *handle); @@ -333,7 +331,6 @@ typedef int (*rte_lcore_iterate_cb)(unsigned int lcore_id, void *arg); * Same return code as the callback last invocation (see rte_lcore_iterate_cb * description). */ -__rte_experimental int rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg); @@ -343,7 +340,6 @@ rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg); * @param f * The output stream where the dump should be sent. */ -__rte_experimental void rte_lcore_dump(FILE *f); @@ -391,14 +387,12 @@ int rte_thread_getname(pthread_t id, char *name, size_t len); * @return * On success, return 0; otherwise return -1 with rte_errno set. */ -__rte_experimental int rte_thread_register(void); /** * Unregister current thread and release lcore if one was associated. */ -__rte_experimental void rte_thread_unregister(void); diff --git a/lib/eal/version.map b/lib/eal/version.map index 38f7de83e1..783e3c6b47 100644 --- a/lib/eal/version.map +++ b/lib/eal/version.map @@ -127,10 +127,14 @@ DPDK_22 { rte_keepalive_mark_sleep; # WINDOWS_NO_EXPORT rte_keepalive_register_core; # WINDOWS_NO_EXPORT rte_keepalive_register_relay_callback; # WINDOWS_NO_EXPORT + rte_lcore_callback_register; + rte_lcore_callback_unregister; rte_lcore_count; + rte_lcore_dump; rte_lcore_has_role; rte_lcore_index; rte_lcore_is_enabled; + rte_lcore_iterate; rte_lcore_to_socket_id; rte_log; rte_log_cur_msg_loglevel; @@ -211,6 +215,7 @@ DPDK_22 { rte_memzone_walk; rte_mp_action_register; rte_mp_action_unregister; + rte_mp_disable; rte_mp_reply; rte_mp_request_async; rte_mp_request_sync; @@ -263,8 +268,10 @@ DPDK_22 { rte_strsplit; rte_sys_gettid; rte_thread_get_affinity; + rte_thread_register; rte_thread_set_affinity; rte_thread_setname; + rte_thread_unregister; rte_uuid_compare; rte_uuid_is_null; rte_uuid_parse; @@ -382,13 +389,6 @@ EXPERIMENTAL { # added in 20.08 rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT - rte_lcore_callback_register; - rte_lcore_callback_unregister; - rte_lcore_dump; - rte_lcore_iterate; - rte_mp_disable; - rte_thread_register; - rte_thread_unregister; # added in 20.11 __rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT