From patchwork Mon Oct 11 12:37:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 101022 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0E2CA034F; Mon, 11 Oct 2021 14:38:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BB88410E1; Mon, 11 Oct 2021 14:38:34 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by mails.dpdk.org (Postfix) with ESMTP id 49F60410E1 for ; Mon, 11 Oct 2021 14:38:32 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fvfYj1pccWlXDHdhCNdLGB40bzMRZBwxp9PBZ79k7ngQcyZ1AnZ6vB+XV2ikFKngY0ctpEAn3o3W3ygC9i4cREB4HFqjk9UqMbRRd6KWaQaewiXo3DfWuiITRBnAjMxEW8UVUBqK/EAUY+LwFHu7sjCrx6el/F1fTc4ExLu/0KbusWF0NChj27gwdZQ5QEO5fZkpzkrdRy+kB831lCbUhIu/lNSwQ/fOnvKMOK3Eul4QgjzhGhg+4guVlATRAYfIaWZYtjOKT36aJwH/1pYlpII9yZUfxQHm9EU65AUNcwiz1mvTGx64EFbkMQ7mv5U4N7+pt75Kl5alaItjgjqjiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvWfbTADmqYZRIl6Pbj7YNYwa9Rpps76lIYdhCRal/s=; b=jIx75WKIKn9s9Z4pvcNOij1iS/jZMa6rJ6TlNpuDML1MBJj24DhhfE+5lhmFPpu4UWMkqM9ed5sZzLTrpzTxXwFwBQ/fzZopS8mXewJ9JiyU8zOIQkrLA/C+ytliIezvC3n2lR2qjMRS+ygj8ycdY/kaJReIoXbMA7ZJo6XoYudCFbRJb8uTlYrxtnrSewCaTun4p6C3+KAW0E4If38yt4NtqSbSw8S2PtP1uuHbxBn9ZDyY0Ne2AAKGiuI71YXzq1ZGCvOPyznn8AacnCfN7OE0Toy+9RaVTNXG0rvx+OQbV0vEm4K1IDvdsyNwVuSlU0L4K/+92jGQLbq/ReU8nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=temperror (sender ip is 216.228.112.34) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=nvidia.com; dmarc=temperror action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bvWfbTADmqYZRIl6Pbj7YNYwa9Rpps76lIYdhCRal/s=; b=NuWtF/B7hyUaD+y+7PgBCJcEGzpIG1dWxM3VjkL9mLh78xoIEd400cAwBiq+KVPtMplbuWmzB6J78M+ddWxTWyX6Yuor6UIZUyOtKzQ470/zS2RcYm7JcTvlZpnly8GfOr4aW1G8kI74jbkaikrhiDX/HuOchzmE1W9kZhQeyPihkl6Scbgx67fRNHllQ2uNxnT8M/Xd3k60GAf4CoUURDWjZKV+slZdakTdMtVRP6AfBi+kMLdtzdfx6E8pW8EXDU+ICPI/Q1L3mM17WxQgJmbzRtfKquC+fls3pthdYvC3AKmenKejG0Wha9CNnSfbIEzlEXMW+5vGoY4bx8xZeA== Received: from DM3PR12CA0134.namprd12.prod.outlook.com (2603:10b6:0:51::30) by DM6PR12MB4265.namprd12.prod.outlook.com (2603:10b6:5:211::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 12:38:30 +0000 Received: from DM6NAM11FT052.eop-nam11.prod.protection.outlook.com (2603:10b6:0:51:cafe::9f) by DM3PR12CA0134.outlook.office365.com (2603:10b6:0:51::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:30 +0000 X-MS-Exchange-Authentication-Results: spf=temperror (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=temperror action=none header.from=nvidia.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of nvidia.com: DNS Timeout) Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT052.mail.protection.outlook.com (10.13.172.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:29 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 11 Oct 2021 12:38:26 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" Date: Mon, 11 Oct 2021 20:37:28 +0800 Message-ID: <20211011123733.961222-2-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011123733.961222-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211011123733.961222-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 011ee322-33d7-46e7-6ccb-08d98cb4076a X-MS-TrafficTypeDiagnostic: DM6PR12MB4265: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lXcGr5BRQgYebj4gPCQBnCHUrhenVs0PbKlNSzLSEIb4unGjpXtI8nnkVA5Jhe5PyqqbaGT8agp9XHZVDq+dWOixwIQVOgp/ke/oZmY08FPwZQUGpsFSMZU9Vp1Ne/gjc2MSB3twyDr9yfJaO2Qseb3oeOou2RXoZ+NlsgEmM8fchIQlh9SV6Xzzcgu3rTeWw8lGd9q44JqvdFkhAEwMQ4CuorT7ajETFBf2Ayyiq2sdsHzeHBkJcLvRcN+CH6kAhbl+0aE64PUhhIP9lPpNzz7csl+Yv2+zRLfkCthM4munXgkDAkO+YxArbzwxxJZ9dJk6uiDr/LN7p4zZcOFZIdM7e+28bu0fRb0lZy6nuajMXP4KyWcmZSrlrchGIprIo2ILFMMIzkGou+ptvEicHmgoIlCQ32jsl9uwQTsmfuljCpzO38LoT3nPy0t0xF5g5s33mkAG7aOop+ibotNhheNW6mIlVugcB3bTbwjrirnb8Kdj6Jpkjog+SMOUeLNMsaPhnGCS0vpqX+5C2EeiJ2ubqG7GIgpey6303BKocY8+pWJlh5fVjo9f7/eN9VB951jafgk+C+R+X9N4hwZTQgWpuTfS7cW8J9QDw3x0DJoFCFqUfnnBkAEy9+5dL8mgIkbWwh4t3B6GZNanY37jL0jM/ItoZuoOrGnZn/Ag+zZ3fssqEMVW4sO9dHS+MjyB1R8DjgJ/RFuXXZrJryGrq7H3yrxaKMzKMh/VzFbFHV6Jdci3DWUnDfb3Rz88kLlHRSYnhQLmkL2eBTFzxgMk/0bFU6vG4FW6nt7qXhH1wGuPEkycmXJCZL7vm57OTR7PeTa+VXJNHlgnFY7/BeV2+w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(86362001)(2616005)(7636003)(63350400001)(7696005)(356005)(4326008)(8936002)(63370400001)(6916009)(1076003)(82310400003)(83380400001)(55016002)(70586007)(316002)(70206006)(508600001)(966005)(36756003)(2906002)(16526019)(336012)(47076005)(6286002)(36860700001)(8676002)(54906003)(5660300002)(26005)(426003)(186003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:38:29.4964 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 011ee322-33d7-46e7-6ccb-08d98cb4076a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT052.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4265 Subject: [dpdk-dev] [PATCH v5 1/5] ethdev: introduce shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In current DPDK framework, each Rx queue is pre-loaded with mbufs for incoming packets. For some PMDs, when number of representors scale out in a switch domain, the memory consumption became significant. Polling all ports also leads to high cache miss, high latency and low throughput. This patch introduce shared Rx queue. Ports with same configuration in a switch domain could share Rx queue set by specifying sharing group. Polling any queue using same shared Rx queue receives packets from all member ports. Source port is identified by mbuf->port. Port queue number in a shared group should be identical. Queue index is 1:1 mapped in shared group. Share Rx queue must be polled on single thread or core. Multiple groups are supported by group ID. Example grouping and polling model to reflect service priority: Group0, 2 shared Rx queues per port: PF, rep0, rep1 Group1, 1 shared Rx queue per port: rep2, rep3, ... rep127 Core0: poll PF queue0 Core1: poll PF queue1 Core2: poll rep2 queue0 Signed-off-by: Xueming Li Cc: Jerin Jacob --- Rx queue object could be used as shared Rx queue object, it's important to clear all queue control callback api that using queue object: https://mails.dpdk.org/archives/dev/2021-July/215574.html --- doc/guides/nics/features.rst | 11 +++++++++++ doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/switch_representation.rst | 10 ++++++++++ doc/guides/rel_notes/release_21_11.rst | 4 ++++ lib/ethdev/rte_ethdev.c | 1 + lib/ethdev/rte_ethdev.h | 7 +++++++ 6 files changed, 34 insertions(+) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 4fce8cd1c97..69bc1d5719c 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -626,6 +626,17 @@ Supports inner packet L4 checksum. ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_OUTER_UDP_CKSUM``. +.. _nic_features_shared_rx_queue: + +Shared Rx queue +--------------- + +Supports shared Rx queue for ports in same switch domain. + +* **[uses] rte_eth_rxconf,rte_eth_rxmode**: ``offloads:RTE_ETH_RX_OFFLOAD_SHARED_RXQ``. +* **[provides] mbuf**: ``mbuf.port``. + + .. _nic_features_packet_type_parsing: Packet type parsing diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini index 754184ddd4d..ebeb4c18512 100644 --- a/doc/guides/nics/features/default.ini +++ b/doc/guides/nics/features/default.ini @@ -19,6 +19,7 @@ Free Tx mbuf on demand = Queue start/stop = Runtime Rx queue setup = Runtime Tx queue setup = +Shared Rx queue = Burst mode info = Power mgmt address monitor = MTU update = diff --git a/doc/guides/prog_guide/switch_representation.rst b/doc/guides/prog_guide/switch_representation.rst index ff6aa91c806..47205f5f1cc 100644 --- a/doc/guides/prog_guide/switch_representation.rst +++ b/doc/guides/prog_guide/switch_representation.rst @@ -123,6 +123,16 @@ thought as a software "patch panel" front-end for applications. .. [1] `Ethernet switch device driver model (switchdev) `_ +- For some PMDs, memory usage of representors is huge when number of + representor grows, mbufs are allocated for each descriptor of Rx queue. + Polling large number of ports brings more CPU load, cache miss and + latency. Shared Rx queue can be used to share Rx queue between PF and + representors among same switch. ``RTE_ETH_RX_OFFLOAD_SHARED_RXQ`` is + present in Rx offloading capability of device info. Setting the + offloading flag in device Rx mode or Rx queue configuration to enable + shared Rx queue. Polling any member port of the shared Rx queue can return + packets of all ports in the group, port ID is saved in ``mbuf.port``. + Basic SR-IOV ------------ diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst index c0a7f755189..aa6b5e2e9c5 100644 --- a/doc/guides/rel_notes/release_21_11.rst +++ b/doc/guides/rel_notes/release_21_11.rst @@ -134,6 +134,10 @@ New Features * Added tests to validate packets hard expiry. * Added tests to verify tunnel header verification in IPsec inbound. +* **Added ethdev shared Rx queue support. ** + + * Added new Rx queue offloading capability flag. + * Added share group to Rx queue configuration. Removed Items ------------- diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index fb69f6ea8d1..d78b50e1fa7 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -127,6 +127,7 @@ static const struct { RTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM), RTE_RX_OFFLOAD_BIT2STR(RSS_HASH), RTE_ETH_RX_OFFLOAD_BIT2STR(BUFFER_SPLIT), + RTE_ETH_RX_OFFLOAD_BIT2STR(SHARED_RXQ), }; #undef RTE_RX_OFFLOAD_BIT2STR diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index 39d2cd612cb..b94f7ba5a3f 100644 --- a/lib/ethdev/rte_ethdev.h +++ b/lib/ethdev/rte_ethdev.h @@ -1077,6 +1077,7 @@ struct rte_eth_rxconf { uint8_t rx_drop_en; /**< Drop packets if no descriptors are available. */ uint8_t rx_deferred_start; /**< Do not start queue with rte_eth_dev_start(). */ uint16_t rx_nseg; /**< Number of descriptions in rx_seg array. */ + uint32_t shared_group; /**< Shared port group index in switch domain. */ /** * Per-queue Rx offloads to be set using DEV_RX_OFFLOAD_* flags. * Only offloads set on rx_queue_offload_capa or rx_offload_capa @@ -1403,6 +1404,12 @@ struct rte_eth_conf { #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 #define RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT 0x00100000 +/** + * Rx queue is shared among ports in same switch domain to save memory, + * avoid polling each port. Any port in the group can be used to receive + * packets. Real source port number saved in mbuf->port field. + */ +#define RTE_ETH_RX_OFFLOAD_SHARED_RXQ 0x00200000 #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ DEV_RX_OFFLOAD_UDP_CKSUM | \ From patchwork Mon Oct 11 12:37:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 101023 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BDABA034F; Mon, 11 Oct 2021 14:38:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2709F410F5; Mon, 11 Oct 2021 14:38:37 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2047.outbound.protection.outlook.com [40.107.95.47]) by mails.dpdk.org (Postfix) with ESMTP id D0D29410F2 for ; Mon, 11 Oct 2021 14:38:35 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TCJ6WiMqQoKvO/mDpy3d36AT3XRceisgKA8hkb02VSMaQWShoMJLgV/8DsWmAV+Mz/0rjYH8uGe5Y23zjqDdjVuprayZh/qOcPoEtXcuRaAA7ID0iXB861VG0NLPtgQVCpIESbox6hBG+F7XsC1SSL22pwztUE5gGG7Pr9qvXWTv9H5L0AGzDFiYxAat8uNJKIr8Rd3H7P1sgKdRK1mg6idkNZ4gVIF4ImQ28qNFIt9RfBLSTjUkLyUTzyxzvw6Bi7PnXgMsz6uPbGgbnsYRZIEJxRdUf1s25RWFDXHx7I7bxHrhoYFyOjXcWBksT1c84xQ2bftexU0FGp9krT/FoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DWKJGg2RL+TJjhVPTxYZI5xeiHHCMQaSjw1Wr0moCgg=; b=T32Zhz3Dsr6KyGIYiDMs4A14vfW83NGBbtLoigQbvt7GHg9VjydjSESRMeohOA+fki27f5x0XeqafvVHKc+fyKyFdhBQjj38OGsDEDPMSdLqmKyypZYOKRGq0d3/4BvEfMyp6d5N/nMZzVN9X9aJvjlyzkHjqXfgI7LSEQGAVB5+FqS5wRl0o00p+fwMuv7oV/xqnaRiv7B1PG3G8heFY4dPXzn08XC4KoOfiY/zksG09YYX+RrUV62K4yl9safVIPR9/ArLRi18opWOkgLc3ceItLMJU2tBEF4j1h5oDdf5sey5isUPqsCL6vRwUzbEMSmtPTJG1VCDM9dTXtIntA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DWKJGg2RL+TJjhVPTxYZI5xeiHHCMQaSjw1Wr0moCgg=; b=IOkPiHiqy3o4ijDGzfZPbbSyfy5HJSB3htMJwZ0GDT3zlPVZZi4q8MzKZBUoVYwwpcQMcswSYScHHP2IxcXH9Mss1ihQz8TkD6WEU7sZysRIIL8Y9ZQ275OIEPvor0kItUEV8ORQNDQhR3X0Jf6nLykMFdz7TNXj8bxO2p+5gMrki3u36yA9X33LCfc1c5P7WBPGgFc5zX/Rl3v2Ow5AYKX7XJp2CIjje9fwqQkCDSLp6Xb0Qb+s0pN+b/lCm3FcD8Brukt3J0Hxlu/WRvVzcaoPTBIV97V6fd721uqtw8hqyy7iHQpdC2RJNMe+59d3Id/1roovMe2sxD+iwgT20A== Received: from DM6PR02CA0038.namprd02.prod.outlook.com (2603:10b6:5:177::15) by BYAPR12MB4709.namprd12.prod.outlook.com (2603:10b6:a03:98::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Mon, 11 Oct 2021 12:38:33 +0000 Received: from DM6NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::4) by DM6PR02CA0038.outlook.office365.com (2603:10b6:5:177::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20 via Frontend Transport; Mon, 11 Oct 2021 12:38:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT039.mail.protection.outlook.com (10.13.172.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:32 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 11 Oct 2021 12:38:29 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" , Xiaoyun Li Date: Mon, 11 Oct 2021 20:37:29 +0800 Message-ID: <20211011123733.961222-3-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011123733.961222-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211011123733.961222-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fab3f109-9eb8-4791-a045-08d98cb4095a X-MS-TrafficTypeDiagnostic: BYAPR12MB4709: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2887; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PlDV2YZaIDA6OdGkt/NZpguuAbf0VJUJul1gWCLl7p7mry8Duzwe1qJ4INQ60ffSqZtut1FOKxqz8fiLep6Y7km0GbnZYw8Q0zSMhUk4AZ265NGbi+TTPu+WwpgliC/fGs3CuTMmuSFN/M35dam+VYWIxeaEGKNu+jjwLeHplIuXLRgO2w3iB7lJsY5I209nngKRmIgwPk51WhqK6JJRuo68W7pKj2gMaT+EH4oBf1Fi1DOWXYkiWe+4ibti2Lzv5zz0sAQ2WXc1TTvJMzAn3XK+w2iOd9mgfc/5BJQPHLSCE4wV247g5Jt2ShYCNexmrS3vlmeKEA24Oa6ivlLL7VIah8zCd1txYHrAhC0zLnW7gmFR5WHs1V1kbUY51Df52DYJPF3P7hUxAw9SVh2JjzIQkTH8cJZYJW2L1qpCc5qFCpdZd7Ot1uGVHPdovDWyWow9vc2p4DuiPgC5L9C8SWE8YHCPxtwdkJ7W3UrgsoE9bd0PZt3fBRVladTN04Ofv5CWcEYkcGNHwnt5H7Lu3hYplZ/v/Ai2uBv6BinUzFpEllsvWdCKmYVCCbAMikInr6zFiyzmNK4SoRahdO5b8iWRhbefly4LVLKUsmp0ahRogPc03F2teOnFajkbmSSRi0lGPGToxPa4IbWSIBFD0amxcFoVnRYjBIYBkeLBFYtRb77jagOoIQuTTdifA8nxz11PQpB7fX03amVYm6Fibg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(508600001)(7696005)(8936002)(356005)(2906002)(186003)(7636003)(6916009)(82310400003)(16526019)(86362001)(426003)(36756003)(4326008)(8676002)(55016002)(336012)(36906005)(1076003)(83380400001)(316002)(26005)(2616005)(70586007)(70206006)(5660300002)(54906003)(6286002)(47076005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:38:32.7512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fab3f109-9eb8-4791-a045-08d98cb4095a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB4709 Subject: [dpdk-dev] [PATCH v5 2/5] app/testpmd: new parameter to enable shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Adds "--rxq-share" parameter to enable shared rxq for each rxq. Default shared rxq group 0 is used, Rx queues in same switch domain shares same rxq according to queue index. Shared Rx queue is enabled only if device support offloading flag RTE_ETH_RX_OFFLOAD_SHARED_RXQ. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 6 +++++- app/test-pmd/parameters.c | 13 +++++++++++++ app/test-pmd/testpmd.c | 18 ++++++++++++++++++ app/test-pmd/testpmd.h | 2 ++ doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++ 5 files changed, 45 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 9c66329e96e..6c7f9dee065 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2709,7 +2709,11 @@ rxtx_config_display(void) printf(" RX threshold registers: pthresh=%d hthresh=%d " " wthresh=%d\n", pthresh_tmp, hthresh_tmp, wthresh_tmp); - printf(" RX Offloads=0x%"PRIx64"\n", offloads_tmp); + printf(" RX Offloads=0x%"PRIx64, offloads_tmp); + if (rx_conf->offloads & RTE_ETH_RX_OFFLOAD_SHARED_RXQ) + printf(" share group=%u", + rx_conf->shared_group); + printf("\n"); } /* per tx queue config only for first queue to be less verbose */ diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 3f94a82e321..30dae326310 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -167,6 +167,7 @@ usage(char* progname) printf(" --tx-ip=src,dst: IP addresses in Tx-only mode\n"); printf(" --tx-udp=src[,dst]: UDP ports in Tx-only mode\n"); printf(" --eth-link-speed: force link speed.\n"); + printf(" --rxq-share: number of ports per shared rxq groups, defaults to MAX(1 group)\n"); printf(" --disable-link-check: disable check on link status when " "starting/stopping ports.\n"); printf(" --disable-device-start: do not automatically start port\n"); @@ -607,6 +608,7 @@ launch_args_parse(int argc, char** argv) { "rxpkts", 1, 0, 0 }, { "txpkts", 1, 0, 0 }, { "txonly-multi-flow", 0, 0, 0 }, + { "rxq-share", 2, 0, 0 }, { "eth-link-speed", 1, 0, 0 }, { "disable-link-check", 0, 0, 0 }, { "disable-device-start", 0, 0, 0 }, @@ -1271,6 +1273,17 @@ launch_args_parse(int argc, char** argv) } if (!strcmp(lgopts[opt_idx].name, "txonly-multi-flow")) txonly_multi_flow = 1; + if (!strcmp(lgopts[opt_idx].name, "rxq-share")) { + if (optarg == NULL) { + rxq_share = UINT32_MAX; + } else { + n = atoi(optarg); + if (n >= 0) + rxq_share = (uint32_t)n; + else + rte_exit(EXIT_FAILURE, "rxq-share must be >= 0\n"); + } + } if (!strcmp(lgopts[opt_idx].name, "no-flush-rx")) no_flush_rx = 1; if (!strcmp(lgopts[opt_idx].name, "eth-link-speed")) { diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 97ae52e17ec..417e92ade11 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -498,6 +498,11 @@ uint8_t record_core_cycles; */ uint8_t record_burst_stats; +/* + * Number of ports per shared Rx queue group, 0 disable. + */ +uint32_t rxq_share; + unsigned int num_sockets = 0; unsigned int socket_ids[RTE_MAX_NUMA_NODES]; @@ -1506,6 +1511,11 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id) port->dev_conf.txmode.offloads &= ~DEV_TX_OFFLOAD_MBUF_FAST_FREE; + if (rxq_share > 0 && + (port->dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_SHARED_RXQ)) + port->dev_conf.rxmode.offloads |= + RTE_ETH_RX_OFFLOAD_SHARED_RXQ; + /* Apply Rx offloads configuration */ for (i = 0; i < port->dev_info.max_rx_queues; i++) port->rx_conf[i].offloads = port->dev_conf.rxmode.offloads; @@ -3401,6 +3411,14 @@ rxtx_port_config(struct rte_port *port) for (qid = 0; qid < nb_rxq; qid++) { offloads = port->rx_conf[qid].offloads; port->rx_conf[qid] = port->dev_info.default_rxconf; + + if (rxq_share > 0 && + (port->dev_info.rx_offload_capa & + RTE_ETH_RX_OFFLOAD_SHARED_RXQ)) { + offloads |= RTE_ETH_RX_OFFLOAD_SHARED_RXQ; + port->rx_conf[qid].shared_group = nb_ports / rxq_share; + } + if (offloads != 0) port->rx_conf[qid].offloads = offloads; diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5863b2f43f3..3dfaaad94c0 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -477,6 +477,8 @@ extern enum tx_pkt_split tx_pkt_split; extern uint8_t txonly_multi_flow; +extern uint32_t rxq_share; + extern uint16_t nb_pkt_per_burst; extern uint16_t nb_pkt_flowgen_clones; extern int nb_flows_flowgen; diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 640eadeff73..6cfe88951f7 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -389,6 +389,13 @@ The command line options are: Generate multiple flows in txonly mode. +* ``--rxq-share=[X]`` + + Create queues in shared Rx queue mode if device supports. + Group number grows per X ports, default to group 0 if X not specified. + Only "shared-rxq" forwarding engine suppose to resolve source stream + correctly. + * ``--eth-link-speed`` Set a forced link speed to the ethernet port:: From patchwork Mon Oct 11 12:37:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 101024 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82338A034F; Mon, 11 Oct 2021 14:38:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9880E410DC; Mon, 11 Oct 2021 14:38:41 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2087.outbound.protection.outlook.com [40.107.220.87]) by mails.dpdk.org (Postfix) with ESMTP id 6ADF3410EA for ; Mon, 11 Oct 2021 14:38:39 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMnmZDATZxn8z2NuEmJOB4Yl7fgB1FAGikJC2/trjELB5QwOC3EBE4EdjtTlyN3bdAuYSCDf+6yMTHr/p1Vkywf/6xvmUqRHZMnhCzuLLbfvu77RzvasSz5CTqk+nhEu5T1hRhRDWXYNT6o4Q+cznbr95JrTmkX5pfSRYu+Z5X1cODZgXpY26N628/2ldxLbrgpsYySLTgzUfTAQOg7X6R+pFEiAJb+i8tkehFkePyyVTH9DK5ZHoHyk0edYamRlpaxMORPGPsn/wXVyzW9b8Ez2fAsXG0m7Zk4lRgHo88L0nYRCuRQnvKbaOSWEfO5d44s8l3ofpS5TSeKlIlYWuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WMmdQKxUkb1lg/PnhuxMHrL9QxXzkfBXCCV5SII83A4=; b=VjR1s9kLSlqmYjr4tx7eyXjThx87Cf5t0Ab4IIcH6Q63rdvji2KTPiQQyTDkXCtiSKN/uQ+eoh7TY9ZQdhYeyT2LUVKGrUlvPGdjWUoZBeP1VanKJ8azfpTuKR69x9adzCwn3iePxHQeey0gA3QLbIT7udSKHvdcI1rVDgmxLT93n3afBj984rmB5/u8X1IlzoMKW+SASJOy8cKdU7raMW+T87irOvoHFUrs159k+7FdAVdK7tKLKrjnH8YJQj66kiK/YdqEG1SQ8B1tsH87N3cRE5v0T0X1wPTcZ1Uo31hsh1uUZWs8G+LZL/LDoUy7gsGPyLOu+sk/kn2vskj7iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WMmdQKxUkb1lg/PnhuxMHrL9QxXzkfBXCCV5SII83A4=; b=FrKrzpHfMkg9Gb5DT0nixNzGnO9cPC3UENW0pOb/Xe3rURNvs7EpvH7d3eXvZ0+y9vOVKJSP3NdnqFhOUTqZtL9lCKYGdZHgfr7WDG1gt8eChgYf8x2IUoHl/L605OqnUFp3SkY30urIuTFgVhnzx4EcfHDv4jKX9e5TmTWzhJivjq7MmsBP1KN92qbv1tvWWpyk75v31FiD2biqTkuWPfiOhkX18RO2Cen6kthl3iz1lTFhAu29QV1ZCrM+5DcUZziRYNPKoo9XJnnuL4f1b2uaVjN2d5Eewpnz2e36AyC834uZWx79PQclrP+Fi1KW1c8tthw4lRpH4w/uxYerjg== Received: from DS7PR03CA0115.namprd03.prod.outlook.com (2603:10b6:5:3b7::30) by CH0PR12MB5220.namprd12.prod.outlook.com (2603:10b6:610:d3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.20; Mon, 11 Oct 2021 12:38:37 +0000 Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::35) by DS7PR03CA0115.outlook.office365.com (2603:10b6:5:3b7::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:36 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 11 Oct 2021 12:38:32 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" , Xiaoyun Li Date: Mon, 11 Oct 2021 20:37:30 +0800 Message-ID: <20211011123733.961222-4-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011123733.961222-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211011123733.961222-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 519cc5b9-7e42-4556-efe9-08d98cb40b9b X-MS-TrafficTypeDiagnostic: CH0PR12MB5220: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:243; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F5Qsbv1rlj7jR4Wea0SPSU4RMJF6STN5e/xc/beedfGgSGC08R+W4EaUfDivsDTLU9EWD8r+z0Muu8xI6yCgMAPE9gUlmGOYYjUgMed47bILOrn5wus2BTmsOcQt24McAi7pcNONtMNmWubaeiHuN90TVbZPViiXg3vtVMUSi7MF59wTqWHOa2QQjMd4Mcxew0k6pWPZGYdqd2wXEYePsve1eXFt6s3XnlsW5cEdsJibTVshpRgUVBIVhJrksUmfIi1AeTpvgmWf20+UgGB3q3fbJs0tBqKUY3oxQ5WwIFJMKlYkSXvnsas5W9drxCs9JRtHovOniMm5suFihFaGZdiwNpFjSgXTRSdCn6mMwAvzvs54odDov3HgoXkEcBy9Mv96TLoAa03QExGZwhQlZTRELHQd0rFPH0G7RtBWxSwQnEg6wotkshrxWL1+IKXjCc3rHQaHie6UZ9kX5W/lqf8E5y88FcxLa1NTP3tZu6PQXvUM/bREspMG8qSytOxK5412sCko5AM1AUobo3f2/X2IXxDvSX2nqeR8xwLSvtvpnaz2zp75zxp/XsGGf8Og4sjRaXw9/BFFFdhRWYiM2GJIZg2mKBIaTEzg1XAfqFNocJjK0fJQzJufXU0fuB3KJ8xViTrW3tqqrtxdjeCczlrdLRneLakP+z2WI6HpujbY7SKmijh797PAt676fPnuEylnovxMOVQhK3xCovkYiQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(86362001)(186003)(16526019)(4744005)(83380400001)(1076003)(8676002)(4326008)(8936002)(2906002)(82310400003)(36860700001)(6916009)(26005)(70586007)(7696005)(70206006)(316002)(5660300002)(7636003)(356005)(6286002)(426003)(55016002)(2616005)(508600001)(54906003)(47076005)(336012)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:38:36.5377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 519cc5b9-7e42-4556-efe9-08d98cb40b9b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5220 Subject: [dpdk-dev] [PATCH v5 3/5] app/testpmd: dump port info for shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In case of shared Rx queue, polling any member port returns mbufs for all members. This patch dumps mbuf->port for each packet. Signed-off-by: Xueming Li --- app/test-pmd/util.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c index 51506e49404..e98f136d5ed 100644 --- a/app/test-pmd/util.c +++ b/app/test-pmd/util.c @@ -100,6 +100,9 @@ dump_pkt_burst(uint16_t port_id, uint16_t queue, struct rte_mbuf *pkts[], struct rte_flow_restore_info info = { 0, }; mb = pkts[i]; + if (rxq_share > 0) + MKDUMPSTR(print_buf, buf_size, cur_len, "port %u, ", + mb->port); eth_hdr = rte_pktmbuf_read(mb, 0, sizeof(_eth_hdr), &_eth_hdr); eth_type = RTE_BE_TO_CPU_16(eth_hdr->ether_type); packet_type = mb->packet_type; From patchwork Mon Oct 11 12:37:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 101025 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4BC7A034F; Mon, 11 Oct 2021 14:38:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5B24410FC; Mon, 11 Oct 2021 14:38:43 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2063.outbound.protection.outlook.com [40.107.93.63]) by mails.dpdk.org (Postfix) with ESMTP id 50C72410EE for ; Mon, 11 Oct 2021 14:38:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrscJ0X8Y9wurzi3ZXo0yzFwYVWzM9pK8oWJXrx0bowKU6jEE1UI6oyvl4oQb6690ViyJ1O5pNa5baaNf5p+kYuTuwRGWfE2zAYQ2IhvgttAy3bwpaB7DGAkdhz79FuVpGfB28R62r/Aglo0VEP6ibea93kKM5A0P0SyP90GT8e4VNMzsNZUAR+Nr0DGwb1Cuj8fipDo9+YIAk5USj2yhoInrjHdvs55WEO5E/2vP7BCykY6gT5LKupyRPKvv7jd9gnKf2aytwpfQeUwoSLsrUExChgcnYs9ErDmgOqaYfDSJOU3VOcEZKr1JhX/fAhxBVr6iX1H0pyBBN99CJkgLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QWx2DkwvLhP8XMk6s0A4KUx9JPJLpr8TYRdwUfuqOL4=; b=OGug3EojAwf+GJBdR37Dq7nkQZqxwj/k2SnYY00XxvczF7e2F86J/7E3gJJ1o6l1zNpTiKLArlwKdsk24XFLbO3NSL/gmzDkm9771986brkcqS6ZwcVgRaaUuzJu+GzvTioB/vqYVjZTUJzFNkFhQ9eTDiujVJ1fGw0IFEnCK26X6M0fDO4mgBRWnb9RbGucB91Dsp0HuqZv40N81aTt67CdgkR2GECsLdCZeJmfzEHmWPS6hIBTdhY7M5E/oSHDVZwxrkAkQa/QxnkNSfh0T/UZovvBewCCaPzeqxza9rbrwwklEXd3/E3yNfZvYaM/cB85Vy6tVuYKY2VjOKm8cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QWx2DkwvLhP8XMk6s0A4KUx9JPJLpr8TYRdwUfuqOL4=; b=oijIp+pNmeawyaBu6VY15wlRZ3/crqApBsVdOBv6+cOG4GuPcHYsBPUn1MfbTSA48iYGLHFt1/2Z1Eeg+Xd2voDA/PqYc3manLSe6QTIlOtD44JAvLTwmVhxanqk+X2EWPw6rTt208jHfD4oyViPHgyC/W07HnnAJ5tuXsa+vU/XATlWhax57hztTSRHd2cc+gvPpB2WxAeVXqWcMYjOT1a+cqr1rCxw5lASjWLh32pmeI1orMaXLV45MHbSchbGBqew9s/yswVwkCYkXUlTDUdGRI64KJhpT9ZQJruYKELVv7v3GLAmw3Ue5Ra041IMxih6ohwpIVXzaqBQt70wqQ== Received: from DS7PR03CA0117.namprd03.prod.outlook.com (2603:10b6:5:3b7::32) by DM5PR12MB1308.namprd12.prod.outlook.com (2603:10b6:3:76::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct 2021 12:38:39 +0000 Received: from DM6NAM11FT042.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::4d) by DS7PR03CA0117.outlook.office365.com (2603:10b6:5:3b7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT042.mail.protection.outlook.com (10.13.173.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:38:38 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 11 Oct 2021 12:38:35 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" , Xiaoyun Li Date: Mon, 11 Oct 2021 20:37:31 +0800 Message-ID: <20211011123733.961222-5-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011123733.961222-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211011123733.961222-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: edce179b-16bf-4201-c63d-08d98cb40cf0 X-MS-TrafficTypeDiagnostic: DM5PR12MB1308: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6VwMhR6NRDFNxAR2xrlV1SNNGNEJHKP+kjtCjexMXPgBGKwLEIApN1gAKnMsks/sGkKCp2m210uT/Q0S1nuG6YgUpi26BtEQDxlADv7RYg3AzSDr+hF4oS8BtjQCC0wrN9uQusxtfJ8KPc72BQ8iZJxQazkXsEHvOmjH/S3hoLkj18CMcV2tzE7cE7DjT/niTMW5R+Hca1HJy6Lz+TQRKC4pjWveDkbh9siW+p+CRdvDwAwtq4zzqp23WKToVODnKZpRdVVZNdSau8b4Yii07FEddliOs4IajIefRz6PNGlALoEU6cvnCP5LS06KMGiCSnpUNRZofJ2uF1ajnr6dyP2XA8RXqHfPgKk9v/A+UBQIXAmvttEI5R4/hUZnbmtRGYGLdmhLYAkV7TU89a8TU+/enKpXipm1Pcy65W+LVYrdSqv94AN8Gtst1PIoYofD8udGSS4c3naytMI285Vy8trXSYVKc9HrGga6mvqpbvQgBV5pGe2XGo5DrzRKnkaYxEA02NJka1voFnpJe/Qlrb44xTf8Uh0z5cY412IPU9tZkaS+bFDxdkaN5cmXZ4JokgKR/Q8FkY/zzctbrNBEDvs3zVDZDymrOocFsgJXriwkI7s3rm6nnNMe8oe6wwgG/dBdhtuRgkaVye0GXJ4tdJF9vgxfUtvlV1/4JTueyQzM9ADqen7WkXJLUffEQe419AFqeHjfwlbfvkVzBgWWOw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(55016002)(7696005)(2616005)(426003)(26005)(356005)(16526019)(36860700001)(186003)(7636003)(4326008)(6916009)(82310400003)(8936002)(1076003)(336012)(54906003)(2906002)(508600001)(8676002)(36756003)(47076005)(6286002)(5660300002)(70206006)(70586007)(83380400001)(316002)(86362001)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:38:38.7654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edce179b-16bf-4201-c63d-08d98cb40cf0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT042.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1308 Subject: [dpdk-dev] [PATCH v5 4/5] app/testpmd: force shared Rx queue polled on same core X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Shared rxqs shares one set rx queue of groups zero. Shared Rx queue must must be polled from one core. Checks and stops forwarding if shared rxq being scheduled on multiple cores. Signed-off-by: Xueming Li --- app/test-pmd/config.c | 96 ++++++++++++++++++++++++++++++++++++++++++ app/test-pmd/testpmd.c | 4 +- app/test-pmd/testpmd.h | 2 + 3 files changed, 101 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 6c7f9dee065..4ab500569ee 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2885,6 +2885,102 @@ port_rss_hash_key_update(portid_t port_id, char rss_type[], uint8_t *hash_key, } } +/* + * Check whether a shared rxq scheduled on other lcores. + */ +static bool +fwd_stream_on_other_lcores(uint16_t domain_id, portid_t src_port, + queueid_t src_rxq, lcoreid_t src_lc, + uint32_t shared_group) +{ + streamid_t sm_id; + streamid_t nb_fs_per_lcore; + lcoreid_t nb_fc; + lcoreid_t lc_id; + struct fwd_stream *fs; + struct rte_port *port; + struct rte_eth_rxconf *rxq_conf; + + nb_fc = cur_fwd_config.nb_fwd_lcores; + for (lc_id = src_lc + 1; lc_id < nb_fc; lc_id++) { + sm_id = fwd_lcores[lc_id]->stream_idx; + nb_fs_per_lcore = fwd_lcores[lc_id]->stream_nb; + for (; sm_id < fwd_lcores[lc_id]->stream_idx + nb_fs_per_lcore; + sm_id++) { + fs = fwd_streams[sm_id]; + port = &ports[fs->rx_port]; + rxq_conf = &port->rx_conf[fs->rx_queue]; + if ((rxq_conf->offloads & RTE_ETH_RX_OFFLOAD_SHARED_RXQ) + == 0) + /* Not shared rxq. */ + continue; + if (domain_id != port->dev_info.switch_info.domain_id) + continue; + if (fs->rx_queue != src_rxq) + continue; + if (rxq_conf->shared_group != shared_group) + continue; + printf("Shared Rx queue group %u can't be scheduled on different cores:\n", + shared_group); + printf(" lcore %hhu Port %hu queue %hu\n", + src_lc, src_port, src_rxq); + printf(" lcore %hhu Port %hu queue %hu\n", + lc_id, fs->rx_port, fs->rx_queue); + printf(" please use --nb-cores=%hu to limit forwarding cores\n", + nb_rxq); + return true; + } + } + return false; +} + +/* + * Check shared rxq configuration. + * + * Shared group must not being scheduled on different core. + */ +bool +pkt_fwd_shared_rxq_check(void) +{ + streamid_t sm_id; + streamid_t nb_fs_per_lcore; + lcoreid_t nb_fc; + lcoreid_t lc_id; + struct fwd_stream *fs; + uint16_t domain_id; + struct rte_port *port; + struct rte_eth_rxconf *rxq_conf; + + nb_fc = cur_fwd_config.nb_fwd_lcores; + /* + * Check streams on each core, make sure the same switch domain + + * group + queue doesn't get scheduled on other cores. + */ + for (lc_id = 0; lc_id < nb_fc; lc_id++) { + sm_id = fwd_lcores[lc_id]->stream_idx; + nb_fs_per_lcore = fwd_lcores[lc_id]->stream_nb; + for (; sm_id < fwd_lcores[lc_id]->stream_idx + nb_fs_per_lcore; + sm_id++) { + fs = fwd_streams[sm_id]; + /* Update lcore info stream being scheduled. */ + fs->lcore = fwd_lcores[lc_id]; + port = &ports[fs->rx_port]; + rxq_conf = &port->rx_conf[fs->rx_queue]; + if ((rxq_conf->offloads & RTE_ETH_RX_OFFLOAD_SHARED_RXQ) + == 0) + /* Not shared rxq. */ + continue; + /* Check shared rxq not scheduled on remaining cores. */ + domain_id = port->dev_info.switch_info.domain_id; + if (fwd_stream_on_other_lcores(domain_id, fs->rx_port, + fs->rx_queue, lc_id, + rxq_conf->shared_group)) + return false; + } + } + return true; +} + /* * Setup forwarding configuration for each logical core. */ diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 417e92ade11..cab4b36b046 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2241,10 +2241,12 @@ start_packet_forwarding(int with_tx_first) fwd_config_setup(); + pkt_fwd_config_display(&cur_fwd_config); + if (!pkt_fwd_shared_rxq_check()) + return; if(!no_flush_rx) flush_fwd_rx_queues(); - pkt_fwd_config_display(&cur_fwd_config); rxtx_config_display(); fwd_stats_reset(); diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 3dfaaad94c0..f121a2da90c 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -144,6 +144,7 @@ struct fwd_stream { uint64_t core_cycles; /**< used for RX and TX processing */ struct pkt_burst_stats rx_burst_stats; struct pkt_burst_stats tx_burst_stats; + struct fwd_lcore *lcore; /**< Lcore being scheduled. */ }; /** @@ -795,6 +796,7 @@ void port_summary_header_display(void); void rx_queue_infos_display(portid_t port_idi, uint16_t queue_id); void tx_queue_infos_display(portid_t port_idi, uint16_t queue_id); void fwd_lcores_config_display(void); +bool pkt_fwd_shared_rxq_check(void); void pkt_fwd_config_display(struct fwd_config *cfg); void rxtx_config_display(void); void fwd_config_setup(void); From patchwork Mon Oct 11 12:37:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xueming Li X-Patchwork-Id: 101026 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C769A034F; Mon, 11 Oct 2021 14:39:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B48D410DA; Mon, 11 Oct 2021 14:39:15 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam08on2066.outbound.protection.outlook.com [40.107.100.66]) by mails.dpdk.org (Postfix) with ESMTP id C909C40E01 for ; Mon, 11 Oct 2021 14:39:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B4z0jeqhnBBTzijTBz25+xKO4YcCyWpyilRdGHj4kFLCJVYn/YjbJFxLymRJM+i2Pb7PtTyEDF4XKhncPZ53/E//DeWaOZbD3zj2AYKUKV8hjW+KzT+PaLfIV/Klje3uP/jYufUsTb12ES3tRXQXG4gT5XHa65x2TA9TkM4GYsGrWO0Bo4F9Qx6UEixImV+1mr8JBz9blz/4HDsdRHj7ahXjOhCvt3EYdjSyLY5AloOqwwu6jolKEtUrEY4YR+aQpOK3z+9uVaYe6p2vjwn/7Lz2GBgWwVDnG8cDhssI/YlrIsc+Z9Lv/Moj0ItCDrRAev3RI0Fe4zwojvbNezCurA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NN3Qa/MO4cYUzNEZsCl8SdG370Qcf5ev737YSADUQ1g=; b=ft7crCkBMdUnegWw51LddAPRic0oFmA7cJnEtm+e8EX1JGgIxRSGp6kAw62UOiOTZrES5lRZFZGLuc0uE8YSBe7jLW0loQ4mnMQM0q2qEUlqc2s4T31e4OgvODHs7nYVsmLi4NIk7+PpSKz29HkMcG15Pwt0/bXZKMDKV0x2ckuk+tEJxKNlfQM7a8L0OByJqIN0C+SC4tX+5HmRB0jLZw1ETd62zxlbZKYf3YsUH5ecewW/cYtqF93gDQ4uAM1N9oGptaIJhpaNtqBAHo47fc2Ha+64DRRDfMPtHnuTCi52uSVC8W3w49C6us1p6LxosKX1P/VxSIDsN5rdxOEARQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NN3Qa/MO4cYUzNEZsCl8SdG370Qcf5ev737YSADUQ1g=; b=arjJX6voqWIaZO4zDoK1V2WLr0+bULTbAqI5xViE78BLI7hqgLnz3Uq+qltgmoAw2Yo4gzzKfi6G6C1QUo0oK2twZ/nrRoC1hiTcuH5Sj/YiDSxuyHKAiyP4XO1b6YFUu6sb9hFMvi+us8l0Tg4fKLI8NRUgs6U7CzzM7QLch1hUOkqcfxFgmBoGRjMsqB/P3yC4BnJxmmQ3gn9z17mSWbIrDvTB3df84aCaOi85K7q4PL9JTsr5WWeESg67XXbkr5wT/FCCjf4LqPxlccg8irbXsWBZqFgwt2kC7SrzBac6fnpvezfJx1IgAbkk1OwVz/K1urF+own+88WwvxGuYQ== Received: from BN0PR04CA0081.namprd04.prod.outlook.com (2603:10b6:408:ea::26) by BYAPR12MB3224.namprd12.prod.outlook.com (2603:10b6:a03:137::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25; Mon, 11 Oct 2021 12:39:12 +0000 Received: from BN8NAM11FT028.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::fb) by BN0PR04CA0081.outlook.office365.com (2603:10b6:408:ea::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.25 via Frontend Transport; Mon, 11 Oct 2021 12:39:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT028.mail.protection.outlook.com (10.13.176.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4587.18 via Frontend Transport; Mon, 11 Oct 2021 12:39:10 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 11 Oct 2021 12:39:07 +0000 From: Xueming Li To: CC: , Jerin Jacob , Ferruh Yigit , Andrew Rybchenko , Viacheslav Ovsiienko , Thomas Monjalon , Lior Margalit , "Ananyev Konstantin" , Xiaoyun Li Date: Mon, 11 Oct 2021 20:37:32 +0800 Message-ID: <20211011123733.961222-6-xuemingl@nvidia.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011123733.961222-1-xuemingl@nvidia.com> References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211011123733.961222-1-xuemingl@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01a9117d-7048-4f91-036d-08d98cb42040 X-MS-TrafficTypeDiagnostic: BYAPR12MB3224: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gkVnSj38BxVV0Ze5nG6EYw4ZSLbrYWFWgltcXtg/07WuhDSHd9HffuoLlSCH3mQsXgZ1Plc3xLIw7u+nj5yVUa4gTKebCE3ytoHAf2vJ6vxSTNXG99ODTBZBVmJU6U+iytlGTONsgqbOtVrXJaEsUISiMKxhzi/H+ISt6rYpOxJy3JHfOcWpv9KW7ohn0rjExz+QBz3l+tTe1kEKkvmq1b71q1mBEEtrthBaQPDp+0V4yYeb/ASE3J2fiM+jbiDqoMNwl3Dgt+gWN4IvzApupGMcPARpP9V7Tw4uqpcvvIvPNNxNe05xCyovKc7fTpZ3zY+1cY8w7nZL33Z/wMM4VT/qWDaKIJC5LC0ucQ0Bbhi69Rtc4fnR/FTP50WD8ytA6W/zGbaNgySwxYCfWhTgpgpunsm/GjjMzI6Otazz1LEy4n2Cj9L3Y82HJR8+Zo8aILjDMd/2dpkVuQh4dvBSlo8zj5WpYfNqQ9PWO1Aoi/bZvOPiej+34b/uG5ieJ0iOGnskXL/LMdAQcvE8a9MZ2IBmmzj7Lms4OXDEpVRridM4sYss3owkCTvfES5pWhVbds0WQgHxAKkWcS4eFq7o6czq8yCJBkWoWVrSiCCSOf5EjxKqu5pSS4NovgkLsuuI05pdwms5hJFtfKeXTNvUllj3peYCWUfMqovRMoMVG5jvw/LvsXUj8vVCHBNgPqZxuq6x5R/Unr+kLNZa2koSNw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(83380400001)(2616005)(316002)(426003)(8676002)(6666004)(186003)(1076003)(16526019)(70206006)(70586007)(4326008)(36860700001)(86362001)(336012)(8936002)(82310400003)(26005)(356005)(36756003)(7636003)(6286002)(6916009)(5660300002)(54906003)(47076005)(508600001)(55016002)(7696005)(2906002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2021 12:39:10.8890 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 01a9117d-7048-4f91-036d-08d98cb42040 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT028.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3224 Subject: [dpdk-dev] [PATCH v5 5/5] app/testpmd: add forwarding engine for shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build | 1 + app/test-pmd/shared_rxq_fwd.c | 148 ++++++++++++++++++++ app/test-pmd/testpmd.c | 1 + app/test-pmd/testpmd.h | 1 + doc/guides/testpmd_app_ug/run_app.rst | 1 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 +- 6 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 app/test-pmd/shared_rxq_fwd.c diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build index 98f3289bdfa..07042e45b12 100644 --- a/app/test-pmd/meson.build +++ b/app/test-pmd/meson.build @@ -21,6 +21,7 @@ sources = files( 'noisy_vnf.c', 'parameters.c', 'rxonly.c', + 'shared_rxq_fwd.c', 'testpmd.c', 'txonly.c', 'util.c', diff --git a/app/test-pmd/shared_rxq_fwd.c b/app/test-pmd/shared_rxq_fwd.c new file mode 100644 index 00000000000..4e262b99bc7 --- /dev/null +++ b/app/test-pmd/shared_rxq_fwd.c @@ -0,0 +1,148 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright (c) 2021 NVIDIA Corporation & Affiliates + */ + +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "testpmd.h" + +/* + * Rx only sub-burst forwarding. + */ +static void +forward_rx_only(uint16_t nb_rx, struct rte_mbuf **pkts_burst) +{ + rte_pktmbuf_free_bulk(pkts_burst, nb_rx); +} + +/** + * Get packet source stream by source port and queue. + * All streams of same shared Rx queue locates on same core. + */ +static struct fwd_stream * +forward_stream_get(struct fwd_stream *fs, uint16_t port) +{ + streamid_t sm_id; + struct fwd_lcore *fc; + struct fwd_stream **fsm; + streamid_t nb_fs; + + fc = fs->lcore; + fsm = &fwd_streams[fc->stream_idx]; + nb_fs = fc->stream_nb; + for (sm_id = 0; sm_id < nb_fs; sm_id++) { + if (fsm[sm_id]->rx_port == port && + fsm[sm_id]->rx_queue == fs->rx_queue) + return fsm[sm_id]; + } + return NULL; +} + +/** + * Forward packet by source port and queue. + */ +static void +forward_sub_burst(struct fwd_stream *src_fs, uint16_t port, uint16_t nb_rx, + struct rte_mbuf **pkts) +{ + struct fwd_stream *fs = forward_stream_get(src_fs, port); + + if (fs != NULL) { + fs->rx_packets += nb_rx; + forward_rx_only(nb_rx, pkts); + } else { + /* Source stream not found, drop all packets. */ + src_fs->fwd_dropped += nb_rx; + while (nb_rx > 0) + rte_pktmbuf_free(pkts[--nb_rx]); + } +} + +/** + * Forward packets from shared Rx queue. + * + * Source port of packets are identified by mbuf->port. + */ +static void +forward_shared_rxq(struct fwd_stream *fs, uint16_t nb_rx, + struct rte_mbuf **pkts_burst) +{ + uint16_t i, nb_sub_burst, port, last_port; + + nb_sub_burst = 0; + last_port = pkts_burst[0]->port; + /* Locate sub-burst according to mbuf->port. */ + for (i = 0; i < nb_rx - 1; ++i) { + rte_prefetch0(pkts_burst[i + 1]); + port = pkts_burst[i]->port; + if (i > 0 && last_port != port) { + /* Forward packets with same source port. */ + forward_sub_burst(fs, last_port, nb_sub_burst, + &pkts_burst[i - nb_sub_burst]); + nb_sub_burst = 0; + last_port = port; + } + nb_sub_burst++; + } + /* Last sub-burst. */ + nb_sub_burst++; + forward_sub_burst(fs, last_port, nb_sub_burst, + &pkts_burst[nb_rx - nb_sub_burst]); +} + +static void +shared_rxq_fwd(struct fwd_stream *fs) +{ + struct rte_mbuf *pkts_burst[nb_pkt_per_burst]; + uint16_t nb_rx; + uint64_t start_tsc = 0; + + get_start_cycles(&start_tsc); + nb_rx = rte_eth_rx_burst(fs->rx_port, fs->rx_queue, pkts_burst, + nb_pkt_per_burst); + inc_rx_burst_stats(fs, nb_rx); + if (unlikely(nb_rx == 0)) + return; + forward_shared_rxq(fs, nb_rx, pkts_burst); + get_end_cycles(fs, start_tsc); +} + +struct fwd_engine shared_rxq_engine = { + .fwd_mode_name = "shared_rxq", + .port_fwd_begin = NULL, + .port_fwd_end = NULL, + .packet_fwd = shared_rxq_fwd, +}; diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index cab4b36b046..681ea591871 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -188,6 +188,7 @@ struct fwd_engine * fwd_engines[] = { #ifdef RTE_LIBRTE_IEEE1588 &ieee1588_fwd_engine, #endif + &shared_rxq_engine, NULL, }; diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index f121a2da90c..f1fd607e365 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -299,6 +299,7 @@ extern struct fwd_engine five_tuple_swap_fwd_engine; #ifdef RTE_LIBRTE_IEEE1588 extern struct fwd_engine ieee1588_fwd_engine; #endif +extern struct fwd_engine shared_rxq_engine; extern struct fwd_engine * fwd_engines[]; /**< NULL terminated array. */ extern cmdline_parse_inst_t cmd_set_raw; diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index 6cfe88951f7..277ef79ed9d 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guides/testpmd_app_ug/run_app.rst @@ -252,6 +252,7 @@ The command line options are: tm noisy 5tswap + shared-rxq * ``--rss-ip`` diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst index bbef7063741..a30e2f4dfae 100644 --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst @@ -314,7 +314,7 @@ set fwd Set the packet forwarding mode:: testpmd> set fwd (io|mac|macswap|flowgen| \ - rxonly|txonly|csum|icmpecho|noisy|5tswap) (""|retry) + rxonly|txonly|csum|icmpecho|noisy|5tswap|shared-rxq) (""|retry) ``retry`` can be specified for forwarding engines except ``rx_only``. @@ -357,6 +357,9 @@ The available information categories are: L4 swaps the source port and destination port of transport layer (TCP and UDP). +* ``shared-rxq``: Receive only for shared Rx queue. + Resolve packet source port from mbuf and update stream statistics accrodingly. + Example:: testpmd> set fwd rxonly