From patchwork Wed Oct 6 11:13:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 100596 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D12FA0C41; Wed, 6 Oct 2021 13:13:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66D1E41137; Wed, 6 Oct 2021 13:13:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 98AF8410F2 for ; Wed, 6 Oct 2021 13:13:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213092408" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213092408" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:13:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458389874" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 04:13:46 -0700 From: Sean Morrissey To: Cc: dev@dpdk.org, Sean Morrissey , Conor Fogarty Date: Wed, 6 Oct 2021 11:13:25 +0000 Message-Id: <20211006111329.152938-2-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006111329.152938-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211006111329.152938-1-sean.morrissey@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/5] devtools: script to remove unused headers includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers flagged by iwyu_tool output file $ ./devtools/process_iwyu.py iwyu.out -b build Remove headers flagged by iwyu_tool output file from sub-directory $ ./devtools/process_iwyu.py iwyu.out -b build -d lib/kvargs Remove headers directly piped from the iwyu_tool $ iwyu_tool -p build | ./devtools/process_iwyu.py - -b build Signed-off-by: Sean Morrissey Signed-off-by: Conor Fogarty --- devtools/process_iwyu.py | 114 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100755 devtools/process_iwyu.py diff --git a/devtools/process_iwyu.py b/devtools/process_iwyu.py new file mode 100755 index 0000000000..c5b93c5ef3 --- /dev/null +++ b/devtools/process_iwyu.py @@ -0,0 +1,114 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2021 Intel Corporation +# + +import argparse +import fileinput +import sys +from os.path import abspath, relpath, join +from pathlib import Path +from mesonbuild import mesonmain + + +def args_parse(): + "parse arguments and return the argument object back to main" + parser = argparse.ArgumentParser( + description="""This script can be used to remove + includes which are not in use\n""") + parser.add_argument('-b', '--build_dir', type=str, + help="""The path to the build directory in which + the IWYU tool was used in.""", default="build") + parser.add_argument('-d', '--sub_dir', type=str, + help='The sub-directory to remove headers from.', + default="") + parser.add_argument('file', type=Path, + help="""The path to the IWYU log file or output + from stdin.""") + + return parser.parse_args() + + +def run_meson(args): + "Runs a meson command logging output to process.log" + with open('process_iwyu.log', 'a') as sys.stdout: + ret = mesonmain.run(args, abspath('meson')) + sys.stdout = sys.__stdout__ + return ret + + +def remove_includes(filename, include, build_dir): + "Attempts to remove include, if it fails then revert to original state" + filepath = filename + + with open(filepath, 'r+') as f: + lines = f.readlines() # Read lines when file is opened + + with open(filepath, 'w') as f: + for ln in lines: # Removes the include passed in + if ln.strip() != include: + f.write(ln) + + # run test build -> call meson on the build folder, meson compile -C build + ret = run_meson(['compile', '-C', build_dir]) + if (ret == 0): # Include is not needed -> build is successful + print('SUCCESS') + else: + # failed, catch the error + # return file to original state + with open(filepath, 'w') as f: + f.writelines(lines) + print('FAILED') + + +def get_build_config(builddir, condition): + "returns contents of rte_build_config.h" + with open(join(builddir, 'rte_build_config.h')) as f: + return [ln for ln in f.readlines() if condition(ln)] + + +def uses_libbsd(builddir): + "return whether the build uses libbsd or not" + return bool(get_build_config(builddir, lambda ln: 'RTE_USE_LIBBSD' in ln)) + + +def process(args): + "process the iwyu output on a set of files" + filename = None + build_dir = abspath(args.build_dir) + directory = args.sub_dir + + keep_str_fns = uses_libbsd(build_dir) # check for libbsd + if keep_str_fns: + print("""Warning: libbsd is present, build will fail to detect + incorrect removal of rte_string_fns.h""", file=sys.stderr) + # turn on werror + run_meson(['configure', build_dir, '-Dwerror=true']) + # Use stdin if no iwyu_tool out file given + for line in fileinput.input(args.file): + if 'should remove' in line: + # If the file path in the iwyu_tool output is + # an absolute path it means the file is outside + # of the dpdk directory, therefore ignore it. + # Also check to see if the file is within the + # specified sub directory. + if (line.split()[0] != abspath(line.split()[0]) and + directory in line.split()[0]): + filename = relpath(join(build_dir, line.split()[0])) + elif line.startswith('-') and filename: + include = '#include ' + line.split()[2] + print(f"Remove {include} from {filename} ... ", end='', flush=True) + if keep_str_fns and '' in include: + print('skipped') + continue + remove_includes(filename, include, build_dir) + else: + filename = None + + +def main(): + process(args_parse()) + + +if __name__ == '__main__': + main() From patchwork Wed Oct 6 11:13:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 100597 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6F3ACA0C41; Wed, 6 Oct 2021 13:13:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 69A9241141; Wed, 6 Oct 2021 13:13:52 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C0EB541134 for ; Wed, 6 Oct 2021 13:13:48 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213092412" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213092412" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:13:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458389878" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 04:13:47 -0700 From: Sean Morrissey To: Ciara Power Cc: dev@dpdk.org, Sean Morrissey Date: Wed, 6 Oct 2021 11:13:26 +0000 Message-Id: <20211006111329.152938-3-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006111329.152938-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211006111329.152938-1-sean.morrissey@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/5] lib/telemetry: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c index 8665db8d03..fb3b93ca7e 100644 --- a/lib/telemetry/telemetry.c +++ b/lib/telemetry/telemetry.c @@ -8,7 +8,6 @@ #include #include #include -#include #endif /* !RTE_EXEC_ENV_WINDOWS */ /* we won't link against libbsd, so just always use DPDKs-specific strlcpy */ diff --git a/lib/telemetry/telemetry_data.h b/lib/telemetry/telemetry_data.h index adb84a09f1..26aa28e72c 100644 --- a/lib/telemetry/telemetry_data.h +++ b/lib/telemetry/telemetry_data.h @@ -5,7 +5,6 @@ #ifndef _TELEMETRY_DATA_H_ #define _TELEMETRY_DATA_H_ -#include #include "rte_telemetry.h" enum tel_container_types { From patchwork Wed Oct 6 11:13:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 100598 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D4E7A0C41; Wed, 6 Oct 2021 13:14:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87D0A41136; Wed, 6 Oct 2021 13:13:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 32EA641136 for ; Wed, 6 Oct 2021 13:13:50 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213092417" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213092417" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:13:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458389883" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 04:13:48 -0700 From: Sean Morrissey To: Honnappa Nagarahalli , Konstantin Ananyev Cc: dev@dpdk.org, Sean Morrissey Date: Wed, 6 Oct 2021 11:13:27 +0000 Message-Id: <20211006111329.152938-4-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006111329.152938-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211006111329.152938-1-sean.morrissey@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 3/5] lib/ring: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index f17bd966be..bb95962b0c 100644 --- a/lib/ring/rte_ring.c +++ b/lib/ring/rte_ring.c @@ -17,16 +17,9 @@ #include #include -#include #include #include -#include -#include #include -#include -#include -#include -#include #include #include #include From patchwork Wed Oct 6 11:13:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 100599 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CB87A0C41; Wed, 6 Oct 2021 13:14:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8AC3641157; Wed, 6 Oct 2021 13:13:54 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 6A90D4113A for ; Wed, 6 Oct 2021 13:13:51 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213092421" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213092421" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:13:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458389887" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 04:13:50 -0700 From: Sean Morrissey To: Olivier Matz Cc: dev@dpdk.org, Sean Morrissey Date: Wed, 6 Oct 2021 11:13:28 +0000 Message-Id: <20211006111329.152938-5-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006111329.152938-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211006111329.152938-1-sean.morrissey@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 4/5] lib/kvargs: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 38e9d5c1ca..4cce8e953b 100644 --- a/lib/kvargs/rte_kvargs.c +++ b/lib/kvargs/rte_kvargs.c @@ -7,7 +7,6 @@ #include #include -#include #include #include "rte_kvargs.h" From patchwork Wed Oct 6 11:13:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sean Morrissey X-Patchwork-Id: 100600 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 290DAA0C41; Wed, 6 Oct 2021 13:14:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08D5041173; Wed, 6 Oct 2021 13:13:57 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C6A0F41165 for ; Wed, 6 Oct 2021 13:13:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="213092425" X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="213092425" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 04:13:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,350,1624345200"; d="scan'208";a="458389902" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga002.jf.intel.com with ESMTP; 06 Oct 2021 04:13:51 -0700 From: Sean Morrissey To: Anatoly Burakov , Jerin Jacob , Sunil Kumar Kori , =?utf-8?q?Mattias_R=C3=B6nnblom?= , Harry van Haaren , Harman Kalra , Bruce Richardson , Konstantin Ananyev Cc: dev@dpdk.org, Sean Morrissey Date: Wed, 6 Oct 2021 11:13:29 +0000 Message-Id: <20211006111329.152938-6-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211006111329.152938-1-sean.morrissey@intel.com> References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211006111329.152938-1-sean.morrissey@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 5/5] lib/eal: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c | 5 ----- lib/eal/common/eal_common_devargs.c | 1 - lib/eal/common/eal_common_errno.c | 4 ---- lib/eal/common/eal_common_fbarray.c | 3 --- lib/eal/common/eal_common_hexdump.c | 3 --- lib/eal/common/eal_common_launch.c | 6 ------ lib/eal/common/eal_common_lcore.c | 7 +------ lib/eal/common/eal_common_log.c | 2 -- lib/eal/common/eal_common_memalloc.c | 3 --- lib/eal/common/eal_common_memory.c | 5 ----- lib/eal/common/eal_common_memzone.c | 4 ---- lib/eal/common/eal_common_options.c | 2 -- lib/eal/common/eal_common_proc.c | 2 -- lib/eal/common/eal_common_string_fns.c | 2 -- lib/eal/common/eal_common_tailqs.c | 11 ----------- lib/eal/common/eal_common_thread.c | 3 --- lib/eal/common/eal_common_timer.c | 6 ------ lib/eal/common/eal_common_trace.c | 1 - lib/eal/common/hotplug_mp.h | 1 - lib/eal/common/malloc_elem.c | 6 ------ lib/eal/common/malloc_heap.c | 5 ----- lib/eal/common/malloc_mp.c | 1 - lib/eal/common/malloc_mp.h | 2 -- lib/eal/common/rte_malloc.c | 6 ------ lib/eal/common/rte_random.c | 3 --- lib/eal/common/rte_service.c | 6 ------ lib/eal/include/rte_version.h | 2 -- lib/eal/linux/eal.c | 10 ---------- lib/eal/linux/eal_alarm.c | 7 ------- lib/eal/linux/eal_cpuflags.c | 2 -- lib/eal/linux/eal_debug.c | 5 ----- lib/eal/linux/eal_dev.c | 4 ---- lib/eal/linux/eal_hugepage_info.c | 8 -------- lib/eal/linux/eal_interrupts.c | 8 -------- lib/eal/linux/eal_lcore.c | 7 ------- lib/eal/linux/eal_log.c | 11 +---------- lib/eal/linux/eal_memalloc.c | 8 -------- lib/eal/linux/eal_memory.c | 9 --------- lib/eal/linux/eal_thread.c | 5 ----- lib/eal/linux/eal_timer.c | 15 --------------- lib/eal/linux/eal_vfio_mp_sync.c | 1 - lib/eal/unix/eal_file.c | 1 - lib/eal/unix/rte_thread.c | 1 - lib/eal/x86/rte_cycles.c | 1 - 44 files changed, 2 insertions(+), 203 deletions(-) diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c index 148a23830a..12bf3d3c22 100644 --- a/lib/eal/common/eal_common_dev.c +++ b/lib/eal/common/eal_common_dev.c @@ -5,20 +5,15 @@ #include #include -#include #include -#include #include #include #include #include -#include #include -#include #include #include -#include #include #include "eal_private.h" diff --git a/lib/eal/common/eal_common_devargs.c b/lib/eal/common/eal_common_devargs.c index 7ab9e71b2a..f4beb35591 100644 --- a/lib/eal/common/eal_common_devargs.c +++ b/lib/eal/common/eal_common_devargs.c @@ -12,7 +12,6 @@ #include #include -#include #include #include #include diff --git a/lib/eal/common/eal_common_errno.c b/lib/eal/common/eal_common_errno.c index f86802705a..1091065568 100644 --- a/lib/eal/common/eal_common_errno.c +++ b/lib/eal/common/eal_common_errno.c @@ -5,15 +5,11 @@ /* Use XSI-compliant portable version of strerror_r() */ #undef _GNU_SOURCE -#include #include #include -#include -#include #include #include -#include #ifdef RTE_EXEC_ENV_WINDOWS #define strerror_r(errnum, buf, buflen) strerror_s(buf, buflen, errnum) diff --git a/lib/eal/common/eal_common_fbarray.c b/lib/eal/common/eal_common_fbarray.c index 3a28a53247..f11f87979f 100644 --- a/lib/eal/common/eal_common_fbarray.c +++ b/lib/eal/common/eal_common_fbarray.c @@ -2,7 +2,6 @@ * Copyright(c) 2017-2018 Intel Corporation */ -#include #include #include #include @@ -14,9 +13,7 @@ #include #include #include -#include #include -#include #include "eal_filesystem.h" #include "eal_private.h" diff --git a/lib/eal/common/eal_common_hexdump.c b/lib/eal/common/eal_common_hexdump.c index 2d2179d411..63bbbdcf0a 100644 --- a/lib/eal/common/eal_common_hexdump.c +++ b/lib/eal/common/eal_common_hexdump.c @@ -1,10 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause * Copyright(c) 2010-2014 Intel Corporation */ -#include #include -#include -#include #include #include diff --git a/lib/eal/common/eal_common_launch.c b/lib/eal/common/eal_common_launch.c index 34f854ad80..2a20b32a77 100644 --- a/lib/eal/common/eal_common_launch.c +++ b/lib/eal/common/eal_common_launch.c @@ -3,16 +3,10 @@ */ #include -#include -#include -#include #include -#include -#include #include #include -#include #include #include "eal_private.h" diff --git a/lib/eal/common/eal_common_lcore.c b/lib/eal/common/eal_common_lcore.c index 66d6bad1a7..c747353b17 100644 --- a/lib/eal/common/eal_common_lcore.c +++ b/lib/eal/common/eal_common_lcore.c @@ -2,19 +2,14 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include -#include #include #include -#include -#include +#include #include #include #include -#include -#include "eal_memcfg.h" #include "eal_private.h" #include "eal_thread.h" diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index ec8fe23a7f..24afb57c89 100644 --- a/lib/eal/common/eal_common_log.c +++ b/lib/eal/common/eal_common_log.c @@ -11,9 +11,7 @@ #include #include -#include #include -#include #include #include "eal_log.h" diff --git a/lib/eal/common/eal_common_memalloc.c b/lib/eal/common/eal_common_memalloc.c index e872c6533b..f8770ff835 100644 --- a/lib/eal/common/eal_common_memalloc.c +++ b/lib/eal/common/eal_common_memalloc.c @@ -5,12 +5,9 @@ #include #include -#include #include -#include #include #include -#include #include "eal_private.h" #include "eal_internal_cfg.h" diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c index f83b75092e..bb0da9e50a 100644 --- a/lib/eal/common/eal_common_memory.c +++ b/lib/eal/common/eal_common_memory.c @@ -2,16 +2,11 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include #include #include #include -#include -#include #include -#include #include -#include #include #include diff --git a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c index 7c21aa921e..67dcaaafbf 100644 --- a/lib/eal/common/eal_common_memzone.c +++ b/lib/eal/common/eal_common_memzone.c @@ -2,20 +2,16 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include #include #include -#include #include #include #include -#include #include #include #include #include -#include #include #include #include diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c index eaef57312f..1eb51be09c 100644 --- a/lib/eal/common/eal_common_options.c +++ b/lib/eal/common/eal_common_options.c @@ -4,7 +4,6 @@ */ #include -#include #include #ifndef RTE_EXEC_ENV_WINDOWS #include @@ -17,7 +16,6 @@ #include #include #endif -#include #include #ifndef RTE_EXEC_ENV_WINDOWS #include diff --git a/lib/eal/common/eal_common_proc.c b/lib/eal/common/eal_common_proc.c index ebd0f6673b..575b4ca24d 100644 --- a/lib/eal/common/eal_common_proc.c +++ b/lib/eal/common/eal_common_proc.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -27,7 +26,6 @@ #include #include #include -#include #include "eal_memcfg.h" #include "eal_private.h" diff --git a/lib/eal/common/eal_common_string_fns.c b/lib/eal/common/eal_common_string_fns.c index ddd1891656..0236ae4023 100644 --- a/lib/eal/common/eal_common_string_fns.c +++ b/lib/eal/common/eal_common_string_fns.c @@ -2,9 +2,7 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include #include -#include #include #include diff --git a/lib/eal/common/eal_common_tailqs.c b/lib/eal/common/eal_common_tailqs.c index ead06897b8..580fbf24bc 100644 --- a/lib/eal/common/eal_common_tailqs.c +++ b/lib/eal/common/eal_common_tailqs.c @@ -3,24 +3,13 @@ */ #include -#include -#include #include -#include #include -#include -#include -#include #include #include -#include -#include -#include -#include #include #include -#include #include "eal_private.h" #include "eal_memcfg.h" diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c index 1a52f42a2b..cfa6a69ad4 100644 --- a/lib/eal/common/eal_common_thread.c +++ b/lib/eal/common/eal_common_thread.c @@ -4,10 +4,7 @@ #include #include -#include -#include #include -#include #include #include #include diff --git a/lib/eal/common/eal_common_timer.c b/lib/eal/common/eal_common_timer.c index 86f8429847..5686a5102b 100644 --- a/lib/eal/common/eal_common_timer.c +++ b/lib/eal/common/eal_common_timer.c @@ -2,16 +2,10 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include #include -#include #include -#include -#include -#include #include -#include #include #include #include diff --git a/lib/eal/common/eal_common_trace.c b/lib/eal/common/eal_common_trace.c index 7bff1cd2ce..036f6ac348 100644 --- a/lib/eal/common/eal_common_trace.c +++ b/lib/eal/common/eal_common_trace.c @@ -3,7 +3,6 @@ */ #include -#include #include #include diff --git a/lib/eal/common/hotplug_mp.h b/lib/eal/common/hotplug_mp.h index 8fcf9b52e2..066494ff27 100644 --- a/lib/eal/common/hotplug_mp.h +++ b/lib/eal/common/hotplug_mp.h @@ -6,7 +6,6 @@ #define _HOTPLUG_MP_H_ #include "rte_dev.h" -#include "rte_bus.h" #define EAL_DEV_MP_ACTION_REQUEST "eal_dev_mp_request" #define EAL_DEV_MP_ACTION_RESPONSE "eal_dev_mp_response" diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c index c2c9461f1d..4c6e6f4910 100644 --- a/lib/eal/common/malloc_elem.c +++ b/lib/eal/common/malloc_elem.c @@ -6,17 +6,11 @@ #include #include #include -#include #include #include #include -#include -#include -#include -#include #include -#include #include "eal_private.h" #include "eal_internal_cfg.h" diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index ee400f38ec..61f0a5d84f 100644 --- a/lib/eal/common/malloc_heap.c +++ b/lib/eal/common/malloc_heap.c @@ -5,7 +5,6 @@ #include #include #include -#include #include #include @@ -13,15 +12,11 @@ #include #include #include -#include -#include #include #include #include #include -#include #include -#include #include #include "eal_internal_cfg.h" diff --git a/lib/eal/common/malloc_mp.c b/lib/eal/common/malloc_mp.c index 2e597a17a2..801b2e7fbd 100644 --- a/lib/eal/common/malloc_mp.c +++ b/lib/eal/common/malloc_mp.c @@ -5,7 +5,6 @@ #include #include -#include #include #include diff --git a/lib/eal/common/malloc_mp.h b/lib/eal/common/malloc_mp.h index 0095062b72..fb10817e13 100644 --- a/lib/eal/common/malloc_mp.h +++ b/lib/eal/common/malloc_mp.h @@ -10,8 +10,6 @@ #include #include -#include -#include /* forward declarations */ struct malloc_heap; diff --git a/lib/eal/common/rte_malloc.c b/lib/eal/common/rte_malloc.c index 9d39e58c08..6c69a2cf3b 100644 --- a/lib/eal/common/rte_malloc.c +++ b/lib/eal/common/rte_malloc.c @@ -6,18 +6,12 @@ #include #include #include -#include #include #include #include #include #include -#include -#include -#include -#include -#include #include #include diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c index ce21c2242a..4535cc980c 100644 --- a/lib/eal/common/rte_random.c +++ b/lib/eal/common/rte_random.c @@ -5,14 +5,11 @@ #ifdef __RDSEED__ #include #endif -#include #include #include #include -#include #include -#include #include struct rte_rand_state { diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c index bd8fb72e78..ef31b1f63c 100644 --- a/lib/eal/common/rte_service.c +++ b/lib/eal/common/rte_service.c @@ -3,22 +3,16 @@ */ #include -#include #include -#include #include -#include #include #include -#include #include #include -#include #include #include -#include #include #include diff --git a/lib/eal/include/rte_version.h b/lib/eal/include/rte_version.h index b06a62e7a2..414b6167f2 100644 --- a/lib/eal/include/rte_version.h +++ b/lib/eal/include/rte_version.h @@ -14,10 +14,8 @@ extern "C" { #endif -#include #include #include -#include #include /** diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 3577eaeaa4..f55d1860d8 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -7,10 +7,8 @@ #include #include #include -#include #include #include -#include #include #include #include @@ -20,32 +18,24 @@ #include #include #include -#include #include #if defined(RTE_ARCH_X86) #include #endif #include -#include #include #include #include #include #include #include -#include #include #include #include -#include -#include #include #include -#include #include -#include -#include #include #include #include diff --git a/lib/eal/linux/eal_alarm.c b/lib/eal/linux/eal_alarm.c index 3252c6fa59..43f6bb14f2 100644 --- a/lib/eal/linux/eal_alarm.c +++ b/lib/eal/linux/eal_alarm.c @@ -3,21 +3,14 @@ */ #include #include -#include #include -#include #include #include #include -#include #include #include #include -#include -#include -#include -#include #include #include #include diff --git a/lib/eal/linux/eal_cpuflags.c b/lib/eal/linux/eal_cpuflags.c index d38296e1e5..c684940e1d 100644 --- a/lib/eal/linux/eal_cpuflags.c +++ b/lib/eal/linux/eal_cpuflags.c @@ -5,8 +5,6 @@ #include #include #include -#include -#include #include #if defined(__GLIBC__) && defined(__GLIBC_PREREQ) diff --git a/lib/eal/linux/eal_debug.c b/lib/eal/linux/eal_debug.c index 64dab4e0da..b0ecf5a9dc 100644 --- a/lib/eal/linux/eal_debug.c +++ b/lib/eal/linux/eal_debug.c @@ -5,16 +5,11 @@ #ifdef RTE_BACKTRACE #include #endif -#include -#include #include #include -#include #include #include -#include -#include #define BACKTRACE_SIZE 256 diff --git a/lib/eal/linux/eal_dev.c b/lib/eal/linux/eal_dev.c index 3b905e18f5..0a654e5b50 100644 --- a/lib/eal/linux/eal_dev.c +++ b/lib/eal/linux/eal_dev.c @@ -4,20 +4,16 @@ #include #include -#include #include #include #include #include #include -#include #include -#include #include #include #include -#include #include #include diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index d97792cade..b3e4c40ee7 100644 --- a/lib/eal/linux/eal_hugepage_info.c +++ b/lib/eal/linux/eal_hugepage_info.c @@ -3,7 +3,6 @@ */ #include -#include #include #include #include @@ -12,19 +11,12 @@ #include #include #include -#include #include #include #include -#include -#include #include /* for hugetlb-related flags */ -#include -#include -#include -#include #include #include #include diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index 22b3b7bcd9..1d5c9b272c 100644 --- a/lib/eal/linux/eal_interrupts.c +++ b/lib/eal/linux/eal_interrupts.c @@ -7,13 +7,10 @@ #include #include #include -#include #include #include #include -#include #include -#include #include #include #include @@ -21,9 +18,6 @@ #include #include -#include -#include -#include #include #include #include @@ -36,8 +30,6 @@ #include #include "eal_private.h" -#include "eal_vfio.h" -#include "eal_thread.h" #define EAL_INTR_EPOLL_WAIT_FOREVER (-1) #define NB_OTHER_INTR 1 diff --git a/lib/eal/linux/eal_lcore.c b/lib/eal/linux/eal_lcore.c index bc8965844c..2e6a350603 100644 --- a/lib/eal/linux/eal_lcore.c +++ b/lib/eal/linux/eal_lcore.c @@ -4,15 +4,8 @@ #include #include -#include -#include #include -#include -#include -#include -#include -#include #include "eal_private.h" #include "eal_filesystem.h" diff --git a/lib/eal/linux/eal_log.c b/lib/eal/linux/eal_log.c index c0aa1007c4..9e72412e2b 100644 --- a/lib/eal/linux/eal_log.c +++ b/lib/eal/linux/eal_log.c @@ -2,19 +2,10 @@ * Copyright(c) 2010-2014 Intel Corporation */ -#include #include -#include #include #include -#include - -#include -#include -#include -#include -#include -#include + #include #include "eal_log.h" diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c index 0ec8542283..e3aba10107 100644 --- a/lib/eal/linux/eal_memalloc.c +++ b/lib/eal/linux/eal_memalloc.c @@ -3,23 +3,17 @@ */ #include -#include #include #include #include #include -#include #include #include -#include #include -#include #include #include #include #include -#include -#include #include #include #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */ @@ -36,9 +30,7 @@ #include #include #include -#include #include -#include #include "eal_filesystem.h" #include "eal_internal_cfg.h" diff --git a/lib/eal/linux/eal_memory.c b/lib/eal/linux/eal_memory.c index 03a4f2dd2d..40ec9663d0 100644 --- a/lib/eal/linux/eal_memory.c +++ b/lib/eal/linux/eal_memory.c @@ -5,7 +5,6 @@ #include #include -#include #include #include #include @@ -13,19 +12,14 @@ #include #include #include -#include #include -#include #include #include #include #include -#include -#include #include #include #ifdef F_ADD_SEALS /* if file sealing is supported, so is memfd */ -#include #define MEMFD_SUPPORTED #endif #ifdef RTE_EAL_NUMA_AWARE_HUGEPAGES @@ -36,12 +30,9 @@ #include #include #include -#include #include -#include #include #include -#include #include "eal_private.h" #include "eal_memalloc.h" diff --git a/lib/eal/linux/eal_thread.c b/lib/eal/linux/eal_thread.c index 83c2034b93..60fa64ea55 100644 --- a/lib/eal/linux/eal_thread.c +++ b/lib/eal/linux/eal_thread.c @@ -4,20 +4,15 @@ #include #include -#include #include #include #include -#include -#include #include #include #include #include #include -#include -#include #include #include #include diff --git a/lib/eal/linux/eal_timer.c b/lib/eal/linux/eal_timer.c index 7cf15cabac..620baf038d 100644 --- a/lib/eal/linux/eal_timer.c +++ b/lib/eal/linux/eal_timer.c @@ -3,28 +3,13 @@ * Copyright(c) 2012-2013 6WIND S.A. */ -#include -#include #include #include -#include -#include -#include -#include -#include -#include -#include #include -#include #include -#include -#include -#include -#include #include "eal_private.h" -#include "eal_internal_cfg.h" enum timer_source eal_timer_source = EAL_TIMER_HPET; diff --git a/lib/eal/linux/eal_vfio_mp_sync.c b/lib/eal/linux/eal_vfio_mp_sync.c index a2accfab3a..e1776166af 100644 --- a/lib/eal/linux/eal_vfio_mp_sync.c +++ b/lib/eal/linux/eal_vfio_mp_sync.c @@ -5,7 +5,6 @@ #include #include -#include #include #include #include diff --git a/lib/eal/unix/eal_file.c b/lib/eal/unix/eal_file.c index ec554e0096..f04f5fbcbc 100644 --- a/lib/eal/unix/eal_file.c +++ b/lib/eal/unix/eal_file.c @@ -3,7 +3,6 @@ */ #include -#include #include #include diff --git a/lib/eal/unix/rte_thread.c b/lib/eal/unix/rte_thread.c index c72d619ec1..c34ede9186 100644 --- a/lib/eal/unix/rte_thread.c +++ b/lib/eal/unix/rte_thread.c @@ -7,7 +7,6 @@ #include #include -#include #include #include #include diff --git a/lib/eal/x86/rte_cycles.c b/lib/eal/x86/rte_cycles.c index edd9621abb..0e695caf28 100644 --- a/lib/eal/x86/rte_cycles.c +++ b/lib/eal/x86/rte_cycles.c @@ -6,7 +6,6 @@ #include #include -#include #include "eal_private.h"