From patchwork Sun Sep 26 15:57:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jilei chen X-Patchwork-Id: 99697 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D43A3A0547; Sun, 26 Sep 2021 22:47:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5617F4003D; Sun, 26 Sep 2021 22:47:37 +0200 (CEST) Received: from cmccmta3.chinamobile.com (cmccmta3.chinamobile.com [221.176.66.81]) by mails.dpdk.org (Postfix) with ESMTP id 7EC114003C for ; Sun, 26 Sep 2021 17:49:29 +0200 (CEST) Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app11-12011 (RichMail) with SMTP id 2eeb6150967339a-d20b5; Sun, 26 Sep 2021 23:49:12 +0800 (CST) X-RM-TRANSID: 2eeb6150967339a-d20b5 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from chenjilei.localdomain (unknown[223.112.32.184]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee26150966fccc-c0470; Sun, 26 Sep 2021 23:49:11 +0800 (CST) X-RM-TRANSID: 2ee26150966fccc-c0470 From: jilei chen To: xiao.w.wang@intel.com Cc: dev@dpdk.org, Jilei Chen Date: Sun, 26 Sep 2021 23:57:57 +0800 Message-Id: <20210926155757.7648-1-chenjilei@cmss.chinamobile.com> X-Mailer: git-send-email 2.12.2 X-Mailman-Approved-At: Sun, 26 Sep 2021 22:47:36 +0200 Subject: [dpdk-dev] [PATCH] Enhance code readability when dma_map in ifc/ifcvp_vdpa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Jilei Chen Signed-off-by: Jilei Chen --- drivers/net/ifc/ifcvf_vdpa.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c index da4667ba54..fe7ec87a8a 100644 --- a/drivers/net/ifc/ifcvf_vdpa.c +++ b/drivers/net/ifc/ifcvf_vdpa.c @@ -37,6 +37,8 @@ #define IFCVF_VDPA_MODE "vdpa" #define IFCVF_SW_FALLBACK_LM "sw-live-migration" +#define IFCVF_MAP 1 +#define IFCVF_UNMAP 0 static const char * const ifcvf_valid_arguments[] = { IFCVF_VDPA_MODE, @@ -535,7 +537,7 @@ update_datapath(struct ifcvf_internal *internal) if (!rte_atomic32_read(&internal->running) && (rte_atomic32_read(&internal->started) && rte_atomic32_read(&internal->dev_attached))) { - ret = ifcvf_dma_map(internal, 1); + ret = ifcvf_dma_map(internal, IFCVF_MAP); if (ret) goto err; @@ -565,7 +567,7 @@ update_datapath(struct ifcvf_internal *internal) if (ret) goto err; - ret = ifcvf_dma_map(internal, 0); + ret = ifcvf_dma_map(internal, IFCVF_UNMAP); if (ret) goto err; @@ -869,7 +871,7 @@ ifcvf_sw_fallback_switchover(struct ifcvf_internal *internal) unset_intr: vdpa_disable_vfio_intr(internal); unmap: - ifcvf_dma_map(internal, 0); + ifcvf_dma_map(internal, IFCVF_UNMAP); error: return -1; } @@ -926,7 +928,7 @@ ifcvf_dev_close(int vid) vdpa_disable_vfio_intr(internal); /* unset DMA map for guest memory */ - ifcvf_dma_map(internal, 0); + ifcvf_dma_map(internal, IFCVF_UNMAP); internal->sw_fallback_running = false; } else {