From patchwork Thu Jun 21 07:30:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raslan Darawsheh X-Patchwork-Id: 41344 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 354741BB3E; Thu, 21 Jun 2018 09:31:15 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by dpdk.org (Postfix) with ESMTP id E8CFD1BA90; Thu, 21 Jun 2018 09:31:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1biJk3YrBjBOSsR4tdIa3H6sTgwx2i8GlYdCbr2WKfU=; b=x7P5onYDbHCBZ6xkxQbXzJYhMPBH6B7b1g+bm3Oji7m5Oc77YH3GtNH+HLmHbZExo5RpVX39ItGhFK4pKRQ5RYPzb1pwG+X6W1AWPonFuN2tPpN9hyWlq2vHRUxBcDPzecrFOvBVFA4+2oSzOql/ut5abSwNg3Gezn79I8zPpEE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; Received: from mellanox.com (37.142.13.130) by HE1PR05MB1258.eurprd05.prod.outlook.com (2a01:111:e400:588a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.17; Thu, 21 Jun 2018 07:31:11 +0000 From: Raslan Darawsheh To: shahafs@mellanox.com Cc: dev@dpdk.org, matan@mellanox.com, nelio.laranjeiro@6wind.com, rasland@mellanox.com, stable@dpdk.org Date: Thu, 21 Jun 2018 10:30:55 +0300 Message-Id: <1529566255-14001-1-git-send-email-rasland@mellanox.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1529413738-28378-1-git-send-email-rasland@mellanox.com> References: <1529413738-28378-1-git-send-email-rasland@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0109.eurprd08.prod.outlook.com (2603:10a6:800:d4::11) To HE1PR05MB1258.eurprd05.prod.outlook.com (2a01:111:e400:588a::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 944ce4a8-7822-4fff-7724-08d5d748f6e7 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:HE1PR05MB1258; X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1258; 3:TCC6CvpESbn+ggSgnQ474P7C6ozTbgSj6bmkRoN6W2hdLaiqNzvwVahx2lTzUkpTOCOBGHxLcZ6+gT5RnEDTj24vc4NTqb7Q7HNYo8c5sc5hPqP8GBOa5ZnWEJ3IWYIAUrbCJ9wQA5rXPmN9FeyiPbwrk7hQPULY9FLXJAEY5GWBY2UgcSjiDO7yuvtRGWKHrunE19Do0v0KxvnDdAGzHXVY0eW8OFLy0hLAB/4EDvwPzrOAhAH46PDZ4dbMpHAw; 25:NzcfiukqN6qrvrbeJg9pbIWnXbgIHCelllxaOuY8rjZYnAgM/mgWHP6XIYXIjI1pHNUx5yeTTlXVI7bp2M1KFwEAXIgbULAkpcRC6vhuRvfNQhzbOYUuFq+445oAIfblsNIcqvftZOBPnITb5w6uNJRe1z6gHW5bpWt8uDLyTc4xoIf1NUCsWMvu1z9iplbHh1oqOU0fjisw9rMusOLnkNIOK+a5a+wJNr8kb9GvUlAyP6cSjc2Al2FfObXzdEcBUlIaPAP/CTo1cJmmxCrTzNSr5lmQ1hMTyHkX3x0exQxDQXBnkysm0CURUYpeYGSmRqXvvgPTZPFCsJsBYCsWXg==; 31:T51BdR/443BURCepkzXYlxha66STHCxFMgSBeeGGfZYziQnvBgYQEEt1GnqleqqYDvW8WGQuJcHAknBweb4J3KSHNXPyJ6xRkGCRkH/xSoNWMl26MiCCZeBDtQeZUMlCNcmOKMAW5FY5BvHnKnVbvdGfjOzest4JUELCsz39qMJSIbYnoCHx/YQ2D4mjuMHve2/qYtZHJCs1AYYGZQoozP6xAa/1gY4tIIxwsIxqZDE= X-MS-TrafficTypeDiagnostic: HE1PR05MB1258: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1258; 20:0TMHB+uzgBGdwxQMEtCclMXIaLG05QVeoI2RjJ1qCFj3RsHk4gWp9p2epFfwf4LplGENBIaEGox/DCrTdcMa0e5iox6VOL1Sg4UhW7uphyWz1RvbWNGJ1k4VLUHsLle4og0uXSADmZYwRjpi3YXsJPxyL3asfaJUJRiOXlwHDcZchxtTsnDE/zz37rXYbw7DLdDnUwXcnnf+rNET46EWj1mv6KjUWhphXeizziYM/k+KigK773QU/5ivFHEyUo7ZZjAtdrVP5T4S9cPupG6sfeNDv09kXwSZDc70UMiQWIOA8Myc4I1MVyxH5RsnhmPRMJEAyfBSl417JfJpwuE5Sb/MuJT0+h/FLN1BXkhi/yvZkhtUBwr+ynP2+Rz6GhP1mzfD0PA10sZGIb9PxMRz67UQc6sRiN77ca1v+5IFLXa3Z9xRrEWRUqlPvlxYh60TXJemhuabYVJ8LEHts7r8DmUyVmOLcruqd+8QbDqsDy+zUBsevHxJG41KnAu+V481; 4:7khRamf9gNctTOxEF9EdbRaA69Ve18F6tkrEhueWB9Jt89T4MUoNSPzWRqfySuz1q1kC/Qe2FKeWYxy5UbpCUtsWk1Dxhe+QHuHOlA1AGI8E+xkOYzv1PgmdIaW8l6iRaZKqntjcYSWbVi6SG1tfSjsNFJUhXt1dzmNgZOIPLTQKgrZNwfYbXC88G0OrRUwPdWPn2xgJH9kIORqf4hGwT3p96CKHDZptEEEtrhk1GqksVKpMemOG9VeGyjsLxRpyW+FBmq4/ZkdylVt+E0P03g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:HE1PR05MB1258; BCL:0; PCL:0; RULEID:; SRVR:HE1PR05MB1258; X-Forefront-PRVS: 07106EF9B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39380400002)(366004)(39860400002)(346002)(376002)(396003)(199004)(189003)(16526019)(2361001)(316002)(33026002)(16586007)(37006003)(66066001)(86362001)(8936002)(81166006)(305945005)(7736002)(97736004)(8676002)(386003)(3846002)(47776003)(50226002)(2351001)(7696005)(81156014)(51416003)(76176011)(6116002)(52116002)(26005)(25786009)(476003)(4326008)(2906002)(486006)(55016002)(956004)(36756003)(105586002)(11346002)(106356001)(53936002)(446003)(5660300001)(21086003)(478600001)(6636002)(50466002)(34206002)(48376002)(2616005)(6666003)(69596002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR05MB1258; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR05MB1258; 23:T/Rh4/w8rwUtvZAq8wjHo8OWITdzDM1r6qCppKCX/?= ahoSCR/2Ay7gyuqlBsYOC6mvKHruB/GlJiuIgOYoKkSLIg7syDHIJvCnxsJ7cMpS91XXg4eG2aapu/psYujPPIdRsYd0//VVSnf+06/uSh0ryEe45GKS3DMfdfjFLAp5TVJvJrl9pGSeBJMpw3aURATppUhW0wvb4Mi9CvxyUzzx3WA49aFt6+nKt8r6p8biF/0efN/iQU56/swBABNNghYVqoYHr/NOSEolPvQM+kHjup+ZjTavI4dd35cy5APweE0X6IBbfH+RlEsaMwIy3EW40PBO6bTxoQuwWZhGyMQeyI5KJmhVb6vq/krgLb0SJEKi5tNjUvztr0IjYRU3CcPGNkULtr8vt5jGrpqP0XAUA/90IquRmz94vN3roCqI12UK2DqwOtazWHODmAlcB8auTYdACGAUQPqBG1Z1rA61ITsA5O4Ej7FFcDDGDJ0TtcjPFZQeXsmL+d69pCj2SGHecyfTEEf+UDygA+0CUV+Oj2BYDijW5gc+xSnxJ3kA1De+DkThXl9AqOY0iY3o9SbrVXbMVzwfPfl2JteU1VQsGRqZmzSHUsO7ji9WUMc/nzcEgHbcbPh8sKfMxIu+tD9V8KFP277Kz3vljcn905txghLpxhjK0MDNmCsoO7fcqtPrVdJgmOMe+8PlCChObRr+2ZpHcTKmm7ufu5Dk9CKg1umSNS9GlT+O/7ETnk8qI5DbvALtOOsy1mvZp3iMxB1huBTB83nw1iBlwMZHhgKhZnth4H2/NRXrVaIbgEr7tklV7LRp4qyrPTgPeiB19rXjC9da2b7dPInVm/vUL20rWiQ0iANSQtG3fJ/cxSphlIO/Va8PV5Bk5OgjpompYddll3FBSAcS5OH+bXhzdC33FcnuV2am+XTA3te9Cr42nXl7IBPLIEzouP5YcMepMP+o1D/ao33mzPAswyKUUXwYTdHXeBf92OlGDptUsiFkKGWQuRbJJnpEjqnagXTdHWjenMY3NMwtqCOcr/GL5Te0PgRkRqTsFz93aBdv8rYUCcRwpWMEzSQp6tC2BgXr3aGHVDEuynhRnMyB4uT1ynJYqJbwXzUWix5zz5CceennM6gDXUW3WznjW626k7mdgNPF+mIngKtGePqqhOSFMy3WIxPDEfMK1cM6JYfOkGNjY/GSAl3xBZNEw0xakYwN1608q4dCCt4fWr03raOEDLY67Vs0GjSDTD7icnTYWE91ANPIwP4uL9vHFxHf6H3NvuBs0QjmlzCoPJrENBs5MRkqQ== X-Microsoft-Antispam-Message-Info: sXEce59YJRmzlE/tTFEuoWSwhpgMxLQxy3bDdjLtl5EcplK7XwWxSSo1qNLIaRarcSSfnT8BCF13pYGu74VEO/hQD44kPwBBlCZbM1Uk0hxHCu3FN5ixmJjfEsuhlHhFqv0+X2zrUuXCWuVJuuK5eotrYXWuRX3FMSUIimNYygqjr/AGffXz6UcV1FmfYeJzr5aw1dKGMacNHQDi/vgFqe2CnnZZsso+Lf6XOWEqKlVHgaBBRYovXGBqHeVvwX0XTfFN9zKr/8yw+ci81w6XoJIDtLBxHxnfBZseOMMSXEwaG2YZrqvBOWqnIcW3VMUW X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1258; 6:JSYn2Gg3WUzWXRb91d4vKNWoHnzyR8VcEStCMwQeohU4NreYi/ehf+2n43m86avuYpgKqYzawfDGkR1CCGKD/v4g0jOnz/F91OPhHKmXMxAT6M6SVcLApxF6NaBQFVAfFmija5LTS9hOlhs8S82vzf3wmlYp3RQngMrVKFTOIpSzpmF9h0TJAeziSTQAE8nZHHaQxn1+qWThrv2YWPD7kDdj0zSLeKKXuDcjay/3hroATfuf5L719YdTbXjNyYPeCWc7x68D38xMmML4ECJNByY4+SLTM94EEyxnp7lbaQC+AZUpKHV7PWP3+vsdgCA9hZmHPoEpEVTNeDnf37ycUW2Gr10hMZDm/Jw+4O3IEjrplPDnfngMMneEhJDVTyOczNzW2NLZBqlpVwLHbFdu6jzTJUJ7z9vI2h36fz83Y73+bnlunanlq7VAsFe1tAoBtHC87U2fdNSL4bJElf3sbw==; 5:ST0ZJGOjTSYhap+9qnMtvaJU+E0YF97KFVBFu0l7y/VpxttmkfwM0jrV4JKJGk4KFzx4U+BgMHOCLUxn14u9X8sr1WS+hzSrc2z0adNdX1wWDKjJo86zlcZhUxLzruGXBRE7dwXEJPn/6iN/v/7eTZ5vcMUvuncDj4bxspSBoQE=; 24:ClSn6TWj2uZEfxSY7UKcAWzMWWgaGGvArMaHt2gjDxybe/hGIN+96fksprBcJCx0bCi2sfokt9959mgGzthdniyx3WbfKqsYn7PRh6MYOHs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR05MB1258; 7:++PHO4KdsCE5NAvdN2N3YflubeUu5uOJPWRAGPI4IZc8dzJyDk+An621Lp60kiC8sIHkDD6Y/GR+B8ADNdePqyqWQ7w1XdeA5cwemRahlsF3M4w7QSUHumj9n3tdOp+ECtMoSVdc1WN+mjql6gnx4nxM6ZLw3xVYz/+Yan2D0h3pRT6bhkokcDg8LA+k4P7BBo1DHXpnXIGWWYkNx59qhmoCc7uLA3k2yhJdfspSz4oJWAqsFV9irKRUzT5V80J0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 07:31:11.1125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 944ce4a8-7822-4fff-7724-08d5d748f6e7 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB1258 Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS level validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When setting the level in rss action it's checking for the value stored in the parser which is set to 0 by default. This change the check to be for the requested action instead. Fixes: d4a40518 ("net/mlx5: support tunnel RSS level") Cc: stable@dpdk.org Signed-off-by: Raslan Darawsheh Acked-by: Shahaf Shuler --- changes in v2: commit massage reword. --- --- drivers/net/mlx5/mlx5_flow.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 994be05..40df633 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -738,7 +738,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #ifndef HAVE_IBV_DEVICE_TUNNEL_SUPPORT - if (parser->rss_conf.level > 1) { + if (rss->level > 1) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions, @@ -747,7 +747,7 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } #endif - if (parser->rss_conf.level > 2) { + if (rss->level > 2) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, actions,