From patchwork Tue Aug 10 23:03:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Kozlyuk X-Patchwork-Id: 96791 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D94D9A0C47; Wed, 11 Aug 2021 01:03:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E62D40150; Wed, 11 Aug 2021 01:03:32 +0200 (CEST) Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mails.dpdk.org (Postfix) with ESMTP id ABB564003C; Wed, 11 Aug 2021 01:03:30 +0200 (CEST) Received: by mail-lj1-f170.google.com with SMTP id h9so1217542ljq.8; Tue, 10 Aug 2021 16:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PEms1vHlONR9jKi5NxZu5i211qgQvuCZ3u4SNWmPC2s=; b=LdWkmh9xh0seW33dhQ32SrKT0lEY+1WJNXpnaJGj0DRTO/pCa94HloddbwEki/GaoT ZvFchy7MDdgiQSVq1Ot0H2WfDJnsL0Wy3vgV7sQKizsoASw0W7MbbCQwGdP6g5iPeu87 hMEIdkTKfBMlx8/cxtXMJ+gVW7OTkr8KoEOFnlJHwuRefYiW2NHmmP61kxjAwIUc5Uyk KbdojZjBTbWo/2P2V80igb67+oKyqPNcyAURrGeMJT9Ef1hUNaGWly0u4B/fLfY6UhAz 826maMdRoQvsWGtTIO2k/3GaFfTteWPiwu2QJPnPbjmiD/bmpVFtXHZTo0UljSGMZ7or tIOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=PEms1vHlONR9jKi5NxZu5i211qgQvuCZ3u4SNWmPC2s=; b=BL7sNUwhJ2wih66A0WeZEdrP4bMU0l7YFL10lb4Wd3B63ee2ybX4Q8jWv9289oJRRk iTgs8FQ2L9BU2L65i9WzwMDz0ZckEBynqONHIY8JvyamJfZB3Q0inhhu6CTmEvN9JioE /4IPBQRXkn3N6KHQSznaKtfi2/YiGD72CIBsWzBqIUfkHmIxIQkJmxQudebGlLDx+xqm LKE9CLufQeuwAsC1IyDXcP+m4fZFypXVXGl3vRggdD9VQoLKdMTteS4EANR/atyVffZ1 7z0i23x72FAnZGX7qbbKnsL8N2jn099MEfAtqZNtDKLrb+TffbVaJ8o1urgdXGEpAkHZ UB4A== X-Gm-Message-State: AOAM530frpU4Z+zHnn9wTBmZf083RFZ5qXSudNUgOdnPhuQbmtFmM2rE N3SlZmn81YauFGCQovbbDka654vE0KU= X-Google-Smtp-Source: ABdhPJxhxA/xqXqi19qwfZe8H/GXO3wT1MMj/ZaZiX/k0NFbxnJgmAO2MsM8EZi9QHUAh2Voh+OkgQ== X-Received: by 2002:a2e:3211:: with SMTP id y17mr20519170ljy.217.1628636609854; Tue, 10 Aug 2021 16:03:29 -0700 (PDT) Received: from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id h9sm1601328ljq.92.2021.08.10.16.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 16:03:29 -0700 (PDT) From: Dmitry Kozlyuk To: dev@dpdk.org Cc: Dmitry Kozlyuk , nick.connolly@mayadata.io, stable@dpdk.org, Bruce Richardson , Narcisa Vasile Date: Wed, 11 Aug 2021 02:03:22 +0300 Message-Id: <20210810230322.230150-1-dmitry.kozliuk@gmail.com> X-Mailer: git-send-email 2.29.3 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] build: fix install from arbitrary directory for meson 0.55 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Install command for meson >= 0.55.0 referenced the script by a plain string, assuming the build directory to be directly under the source tree root. This resulted in an error when the assumption did not hold: c:\python\python.exe: can't open file '../buildtools/symlink-drivers-solibs.py': [Errno 2] No such file or directory Use files() to make a valid script path for any build directory. Fixes: cd27047dbee1 ("build: support drivers symlink on Windows") Cc: nick.connolly@mayadata.io Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Bruce Richardson --- Note: this is not limited to Windows, it just happens that Windows requires newer meson and the error example is from Windows build. config/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/meson.build b/config/meson.build index e80421003b..3b5966ec2f 100644 --- a/config/meson.build +++ b/config/meson.build @@ -61,7 +61,8 @@ if not is_windows get_option('libdir'), pmd_subdir_opt) elif meson.version().version_compare('>=0.55.0') # 0.55.0 is required to use external program with add_install_script - meson.add_install_script(py3, '../buildtools/symlink-drivers-solibs.py', + meson.add_install_script(py3, + files('../buildtools/symlink-drivers-solibs.py'), get_option('libdir'), pmd_subdir_opt, get_option('bindir')) endif