From patchwork Wed Oct 10 17:04:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Moti Haimovsky X-Patchwork-Id: 46510 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19D8C1B6C7; Wed, 10 Oct 2018 19:05:00 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0040.outbound.protection.outlook.com [104.47.2.40]) by dpdk.org (Postfix) with ESMTP id 712341B4D1 for ; Wed, 10 Oct 2018 19:04:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQDSHqhUffDM6qix/41M369w2DWZUpiQDO3KpGWNCBE=; b=mJsTdv98ZH3tC4v5pPTgVuah2GG4pLwDf5Wnwk3nzBlxLBMLdirmV08EOPRR0sS+KJWILjEkriASWmUYe3WO8EmfJFTyeDS/Dh56fX8inbNPqewDy74LT0OqpLQOvD6O9nVF+HYk3ToaIeEw9McAsVOECHVeENfvPbQeijM1sOI= Received: from AM0PR05MB4435.eurprd05.prod.outlook.com (52.134.92.20) by AM0PR05MB4209.eurprd05.prod.outlook.com (52.134.91.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.22; Wed, 10 Oct 2018 17:04:56 +0000 Received: from AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::2549:a872:4864:b84e]) by AM0PR05MB4435.eurprd05.prod.outlook.com ([fe80::2549:a872:4864:b84e%6]) with mapi id 15.20.1207.024; Wed, 10 Oct 2018 17:04:56 +0000 From: Mordechay Haimovsky To: Adrien Mazarguil , Shahaf Shuler , Ori Kam CC: "dev@dpdk.org" , Mordechay Haimovsky Thread-Topic: [PATCH] app/testpmd: fix flow query failure Thread-Index: AQHUYLtezpIFwK1+5EWur2IGcQ2jJA== Date: Wed, 10 Oct 2018 17:04:56 +0000 Message-ID: <1539191078-8501-1-git-send-email-motih@mellanox.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR03CA0048.eurprd03.prod.outlook.com (2603:10a6:803:50::19) To AM0PR05MB4435.eurprd05.prod.outlook.com (2603:10a6:208:5a::20) authentication-results: spf=none (sender IP is ) smtp.mailfrom=motih@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [37.142.13.130] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR05MB4209; 6:nLzJj7e6lzclSvMZ+8V4ejn4d7EJmooaebrWM+VjFAlq/nIHcMnerxRevccjZi/7dIpimvFa+0OGTmkmxoB7HqpMC/z1v6J7RkVLCvK/It1MLVmnPm2T/nzUp9JoCu+GD+whMby185KjiOF0ZMMcNtr3YmByczTpHVCrfjt2TE5wH+KDImMaf3IMu3Ln68XrhyS6nEQ++FKJafmHAzbBtpE3+SKkk7BBnCAKzufNrKM6OuF1wCkHwhzzvl+JtMRCFGVZU7hpT34Ff+oAa30CraGXiNHbfOW9monxioZs95A1Hu2fceuRHeraBNN5gS0Eul0bn04/SCoR+OrOS/jcnUYIvCXWQ5Scn3bYWp3B59exCkoiFYaNaNf+BKdUP7A4KzjL8l1hI2Dt3Wyc4knGR1HJ7SuzgGMaUt6cXPctkLSda6r5wpfIZf4PscJKBL5wtLgcV4cTJIQoCUcQGU34zw==; 5:YmFPSZjqjJAdk60HggCNcZ5RaK+QFYtNiDjrwcZCuceR5zhWfPXHvVw2zcma9Pi6hjy1PMbMUMTm4ashsZRxmTYkr64j/zPR9s83XNn1J6Pwjv1BUY/L8BHlJbBpG1ljmLsFV0U84/L8CVVHSszup94LF64eXrxnY7bQaKWvpB4=; 7:G6a71OTqxR/BxX5Zy2qycEFbdF8rHdXvbBY++lH2aVod6+WNLcGk63yCeNOGfeammRZYvHrbjQi2FvP+QVM3FxWcZIpd5PvN02KGCbVmit43TaCsqEO8bKzlnVvVxHcNO2ee4//KQFMhfVJCQYTFhiDThL7JrLDnPePDT6WLZpnJjl9Gis9mIsS2UOuNSObTsLektBSCo+jHUro88CGE5PzxGCwFOAa5EMlTa/3lp8N4tX8UrQ1dz6tmFs0eXhj+ x-ms-office365-filtering-correlation-id: dc4495aa-8520-49f1-d104-08d62ed280cd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4209; x-ms-traffictypediagnostic: AM0PR05MB4209: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123560045)(20161123564045)(201708071742011)(7699051); SRVR:AM0PR05MB4209; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4209; x-forefront-prvs: 08213D42D3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(136003)(346002)(396003)(366004)(199004)(189003)(99286004)(7736002)(26005)(6436002)(8676002)(6486002)(1857600001)(6636002)(186003)(478600001)(102836004)(5250100002)(71200400001)(81156014)(6116002)(71190400001)(3846002)(81166006)(6506007)(386003)(8936002)(110136005)(305945005)(54906003)(2906002)(68736007)(256004)(52116002)(14444005)(5660300001)(316002)(66066001)(486006)(476003)(97736004)(14454004)(2616005)(107886003)(6512007)(36756003)(4326008)(106356001)(575784001)(86362001)(2900100001)(105586002)(53936002)(25786009)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4209; H:AM0PR05MB4435.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 3KDs+8nuumi8iOg+JeSBfZOMLXSPPcvDIPBTNjCI5AGirldRaE2GLzvzl5ijBxpln2R6zP6v6xBMhYP807tDEIxT6mw2Ht/XMsnrYe8P7NIRvJp4iXYFgu0NuJSvKS1Uu8gzVc+x1Pt/9CAg/RFoBzQa/M8/P3JO6neA/FEIIwT3J4AUPI7aKMrhBdxeTuisgS3bTHfaBnmTGBdaZHwBF4Ob8RwK4q4v5fU8RWIf2Xab4XDMk4FmcGTHrARmEgHfs7zsYqUkTfipUM8O/eA12AKb1rfc+7rBi/00NkP7AuiI/pF6o/fw0C2m/Vx74CiL5n3ZOarjnHo+bMvBeRdYn2qKiEGhVonQYOkuM3brPk4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc4495aa-8520-49f1-d104-08d62ed280cd X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Oct 2018 17:04:56.5901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4209 Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow query failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes a bug found in port_flow_query routine which caused flow query command to fail with the following error "Caught error type 1 (cause unspecified): unknown object type to retrieve the name of: Invalid argument". Fixes: f7ba5e7a0f8c ("app/testpmd: rely on flow API conversion function") Signed-off-by: Moti Haimovsky Tested-by: John Daley Acked-by: Adrien Mazarguil Acked-by: Ori Kam --- app/test-pmd/config.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 009c92c..b11317b 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -1239,7 +1239,8 @@ void print_valid_ports(void) return -ENOENT; } ret = rte_flow_conv(RTE_FLOW_CONV_OP_ACTION_NAME_PTR, - &name, sizeof(name), action, &error); + &name, sizeof(name), + (void *)(uintptr_t)action->type, &error); if (ret < 0) return port_flow_complain(&error); switch (action->type) {