From patchwork Tue Jul 27 10:27:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Kozlyuk X-Patchwork-Id: 96325 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B3F5A0A0C; Tue, 27 Jul 2021 12:27:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA062410F0; Tue, 27 Jul 2021 12:27:41 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2077.outbound.protection.outlook.com [40.107.101.77]) by mails.dpdk.org (Postfix) with ESMTP id 7B8E2410ED; Tue, 27 Jul 2021 12:27:40 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ewf/uYc2vqz+SUYlxiLCt9DXb+5VJOmk33ixY4DVOcKecTmsOzcPlnmHz7e6QErMSQpoyZwtNnuSjtB7TiYw/KqKcXHemO/LlcYzCKGpz/RAurEkjtX6CjGIz1t42SJR0Eyx8/CdXky9wxtFZ0m/y7TKyx0x6zhEtOT780fK+je8KTv92Vgv2Cfd85LizRFirmBvrFaBKQCn9F9WeZv5rsDmEBPJKu5Tl4v6q8avyuV7DjSE7a28rHKrrWGIbjnTy6yvwx8uTfb2GJebt08KLsOjHBIl1kUq9egxLeHAKOFFFFUvIuJ3EvyTEY2eCZDQnANDfU850wA7r/K2wgUDTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQrJhAhZtpMjlsu57Msx7ur5/2OOSaDvQlZNIWM7Jr4=; b=Ewhxj5IXhE5BEShYaYyg3MYDi2ZezwLdMIPtwbUAZ5y3SZnLw+JL/0Znt15L5Uon+derW5OA6uWBjLCZt8FolVU0X/QchCLLcjQW7FD012uD5IAv/GCoU7G3i1IL8WjMc47UoMTwlv6dsqd/W7jw7380SmIjmvjlpg7rStU0IhhCJlkpJvjhHITBzARSG8GoTFa6g9vAE9WFg0xuatKr080Yk751Hw6s2kAkdMjTyQypaH6VcdQ6a/RLuzCwpp3vE1fhLpZ7/iEpx6l4+S6IHUXqOyxJ1W2mK4LLRldZqzDvWZ2xVSLCYehKO9ZPjdQTmw9cxglzZdynONkrtT98Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FQrJhAhZtpMjlsu57Msx7ur5/2OOSaDvQlZNIWM7Jr4=; b=IR1HKfSYc+OgW0ZryF53/MqDfRXKPAwfzCrFvpP/smAlGX+LwXNWlyDhtLh9gltkSrNe5iSO8q4jZQN19R6gAazxNnfgDAlS76twJ4+YCMkvUmL2ofV0SIdWyD1MkDSDy51TuUkJ+pPkpDE548xqW71XKaZELMw6gcehy0sMT0ihV4xpAwIyDy2J+9lHB6s6OES4V7X+WXcWut6v+NqVuTJwGqXUvNMAM0hjLwFXRKq49tw3nx8dgHEXuRhox//+g0uiucZKmIbtfRqpeBtt1/bicsuPpioc1+GclZVwp1DEIoFiJmrku3yhEFjlhLgxqOEjJN6VnPTLcV4r6x3ZuA== Received: from DS7PR03CA0137.namprd03.prod.outlook.com (2603:10b6:5:3b4::22) by DM5PR12MB1241.namprd12.prod.outlook.com (2603:10b6:3:72::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.30; Tue, 27 Jul 2021 10:27:38 +0000 Received: from DM6NAM11FT047.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b4:cafe::55) by DS7PR03CA0137.outlook.office365.com (2603:10b6:5:3b4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26 via Frontend Transport; Tue, 27 Jul 2021 10:27:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; amazon.com; dkim=none (message not signed) header.d=none;amazon.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT047.mail.protection.outlook.com (10.13.172.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4352.24 via Frontend Transport; Tue, 27 Jul 2021 10:27:38 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Jul 2021 10:27:34 +0000 From: Dmitry Kozlyuk To: CC: Andrew Rybchenko , , Viacheslav Ovsiienko , Xueming Li , Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Parav Pandit , Stephen Hemminger , Long Li Date: Tue, 27 Jul 2021 13:27:20 +0300 Message-ID: <20210727102720.902969-1-dkozlyuk@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210616100712.829035-1-dkozlyuk@nvidia.com> References: <20210616100712.829035-1-dkozlyuk@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58f29f0b-f20e-4d17-67f8-08d950e92862 X-MS-TrafficTypeDiagnostic: DM5PR12MB1241: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dKch8WkxSxaYozba6cpV3DuxZqbumqWqFje3wXxbJkb+KhyiCoUizlsWcqpZsr2Ov9ZKPfithiFN6DH730by3PawBRv1bmdtwB5iCvo6hkOnUa6oRpFIyEa3eLVrtWFy6KlbwOjwZ/iUFE6K63W1t4Aj6sJO0UsgFk52E1e9aymebqSH6cFw19Wbh0b7qeVpGNT75+qR00nquaR5ElWG/HlJrbh4kobQ/7NX6yU4rRaW8IZ86/0sEID5BAKbPO2+03BqY2WI+kAcCEKv4ZeGJMzS6FOQSrH0yeMXmkhr3chJTktVFLocszq0DLcT3XnENYOE4mu+gQdesf4w5wIhidG34SH9QW3Jww4eqvSp224wiLyfsEjCABtohWnXboj136KFsN4jYUD5snyrBEeDjA2iARwnd8LHbtcz0ebZ8apwjpdiSEAjp+xuNN6846L8ZVEMyInlNpePGHnu/OU/1U7FMNSmes9X6LcTOaffXdGGf/TQc1h7M1rAxbdOE1TZ0mhnuEmEHePG6Y6OneKbZrreHsTVTTfoLWNcNxlljj/IZ7djct6RoWngpQ7ckl5bIZT7AY6gTCTl6r+UataVn1YFX/EZU3PavKVTRkq3pBBlShwDvCel1SFn4MsxeYrfq1I1yiuO0hdArJvrmY/agr9HYlLpN4Mfg9YzVSBDA+jVmPCI3s9YsKV4Evo3/5dEZYv9QoklkpYQlIW2Dsznaw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(346002)(39860400002)(46966006)(36840700001)(8936002)(36860700001)(7696005)(426003)(6666004)(2616005)(16526019)(1076003)(2906002)(186003)(36756003)(82740400003)(8676002)(26005)(54906003)(47076005)(7636003)(86362001)(478600001)(7416002)(4326008)(5660300002)(70586007)(82310400003)(6916009)(70206006)(336012)(316002)(356005)(55016002)(83380400001)(36906005)(6286002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2021 10:27:38.3566 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58f29f0b-f20e-4d17-67f8-08d950e92862 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT047.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1241 Subject: [dpdk-dev] [PATCH v3] bus: clarify log for non-NUMA-aware devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PCI, vmbus, and auxiliary drivers printed a warning when NUMA node had beed reported as (-1) or not reported by OS: EAL: Invalid NUMA socket, default to 0 This message and its level might confuse users, because configuration is valid and nothing happens that requires attention or intervention. Reduce level to INFO, reword the message, and suppress it when there is only one NUMA node, bacause NUMA-awareness does not matter in this case. Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe") Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support") Fixes: 1afce3086cf4 ("bus/auxiliary: introduce auxiliary bus") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Reviewed-by: Viacheslav Ovsiienko Reviewed-by: Xueming Li --- v3: keep resetting device NUMA node to 0 (Andrew). doc/guides/nics/ena.rst | 2 +- drivers/bus/auxiliary/auxiliary_common.c | 3 ++- drivers/bus/pci/pci_common.c | 3 ++- drivers/bus/vmbus/vmbus_common.c | 3 ++- 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/doc/guides/nics/ena.rst b/doc/guides/nics/ena.rst index 63951098ea..c506fd5bd4 100644 --- a/doc/guides/nics/ena.rst +++ b/doc/guides/nics/ena.rst @@ -246,7 +246,7 @@ Example output: [...] EAL: PCI device 0000:00:06.0 on NUMA socket -1 - EAL: Invalid NUMA socket, default to 0 + EAL: Device is not NUMA-aware, defaulting socket to 0 EAL: probe driver: 1d0f:ec20 net_ena Interactive-mode selected diff --git a/drivers/bus/auxiliary/auxiliary_common.c b/drivers/bus/auxiliary/auxiliary_common.c index 89e653c54e..3891bab0e7 100644 --- a/drivers/bus/auxiliary/auxiliary_common.c +++ b/drivers/bus/auxiliary/auxiliary_common.c @@ -106,7 +106,8 @@ rte_auxiliary_probe_one_driver(struct rte_auxiliary_driver *drv, } if (dev->device.numa_node < 0) { - AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0"); + if (rte_socket_count() > 1) + AUXILIARY_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0"); dev->device.numa_node = 0; } diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 35d7d092d1..b09e42c489 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -190,7 +190,8 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr, } if (dev->device.numa_node < 0) { - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n"); + if (rte_socket_count() > 1) + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n"); dev->device.numa_node = 0; } diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus_common.c index d25fd14ef5..2fdf2c7092 100644 --- a/drivers/bus/vmbus/vmbus_common.c +++ b/drivers/bus/vmbus/vmbus_common.c @@ -112,7 +112,8 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr, dev->driver = dr; if (dev->device.numa_node < 0) { - VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0"); + if (rte_socket_count() > 1) + VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0"); dev->device.numa_node = 0; }