From patchwork Wed Jul 7 16:49:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satha Koteswara Rao Kottidi X-Patchwork-Id: 95513 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30657A0C4B; Wed, 7 Jul 2021 18:49:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E58D2413DB; Wed, 7 Jul 2021 18:49:49 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 689F3413B6 for ; Wed, 7 Jul 2021 18:49:49 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 167GkjOG029236 for ; Wed, 7 Jul 2021 09:49:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=pfpt0220; bh=p29IEBmjJarPjSwbLenngK0DVuLnv0fOdx5+KdtRenI=; b=eZcFmurpn4c/evWUdD7t1AMu+UFDXYfu3dW2/KNLiIFIeInT2iMlSPzxgJzDsTJu1Zd3 aN362Z8kPN74Lb3nMWVZkILB2+dAYZQYqlARG1hHSGheC0zR+HM1Z5fuZUOoghAzrdjI 7HP90wUs1z/MlrsI1iiqOCDXjnnFuN+KIA9wtl40PhQRKdX2ZrinIylpAxyT9rF+cIAn 7Go+MycYZ+dPwLGo8KrKZ/4haDoZq2FYqqFcQAxT2ZfUW88GdKbU4n63ZGpwr/gCZMxt Ia8AAh1dGK5OxoTSW9o0TPULvsDbrru3CSAgwUZovom+d1Mfnv8X1RfYpU+eleUX5sfa lg== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0b-0016f401.pphosted.com with ESMTP id 39nfapr7g5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jul 2021 09:49:48 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 7 Jul 2021 09:49:46 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 7 Jul 2021 09:49:46 -0700 Received: from cavium.marvell.com (cavium.marvell.com [10.28.34.244]) by maili.marvell.com (Postfix) with ESMTP id 051C73F707D; Wed, 7 Jul 2021 09:49:44 -0700 (PDT) From: To: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K CC: , Satha Rao Date: Wed, 7 Jul 2021 12:49:15 -0400 Message-ID: <1625676557-2269-1-git-send-email-skoteshwar@marvell.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: zYPXDz2gJb1prbpNWLG70YeI1zgdHSDQ X-Proofpoint-GUID: zYPXDz2gJb1prbpNWLG70YeI1zgdHSDQ X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-07_08:2021-07-06, 2021-07-07 signatures=0 Subject: [dpdk-dev] [PATCH 1/3] net/octeontx2: handle link status when device stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Satha Rao Set link status to down and don't fetch link status from kernel when device in stopped state. Signed-off-by: Satha Rao --- drivers/net/octeontx2/otx2_ethdev.c | 5 +++++ drivers/net/octeontx2/otx2_link.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c index 84225f4..ac53d8c 100644 --- a/drivers/net/octeontx2/otx2_ethdev.c +++ b/drivers/net/octeontx2/otx2_ethdev.c @@ -2171,6 +2171,7 @@ struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); struct rte_mbuf *rx_pkts[32]; struct otx2_eth_rxq *rxq; + struct rte_eth_link link; int count, i, j, rc; nix_lf_switch_header_type_enable(dev, false); @@ -2196,6 +2197,10 @@ for (i = 0; i < eth_dev->data->nb_tx_queues; i++) otx2_nix_tx_queue_stop(eth_dev, i); + /* Bring down link status internally */ + memset(&link, 0, sizeof(link)); + rte_eth_linkstatus_set(eth_dev, &link); + return 0; } diff --git a/drivers/net/octeontx2/otx2_link.c b/drivers/net/octeontx2/otx2_link.c index 5378e5c..81dd624 100644 --- a/drivers/net/octeontx2/otx2_link.c +++ b/drivers/net/octeontx2/otx2_link.c @@ -148,7 +148,7 @@ RTE_SET_USED(wait_to_complete); memset(&link, 0, sizeof(struct rte_eth_link)); - if (otx2_dev_is_sdp(dev)) + if (!eth_dev->data->dev_started || otx2_dev_is_sdp(dev)) return 0; if (otx2_dev_is_lbk(dev)) From patchwork Wed Jul 7 16:49:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satha Koteswara Rao Kottidi X-Patchwork-Id: 95514 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CDF3A0C4B; Wed, 7 Jul 2021 18:49:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 067C341400; Wed, 7 Jul 2021 18:49:59 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 459DD413EE for ; Wed, 7 Jul 2021 18:49:58 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 167Gj1T0026758 for ; Wed, 7 Jul 2021 09:49:57 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=9PwsJXLBrtQLC6Mg7TsHAxhEkncoW5NSeFKuiKGYc14=; b=Mo5JO2UMbaGewZi3dotitTIDebOkjYYDBQCLOR1bSJR8bkcX7qicxOj1MW1jJ+39Pt3d q29ubw7RdC/43Hjq84jIV9UXwSjiICkGmKoVuoMS7M9M3utF2epGJ+2qkAQQlJf6moMH VQlHAj5WeReRVMEm2wYaF6Xc+t7uBbyzxLpupMQFqtt28oOj//skzWBrKpfBcTyxFYr3 3LD4f08T9m2uNZ73FR5+LfWcgjlHwprnaVIWL1wgTvKTKAcag/ou8h0DrLBzyo3TmfeU 6buCGhvHpJ2utLfwuW/N+B2YqyS1FfzxGoP9bSGTgTEgPqdcCoWZ0bBGigVinQ/jJWC4 JQ== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 39n5tg2s43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jul 2021 09:49:57 -0700 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 7 Jul 2021 09:49:55 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 7 Jul 2021 09:49:55 -0700 Received: from cavium.marvell.com (cavium.marvell.com [10.28.34.244]) by maili.marvell.com (Postfix) with ESMTP id 718073F707F; Wed, 7 Jul 2021 09:49:54 -0700 (PDT) From: To: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K CC: , Satha Rao Date: Wed, 7 Jul 2021 12:49:16 -0400 Message-ID: <1625676557-2269-2-git-send-email-skoteshwar@marvell.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1625676557-2269-1-git-send-email-skoteshwar@marvell.com> References: <1625676557-2269-1-git-send-email-skoteshwar@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: AIpoW4PPdRaGIdh1iH0xEnN_6id0ahyN X-Proofpoint-ORIG-GUID: AIpoW4PPdRaGIdh1iH0xEnN_6id0ahyN X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-07_08:2021-07-06, 2021-07-07 signatures=0 Subject: [dpdk-dev] [PATCH 2/3] net/octeontx2: get tm node stats after resource allocated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Satha Rao We are getting kernel crash while reading tm node stats when tm hierarchy is not committed. Until hierarchy committed hardware resources are not allocated for node, this causes mbox timeout. This patch check for status of HW resources before reading statistics. Signed-off-by: Satha Rao --- drivers/net/octeontx2/otx2_tm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/octeontx2/otx2_tm.c b/drivers/net/octeontx2/otx2_tm.c index fdd5669..6aff1f9 100644 --- a/drivers/net/octeontx2/otx2_tm.c +++ b/drivers/net/octeontx2/otx2_tm.c @@ -2769,6 +2769,12 @@ int otx2_nix_sq_enable(void *_txq) return -EINVAL; } + if (!(tm_node->flags & NIX_TM_NODE_HWRES)) { + error->type = RTE_TM_ERROR_TYPE_NODE_ID; + error->message = "HW resources not allocated"; + return -EINVAL; + } + /* Stats support only for leaf node or TL1 root */ if (nix_tm_is_leaf(dev, tm_node->lvl)) { reg = (((uint64_t)tm_node->id) << 32); From patchwork Wed Jul 7 16:49:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Satha Koteswara Rao Kottidi X-Patchwork-Id: 95515 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50E1FA0C4B; Wed, 7 Jul 2021 18:50:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34730413EE; Wed, 7 Jul 2021 18:50:09 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 82606413B6 for ; Wed, 7 Jul 2021 18:50:07 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 167GihVc026528 for ; Wed, 7 Jul 2021 09:50:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=pfpt0220; bh=nCOj6wWvA7ziwl/l4P1KUVzWGuAMgLJBL+QJxmnVLB0=; b=Z3v3YVYYHQmb1bVyBeOqMLc3qXZRlbr3FcngRddUkdvHFYqF+h+jPlATPKx8YSSrT/vY iXa64B583HjCPpInI2TGFOfSJkQqMWbFWLf1ao/b5esxBPfMqQ5qBUyBm0BvEG/g5crf CKwJk343Aa/IlqrFIkY+kV6Oqp2E7yMG7V2MapPDbguPM2VkPPplsFKbrf8/G5eE3zjo LSf9gRKbEavAmYOekSO7RMUs+BG2URdVgQiTxh+1Pf1IWVm1KfedEs+innezrdTEcn0h y1aIRNDjqisTTkaJ16C7VwDgb1vFRIrUE0Md+sr38OY6UzU5AGQYVWCSTn7zCH/apan9 xA== Received: from dc5-exch02.marvell.com ([199.233.59.182]) by mx0a-0016f401.pphosted.com with ESMTP id 39n5tg2s4j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 07 Jul 2021 09:50:06 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 7 Jul 2021 09:50:05 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend Transport; Wed, 7 Jul 2021 09:50:05 -0700 Received: from cavium.marvell.com (cavium.marvell.com [10.28.34.244]) by maili.marvell.com (Postfix) with ESMTP id 96D943F70CF; Wed, 7 Jul 2021 09:50:01 -0700 (PDT) From: To: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao CC: Date: Wed, 7 Jul 2021 12:49:17 -0400 Message-ID: <1625676557-2269-3-git-send-email-skoteshwar@marvell.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1625676557-2269-1-git-send-email-skoteshwar@marvell.com> References: <1625676557-2269-1-git-send-email-skoteshwar@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: XX_WzqtlgzpGaPtiqwf_VpoxvpghyAPj X-Proofpoint-ORIG-GUID: XX_WzqtlgzpGaPtiqwf_VpoxvpghyAPj X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-07-07_08:2021-07-06, 2021-07-07 signatures=0 Subject: [dpdk-dev] [PATCH 3/3] net/cnxk: update link status when device stopped X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Satha Rao Set link status to down and don't fetch link status from kernel when device in stopped state. Signed-off-by: Satha Rao --- drivers/net/cnxk/cnxk_ethdev.c | 5 +++++ drivers/net/cnxk/cnxk_link.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 7adab46..0e3652e 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -1096,6 +1096,7 @@ struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); const struct eth_dev_ops *dev_ops = eth_dev->dev_ops; struct rte_mbuf *rx_pkts[32]; + struct rte_eth_link link; int count, i, j, rc; void *rxq; @@ -1128,6 +1129,10 @@ for (i = 0; i < eth_dev->data->nb_tx_queues; i++) dev_ops->tx_queue_stop(eth_dev, i); + /* Bring down link status internally */ + memset(&link, 0, sizeof(link)); + rte_eth_linkstatus_set(eth_dev, &link); + return 0; } diff --git a/drivers/net/cnxk/cnxk_link.c b/drivers/net/cnxk/cnxk_link.c index caf35ee..3fdbdba 100644 --- a/drivers/net/cnxk/cnxk_link.c +++ b/drivers/net/cnxk/cnxk_link.c @@ -90,7 +90,7 @@ RTE_SET_USED(wait_to_complete); memset(&link, 0, sizeof(struct rte_eth_link)); - if (roc_nix_is_sdp(&dev->nix)) + if (!eth_dev->data->dev_started || roc_nix_is_sdp(&dev->nix)) return 0; if (roc_nix_is_lbk(&dev->nix)) {