From patchwork Thu Jul 1 06:39:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 95093 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1500A0A0C; Thu, 1 Jul 2021 08:40:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FD7F40141; Thu, 1 Jul 2021 08:40:02 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2059.outbound.protection.outlook.com [40.107.223.59]) by mails.dpdk.org (Postfix) with ESMTP id F257440040; Thu, 1 Jul 2021 08:40:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z5qFtOrGaU8JVnCv6RkbtVp+vYa8j3wYfQznATCEfu3UCjHBij5zbOYFdT5QJDgcywYJSg+CtLyhWNQw2Q0ruetP3Auf/VPLJbeTzyEbcT/FQAXWxaifnnVnGX87nNnEV4xr2x81vdcdM2wsUZBky0CSHI2KBOO+kID7w0y37N+/L97aLP0/yq6rMKf9cy/AObgCCXulIwujhr7zYO9uDN+eImMd1JDiWJ7QxN55WxaFbCgTxVgftpnPu+P2wl+hNtBjd5G3eKy53/uAyU2Ro3aGy2XZ8FzQLWYLfXd6gUsVH9GwG5LWw8T0frGRo9rE8iBWNHVLHyEcj8BqAOIpRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YppqctsSU7JawQv3SXiDwXJ86ACRPknsKZK+oXPgW5g=; b=Hhbn6pXHqorstAPcQqV7uqg5LFdESWiJ0o+IkXk4JShR8yxth95uI4u/fX5xvoAhGn2P4mU4OgushlLY72yTEFv5lPTo7DnmyC609oLdvQDFcKgh9dIVelQJfIbkgSX7DCvbOYwU73qu5m8uXdStdhArYVcGPUSHjXt6d+DVN8opE31zvBOGoXsj32zfgAZgfMNmmfDsloS4DP2aryhOIDcB/+oNTjTMKQkA6kQgdzqHZEHC6WmtA3uT1JRBgaI5sRkXcgRODFdjS+8lvqIW7FUZQy3YCsoe6dYMVfLZgsw7AvM9+SgtT6FeCdyuf2hSetsa6AXVbjsPz+ztMvkS6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YppqctsSU7JawQv3SXiDwXJ86ACRPknsKZK+oXPgW5g=; b=ViMXLIb4FBhmL5A3IKgNzCGlRKRYpH5YpPsp3DxA4W6xnExMAUxXeDxkX/bczanv12iFxBb4VPck/1HofJgRyD4XWOEmtkpB+/C53DCXJS3MoA8XcP26L76Y6wfVzwHbXe0pFHQTNHTGccaRFLqj6gO3lYptTgrjOhEHn6fWG5PY5VZ+q+Vl6il4WAmQoShUBIorf/fYR7WgsGdI6l+8LddXmWencC01zjDvjfW8ICA57CiFh+C05kMtvwmqmt2IN/XXq6X2C6zhRIysSdZRxZqonlgEb0/6hZYHaStudT1Cm+BDh3fdrkdYpqNbepuTIgHZe4E0aDerTzl8egIezA== Received: from MWHPR17CA0088.namprd17.prod.outlook.com (2603:10b6:300:c2::26) by DM6PR12MB4300.namprd12.prod.outlook.com (2603:10b6:5:21a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Thu, 1 Jul 2021 06:39:59 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:300:c2:cafe::2c) by MWHPR17CA0088.outlook.office365.com (2603:10b6:300:c2::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Thu, 1 Jul 2021 06:39:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 06:39:58 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Jul 2021 06:39:56 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Thu, 1 Jul 2021 09:39:13 +0300 Message-ID: <20210701063916.2016763-1-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210601071122.1612432-1-michaelba@nvidia.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dbfe820-8ba8-4667-5c6e-08d93c5b0bbd X-MS-TrafficTypeDiagnostic: DM6PR12MB4300: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HuqWYiwJXYo6QtZi3ECzImZ9EaA6vmTrxh83HolgMLuDsQl38Szva05KY7RmBG/eD5Js3RmDSXweHZYXvb9M3bOMNpGD8Y27QKiPjOAlppkmAzJAACMb9RO+BB7C7yHFqtpT6W1WVpX9g6SWyl6OorCwr0e4Gzwy9pe1aBc0/UwhbAXhqdRvV2qGxaWjD/oSmj36kvd0XJ7zfGwE/bSGqDMDEGnRD4uwlTJPZ/liZriR0wAdf5GOV02qmarDdTX0aCuVgDhg8i5xNisf2wGAgeBrOV2y7DwbN57bwv+KjwTgEpQryxe5aayNEj88rJ1tO+6lwdMqjX+Z2sfDLcVf7/Vi4aBkbIyJPLuqBH8gxnaPbQi7SAmkNn78X/UXd8lEnEB16Cm+QowcX8fLP1a53hVlSuJupGCC+yRHZyKfr4aA4f/wwDxLW/NGPu0vDKaAtB/ExtnzV75NTWtnbQQClgsSGg07MphuPYmvpHU3Gr4ygHmSAxrX2egYGLnDPCbQPsEcU2E9vjcQWF67rBsRlrKs2v6uOAtZaqN1W6G5OXzzblDTAAcS9yM+muzYLQErUK4QGZInl4d0nc3qGF6M2iqNKpwPDFHXE7qDAI5e0MyV08vSR7dIQa/P9zDACGn3KJcoIDfYhIlF9VJcJdN0rEF7eHkqLwKCgK6tTcLTzSVFYVCRn6NJpV4Nq0JoHdk+Mu5qBtFHzowSfZViPeu5bQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(39860400002)(376002)(36840700001)(46966006)(478600001)(450100002)(82310400003)(36860700001)(70586007)(356005)(6666004)(8936002)(316002)(4326008)(47076005)(7696005)(6286002)(2906002)(70206006)(5660300002)(36756003)(1076003)(83380400001)(186003)(16526019)(86362001)(54906003)(8676002)(336012)(26005)(426003)(55016002)(7636003)(6916009)(82740400003)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 06:39:58.5146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dbfe820-8ba8-4667-5c6e-08d93c5b0bbd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4300 Subject: [dpdk-dev] [PATCH v2 1/4] regex/mlx5: fix size of setup constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The constant representing the size of the metadata is defined as a unsigned int variable with 32-bit. Similarly the constant representing the maximal output is also defined as a unsigned int variable with 32-bit. There is potentially overflowing expression when those constants are evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type size_t that might be 64 bit. Change the size of the above constants to size_t. Fixes: 30d604bb1504 ("regex/mlx5: fix type of setup constants") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- v2: use size_t and uintptr_t instead of uint64_t. drivers/regex/mlx5/mlx5_regex_fastpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex_fastpath.c b/drivers/regex/mlx5/mlx5_regex_fastpath.c index b57e7d7794..910bc845f3 100644 --- a/drivers/regex/mlx5/mlx5_regex_fastpath.c +++ b/drivers/regex/mlx5/mlx5_regex_fastpath.c @@ -25,8 +25,8 @@ #include "mlx5_regex.h" #define MLX5_REGEX_MAX_WQE_INDEX 0xffff -#define MLX5_REGEX_METADATA_SIZE UINT32_C(64) -#define MLX5_REGEX_MAX_OUTPUT RTE_BIT32(11) +#define MLX5_REGEX_METADATA_SIZE ((size_t)64) +#define MLX5_REGEX_MAX_OUTPUT (((size_t)1) << 11) #define MLX5_REGEX_WQE_CTRL_OFFSET 12 #define MLX5_REGEX_WQE_METADATA_OFFSET 16 #define MLX5_REGEX_WQE_GATHER_OFFSET 32 From patchwork Thu Jul 1 06:39:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 95094 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F7B8A0A0C; Thu, 1 Jul 2021 08:40:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89B79412A4; Thu, 1 Jul 2021 08:40:04 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2089.outbound.protection.outlook.com [40.107.95.89]) by mails.dpdk.org (Postfix) with ESMTP id 2A2B84129C; Thu, 1 Jul 2021 08:40:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ebx1ysy6/Tzwl1Xr2vHednXAYHMHNnjT4eGK9AKqmue1PQUz9FvmiQblEvVaJ+UnMUbFIM3hXeNaLpiTY26qNypaMRsuLS5G4qRZoyMXBSfH+3kmYYQ3qcvp6ZMkLyk41OSgHT/fymvsQ3u3IHxBlSSOiBvdyErrYzPQgkhlFWEozEZINHDSTgvKk4JP9V6KtwzZmw+o0F8UZt79ZLQXu+unvcEcUucw21fyqVI4nQSZ5A7e7y/bVF1tn3gjav1HJqPSkDaG3xznz/KZjXCe11EDB+Cn6QH5V4C0lJmX5klDzyQplZ8b9QRJthU7q39q8btadBkdAQJB1epk0dyO8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DAV6b7bXyxY/N+9gYvVZOJXfPnzsebSswtX99+8DMrM=; b=Irbq/QjgqmhEiVY9siOABX9fFypNUyIPhwQ8DdBuuWeZd/Fc1V5JddQBeE3BzIm4B5lp/wUklzTv0LofEBwCTyPgqxV7WizcxBJC6Cs5bmil5yy7oeRU+Hqg7ANBv37Yvf/qdSqh47z/FSE8moxSuTsnACZk+DFDVilPS4A+3K9OMoo11OxT+kKGIRLLU96/CRaJE4wUWUkpnN+7acTzZwoq9Evzz26X4RYpLXQz5cyU+ni14uPczePXHkac1DS3nRJ5Oc+JEw96jtziquTSntpJ1M5/0nLEAu/hOnoH4P9GpaSkHbN/BF29i4gWbdOwTmX+kCj7zuPT+1ywfJ3eDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DAV6b7bXyxY/N+9gYvVZOJXfPnzsebSswtX99+8DMrM=; b=TpsDaW282CojKxhwVOgZHEvrnTz1YdWiI3Kr5gHE6ulyqQ7L684UuKlIB0rceIPnv/jOToLX1bHprmnwbn2Ae3wU503cQlBkASFDO2sdGXES/pXbqJf7xeIf4/ld6sbG3ZROe3wRqdLVnbtT8bmkxqoL+210JbVjpo5Au8PSbt+XuDPAqpTLVTeAuVCMgwJzLV1YCHXNS9bu5mQBPD0dHD1NiRNqnxmplRy6ubEcp59ibSUBZ32z/x+mFVDDUz9ADOFviwWScI1W+Hw9iRMTSWO8yoPw/4WdZ7AzF48lcHowcMPtU3xUeWJRTuBktfvhRl9lhC2kpZyTH9P7F3WLEA== Received: from MWHPR17CA0095.namprd17.prod.outlook.com (2603:10b6:300:c2::33) by CY4PR12MB1255.namprd12.prod.outlook.com (2603:10b6:903:36::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Thu, 1 Jul 2021 06:40:01 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:300:c2:cafe::43) by MWHPR17CA0095.outlook.office365.com (2603:10b6:300:c2::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 06:40:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 06:40:00 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Jul 2021 06:39:58 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Thu, 1 Jul 2021 09:39:14 +0300 Message-ID: <20210701063916.2016763-2-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701063916.2016763-1-michaelba@nvidia.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210701063916.2016763-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 746a46c2-e425-4ebd-d28b-08d93c5b0cca X-MS-TrafficTypeDiagnostic: CY4PR12MB1255: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BtMFNl/lANoz0wJGtT5q9m0/zdW0xwOtgdgD7436K2sY0X/Eh3eeN4UW85RMRubiR6j4TiyqS1HVvF61Oic5sPxlEPE64ur65tLYwGqxyHKfkGMl/JA4h7aEiIY3u7faS1sgv/D/klYILNpgDoOpAlzkCoVW/SRJGyiJKijot2ZGRF+LmVrgQX3/MFlTTho97Sl9NAqc32OicTigYvYn/xrAE0dCCebZYCRy1n6Qrk97ViANy0YBosaBU9IBKleyTCf3gmbQKA6wz/fmH51Nx7Hy4mhIrKSCUbJb3qTRd6fwV9MbtKfd8Zo9mfBxrdep2GhiT2sH1SmmJXrj3J4OmYE5y8cvWkfONURaAlk8AHgX2ce2CWYfJrgBCSXb5IqCTgpGXPOSFfdp1AVpKnHmsTNI4vfvqIW4OMajHUe4wD5LwQspxWc5lj1t8KOVdPt2bxoAxMfkx/u1L6yZicHqEZ/sYXo3XGWzakvbVOjVv2V4BO2KX+yV4FNs0jwohPajyMNzicc7Fsg3upJtfTwLxRDGg0PbKx9fqPcI8/Ys9xItYNJMbd/wblIspMNufthfSzn9cgX573wW1PzMr4+d7mMS1YF5QwU7ehQr1TZcc26lmwRPaHVCkmv0VKDXHsVP+b3HVR37Pswne0Ocf7nkK1dKRWr/lzEM9EPo9g+YFY4FcFmj8cSidSMguYoDlK0lrG1dkQ46YRXZl31Tdg/x9w== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(7636003)(83380400001)(54906003)(356005)(6666004)(26005)(7696005)(36860700001)(5660300002)(478600001)(1076003)(8936002)(2616005)(55016002)(6916009)(186003)(316002)(16526019)(86362001)(82740400003)(6286002)(8676002)(426003)(47076005)(70206006)(2906002)(36756003)(4326008)(70586007)(336012)(450100002)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 06:40:00.2765 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 746a46c2-e425-4ebd-d28b-08d93c5b0cca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1255 Subject: [dpdk-dev] [PATCH v2 2/4] compress/mlx5: fix constant size in QP creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5_compress_qp_setup function makes shifting to the numeric constant 1, then sends it as a parameter to rte_calloc function. The rte_calloc function expects to get size_t (might be 64 bit) and instead gets a 32-bit variable, because the numeric constant size is a 32-bit. In case the shift is greater than 32 bit and it 64-system, the variable will lose its value even though the function can get 64-bit argument. Change the size of the numeric constant 1 to size_t. Fixes: 8619fcd5161b ("compress/mlx5: support queue pair operations") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/compress/mlx5/mlx5_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c index 80c564f10b..f09f71ecd6 100644 --- a/drivers/compress/mlx5/mlx5_compress.c +++ b/drivers/compress/mlx5/mlx5_compress.c @@ -209,7 +209,7 @@ mlx5_compress_qp_setup(struct rte_compressdev *dev, uint16_t qp_id, return -rte_errno; } dev->data->queue_pairs[qp_id] = qp; - opaq_buf = rte_calloc(__func__, 1u << log_ops_n, + opaq_buf = rte_calloc(__func__, (size_t)1 << log_ops_n, sizeof(struct mlx5_gga_compress_opaque), sizeof(struct mlx5_gga_compress_opaque)); if (opaq_buf == NULL) { From patchwork Thu Jul 1 06:39:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 95095 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE3A5A0A0C; Thu, 1 Jul 2021 08:40:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B71B412B5; Thu, 1 Jul 2021 08:40:06 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2068.outbound.protection.outlook.com [40.107.95.68]) by mails.dpdk.org (Postfix) with ESMTP id B8839412A8; Thu, 1 Jul 2021 08:40:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FdyJZTKmCH9UB0k66UD6F44DPbsS8uVP1vI1/xeghLHuwnABOe2GJxLBbB5YWTQrNNQFAN7SVSGyzjf57jQwPKCHbCNtzVUch7IC1DAdqp6RBh7IbHOasSsHy8fUsuGp1N7oYItvIsCMbnPZaPlH00HuCoILIl5qfXGiI5lMQTIaefc2Z8XmCHIHUvwg+BhJbLnBQdnC54tmA5E/3LNEDrKTS88XEEapZh5WGgTLH/dH/OYafFGO6UQ30wq7IalApHGLRxHwrmgrZdc3er0NEzpwDZN0wLQ2OFgwt3HnlJPcjeUh/mvXyaJRc7sPi66AWxTwPj6NAFDMtZdioQLCgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMoEMLCY1WUF0dg/GO0QEn3cHzjzwALGXw55jTfKD00=; b=j3bMYZj4ENcq+j3dYHixDiYvg0lgyBysidcsQdtgYMlKY8PAJ9dtvHuRTr71Il+Mm2vONvC/TSW9++/9+c3D8jIabWUUSCm7karT2lzp080XAA8G4aa5+pfpBcHl4lWNev09bQvmTxZv82+f88GEshbNTj2f4xOwXfG+Uu4GA3dNuab079iOyPOfhVy/rfst+ZCLfUL9IbHQqtGooQBi+Eqz+Y2FoaCPfFAatJ6rtTx/+GgovFHcLe/TkzwZ0QmRWeDv+UhMt9zVj4yNLxvceCDhmBf9CsR1ujhhwtOxXHLQc13KdOFh4pbmy9ae6pxU0cU1gmg2bPM1cu2en8wlMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iMoEMLCY1WUF0dg/GO0QEn3cHzjzwALGXw55jTfKD00=; b=NbxIVusUSF1bO4P1PahOpOgjxhMmB4vSEN4OiqbdlQEL3gZDFeXCmNaUe4KKaMxvMsoKe0O/ag+sZyAu3sIS1Alpk3diydFceX761QheBhH/bUpywpw/Ps3TiAzHDIn4IPU4FjtksVZUAL524BdX1MmbuLbaVU2aowSbq6ojFqXrXqeflxj9bEHoFo9nfrMf5CfpgRgWE69/fKVQCSD5XrkoS7drhlrJIyTXIazG5F/s1pzvjDmNhWA0UC0O7SZO2oEkdpO+mW4fghodlA45W/lF7oTPRhRaNZ4XzqB0f2loVZmGPeHF4nqy1VRhAIdN8WKDu+/nC5C4c1VPn30umQ== Received: from MWHPR17CA0087.namprd17.prod.outlook.com (2603:10b6:300:c2::25) by DM6PR12MB4894.namprd12.prod.outlook.com (2603:10b6:5:209::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Thu, 1 Jul 2021 06:40:03 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:300:c2:cafe::9e) by MWHPR17CA0087.outlook.office365.com (2603:10b6:300:c2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 06:40:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 06:40:02 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Jul 2021 06:39:59 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Thu, 1 Jul 2021 09:39:15 +0300 Message-ID: <20210701063916.2016763-3-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701063916.2016763-1-michaelba@nvidia.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210701063916.2016763-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 85df34fe-ae5f-434a-08b0-08d93c5b0e3a X-MS-TrafficTypeDiagnostic: DM6PR12MB4894: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jwS8YSAnm60pCB++QalICUqibVV3y2bLnHeJqhTJgDDJtDuvw8qe836rsjm6AmsLXngJ4AvsRhN1CQNL8K24LT2NmxGwnocqjdKBNsW5zp1MMtMaTnBcIuM5tht6bYLAmAyIuOetCL61cXZt991DTW2yjqSlLG/8yVvCkqeXl4QtAeThlnOzh4ztCDlhK5sPaWs6iPhrgGTJJoskHq679RCrc/IRd1XjF6v/9/I6Ruvyo2SGAVnMOYWCyUveWlNcivEs8WTP1Z8bcMIKf9uWaIeA9K6XROOvg9khz8VwGeUN7cmziudr/uiiuw2N2H1AoiSf9sz1XOdvpBN3SaV+1kFfOdGbabP4oLfwodZwgpES4IiOCrcMCFE+JL+u/TibdUvOAIipjNd7s7Y9433I/kcAGkQOrpAWGcUb5EgeywLfOc6BY8JcfZ9fY1Yh9w9Ufx0vJvHbASkrowJm8r9ZQZMrj66pu4OABpJ0tsbZQsFmIiBS7Nlc13U7Vc86vIYEfvCEDPneiVbCd/24Wg9FrDwPea68riEhhjKHAevkq3/GdShP86+/QXq+ACS5AV249zueTHNqi9q25mK55r833QkFtOX1aOPGkfhGpGXowXJnOCRIl+w/Mys9hEPW4HYORwj0PutUX8W6+JCPfIrB+Vc2P4t4z3gVcZsa2Ex8PUAawndAkiuHZ/cRZyEKjhK6HJl4E8y24QudkRaT1s1JGg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(36840700001)(46966006)(336012)(426003)(6916009)(7696005)(316002)(7636003)(5660300002)(356005)(70206006)(70586007)(55016002)(2906002)(54906003)(6666004)(478600001)(4326008)(26005)(82310400003)(186003)(83380400001)(16526019)(8936002)(1076003)(2616005)(82740400003)(86362001)(36756003)(47076005)(450100002)(6286002)(8676002)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 06:40:02.6891 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85df34fe-ae5f-434a-08b0-08d93c5b0e3a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4894 Subject: [dpdk-dev] [PATCH v2 3/4] vdpa/mlx5: fix constant type in QP creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5_vdpa_event_qp_create function makes shifting to the numeric constant 1, then multiplies it by another constant and finally assigns it into a uint64_t variable. The numeric constant type is an int with a 32-bit sign. if after shifting , its MSB (bit of sign) will change, the uint64 variable will get into it a different value than what the function intended it to get. Set the numeric constant 1 to be uint64_t in the first place. Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c index 88f6a4256d..3541c652ce 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c @@ -629,8 +629,8 @@ mlx5_vdpa_event_qp_create(struct mlx5_vdpa_priv *priv, uint16_t desc_n, attr.wq_umem_id = eqp->umem_obj->umem_id; attr.wq_umem_offset = 0; attr.dbr_umem_id = eqp->umem_obj->umem_id; - attr.dbr_address = (1 << log_desc_n) * MLX5_WSEG_SIZE; attr.ts_format = mlx5_ts_format_conv(priv->qp_ts_format); + attr.dbr_address = RTE_BIT64(log_desc_n) * MLX5_WSEG_SIZE; eqp->sw_qp = mlx5_devx_cmd_create_qp(priv->ctx, &attr); if (!eqp->sw_qp) { DRV_LOG(ERR, "Failed to create SW QP(%u).", rte_errno); From patchwork Thu Jul 1 06:39:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Baum X-Patchwork-Id: 95096 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BE2CA0A0C; Thu, 1 Jul 2021 08:40:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1E678412AA; Thu, 1 Jul 2021 08:40:09 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by mails.dpdk.org (Postfix) with ESMTP id 37D7D412AA; Thu, 1 Jul 2021 08:40:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtQnCOU6YY/q8HlauIrK3OUPHY5ARujNAglt9Gpz0Hc3QcvfZVLJQChFMrKWiy/lFalVwEShmgz19n23Zn/IWZ1sK2GEek2rl+JABQ0sWf/aaKTi2kQRMEtc2KmLT/VyXdadAGb6hZ8KYyJpGzqfHZT5APGqPVLanvnBduoN2JxgAp1PNwI4XIgpDePsfNOsCM5BZS0+iveZDBI2aohAYIoYaOAsMfDHB8I6KxuIhJDNP6uYPZ+5WPaoz1F3CAVj57byYEZ+i2uIYFB7D5KqzZ0tJ01EkSMKa56QhGnEbPK7NDrq8TpEaFoB0wtJkkGkjb4QVVuAtM1zFdVW65Fqrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YR+Lxwu5LnM+r9Yn01OUXBv/yLRZOgRmKXcYLxJRaTY=; b=QVK+A2H74lPkIpq1iC62RtxiWkuilTY2kh29wBew4mTk7MVR7L6eqLklYKHAwIFrSi5lwNuMo6xroz8J5msDTrTQv0TzstkTTqBgjtMuLPja0/9B6Kll3rmlR+foSvRZdYn/BRC3vHY+8bPXVwYSZgdosajCNocYj5TFzhSdFntN/JLCLZwgIdp9zzpA/xYpOdG9dTMJSjbLtbMu9oyHloxEpaDzjgHb1GDU5lK6CEboJCASQy7nl5CbJnZ9gxSD6GZi/Yq26faZ6o0gLZDuo7oiktCqR0TwjDoRFmN8GLz28LmVqx17evp8QDY/9ZPyRMwS937ZS50mRCWZaJWObg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YR+Lxwu5LnM+r9Yn01OUXBv/yLRZOgRmKXcYLxJRaTY=; b=T6MSvtjTufTBiyvzMLDtJOw76AoOnOGNbT24B49GCFP9tOg3EeEMgdQd6g5LmRlieIlqgwqntZvJLifXFg+J+f8FSvCAV7naK+dhx30XCVogPxMlSABly0YVCvSqpqAtTmYYWdwkkRo3SmkAzA39IkMPFQq9xo3vVvVkcg6/C3JarGI7xLYVHdineq/83aIjOOvx0N8VjCsskCHFjdcmOSRUuP68EcDYajcAkWgSF/tlxguFSLd58YZ1b2mChZ6JbOx31havJ7ohczZ+lempVqpPcBWvWMgZWAJAi7WEyfaZPxSKOoZVnRHTD8sdCSj33F75HeSk3HFsiFxnNCM9pg== Received: from MWHPR17CA0083.namprd17.prod.outlook.com (2603:10b6:300:c2::21) by SN6PR12MB2637.namprd12.prod.outlook.com (2603:10b6:805:6b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Thu, 1 Jul 2021 06:40:05 +0000 Received: from CO1NAM11FT056.eop-nam11.prod.protection.outlook.com (2603:10b6:300:c2:cafe::8c) by MWHPR17CA0083.outlook.office365.com (2603:10b6:300:c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Thu, 1 Jul 2021 06:40:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT056.mail.protection.outlook.com (10.13.175.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Thu, 1 Jul 2021 06:40:05 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 1 Jul 2021 06:40:01 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Thu, 1 Jul 2021 09:39:16 +0300 Message-ID: <20210701063916.2016763-4-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210701063916.2016763-1-michaelba@nvidia.com> References: <20210601071122.1612432-1-michaelba@nvidia.com> <20210701063916.2016763-1-michaelba@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5074f901-c9c9-4f18-ce3e-08d93c5b0fa6 X-MS-TrafficTypeDiagnostic: SN6PR12MB2637: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDdqoi93hZlgfKFWUWm8EoDWXDG6a9t7AGcOfay47fpI4O8KziU2Nl6bwswEP5FbR3n37Cj8b+ckvk6YcK5kfv/w8L4/8QHCVcXixYgLh33ZhA2Me80E3hfUJzH0IxooroDrex/kkdK2DrLPlxUiMmXLx4wBOjDYw0X+6puJiHf6dOysY4B3TfQKAaEpPFBY/A9MIJg0QaliUv6EpZ+AQbfNm46qOED9D+nL/FhVVndA/uGfEyePC0owcefo4bc21K/IhX1yxidEBhKDJH5geCKqFNv8pSaEYnzNuHonJSzPTj35Gw0V5ait+vEkaPADMyUZzzDieo75sApoAKoPaT6sJuWLk4CfmRHaI9w6QATU/nbadvkNfRcuWIP9tOLw4yTTAJ1BcQcgl+Rr4bAT8GwOHh5Ms/FAebrVtqJRxW7FT3x6/QuS3LvrwW+ooP/1+7c66OfpJC6UQL4J6He2jWZ42ptTJaqYcsB/aNh7RlfO38xyRxjSO3lIPtoRt6v/N6k3aW+0HE94LHy1v2O5Oae9zLIRqL3ctXBIix+re2zauAsPPOBVVp3PLzWPOYyJhsv8mAhiQ0FQGhqOGATe8UcktOa/qMSlLPgFW7zhAPxoQdaWO4hgKqxuyUulKR0YDBbxk1+mQPsXR/3ingWHvQCu8GSw+gL/pWm5j7uJDxSjTZ/cmbXYvNBE3d7+5EiCZQUbCiHB8pCsU/DI8UjKVA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966006)(36840700001)(8676002)(6916009)(70206006)(54906003)(36860700001)(426003)(70586007)(316002)(2616005)(4326008)(450100002)(86362001)(1076003)(5660300002)(82740400003)(2906002)(6286002)(336012)(55016002)(8936002)(7696005)(82310400003)(7636003)(36756003)(47076005)(356005)(6666004)(478600001)(186003)(26005)(16526019)(83380400001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2021 06:40:05.0817 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5074f901-c9c9-4f18-ce3e-08d93c5b0fa6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT056.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2637 Subject: [dpdk-dev] [PATCH v2 4/4] net/mlx5: fix constant type in MP allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The mlx5_mprq_alloc_mp function makes shifting to the numeric constant 1, for sending it as a parameter to rte_mempool_create function. The rte_mempool_create function expects to get void pointer (uintptr_t, might be 64-bit) and instead gets a 32-bit variable, because the numeric constant size is a 32-bit. In case the shift is greater than 32 the variable might lose its value even though the function might get 64-bit argument. Change the size of the numeric constant 1 to uintptr_t. Fixes: 3a22f3877c9d ("net/mlx5: replace external mbuf shared memory") Cc: stable@dpdk.org Signed-off-by: Michael Baum Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index bb9a908087..83ee8ddb9c 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -1240,7 +1240,7 @@ mlx5_mprq_alloc_mp(struct rte_eth_dev *dev) snprintf(name, sizeof(name), "port-%u-mprq", dev->data->port_id); mp = rte_mempool_create(name, obj_num, obj_size, MLX5_MPRQ_MP_CACHE_SZ, 0, NULL, NULL, mlx5_mprq_buf_init, - (void *)(uintptr_t)(1 << strd_num_n), + (void *)((uintptr_t)1 << strd_num_n), dev->device->numa_node, 0); if (mp == NULL) { DRV_LOG(ERR,