From patchwork Wed Jun 30 07:04:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 95041 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72EA3A0A0F; Wed, 30 Jun 2021 09:05:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FA6B41236; Wed, 30 Jun 2021 09:05:18 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2054.outbound.protection.outlook.com [40.107.94.54]) by mails.dpdk.org (Postfix) with ESMTP id 488CE41235 for ; Wed, 30 Jun 2021 09:05:17 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RZ/4d42VLHKkKGkAK5f6UaOzcXXOoy646g2rFFovdbhfFO/m/571/u34N34/O+JA3+m1Y2ldyCCMd5sonhv3vxIT2Dy+St5E3F3XZMUwbFad7LcNltL+c6TYFQKixIqORMmt16eq+c6oSSam9NCc4yL6eNRkBJPLmStqc6j3ctIw90xThxMJfS95Odu+i0fXzMLTz0eFkyyJwpfm3Sl8vyq4M8EyBBbMKFtceEDtPiOqJB1WUwUNzD9O98qrKZCwpbCrqB+CS1BKaeaJqk3hcsq47Px95rceRG8HAvywtP5UKvWPzbFGNhgXqFWaFre98l8nTTfv48ZKdqb+8KWf8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0rg62N37rlGUuVvRDv87Xc7GvN2Q0Itl3207vt95nkQ=; b=Yq/0+w2SY5LDD2t/1pA2PiMtjH1CZsROsAodNpBwFDRSE/Ga2fsfa2RIFVFM4Mod9uYQCyiy26BaerLnr+A5H5nqz4Uh9tU2OTfetmUIiVrr+C+HjjcjyfD7PnjyhcxWGTkeWoDX35xcQQFxFWQbBgU8ITcoexgogKFZxG0AEvELOPZaLlYUPJDc6F/IzXncTzL2BBSDzfU9jcILyF4wG1iQUccF+APhAzGToE/zjFU/qakyc6TQHg3VfKv3enqaYuv9hQxuMMRCLmc/g+Ii+2vNlvOEee7yUU0enigJeOBQF59iSFXk1FjudILO6AlmYDsd8Xidli8gbtAeBJS0PQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0rg62N37rlGUuVvRDv87Xc7GvN2Q0Itl3207vt95nkQ=; b=q0FxJ8cM84Uha9EMx489NDWtKwZvrMvkdxm/B9O3T287Bo60fvCXXUlERtMyHgl0s0QNJDGNjNJmA9TnKoe3ERQ3+obNBUnfb7DxSOiWLBylUXWB+z1rVmN6tcwn6ziw19G34khIuk9mB381h+g5elnPUaCGjo83nEJkiasqaJE6kjw6+Q+NV8PGGWnhCA8QDhjiwhJX1ZcJNSWHqAMDl+Fr10c/WBbRAVelYnEmbV4z56WXwR33Fb3NXRa+PPEpYjz3LYcTC+rRlWctuFkt0gIraQerbjA1seIE+0TwbavjWk6Im4Hwtj/iQM7tUEQewIk/Yo+oncUVVyqAUodqyg== Received: from DM6PR02CA0102.namprd02.prod.outlook.com (2603:10b6:5:1f4::43) by CY4PR1201MB0007.namprd12.prod.outlook.com (2603:10b6:903:d4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Wed, 30 Jun 2021 07:05:15 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::4f) by DM6PR02CA0102.outlook.office365.com (2603:10b6:5:1f4::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 07:05:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 07:05:15 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Jun 2021 07:05:11 +0000 From: Gregory Etelson To: CC: , , , Viacheslav Ovsiienko , Shahaf Shuler Date: Wed, 30 Jun 2021 10:04:50 +0300 Message-ID: <20210630070452.14055-2-getelson@nvidia.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210630070452.14055-1-getelson@nvidia.com> References: <20210630070452.14055-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d34e1ec-1739-4e49-4e48-08d93b956951 X-MS-TrafficTypeDiagnostic: CY4PR1201MB0007: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N5dUQEu3C9w4q7y8LktyNw52p+VLTGHmzbzTAx+/UjPVqJLknWkx6oYjqwoxF8IQMDbfnx7XqQ4ZMz0j1R89OKxmtjWLckQ7gNKuIP9mItdarUEsJ6WBXcsJ4Q98Bq/Ko/kAjN86s1LTPE0xCTe/HZ0vPBSlM3epTsaOB+TJWHo1GF/uJp4e35xSXw1Tf9OSL0drzzp0XAzMlzhuAvErclWfAubv/aLuwdME5cF3dbOPpKLxBAbSG3OAieVIFDgcv1s1CgaaVu5PNjbiI1UlJUTnu+cq2Puq8fweyaFecfNE03py3/1KF6sWDmNCu7DymATj4Vd2cOXifGprmO8JtPoElpiJioNMONmUXFTaDl6qX3U1mejuglp2gx7WqNPjvIkTIUzgxMswBIaHudNlV+p2PALGqYj82XaiTlQJq4lQXiOSV5q5SqmXKNnXOPYJgmu/SpAtUq7gqRMxqiAtPEOjCLruchMB+Ob21cON7PR38ZFfkXjOktAOSRdQ5UrOiSyYuWH/MRWPK70iSpo06pxVaM81/axJsT0asVpq/moXigbvZO8+y4fIYFLhWpaRuJZLXf/OLqTxH+OLA5x7lNo8oPaHKacUHNnwRGL6w72rHMYCkKbkFjM2k6zYLYulA8qH8Ny+JVr/DfGTVarkN7v5J22gOwAAjavlgt2zmxd+ev3DccSpN22z6OCllLn5bOlXc4SHAguYLQXM+MY1Qw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(376002)(39860400002)(36840700001)(46966006)(5660300002)(1076003)(356005)(26005)(36756003)(70586007)(8676002)(70206006)(316002)(6286002)(82310400003)(7636003)(6666004)(426003)(55016002)(2906002)(107886003)(54906003)(86362001)(83380400001)(2616005)(7696005)(4326008)(478600001)(186003)(16526019)(47076005)(36860700001)(6916009)(82740400003)(8936002)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 07:05:15.1618 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d34e1ec-1739-4e49-4e48-08d93b956951 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1201MB0007 Subject: [dpdk-dev] [PATCH 1/3] common/mlx5: query for hardware capability to offload IPv4 IHL field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The patch queries MLX5 port hardware if it is capable to offload IPv4 IHL field. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 6 ++++++ drivers/common/mlx5/mlx5_devx_cmds.h | 2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index f5914bce32..9070691332 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -948,6 +948,12 @@ mlx5_devx_cmd_query_hca_attr(void *ctx, (flow_table_nic_cap, hcattr, flow_table_properties_nic_receive.log_max_ft_sampler_num); attr->pkt_integrity_match = mlx5_devx_query_pkt_integrity_match(hcattr); + attr->inner_ipv4_ihl = MLX5_GET + (flow_table_nic_cap, hcattr, + ft_field_support_2_nic_receive.inner_ipv4_ihl); + attr->outer_ipv4_ihl = MLX5_GET + (flow_table_nic_cap, hcattr, + ft_field_support_2_nic_receive.outer_ipv4_ihl); /* Query HCA offloads for Ethernet protocol. */ memset(in, 0, sizeof(in)); memset(out, 0, sizeof(out)); diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h index f8a17b886b..034c40b49c 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.h +++ b/drivers/common/mlx5/mlx5_devx_cmds.h @@ -148,6 +148,8 @@ struct mlx5_hca_attr { uint32_t crypto_login:1; /* General obj type CRYPTO_LOGIN supported. */ uint32_t regexp_num_of_engines; uint32_t log_max_ft_sampler_num:8; + uint32_t inner_ipv4_ihl:1; + uint32_t outer_ipv4_ihl:1; uint32_t geneve_tlv_opt; uint32_t cqe_compression:1; uint32_t mini_cqe_resp_flow_tag:1; From patchwork Wed Jun 30 07:04:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 95042 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8474DA0A0F; Wed, 30 Jun 2021 09:05:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F7784123F; Wed, 30 Jun 2021 09:05:20 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) by mails.dpdk.org (Postfix) with ESMTP id 818194123D for ; Wed, 30 Jun 2021 09:05:19 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CGSlghrik9exRJGsB0e9WLqiuhhqd38Y31dxRy2NfFDcEdTX+9g+b3WDkxZfK1u40fMocE/maPH0WJdy9d0D/PKLpjXwyz0rTHPk9ZE4VpLF6I/pJKiDvlyTgfywV7+1PnlM/h7qkzCuDaXCvQ/OBTHX6A9noP5jBy/rTRx/0UgMgkUdUzwjeDeVqi2ce3qrullvLu6MVFUV/MNYDfiSkOR4QKY7Jsrk4BO1EeEAOZMHe5bNrzgzPFdspWGD4sSSouggXAFQbCCwRsjcgijxQuZ6b+u6hStZbhssv0T447Fii0SbNBt1oTFVvLvUhzjQn+3ZT1IUGkE3zsgjI6hL3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c4kHAliesll5IZPjPkMlO7/HME/lRZ0VXa81mD07OBU=; b=Zqzo4vqHZ+LSfmN8z8HcWJqdxMqNr89ELCiusRfoMtXhRhXCWjgsOjoUlrpOGW2wwxmfX58TaCZPqg05MXVrstTBmOGscyysDS6v1luMDJId3E30Gdy99YpRmXcLEwzkFTDrifWReqZXCkQpo0Z3ttp8SWTDwDRDiNSqo5rQc5QEBU4qMUIJmuA0Pf5fIJ4vZ5r60IqKLw/YRib8SnJnzDAQ6T0ipYeHFlQBh80vW9UYi4tzUFUEuTjHsDs1rhMNy0jZc2ChmuHAJ0+EatWUCo9CosqiFITqDJK8BTUWaBJRAX1uIIoOxUu7sZNE4iirAVVo4bJGeEOdIO3aBsV2Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c4kHAliesll5IZPjPkMlO7/HME/lRZ0VXa81mD07OBU=; b=rqbaVWcq24ih93Z6geAB2Z6vw3Elea3IQlQXD9Qtdvro9qIFybWmcUtGwngoZszYNo2VirLEAgs1fQKxyIpT4/g+6xKyUXQUf70kCiaXGUs/RBzEbxJ6MJ7nRZ/Wyb9FdAGj8S52iwp7t2ltqByNXeqjt/5abiqdRzMpFzyX61R5PZT4+dWJaKxs2yqzLpyLb0yPGwaZFmN933OrxaaM7GpOjOcKgShxWAXSCjG56H0FEwyrM5ykPU2kklnEyHiMwSawMRusAChHSg/8SRD+u9xoFkqI30kfSg1S01d64HaLprM+BAQIlKJleBSPgh9NasDS2RKU4QFPP0zExnlqHw== Received: from DM6PR02CA0089.namprd02.prod.outlook.com (2603:10b6:5:1f4::30) by MN2PR12MB3309.namprd12.prod.outlook.com (2603:10b6:208:106::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Wed, 30 Jun 2021 07:05:18 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::a3) by DM6PR02CA0089.outlook.office365.com (2603:10b6:5:1f4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.23 via Frontend Transport; Wed, 30 Jun 2021 07:05:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 07:05:17 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Jun 2021 07:05:14 +0000 From: Gregory Etelson To: CC: , , , Viacheslav Ovsiienko , Shahaf Shuler Date: Wed, 30 Jun 2021 10:04:51 +0300 Message-ID: <20210630070452.14055-3-getelson@nvidia.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210630070452.14055-1-getelson@nvidia.com> References: <20210630070452.14055-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2f163ead-d77a-4ea1-6130-08d93b956aeb X-MS-TrafficTypeDiagnostic: MN2PR12MB3309: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:478; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uZupsu19J7+8wuQjpjt88uAqMOvEC/Y6H01AdLY80955AE1BMG7KH4hoxD1DXN8ImLQcuugZNANzdevrkE3Vpa3UXiPwFdsvusfhH6mwg9GW/9oAhz6iZskKV6NqrF+nBJUKttCMrraUjG7jdI55AZYXj/bXwRg3L4GPksXbvxCLTvo/PZR5THISoUM/inip5vYjuSNKxKlG0F9GRyKuIqWAM1vPB1xbBzf0q2T6wZfhlCYUO6AAucnstg5Fn+spNZ0ywDiU6HdVFiFQ4tIEqQ7sI58CWOIwITxpb1/vJNI+JqnZd46MbSH3XqMReiICX+T/djyh5lzxBC+uggOW6LAFDI1t7FywYFAG9RtD/6TCy6wfq2/MWN5vv5+LriVgae89QHeFf8O1Dh7z/z/eij7mqy/n6WfpJJn2FG48bttwtpXRnWZxqsvGkSF5LECaJQs+rQY+gxpDx8C1MJxqKW0hoJfqoQNPDgLpsRXFag5N8894kf+kzXce4XvF+PAtTztoOm7P3NKtn7+hnaWNZQPnGvYno76EYGL7yTRABBhbbIUolag20fnB1C+loN9rwVdPMwaHhyYi8zhmJx+O/FgM6f4u2jUVOlKxolILsi7rP6ZhUDEcV65afSD13/uOhT1pErXBzGmZIvcbootvqp1kDK/MPKuxWnjfF9Jy1RWmVsoxE9Q78U1tQ2Im90hGogo5oxgd9Uu/f8Ks6AsCVQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(36840700001)(46966006)(83380400001)(7636003)(356005)(6666004)(54906003)(8936002)(82740400003)(5660300002)(478600001)(26005)(1076003)(36860700001)(55016002)(2616005)(186003)(7696005)(86362001)(6916009)(16526019)(316002)(6286002)(107886003)(36756003)(8676002)(426003)(47076005)(70586007)(70206006)(2906002)(36906005)(82310400003)(336012)(4326008); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 07:05:17.8503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f163ead-d77a-4ea1-6130-08d93b956aeb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3309 Subject: [dpdk-dev] [PATCH 2/3] net/mlx5: add flow rule match for IPv4 IHL field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Provide flow rules capability to match on IPv4 IHL field. Minimal HCA firmware version requiredto offload IPv4 IHL is xx_30_2000. Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c5d4b01e57..155f686ad1 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -2451,19 +2451,19 @@ flow_dv_validate_item_gtp_psc(const struct rte_flow_item *item, * 0 on success, a negative errno value otherwise and rte_errno is set. */ static int -flow_dv_validate_item_ipv4(const struct rte_flow_item *item, - uint64_t item_flags, - uint64_t last_item, - uint16_t ether_type, - struct rte_flow_error *error) +flow_dv_validate_item_ipv4(struct rte_eth_dev *dev, + const struct rte_flow_item *item, + uint64_t item_flags, uint64_t last_item, + uint16_t ether_type, struct rte_flow_error *error) { int ret; + struct mlx5_priv *priv = dev->data->dev_private; const struct rte_flow_item_ipv4 *spec = item->spec; const struct rte_flow_item_ipv4 *last = item->last; const struct rte_flow_item_ipv4 *mask = item->mask; rte_be16_t fragment_offset_spec = 0; rte_be16_t fragment_offset_last = 0; - const struct rte_flow_item_ipv4 nic_ipv4_mask = { + struct rte_flow_item_ipv4 nic_ipv4_mask = { .hdr = { .src_addr = RTE_BE32(0xffffffff), .dst_addr = RTE_BE32(0xffffffff), @@ -2474,6 +2474,17 @@ flow_dv_validate_item_ipv4(const struct rte_flow_item *item, }, }; + if (mask && (mask->hdr.version_ihl & RTE_IPV4_HDR_IHL_MASK)) { + int tunnel = !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); + bool ihl_cap = !tunnel ? priv->config.hca_attr.outer_ipv4_ihl : + priv->config.hca_attr.inner_ipv4_ihl; + if (!ihl_cap) + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_ITEM, + item, + "IPV4 ihl offload not supported"); + nic_ipv4_mask.hdr.version_ihl = mask->hdr.version_ihl; + } ret = mlx5_flow_validate_item_ipv4(item, item_flags, last_item, ether_type, &nic_ipv4_mask, MLX5_ITEM_RANGE_ACCEPTED, error); @@ -6771,7 +6782,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, case RTE_FLOW_ITEM_TYPE_IPV4: mlx5_flow_tunnel_ip_check(items, next_protocol, &item_flags, &tunnel); - ret = flow_dv_validate_item_ipv4(items, item_flags, + ret = flow_dv_validate_item_ipv4(dev, items, item_flags, last_item, ether_type, error); if (ret < 0) @@ -8154,7 +8165,7 @@ flow_dv_translate_item_ipv4(void *matcher, void *key, void *headers_v; char *l24_m; char *l24_v; - uint8_t tos; + uint8_t tos, ihl_m, ihl_v; if (inner) { headers_m = MLX5_ADDR_OF(fte_match_param, matcher, @@ -8183,6 +8194,10 @@ flow_dv_translate_item_ipv4(void *matcher, void *key, *(uint32_t *)l24_m = ipv4_m->hdr.src_addr; *(uint32_t *)l24_v = ipv4_m->hdr.src_addr & ipv4_v->hdr.src_addr; tos = ipv4_m->hdr.type_of_service & ipv4_v->hdr.type_of_service; + ihl_m = ipv4_m->hdr.version_ihl & RTE_IPV4_HDR_IHL_MASK; + ihl_v = ipv4_v->hdr.version_ihl & RTE_IPV4_HDR_IHL_MASK; + MLX5_SET(fte_match_set_lyr_2_4, headers_m, ipv4_ihl, ihl_m); + MLX5_SET(fte_match_set_lyr_2_4, headers_v, ipv4_ihl, ihl_m & ihl_v); MLX5_SET(fte_match_set_lyr_2_4, headers_m, ip_ecn, ipv4_m->hdr.type_of_service); MLX5_SET(fte_match_set_lyr_2_4, headers_v, ip_ecn, tos); From patchwork Wed Jun 30 07:04:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 95043 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0567BA0A0F; Wed, 30 Jun 2021 09:05:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E95B41247; Wed, 30 Jun 2021 09:05:22 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2076.outbound.protection.outlook.com [40.107.96.76]) by mails.dpdk.org (Postfix) with ESMTP id 4A76541243 for ; Wed, 30 Jun 2021 09:05:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C41iPKR9ju+TlmH8cTLCJPO4hh8vKNeTmwP78TSBUFsm3nUu8pGXUIbPwt5HoUAaoe5HToFfneGIBVw+rQA62vEvp5a1G9yJqEbviIOEgqGMoAiP86xBZbGAqGTOumTxCl4rMOGqpAoygv41O81Tc7trcNHg3hRMJIVmWH1MfvIqrvKOdF2lnMmyQBNmXwLT6ImHLaTEAx9uGKAxI0sPQkUxcbCi10gXjSyiWwG0f81sLmG7thE/C9qKD/l6mJbz/voBKbNu1PXMaOrxXdcvNCb2eEFpXPwMYXmTi+xaCsxBszWjXwWqEeuY/9lcNQgMQF1rD6qIltz8bRWKeWgBAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yERNgjPBMoLH9C3G+UtDwXxICYiuQRHIsq/Z0P1prps=; b=bbAsGvE7/pKXkVXyrRhWgNAtD1KW4Bk997k9FsUR4MlXhppCDwkGdN/fM+R+/SczazGA7uluCidxIfdCxaZRS4uyRCUtrTahCFEFNqI9EZPWb87skawHbZVG7zF5HoNvLFvkAKGdXSUwQu1P30SKFiuW/cUNVvD0QsKvActBzaGw+UZm3jiEGAs/tpfN03lB4l9ivOMlCV2j9dxTiv0xh64uX03joFH76mR6wL7s6u4G/sjeJv6eT1R/+nmrDuBbyEMccr5lVJN75LqMHvoRgU4u+RMxpGB7EFTnSUcmVjKkSMpXjZrPtkyAbkrF37nUWQ5aKluLAFlfAbtJOJQsiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yERNgjPBMoLH9C3G+UtDwXxICYiuQRHIsq/Z0P1prps=; b=ehzZO+S7vs3KPsTpkoE/lzL2OVwIxfz5Wu0rfvfTKYkNB7NBFP0ohJUdrSU+Yec1ujs3Fif9tD8063G06ho8PesJJ+Ixq/2xNszCj1NT0RlE/eJ8yDfbs3FVIFgdV4PaY8EQh+78dLNI16FjrEIDd5wid5XF9dUOWHSmZLO/79VdmWL4IxzkhqjfeSQAsYHLQSET9gpr4KSlAhW9WcFdFK5tH/O+pvVng+p7F9Ejzifdp0wdnGxBMrhR3x32jl7vNrW5xtYCXQ9DVZuZfk982ANNcggsfuw9LOCiLlu1CnSjj+TdrEfYBShKpGO8NlS+wQ+qmsquuLN+4g3V8Uf6Rg== Received: from DM6PR02CA0098.namprd02.prod.outlook.com (2603:10b6:5:1f4::39) by BYAPR12MB2693.namprd12.prod.outlook.com (2603:10b6:a03:6a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Wed, 30 Jun 2021 07:05:19 +0000 Received: from DM6NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1f4:cafe::c6) by DM6PR02CA0098.outlook.office365.com (2603:10b6:5:1f4::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 07:05:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by DM6NAM11FT040.mail.protection.outlook.com (10.13.173.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Wed, 30 Jun 2021 07:05:19 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 30 Jun 2021 07:05:16 +0000 From: Gregory Etelson To: CC: , , , Ori Kam , Xiaoyun Li Date: Wed, 30 Jun 2021 10:04:52 +0300 Message-ID: <20210630070452.14055-4-getelson@nvidia.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210630070452.14055-1-getelson@nvidia.com> References: <20210630070452.14055-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e3e7fc5-b790-4960-ace2-08d93b956bc6 X-MS-TrafficTypeDiagnostic: BYAPR12MB2693: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ag1HGr1lQWQ1GKevN9q7F7tvR0IAyt80aYixmktFbsDk+DCSbtSiWyKfQdgwFPVOhy7zHi4DuMZrHqwle2HHDf+meuNNOiypSoIDxVtBREvc3bBwVMm5xZV0Ap6qN9Cgz2zv3gqLJ8MaHGF3iLkRdUEkhQ726Rh5335wHqG1TVqjIOs9L6PD/SH/TPBcH7Clq27gBQmbltAYP3mhs3mE/F9UVi6YqSHpyLk+KVu+oIETYUr3UKAbX68jdSmJ2WUgUNbOAwoERq/GvWXyNKTABgG1P9zRrb/30usFbZQ72fWPBs0FlWCegQ7sbuP8E9/7Jm7HCYZigSvSwXSyBvwc+5PdFGiZJawUNQUIWxU0p4AiOBINfspZSkD9Lu1vjWLhzVUZii8jjekr+JdTEEgSD0BVmwSf7DEmjqLLBEPtwDvtRvKhW+eW5iSD2Ct0U64BNi0ZN+dssy29aaFv/42QTqOuF+dzhOihuOYZtMAVKTfgFrqwPU/Jzm/ox30uqPhuenAqaEPrLO7Zah/WPofuj64CPL/ivU8Cy4pOBvKGQqBgE6WhS3ZWQlrB/Q8Ay8nAcBNPAL0Pkd5ZARg6FR8uvuDRCRDOsp28+duNwv5RQtvF35IA6IhU/g+etzigqybkv/jzAT+EwQ9BnzzQqhClG5TAEJ00aY60byjr9vEA4jsRXBZFriePAFcZRXm/xJ7Q50Bw//VvM0dsAklRCs/hOQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(39860400002)(346002)(36840700001)(46966006)(16526019)(186003)(7696005)(336012)(54906003)(70206006)(82310400003)(316002)(4326008)(36860700001)(86362001)(47076005)(5660300002)(36906005)(1076003)(6286002)(36756003)(70586007)(55016002)(2616005)(356005)(8936002)(83380400001)(478600001)(6916009)(8676002)(426003)(26005)(2906002)(6666004)(82740400003)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 07:05:19.2754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e3e7fc5-b790-4960-ace2-08d93b956bc6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2693 Subject: [dpdk-dev] [PATCH 3/3] app/testpmd: add flow item to match on IPv4 version_ihl field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The new flow item allows PMD to offload IPv4 IHL field for matching, if hardware supports that operation. Signed-off-by: Gregory Etelson --- app/test-pmd/cmdline_flow.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index 1c587bb7b8..c1c7b9a9f9 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -173,6 +173,7 @@ enum index { ITEM_VLAN_INNER_TYPE, ITEM_VLAN_HAS_MORE_VLAN, ITEM_IPV4, + ITEM_IPV4_VER_IHL, ITEM_IPV4_TOS, ITEM_IPV4_ID, ITEM_IPV4_FRAGMENT_OFFSET, @@ -1071,6 +1072,7 @@ static const enum index item_vlan[] = { }; static const enum index item_ipv4[] = { + ITEM_IPV4_VER_IHL, ITEM_IPV4_TOS, ITEM_IPV4_ID, ITEM_IPV4_FRAGMENT_OFFSET, @@ -2567,6 +2569,13 @@ static const struct token token_list[] = { .next = NEXT(item_ipv4), .call = parse_vc, }, + [ITEM_IPV4_VER_IHL] = { + .name = "version_ihl", + .help = "match header length", + .next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param), + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4, + hdr.version_ihl)), + }, [ITEM_IPV4_TOS] = { .name = "tos", .help = "type of service", @@ -8123,7 +8132,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto) break; case RTE_FLOW_ITEM_TYPE_IPV4: ipv4 = (struct rte_ipv4_hdr *)buf; - ipv4->version_ihl = 0x45; + if (!ipv4->version_ihl) + ipv4->version_ihl = RTE_IPV4_VHL_DEF; if (next_proto && ipv4->next_proto_id == 0) ipv4->next_proto_id = (uint8_t)next_proto; break;