From patchwork Tue Jun 22 14:07:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hunt, David" X-Patchwork-Id: 94677 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E82C1A0548; Tue, 22 Jun 2021 16:08:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 731284003F; Tue, 22 Jun 2021 16:08:23 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 4F85A4003C for ; Tue, 22 Jun 2021 16:08:22 +0200 (CEST) IronPort-SDR: mB281A9Js2FHD1WNoMqi4gv9ctOeqgsDkRVGPapchYxKUDIqNBPywyIxeNu/+ZGiNdoHQ90RH8 N7Ovel+wSe/A== X-IronPort-AV: E=McAfee;i="6200,9189,10022"; a="194198621" X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="194198621" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2021 07:08:20 -0700 IronPort-SDR: fTyJuZeneqm3d3XpiDzLTR3V9Sxcjdd+v+zSSuvUJbW3KHNnGvpyUex5+XhzLzvPEvkx87iNC2 Y+2hKvLHIGGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,291,1616482800"; d="scan'208";a="452628563" Received: from silpixa00399952.ir.intel.com ([10.55.129.13]) by orsmga008.jf.intel.com with ESMTP; 22 Jun 2021 07:08:00 -0700 From: David Hunt To: dev@dpdk.org Cc: david.hunt@intel.com, anatoly.burakov@intel.com Date: Tue, 22 Jun 2021 15:07:50 +0100 Message-Id: <20210622140750.6208-1-david.hunt@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210531113008.3087-1-david.hunt@intel.com> References: <20210531113008.3087-1-david.hunt@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/power: add baseline mode to PMD power X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The PMD Power Management scheme currently has 3 modes, scale, monitor and pause. However, it would be nice to have a baseline mode for easy comparison of power savings with and without these modes. This patch adds a 'baseline' mode were the pmd power management is not enabled. Use --pmg-mgmt=baseline. Signed-off-by: David Hunt Acked-by: Anatoly Burakov --- changes in v2 * added a bool for baseline mode rather than abusing enums --- examples/l3fwd-power/main.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index f8dfed1634..aeb2411e62 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -207,6 +207,7 @@ enum appmode { enum appmode app_mode; static enum rte_power_pmd_mgmt_type pmgmt_type; +bool baseline_enabled; enum freq_scale_hint_t { @@ -1617,7 +1618,7 @@ print_usage(const char *prgname) " empty polls, full polls, and core busyness to telemetry\n" " --interrupt-only: enable interrupt-only mode\n" " --pmd-mgmt MODE: enable PMD power management mode. " - "Currently supported modes: monitor, pause, scale\n", + "Currently supported modes: baseline, monitor, pause, scale\n", prgname); } @@ -1714,6 +1715,7 @@ parse_pmd_mgmt_config(const char *name) #define PMD_MGMT_MONITOR "monitor" #define PMD_MGMT_PAUSE "pause" #define PMD_MGMT_SCALE "scale" +#define PMD_MGMT_BASELINE "baseline" if (strncmp(PMD_MGMT_MONITOR, name, sizeof(PMD_MGMT_MONITOR)) == 0) { pmgmt_type = RTE_POWER_MGMT_TYPE_MONITOR; @@ -1729,6 +1731,10 @@ parse_pmd_mgmt_config(const char *name) pmgmt_type = RTE_POWER_MGMT_TYPE_SCALE; return 0; } + if (strncmp(PMD_MGMT_BASELINE, name, sizeof(PMD_MGMT_BASELINE)) == 0) { + baseline_enabled = true; + return 0; + } /* unknown PMD power management mode */ return -1; } @@ -2528,6 +2534,9 @@ main(int argc, char **argv) /* init RTE timer library to be used late */ rte_timer_subsystem_init(); + /* if we're running pmd-mgmt mode, don't default to baseline mode */ + baseline_enabled = false; + /* parse application arguments (after the EAL ones) */ ret = parse_args(argc, argv); if (ret < 0) @@ -2767,7 +2776,8 @@ main(int argc, char **argv) "Fail to add ptype cb\n"); } - if (app_mode == APP_MODE_PMD_MGMT) { + if ((app_mode == APP_MODE_PMD_MGMT) && + (baseline_enabled == false)) { ret = rte_power_ethdev_pmgmt_queue_enable( lcore_id, portid, queueid, pmgmt_type);