From patchwork Mon May 10 12:20:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alvin Zhang X-Patchwork-Id: 93091 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AF33A0A0E; Mon, 10 May 2021 14:21:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71ECF41108; Mon, 10 May 2021 14:21:02 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 9B4E84003E for ; Mon, 10 May 2021 14:20:59 +0200 (CEST) IronPort-SDR: To3ZMOQ1yOVu5W+alAU13l9YzuZsYDPrxASXYK8I1WuIGGa+vJdS/IEhHQh3CAVgb0UVcy8qKF VcY/QmaUxF2g== X-IronPort-AV: E=McAfee;i="6200,9189,9979"; a="196085959" X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="196085959" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:20:59 -0700 IronPort-SDR: 1zZvHgJ4EPwiLWOvkt0CVe9r8SrvgGVlXe7qVa/L9dAhrCUgMMU4RIMbajvS21KrwunfGlGrAv 42YPUXZtPKgQ== X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="454392062" Received: from shwdenpg235.ccr.corp.intel.com ([10.240.182.60]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2021 05:20:57 -0700 From: Alvin Zhang To: beilei.xing@intel.com, Ting.Xu@intel.com Cc: dev@dpdk.org, Alvin Zhang Date: Mon, 10 May 2021 20:20:48 +0800 Message-Id: <20210510122050.32668-2-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20210510122050.32668-1-alvinx.zhang@intel.com> References: <20210510122050.32668-1-alvinx.zhang@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/iavf: fix error logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Remove some useless logs which are duplicated of the lower-level function logs and may confuse users when running VF without some features supportted by PF. Fixes: 5a038d19962d ("net/iavf: fix RSS configuration on i40e VF") Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") Signed-off-by: Alvin Zhang --- drivers/net/iavf/iavf_vchnl.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index ca5c56e..dfa7ce3 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -1519,11 +1519,8 @@ args.out_size = IAVF_AQ_BUF_SZ; err = iavf_execute_vf_cmd(adapter, &args); - if (err) { - PMD_DRV_LOG(ERR, - "Failed to execute command of OP_GET_RSS_HENA_CAPS"); + if (err) return err; - } *caps = ((struct virtchnl_rss_hena *)args.out_buffer)->hena; return 0; @@ -1535,7 +1532,6 @@ struct iavf_info *vf = IAVF_DEV_PRIVATE_TO_VF(adapter); struct virtchnl_rss_hena vrh; struct iavf_cmd_info args; - int err; vrh.hena = hena; args.ops = VIRTCHNL_OP_SET_RSS_HENA; @@ -1544,12 +1540,7 @@ args.out_buffer = vf->aq_resp; args.out_size = IAVF_AQ_BUF_SZ; - err = iavf_execute_vf_cmd(adapter, &args); - if (err) - PMD_DRV_LOG(ERR, - "Failed to execute command of OP_SET_RSS_HENA"); - - return err; + return iavf_execute_vf_cmd(adapter, &args); } int