From patchwork Wed May 5 14:21:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 92933 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87C88A0524; Wed, 5 May 2021 16:21:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2DB640040; Wed, 5 May 2021 16:21:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 49E474003C for ; Wed, 5 May 2021 16:21:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620224477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fVW8Xf/Nh/UQsT4VRHXyVrfJGriBoPZnl7Ux9f73xxI=; b=XY7sJGYOxBohpVf5G4SO4pQiLxtNgGfuV6u1e8sRKRzBLByZh3cuzgZl5VORdOm9mHeAxq xFJgJo1muYVthSVnBTGAkIKFD6qMi4TPjJ7GaAgxG2/FBZXtiZ/WDSAuTUqo1TwTWUoQa5 p8f6uMfF+NhxSObCV0A1nkTspcZ6e6c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-ZWgup0hfMTytMhwN3cSoAA-1; Wed, 05 May 2021 10:21:15 -0400 X-MC-Unique: ZWgup0hfMTytMhwN3cSoAA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C17A8107ACCA; Wed, 5 May 2021 14:21:14 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.192.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 96A8260BF1; Wed, 5 May 2021 14:21:13 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: thomas@monjalon.net, Bruce Richardson Date: Wed, 5 May 2021 16:21:05 +0200 Message-Id: <20210505142105.12914-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] lib: restore developer mode checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Most of the checks on developer_mode have been accidentally dropped. Restore them. Fixes: 7d611e35b077 ("lib: simplify main build file") Signed-off-by: David Marchand Acked-by: Bruce Richardson --- lib/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 64a59abab6..77f363a516 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -170,7 +170,7 @@ foreach l:libraries libname = 'rte_' + name includes += include_directories(l) - if is_windows and use_function_versioning + if developer_mode and is_windows and use_function_versioning message('@0@: Function versioning is not supported by Windows.'.format(name)) endif @@ -227,7 +227,7 @@ foreach l:libraries endif lk_deps = [version_map, def_file, mingw_map] - if not is_windows + if developer_mode and not is_windows # on unix systems check the output of the # check-symbols.sh script, using it as a # dependency of the .so build