From patchwork Wed Apr 28 08:04:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Zhang X-Patchwork-Id: 92313 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 362A6A0A0E; Wed, 28 Apr 2021 10:13:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F90A4014E; Wed, 28 Apr 2021 10:13:35 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 063D140147 for ; Wed, 28 Apr 2021 10:13:33 +0200 (CEST) IronPort-SDR: U4Xt9JGQlrCjLKggb+nD7W+sVsKGm9ccP1p7hlpfkhihDFVbfDRdGY7/HoEH60PX26gWuwZhLD tQ6qg4u785/Q== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="184170012" X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="184170012" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 01:13:32 -0700 IronPort-SDR: cIRLA5FxziueeL1sBqlD4P3pvIXXl5O4QliDa0zmYnOgmHEo6whBu/u6XHSzkCLBg2f7N2fzBf tor/beWYu4Ww== X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="465815790" Received: from unknown (HELO intel-npg-odc-srv03.cd.intel.com) ([10.240.178.145]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 01:13:30 -0700 From: Robin Zhang To: dev@dpdk.org Cc: beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, stevex.yang@intel.com, Robin Zhang Date: Wed, 28 Apr 2021 08:04:51 +0000 Message-Id: <20210428080452.542274-1-robinx.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210427092243.391908-1-robinx.zhang@intel.com> References: <20210427092243.391908-1-robinx.zhang@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 1/2] net/iavf: fix missing set primary MAC type when start port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When start port, all MAC addresses will be set. We should set the MAC type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: b335e7203475 ("net/iavf: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang Acked-by: Qi Zhang --- v2: -fix commit message typo --- drivers/net/iavf/iavf_vchnl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index 0026120cf4..5d57e8b541 100644 --- a/drivers/net/iavf/iavf_vchnl.c +++ b/drivers/net/iavf/iavf_vchnl.c @@ -1172,7 +1172,9 @@ iavf_add_del_all_mac_addr(struct iavf_adapter *adapter, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3], From patchwork Wed Apr 28 08:04:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robin Zhang X-Patchwork-Id: 92314 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4B75A0A0E; Wed, 28 Apr 2021 10:13:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2E2441281; Wed, 28 Apr 2021 10:13:38 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 725574125C for ; Wed, 28 Apr 2021 10:13:37 +0200 (CEST) IronPort-SDR: WxQsmV6e3veWMUIcJtJAZ/9/PMEd8d6sZa91x784kgwXMa7NV0Fg0yF/Anxqm9gDdXYFvq/gDJ W41T8mzIggiA== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="184170023" X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="184170023" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 01:13:37 -0700 IronPort-SDR: Jf/dCfLgmLW/NwGLHZHIoij4vFO69vcPRuZ4cLefZKXUGF9MVKXltZ/VaSpInjFCPgHCT1NsWr /Ix404RV2Pgw== X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="465815818" Received: from unknown (HELO intel-npg-odc-srv03.cd.intel.com) ([10.240.178.145]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 01:13:34 -0700 From: Robin Zhang To: dev@dpdk.org Cc: beilei.xing@intel.com, jia.guo@intel.com, qiming.yang@intel.com, stevex.yang@intel.com, Robin Zhang Date: Wed, 28 Apr 2021 08:04:52 +0000 Message-Id: <20210428080452.542274-2-robinx.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210428080452.542274-1-robinx.zhang@intel.com> References: <20210427092243.391908-1-robinx.zhang@intel.com> <20210428080452.542274-1-robinx.zhang@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix missing set primary MAC type when start port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When start port, all MAC addresses will be set. We should set the MAC type of default MAC address as VIRTCHNL_ETHER_ADDR_PRIMARY. Fixes: 3f604ddf33cf ("net/i40e: fix lack of MAC type when set MAC address") Signed-off-by: Robin Zhang Acked-by: Qi Zhang --- v2: -fix commit message typo --- drivers/net/i40e/i40e_ethdev_vf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index aeb6816b9f..8f3b152b6c 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -2127,7 +2127,9 @@ i40evf_add_del_all_mac_addr(struct rte_eth_dev *dev, bool add) continue; rte_memcpy(list->list[j].addr, addr->addr_bytes, sizeof(addr->addr_bytes)); - list->list[j].type = VIRTCHNL_ETHER_ADDR_EXTRA; + list->list[j].type = (j == 0 ? + VIRTCHNL_ETHER_ADDR_PRIMARY : + VIRTCHNL_ETHER_ADDR_EXTRA); PMD_DRV_LOG(DEBUG, "add/rm mac:%x:%x:%x:%x:%x:%x", addr->addr_bytes[0], addr->addr_bytes[1], addr->addr_bytes[2], addr->addr_bytes[3],