From patchwork Tue Apr 20 08:59:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 91831 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54F9BA0579; Tue, 20 Apr 2021 11:00:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A69E24165B; Tue, 20 Apr 2021 10:59:46 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 06C1E41417 for ; Tue, 20 Apr 2021 10:59:42 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPcy60jw4z17R9P for ; Tue, 20 Apr 2021 16:57:18 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 16:59:38 +0800 From: "Min Hu (Connor)" To: CC: Date: Tue, 20 Apr 2021 16:59:48 +0800 Message-ID: <1618909192-17431-2-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com> References: <1618909192-17431-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 1/5] net/hns3: delete unused macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'HNS3_RXD_LKBK_B' was defined in previous versions but no used. This patch deleted it. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: stable@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h index f7b457b..703c4b7 100644 --- a/drivers/net/hns3/hns3_rxtx.h +++ b/drivers/net/hns3/hns3_rxtx.h @@ -106,7 +106,6 @@ #define HNS3_RXD_L3L4P_B 11 #define HNS3_RXD_TS_VLD_B 14 -#define HNS3_RXD_LKBK_B 15 #define HNS3_RXD_GRO_SIZE_S 16 #define HNS3_RXD_GRO_SIZE_M (0x3fff << HNS3_RXD_GRO_SIZE_S) From patchwork Tue Apr 20 08:59:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 91829 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FCA6A0579; Tue, 20 Apr 2021 10:59:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CD4441638; Tue, 20 Apr 2021 10:59:44 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id C38E741319 for ; Tue, 20 Apr 2021 10:59:41 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPcy60smFz17R9q for ; Tue, 20 Apr 2021 16:57:18 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 16:59:38 +0800 From: "Min Hu (Connor)" To: CC: Date: Tue, 20 Apr 2021 16:59:49 +0800 Message-ID: <1618909192-17431-3-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com> References: <1618909192-17431-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 2/5] net/hns3: fix enum variable used as boolean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" params->leaf.cman has enum type which is not isomorphic with boolean type, however it is used as a boolean expression. This patch fixed it. Fixes: c09c7847d892 ("net/hns3: support traffic management") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_tm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hns3/hns3_tm.c b/drivers/net/hns3/hns3_tm.c index 165d1fb..aae4970 100644 --- a/drivers/net/hns3/hns3_tm.c +++ b/drivers/net/hns3/hns3_tm.c @@ -385,7 +385,7 @@ hns3_tm_leaf_node_param_check(struct rte_eth_dev *dev __rte_unused, return -EINVAL; } - if (params->leaf.cman) { + if (params->leaf.cman != RTE_TM_CMAN_TAIL_DROP) { error->type = RTE_TM_ERROR_TYPE_NODE_PARAMS_CMAN; error->message = "congestion management not supported"; return -EINVAL; From patchwork Tue Apr 20 08:59:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 91828 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26615A0579; Tue, 20 Apr 2021 10:59:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D33041319; Tue, 20 Apr 2021 10:59:43 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id C38594127B for ; Tue, 20 Apr 2021 10:59:41 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FPcy60Yyfz17R7f for ; Tue, 20 Apr 2021 16:57:18 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 16:59:38 +0800 From: "Min Hu (Connor)" To: CC: Date: Tue, 20 Apr 2021 16:59:50 +0800 Message-ID: <1618909192-17431-4-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com> References: <1618909192-17431-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 3/5] net/hns3: fix unchecked function call X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In hns3 PMD, as the handler always return 0, the return value of a function 'rte_kvargs_process' no need to be checked. But the API definition has return value, so 'void' could be used to ignore that. Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c index b29aab5..60267e1 100644 --- a/drivers/net/hns3/hns3_ethdev.c +++ b/drivers/net/hns3/hns3_ethdev.c @@ -7268,11 +7268,11 @@ hns3_parse_devargs(struct rte_eth_dev *dev) if (!kvlist) return; - rte_kvargs_process(kvlist, HNS3_DEVARG_RX_FUNC_HINT, + (void)rte_kvargs_process(kvlist, HNS3_DEVARG_RX_FUNC_HINT, &hns3_parse_io_hint_func, &rx_func_hint); - rte_kvargs_process(kvlist, HNS3_DEVARG_TX_FUNC_HINT, + (void)rte_kvargs_process(kvlist, HNS3_DEVARG_TX_FUNC_HINT, &hns3_parse_io_hint_func, &tx_func_hint); - rte_kvargs_process(kvlist, HNS3_DEVARG_DEV_CAPS_MASK, + (void)rte_kvargs_process(kvlist, HNS3_DEVARG_DEV_CAPS_MASK, &hns3_parse_dev_caps_mask, &dev_caps_mask); rte_kvargs_free(kvlist); From patchwork Tue Apr 20 08:59:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 91832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA9D3A0579; Tue, 20 Apr 2021 11:00:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB3E641662; Tue, 20 Apr 2021 10:59:48 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id B738641658 for ; Tue, 20 Apr 2021 10:59:45 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FPcyh6y8PzjZss for ; Tue, 20 Apr 2021 16:57:48 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 16:59:39 +0800 From: "Min Hu (Connor)" To: CC: Date: Tue, 20 Apr 2021 16:59:51 +0800 Message-ID: <1618909192-17431-5-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com> References: <1618909192-17431-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 4/5] doc: update hns3 feature list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hns3 PMD has supported SR-IOV in 19.11 version. This patch added feature description in hns3.ini. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini index 0f89c60..2a46dde 100644 --- a/doc/guides/nics/features/hns3.ini +++ b/doc/guides/nics/features/hns3.ini @@ -25,6 +25,7 @@ Multicast MAC filter = Y RSS hash = Y RSS key update = Y RSS reta update = Y +SR-IOV = Y DCB = Y VLAN filter = Y Flow control = Y From patchwork Tue Apr 20 08:59:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "humin (Q)" X-Patchwork-Id: 91833 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DC33A0579; Tue, 20 Apr 2021 11:00:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AD514127B; Tue, 20 Apr 2021 10:59:50 +0200 (CEST) Received: from szxga06-in.huawei.com (szxga06-in.huawei.com [45.249.212.32]) by mails.dpdk.org (Postfix) with ESMTP id E8F9941659 for ; Tue, 20 Apr 2021 10:59:45 +0200 (CEST) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FPcyj010nzjZt1 for ; Tue, 20 Apr 2021 16:57:48 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Tue, 20 Apr 2021 16:59:39 +0800 From: "Min Hu (Connor)" To: CC: Date: Tue, 20 Apr 2021 16:59:52 +0800 Message-ID: <1618909192-17431-6-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1618909192-17431-1-git-send-email-humin29@huawei.com> References: <1618909192-17431-1-git-send-email-humin29@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH 5/5] doc: fix Rx burst function doc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The patch 'net/hns3: rename Rx burst function' changed `simple' Rx function name from 'scalar' to 'scalar simple', but doc ignored that. This patch fixed it. Fixes: aa5baf47e1a3 ("net/hns3: rename Rx burst function") Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst index fa45721..52d6718 100644 --- a/doc/guides/nics/hns3.rst +++ b/doc/guides/nics/hns3.rst @@ -59,7 +59,7 @@ Runtime Config Options ``sve``, if supported use the ``sve`` Rx function which indicates the sve algorithm. ``simple``, if supported use the ``simple`` Rx function which indicates - the scalar algorithm. + the scalar simple algorithm. ``common``, if supported use the ``common`` Rx function which indicates the scalar scattered algorithm.