From patchwork Mon Apr 12 21:53:38 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 91124 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FC01A0524; Mon, 12 Apr 2021 23:54:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D68AC14131F; Mon, 12 Apr 2021 23:54:02 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 64637141309 for ; Mon, 12 Apr 2021 23:54:01 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E0DE05C0187; Mon, 12 Apr 2021 17:54:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 12 Apr 2021 17:54:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm3; bh=/xGWwmvfrmlkpWEP0tXO96Sbky gNNPerjQB6fGbvWRI=; b=ZnahzLQfR6Rj9HRSntMwrvC+n1guMjt5bXLNHNMN// jA3/zKTEgsostYWNsZgOiQarGzFsW4DXeS19YcVbv5GbijgkXAibLbS0JG0HRSwa ChJFU8IjqcIi8rscXbycVyvGFZGjXp07l5PFCovfBUUIG/AeCAoe5mEOYgN1Y4kJ OxYxj9cCLPW6bTMHbpn0rFkHA7J+MUp2tKV7YH4nwsLaU0qEjkpYyav72cxaofaB d28nd8Wv+3ISt7Wx+leS4oHVjvJAb40/c9ucINSWmJSvR/qA/h3i0+Lg769zmOrD Q5scpMKIU9BM4J4lBK5t3LZ9BT3lexisecThK4FRAQ/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/xGWwmvfrmlkpWEP0 tXO96SbkygNNPerjQB6fGbvWRI=; b=Gi6uDL/POp3YjRTMORB7Y2EIlzkrMyNiA c/cwoJMuS3Bl5hXoSTiU3WSunOMbzKrhQUwI1uWOCMOOwg0CvoCBrzw9TIHSqlbi FlfL+qDKa7K61MaAwmbqotH6r6s05xmPV1GwdOTUUxY0GWH4fapER0bn9QP0gjHO NjQ6779Ct9TAjlz/HypEibgUVI7qjS6BVIWUG96xy1DnbXCOTUKHgOSmkQ3MRZ/s Zi7aKDwMjRl5WlkxfgyLZtLp/SpLui20glc5vPuIx9MIjaZxxj34B/qwaGB5d1t+ QGOCfOKBVt/cwjogmmlTYYmDprFicmxUeSfU71AS4A2+DGpHLVu2A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekkedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgggfestdekredtre dttdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhho nhhjrghlohhnrdhnvghtqeenucggtffrrghtthgvrhhnpedvledvudehvdduudevuedvve ehgeduleegiefgjeehudehtddtgeduffejiefhgfenucfkphepjeejrddufeegrddvtdef rddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0FAD41080054; Mon, 12 Apr 2021 17:53:59 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com Date: Mon, 12 Apr 2021 23:53:38 +0200 Message-Id: <20210412215339.2439530-1-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] devtools: test different build types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize build type. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- devtools/test-meson-builds.sh | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index daf817ac3e..37f258bd48 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -92,13 +92,16 @@ load_env () # command -v $targetcc >/dev/null 2>&1 || return 1 } -config () # +config () # { dir=$1 shift builddir=$1 shift + abicheck=$1 + shift if [ -f "$builddir/build.ninja" ] ; then + [ $abicheck = ABI ] || return 0 # for existing environments, switch to debugoptimized if unset # so that ABI checks can run if ! $MESON configure $builddir | @@ -114,7 +117,9 @@ config () # else options="$options -Dexamples=l3fwd" # save disk space fi - options="$options --buildtype=debugoptimized" + if [ $abicheck = ABI ] ; then + options="$options --buildtype=debugoptimized" + fi for option in $DPDK_MESON_OPTIONS ; do options="$options -D$option" done @@ -165,7 +170,7 @@ build () # [meson options] cross= fi load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $cross --werror $* + config $srcdir $builds_dir/$targetdir $abicheck $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION @@ -179,7 +184,7 @@ build () # [meson options] fi rm -rf $abirefdir/build - config $abirefdir/src $abirefdir/build $cross \ + config $abirefdir/src $abirefdir/build $abicheck $cross \ -Dexamples= $* compile $abirefdir/build install_target $abirefdir/build $abirefdir/$targetdir @@ -213,9 +218,10 @@ for c in gcc clang ; do abicheck=ABI else abicheck=skipABI # save time and disk space + buildtype='--buildtype=minsize' fi export CC="$CCACHE $c" - build build-$c-$s $c $abicheck --default-library=$s + build build-$c-$s $c $abicheck $buildtype --default-library=$s unset CC done done @@ -227,7 +233,7 @@ generic_machine='nehalem' if ! check_cc_flags "-march=$generic_machine" ; then generic_machine='corei7' fi -build build-x86-generic cc skipABI -Dcheck_includes=true \ +build build-x86-generic cc skipABI --buildtype=debug -Dcheck_includes=true \ -Dlibdir=lib -Dmachine=$generic_machine $use_shared # 32-bit with default compiler