From patchwork Tue Apr 6 16:17:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balazs Nemeth X-Patchwork-Id: 90748 X-Patchwork-Delegate: maxime.coquelin@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1453A0546; Tue, 6 Apr 2021 18:17:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2CF214125D; Tue, 6 Apr 2021 18:17:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id AB1AC14125D for ; Tue, 6 Apr 2021 18:17:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617725871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aqnYzqtgvU9hEZLTOb7WP1TMSclBGNCmAnZpxmzJN8I=; b=FH8hCI/1c8gsKcoV8DBiBXaVB3+UFfJzMNzLGQjcHnE9Vw2sqy6sNB9A/I1Fu6ogDZ5TP0 O/zNZXO2coiwxqsRtIOPZRNa/sCRFM9ToalAHaAKFj5ZeYmFsnP2MKafiuKOxcR7UiT1V8 jFCF6bhh41QjTJFJbPc5zJLcqgc/tzM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-uoElESN1NiCpLQT5i_jbvA-1; Tue, 06 Apr 2021 12:17:48 -0400 X-MC-Unique: uoElESN1NiCpLQT5i_jbvA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90057839A5B for ; Tue, 6 Apr 2021 16:17:47 +0000 (UTC) Received: from bnemeth.users.ipa.redhat.com (ovpn-112-176.ams2.redhat.com [10.36.112.176]) by smtp.corp.redhat.com (Postfix) with ESMTP id B6BEF5D9DC; Tue, 6 Apr 2021 16:17:46 +0000 (UTC) From: Balazs Nemeth To: bnemeth@redhat.com, dev@dpdk.org Date: Tue, 6 Apr 2021 18:17:41 +0200 Message-Id: <94228658a6582daf009196f351cf665857826a4f.1617725759.git.bnemeth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=bnemeth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH] vhost: read last used index once X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Instead of calculating the address of a packed descriptor based on the vq->desc_packed and vq->last_used_idx every time, store that base address in desc_base. On arm, this saves 176 bytes in code size of function in which vhost_flush_enqueue_batch_packed gets inlined. --- lib/librte_vhost/virtio_net.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 179c57b46..f091384a6 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost/virtio_net.c @@ -217,6 +217,8 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev, { uint16_t i; uint16_t flags; + uint16_t last_used_idx = vq->last_used_idx; + struct vring_packed_desc *desc_base = &vq->desc_packed[last_used_idx]; if (vq->shadow_used_idx) { do_data_copy_enqueue(dev, vq); @@ -226,16 +228,17 @@ vhost_flush_enqueue_batch_packed(struct virtio_net *dev, flags = PACKED_DESC_ENQUEUE_USED_FLAG(vq->used_wrap_counter); vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) { - vq->desc_packed[vq->last_used_idx + i].id = ids[i]; - vq->desc_packed[vq->last_used_idx + i].len = lens[i]; + desc_base[i].id = ids[i]; + desc_base[i].len = lens[i]; } rte_atomic_thread_fence(__ATOMIC_RELEASE); - vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) - vq->desc_packed[vq->last_used_idx + i].flags = flags; + vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) { + desc_base[i].flags = flags; + } - vhost_log_cache_used_vring(dev, vq, vq->last_used_idx * + vhost_log_cache_used_vring(dev, vq, last_used_idx * sizeof(struct vring_packed_desc), sizeof(struct vring_packed_desc) * PACKED_BATCH_SIZE);