From patchwork Thu Apr 1 13:32:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ma, WenwuX" X-Patchwork-Id: 90251 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1B81A034F; Thu, 1 Apr 2021 03:38:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5CBF8140F79; Thu, 1 Apr 2021 03:38:35 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 3EDE240142 for ; Thu, 1 Apr 2021 03:38:33 +0200 (CEST) IronPort-SDR: gigvc4C7tWi4ZJEG3e21cJJSiDLZXF5gv9U+a86mce0HF6PqK7HElDrA9/fqJULVWxohqpO0is Mpf4X8DLYFBw== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="192152123" X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="192152123" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 18:38:32 -0700 IronPort-SDR: GMM7z8fMuJQ9E9VN7tYisjtoKRC7FXpBJVKTv5KAa6mQDeEq63mbfQdGEzjE73Boz7nzgK8OOA Tw+gJ5UcULsw== X-IronPort-AV: E=Sophos;i="5.81,295,1610438400"; d="scan'208";a="455754536" Received: from unknown (HELO localhost.localdomain) ([10.240.183.109]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 18:38:30 -0700 From: Wenwu Ma To: qiming.yang@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org Date: Thu, 1 Apr 2021 13:32:15 +0000 Message-Id: <20210401133215.17962-1-wenwux.ma@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access in releasing vsi X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When deleting the mac filter in ice_remove_all_mac_vlan_filters(), TAILQ_FOREACH_SAFE should be used instead of TAILQ_FOREACH, Otherwise, it will result in a illegal pointer access. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9c9b84a93..8cc8d4c7a 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -1094,12 +1094,13 @@ ice_remove_all_mac_vlan_filters(struct ice_vsi *vsi) { struct ice_mac_filter *m_f; struct ice_vlan_filter *v_f; + void *temp; int ret = 0; if (!vsi || !vsi->mac_num) return -EINVAL; - TAILQ_FOREACH(m_f, &vsi->mac_list, next) { + TAILQ_FOREACH_SAFE(m_f, &vsi->mac_list, next, temp) { ret = ice_remove_mac_filter(vsi, &m_f->mac_info.mac_addr); if (ret != ICE_SUCCESS) { ret = -EINVAL; @@ -1110,7 +1111,7 @@ ice_remove_all_mac_vlan_filters(struct ice_vsi *vsi) if (vsi->vlan_num == 0) return 0; - TAILQ_FOREACH(v_f, &vsi->vlan_list, next) { + TAILQ_FOREACH_SAFE(v_f, &vsi->vlan_list, next, temp) { ret = ice_remove_vlan_filter(vsi, &v_f->vlan_info.vlan); if (ret != ICE_SUCCESS) { ret = -EINVAL;