From patchwork Thu Feb 25 11:13:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ZhangTengfei X-Patchwork-Id: 88213 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69D64A034F; Thu, 25 Feb 2021 12:13:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB21C16077D; Thu, 25 Feb 2021 12:13:58 +0100 (CET) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-eopbgr1310048.outbound.protection.outlook.com [40.107.131.48]) by mails.dpdk.org (Postfix) with ESMTP id D4FB140692 for ; Thu, 25 Feb 2021 12:13:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FsBPP3W80l0f7/zO7vKS3w8HUuDsagIsew+HPgIYoTlzu0zC3+RQS7MVvODHaFOwaMmpYFffba99qWNbzfe1IifJN41fvB/sAhuJ2oRFC4ZPisWHCAmMc/wUah5Dtw8LVXfWDAFVohSSlfCQMmMdSQIGq93wgKdyWeNG+qNl7P+Zw0+ZRpPzcEDIf881SuSHKyarUaBfoRiRl0E0UjDzf6jOKsrVnEOc7lkr3NZ/zrpeR8EVMpmULR+IauEazK08KAyGpTnqKns5GRa1vflqvBUUrgoIY/B7L9YrfQ1wFE1UCAVnHGFjw9oN5fZjrYcEAtyFG3JytEWaqhjmuzk4BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hlPhD0s2urDZKuPxtOV0JNj157IrGmXanwCaIGzTUs=; b=A2eWSGoqjoYnH5wFBQ1Vd5ZJF0Wev4WCw8dlQRVWr1OXbf1bu+h3cWV+LVwDNnTDrZ/Qy4taRC/sGZXaWqF9NeY7+ywqS22rZGct2TlrnUV65SYD2QC2ipdZSkHmyfKBVQ32I0pUPggI1FK6A8DyZ5+zf94nclRy9Gn4OKJOSvb63XlhREUbzdv1KedH2vyrF6XAg9rJihEHYnR7UHvZdT8CWx/VWNtGhgudqdc9mGPlKi3VeOg34vIYgXUMVSv92A4UqcTjBFhDJaQvWojrS2VGnKkBpTlEKLqjX7XTpSWvAnX+9JuGZE8vIQmky2TPWeExNV6tWTRFZr1Ka/09tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1hlPhD0s2urDZKuPxtOV0JNj157IrGmXanwCaIGzTUs=; b=ie0pkwuOVn2YCzycjH9cJwC6IGppduKRLVj1sbElZcX77/v0I8giiuLC7V+0qo5YJESsuNVCUS5cLIG2B6obHWVK4N6/WrfFkjbt1HOJ2aL/E4KPzI1W4WRtYGMFnfgUM3QNooTM26JJ0KMdgFL/xbpZgrqnvzjUXxA8HVqvlCg= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oppo.com; Received: from SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) by SG2PR02MB3720.apcprd02.prod.outlook.com (2603:1096:4:37::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.29; Thu, 25 Feb 2021 11:13:54 +0000 Received: from SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9]) by SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9%6]) with mapi id 15.20.3868.033; Thu, 25 Feb 2021 11:13:54 +0000 From: ZhangTengfei To: ferruh.yigit@intel.com Cc: dev@dpdk.org, ZhangTengfei Date: Thu, 25 Feb 2021 19:13:28 +0800 Message-Id: <20210225111327.1809-1-zhangtengfei@oppo.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [58.252.5.72] X-ClientProxiedBy: HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) To SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from N80315124.adc.com (58.252.5.72) by HK0PR01CA0058.apcprd01.prod.exchangelabs.com (2603:1096:203:a6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.19 via Frontend Transport; Thu, 25 Feb 2021 11:13:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c164f95-a899-45d7-f3cd-08d8d97e6fc3 X-MS-TrafficTypeDiagnostic: SG2PR02MB3720: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SY4+vWngarHzSrpBU74kvgahsg4ITb81A+md52/A4lv7ecn1b6hkP44m4qVTPy0/lzwLBoW8gAVfl2UcQf1miAXtcm4uiSOOGBJfEztsE3//iddYKGTpI9AUz/Qj426xXMcuVP0ybAIUudInXgtab/Lgt9QLDFkMFRHjQ35N+jWQZ57KS45HOyVvNjW83edw8G5OabhIBVNY7tn55P7l44Mm0N5zge2+9+DVakndv/Hg2aXx7IPh59ivxv4lKwLwG1fCwOY6AXveLy6OeVs0Ss1w9Ph39aV/HCY9Wvk75JNsxpP6THWun3dCUIDgam4Ltw+/smUXBXJrDU4cOCNLteIB8y9sopjvJa6KAwgEahIWiovMG2jwqU6180GcnhhKTBBozvWWzJ6GIZFwc5RfynI4lLVSv9mWV+MlHlPgM4LLnwpmlu5XKZvBwUjd/kkahCgMOQAO4vAIX5o/0UVX19BJ/uyX51hAmbs5wRPYgb5FiefLyPNYHI4sRCvdwOOO+GhYhzLBTBYM5V7wBhy/zERVuipDLWrNpJ6x6uCtlRT+8CouMdyrf7lmXbcTerB4 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SG2PR02MB3452.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(136003)(396003)(39860400002)(366004)(107886003)(6512007)(316002)(66476007)(4326008)(66946007)(86362001)(6486002)(83380400001)(478600001)(66556008)(26005)(1076003)(6916009)(8676002)(8936002)(2616005)(956004)(16526019)(2906002)(5660300002)(36756003)(52116002)(6506007)(6666004)(186003)(11606007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: VjJqlaC5KOEmPl9e+t5egx3neA3seDRXZHXUe685+Zjw9itTOuwt3KTaYF1uYCgfj4pmU04v0XhNFEjHTJqLtcX988kDMONUeDfkdnzxlKWSOLFwbpwzQXnktmh8eNGRnzU6ElylafoqqstKy+JK5SQDrfP5OUzsPqLSaXXYlWNAwN6Pz/RedewTTJ0903gveW17DDq5MvAfCab27yPLhGLQighNg0FZmiR5U3bLPdEmXk0Rq+r91ocbUinRPIVOjmjEoI98Vuv3VB94dGHS9/6S7eum131EXaYk2jI69zhDLVJT6/CaDMIHVmeqFnFK1AIUMSwXoSZi2dnMLYlHLmXM9suUyG6sscUV+dxCJ28ww3k0tWNPrWLZTtkZGtyFBRVwmUUA4nm6TSBKYFk0wq9it+Q6w/+QGUu9Gj35FfGlez9VXttr0nT8lc+3xOF1cgUahvY1kn3+Xc8ZMyuID7gsSnPwSgNiBHDvYxZey9xqV8GFQwqWCjJsnZV+0WQ388WJ4RbcgSvlB/9UMHmID8jA427qY+oW7gD0uPiihcQ+4XpsYZp0xIBBaiDIXYB88nMvRoiiQD1W7rZkwO3IMJDn4nk0zMJrM6L2SP5BwB+0/f9vr60EtKFyUdOkmgWVG1XiAEGkOzjT0Q/w41g9rVBsYIP+62gilhO9xQ5e0OcFNP0wM5KVplCxOj+WIuVwHEmcTegkiqGtxneZ1eL2gL9pSTX0cb8aBAiVPlIHNdJU2yDc8D1zPHxpm86Z/uaywDPgdM0z5Fwr00eciduPMI+qvWgHUEEjNrIp2rizICmhuotyP3pSXVNG/CkQAhXk+fXcVmcjVZ2JMAphY+JvzPeAnJsw1HS/0H4gyeBglvonTmeu5R/kX6dtn6aDZm/qxFq//eqnCg753WDh6VG6qzkRZoaCxR8fPlxsY54zZ9MPg0VCTLoCDNy4UeAnD1va3hc6F093Wu85geJ3WtYv6ObRcU1wm7oRWbga7JYyLRzNaI6y8UwcQ+trhZrOAnRlRc/KOumZq7bmYAwshdc46VQp5zFf959Y27trN8tYM+J+KM5hQdMUJy34pLHuRStiDG0APBtGvepgbvicXFUeqxSeE5TXK7ekGsOoHFw3rKqj6ZP91TpmAx7uE0VHdlZKQg5XEU99uhzMsmJE/w+UJdD/BSpTiWldf9VGDoukiBm8DfGsBJ7IpUEQbGyqg6htVmrFAFOQkgeQMnAr0ceBth4SXb4LnS7eARzFkU2Pro1sfzTaoUyKCuNeOgGaUZqw368jm5Yx7wDUQ2/Cv/6sqKkqJZqG/xcOpcIUOk+DKUtBqkEyKcEpR+WYXAP16a4i X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c164f95-a899-45d7-f3cd-08d8d97e6fc3 X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB3452.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2021 11:13:53.9463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cLanC6pMvaKyPd12hJQz4tqquENpVg2I0igNr/omHbIaVTMrzJaQk0MdboNmwFZTMOSjsgvQ2wvnHFDW9vgGgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR02MB3720 Subject: [dpdk-dev] [PATCH v2] driver/net/pcap: fix fd leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pcap file was opened when pcap vdev probed, but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d75ea..fb01ea924 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1597,6 +1597,7 @@ pmd_pcap_remove(struct rte_vdev_device *dev) if (eth_dev == NULL) return 0; /* port already released */ + eth_dev_stop(eth_dev); eth_dev_close(eth_dev); rte_eth_dev_release_port(eth_dev);