From patchwork Thu Feb 25 08:59:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ZhangTengfei X-Patchwork-Id: 88203 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82176A034F; Thu, 25 Feb 2021 09:59:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68CD616080C; Thu, 25 Feb 2021 09:59:35 +0100 (CET) Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-eopbgr1320052.outbound.protection.outlook.com [40.107.132.52]) by mails.dpdk.org (Postfix) with ESMTP id 7419F40692 for ; Thu, 25 Feb 2021 09:59:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rk2qMfv+XV9krGSRQui7rvWdYYsCM5B5W8s5ZruCH5/7s6z4BaEIDbnsjQctJGs88b+NvfW8FAjhJWUIGT4Ue1TZC4VGJrSVHca8B6ySOqNhFxsImU5hmQNLTes3gWIFbUZrYxH+vIrhLsMiDMCAUXFmgeZyDaP3zjLfY4yXOOmdTpgf6loyJg0bSdou/qaylHwYb7BTN952dUQZLvDrHs74PVvm+ooZ4by74J5pp5nACGyXR9m9ijz07zVnHL3ME/hXUSpV5iLaqS2vW7zNiFpWrOy/LttT4LdF6XVm2C6OITiHnEmyIEeJhJUMPOkhd2tspPne/QbEJhjtxWazRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9GsySZ6H6FYnJlm9qKCAnyk0bSF/vts4VkMy8lLO57Y=; b=ijyhHAldvvzeUvw84dADKEKwLi2tjpZOIFrRlMvlziB/nbAXJS9kQPfU0e4ojfRj8VMZ7OJKx6CSgvcVBUcHfnk62vOPHPq0OlNSbDcIYhyzB9rUR57V/lZM9chMg+m0Gtyr+CBRjeWX2VU9ebIAJEppqzAEuTSIady2g3gWnZximuQiWu/BPLOTHod3vH6zC/oP2Zao0H+Ot5Bx/AQLE7j8rfuAs/JmMB5HzTxoaQtgk+7BrhMN6WUtRvzEFAjz2eFSY52nd5J+/IkHrT/NvEI2lHlCtUS1cKRu5WPnQYhdQql0XRzjKYbQpvbQrLdnDQwAyONXfn9yWPa6eD0aYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oppo.com; dmarc=pass action=none header.from=oppo.com; dkim=pass header.d=oppo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oppo.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9GsySZ6H6FYnJlm9qKCAnyk0bSF/vts4VkMy8lLO57Y=; b=k62710ZPjkkFq/qrCLlYRHdlNLlRM1RxL9Qe+h05WpnoZ8lV1PJimcOqPX4UNujmHmRYvRqLrIvs+r6QWuveICRyG4cYZcOjjg/jDob48VikS2jm113mWeQFmP8goKaCNqyw5BKpCsw2p6Maal5VU+6AmN9jxQECdTRS9j9Nb64= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=oppo.com; Received: from SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) by SG2PR02MB2478.apcprd02.prod.outlook.com (2603:1096:3:1d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3868.27; Thu, 25 Feb 2021 08:59:27 +0000 Received: from SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9]) by SG2PR02MB3452.apcprd02.prod.outlook.com ([fe80::ac8d:e4d8:efcb:34c9%6]) with mapi id 15.20.3868.033; Thu, 25 Feb 2021 08:59:26 +0000 From: ZhangTengfei To: ferruh.yigit@intel.com Cc: dev@dpdk.org, ZhangTengfei Date: Thu, 25 Feb 2021 16:59:02 +0800 Message-Id: <20210225085902.2536-1-zhangtengfei@oppo.com> X-Mailer: git-send-email 2.25.1 X-Originating-IP: [58.252.5.72] X-ClientProxiedBy: HK2PR02CA0213.apcprd02.prod.outlook.com (2603:1096:201:20::25) To SG2PR02MB3452.apcprd02.prod.outlook.com (2603:1096:4:4f::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from N80315124.adc.com (58.252.5.72) by HK2PR02CA0213.apcprd02.prod.outlook.com (2603:1096:201:20::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.20 via Frontend Transport; Thu, 25 Feb 2021 08:59:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 949bf46a-92d4-4134-1c93-08d8d96ba73e X-MS-TrafficTypeDiagnostic: SG2PR02MB2478: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mppZ3gq3AFUgjldvgj/pvOVADA7taDz6PIZ/fFFFL5BXutLkTWT8lGCIbnSfkUvN7076PK9zfyiBlDvizPPbgJ69g4PwIjOWJKxtFMDBWYzT8HOVrOAY+VnOQNWCaN+qaYMC4ckVTBlvV93ZZrpef/2poGJlv+H6EanmtY4xptb/xYsI2e4Qtp4eeCT8xmbAluybK4cMd1kgIA2FF3pFJkuyOa/EtKVe7+ckSVVYaMvYyyi+sKcO6Wmv2YR6I53oGJmgnrk5m/gkVO3ksfRQjdZCUrLB7FVSjRf/SK/YxJuNXnaPw5NN0YsdFau02GRxWoMla0m7IDF3rGnkEG3+tYmKm4bX7NbonBRsuUKZyeiGpMI6lCiq/7+/HqsjcBGVP6nLCXXEB08C2XAlxoBiNTSKVnEyQ6FU35bQJpESyZmUZu2fB10QdBkMMoq3CPtPJv97m9ume48YWXKcJhMQZRHSdI5sASjrivgtHWf+gcwvJxSgIjIZvNv0uEwNTD3ervPT8h1F3ZeU5ANX1gayfQCfhuWIAAZYy20qz3VFy/khuwm5PgzPukjD9iTCLwpO X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SG2PR02MB3452.apcprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(346002)(366004)(376002)(2906002)(6916009)(316002)(478600001)(6666004)(8936002)(83380400001)(107886003)(956004)(8676002)(4326008)(6506007)(186003)(66556008)(66476007)(1076003)(36756003)(66946007)(5660300002)(2616005)(86362001)(16526019)(52116002)(6512007)(6486002)(26005)(11606007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: Uz8dC4xfll2p0LspyLWpUYPuY/q3rQpilSRpWTC/W6dNGiK6TkEkmwHgIPo4KocjpIwJX1Pael9hqQG0MfnlGI0bfTLxK7FMb6oDa144hp/Vv8VBkoOSoqtPxaYBKFPS1pRzBqx564OSqi2zKK48F/CRUlNQkn2e5kV/PEJrbt0Th52oNnSLUnxLnKxM4FPR8uJ248wTRU4oSMgYTQIs4AEG4aGeroEMfbWhZTWX67eC9Fnf0fh+ZC/TFDKVLbht/8ehbMEH5bjHRhDOrVjzkP50sYVkC9OGnn8enabUDpCkChAOQvnC39ZVepDOFidwhM7a7r25tpXNUtCxDXHM0MjD3DEpqyXxf5r4nLspbj1Cff+e9Zq5iyVTvXnfdHZC8dA8u+PJYOyVJ5PIQCBGvzEfOoIRRmY55ISHnxEzxVNqos9Ks/x3q/8nDkLLKgbK6h9bPyFsQ55NdI4ALkcpTv8xauccKXfh9315eM+3UujQ8GihULt964X7DAlSDbGnYLUHZEjGMi2T9948wV5Zv+EkcJp/xyl0Y7oqImkiAHzLu9R1IebtUvukF/Loi275QD2XmGbLdbZhiIl8woNEdNnn2Y989g7GvEKWi+fBEqJqGLo26r2T9QUQdG3VVjwogiF51zQ5ocphP6Up4AUQLGvlmhgLBpKq9bwB1l2Gfr16kqKRFPUETJrfW+Dfd/CRbpv8Bd365KM1d4aLItf14i0co4ZsLxJ939zAVhl2jgZANVu7toPLo5vm7UVlVaJ7Tb+UKyahb2/WoSQL12E6vbD7A17gSHhyU2cb7lFYrhIAD+9HRsiCst4Ai6R7Uo9zbUpsbzQE/2K7BD83fhMynxc11mH5IYV8k3sXWvZ+MXywuQoiWNiGSHZpHUBBAp6Og8pI6GSOUTKtqx32X73jxwgTlphaGqjkGEGuAuKeV5Yx3lT8amRp3qmMEWkdAAFlCszuDD3pg7VwtJY/ZdAbLyTd3/VoN59FeRoXuLV1d4WMutqoN7AnljK6Fw6+A2D6dts+A5FhX3kWS1nMar6Sv0ERqkT8mAJD+fJa6sf5q84WfrAFffUhBPHgULBjtI8b8BvA/fi9xJvFWGdwfOkbCpQY8Eq2C+oPgmokuOYGQXqczwSdh7aaCLrPiOTpnr0AfV1noSDITqVrSLKUmo4SG2OfQ7pY/+kfviwufDGmCTC4oUeuER/qLx/qnYvyJ5qSSxbUQMQY/lYZeNvZ4jo0QdJHbFfdv9VFD0yvsjdtAjADv/ahoHbblFrrZNUYznHONFQYM4C1Xf5Cwa5bvS7AAO6mHdgXZAQh2USK5Mt6pwXcFi3lh9Tt7CVYcHOh8DFZ X-OriginatorOrg: oppo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 949bf46a-92d4-4134-1c93-08d8d96ba73e X-MS-Exchange-CrossTenant-AuthSource: SG2PR02MB3452.apcprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2021 08:59:26.7916 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f1905eb1-c353-41c5-9516-62b4a54b5ee6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TIZOJk/7KzNplhAOs5LfAmxGzvzkK4/127l6MceEeGvzsppPg8hp4zMobkebFjoVOIJKIqp0lMv0f6iixAmr4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR02MB2478 Subject: [dpdk-dev] [PATCH] driver/net/pcap: fix fd leak X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" pcap file was opened when pcap vdev probed; but was not closed where vdev removed. This bug appears in dpdk-pdump Signed-off-by: ZhangTengfei --- drivers/net/pcap/rte_eth_pcap.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 90f5d75ea..96d189f19 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -1597,6 +1597,7 @@ pmd_pcap_remove(struct rte_vdev_device *dev) if (eth_dev == NULL) return 0; /* port already released */ + eth_dev_stop(eth_dev); eth_dev_close(eth_dev); rte_eth_dev_release_port(eth_dev);