From patchwork Tue Feb 9 15:26:43 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 87831 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 498B3A0549; Tue, 9 Feb 2021 16:26:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1436F4014E; Tue, 9 Feb 2021 16:26:50 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 70C2940147 for ; Tue, 9 Feb 2021 16:26:48 +0100 (CET) IronPort-SDR: 4k1zrTJei26Un/EYL+C3/PUZDm5jE8q9YOrIwWyMo/2kLmjwiWp1MnFxjQijn+euGWq/YHlzG5 LLNtmBe308/A== X-IronPort-AV: E=McAfee;i="6000,8403,9889"; a="169576576" X-IronPort-AV: E=Sophos;i="5.81,165,1610438400"; d="scan'208";a="169576576" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2021 07:26:47 -0800 IronPort-SDR: jG+QnpKouy4DqTP37w1Usfec2BIxcoXl3QJsJWn5/mrhGRErhAQ4Mmtw9NNWXleCXYo2q7eOc9 oG8hMDuWTL+g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,165,1610438400"; d="scan'208";a="436197965" Received: from silpixa00399752.ir.intel.com (HELO silpixa00399752.ger.corp.intel.com) ([10.237.222.27]) by orsmga001.jf.intel.com with ESMTP; 09 Feb 2021 07:26:45 -0800 From: Ferruh Yigit To: Thomas Monjalon Cc: Ferruh Yigit , dev@dpdk.org, David Marchand , Aaron Conole Date: Tue, 9 Feb 2021 15:26:43 +0000 Message-Id: <20210209152643.1832506-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] devtools: add llx format specifier check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" %llx tends to be wrong when used for fixed size, like uint64_t, variables, adding a warning to double check them. Signed-off-by: Ferruh Yigit --- Cc: David Marchand Cc: Aaron Conole --- devtools/checkpatches.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh index 78a408ef9823..68005389820a 100755 --- a/devtools/checkpatches.sh +++ b/devtools/checkpatches.sh @@ -118,6 +118,14 @@ check_forbidden_additions() { # -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ "$1" || res=1 + # check %llx usage + awk -v FOLDERS='lib drivers app examples' \ + -v EXPRESSIONS='%ll*[xud]' \ + -v RET_ON_FAIL=1 \ + -v MESSAGE='Please check %llx usage which tends to be wrong most of the times' \ + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ + "$1" || res=1 + # svg figures must be included with wildcard extension # because of png conversion for pdf docs awk -v FOLDERS='doc' \