From patchwork Fri Jan 22 03:19:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ding, Xuan" X-Patchwork-Id: 87048 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43AAFA0A0A; Fri, 22 Jan 2021 04:20:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D49B5140DF7; Fri, 22 Jan 2021 04:20:12 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 3A2B3140DEA; Fri, 22 Jan 2021 04:20:11 +0100 (CET) IronPort-SDR: pwFIiaKuf4X5Y7Csxmj97jVo9WgR96S0fo8E72feTyztcP0QiTi3+JkbhS3JAeOAJYfVBQxvCL 3uiwH5BoMIag== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="166483170" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="166483170" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 19:20:09 -0800 IronPort-SDR: HnE53paQWFd/JDlbJcXSaNb9NfMCC9DV3LALrksxAErI1uJ+0SfKVuW3bYc+lQQ5j+u9IS4FKd bcyAeLpjmHSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="385590019" Received: from dpdk-xuanding-dev2.sh.intel.com ([10.67.119.124]) by orsmga008.jf.intel.com with ESMTP; 21 Jan 2021 19:20:07 -0800 From: Xuan Ding To: qi.z.zhang@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com Cc: dev@dpdk.org, Xuan Ding , stable@dpdk.org Date: Fri, 22 Jan 2021 03:19:22 +0000 Message-Id: <20210122031922.48867-1-xuan.ding@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/iavf: fix symmetric rule creating X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Only allow to create symmetric rule for L3/L4. Fixes: 91f27b2e39ab("net/iavf: refactor RSS") Cc: stable@dpdk.org Signed-off-by: Xuan Ding Acked-by: Beilei Xing --- drivers/net/iavf/iavf_hash.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 958c73c4fb..5fa2f3cf59 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -927,6 +927,13 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func, if (rss_type & (ETH_RSS_L3_SRC_ONLY | ETH_RSS_L3_DST_ONLY | ETH_RSS_L4_SRC_ONLY | ETH_RSS_L4_DST_ONLY)) return true; + + if (!(rss_type & + (ETH_RSS_IPV4 | ETH_RSS_IPV6 | + ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP | + ETH_RSS_NONFRAG_IPV4_TCP | ETH_RSS_NONFRAG_IPV6_TCP | + ETH_RSS_NONFRAG_IPV4_SCTP | ETH_RSS_NONFRAG_IPV6_SCTP))) + return true; } /* check invalid combination */