From patchwork Thu Jan 21 12:46:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 87028 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 734AEA09E4; Thu, 21 Jan 2021 13:46:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7D04140DD9; Thu, 21 Jan 2021 13:46:41 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id 0AE80140DB2 for ; Thu, 21 Jan 2021 13:46:39 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from viacheslavo@nvidia.com) with SMTP; 21 Jan 2021 14:46:35 +0200 Received: from nvidia.com (pegasus12.mtr.labs.mlnx [10.210.17.40]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10LCkZHu014470; Thu, 21 Jan 2021 14:46:35 +0200 From: Viacheslav Ovsiienko To: dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, wenzhuo.lu@intel.com, stable@dpdk.org Date: Thu, 21 Jan 2021 12:46:33 +0000 Message-Id: <1611233193-20886-1-git-send-email-viacheslavo@nvidia.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is the "set rxpkts" command in the testpmd interactive mode, it configures the segment sizes to split the packet on receiving. The mentioned segment sizes are provided on the Rx queue setup as part of queue configuration. Hence, to take the rxpkts command into effect the Rx queues must be explicitly reconfigured. The explained above is related to the "set rxoffs" as well. The patch sets the queue reconfiguration request flag for all devices once Rx split settings are updated, to take the changes into effect the port(s) should be restarted. Fixes: 0f2096d7ab36 ("app/testpmd: add rxpkts commands and parameters") Fixes: 91c78e090eed ("app/testpmd: add rxoffs commands and parameters") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 0d2d6aa..3ffc7bf 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -3782,6 +3782,7 @@ struct cmd_set_rxoffs_result { MAX_SEGS_BUFFER_SPLIT, seg_offsets, 0); if (nb_segs > 0) set_rx_pkt_offsets(seg_offsets, nb_segs); + cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1); } cmdline_parse_token_string_t cmd_set_rxoffs_keyword = @@ -3828,6 +3829,7 @@ struct cmd_set_rxpkts_result { MAX_SEGS_BUFFER_SPLIT, seg_lengths, 0); if (nb_segs > 0) set_rx_pkt_segments(seg_lengths, nb_segs); + cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1); } cmdline_parse_token_string_t cmd_set_rxpkts_keyword =