From patchwork Thu Jan 14 11:05:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86592 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B512A0A02; Thu, 14 Jan 2021 12:06:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 970F814114C; Thu, 14 Jan 2021 12:06:19 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2E464141149; Thu, 14 Jan 2021 12:06:18 +0100 (CET) IronPort-SDR: ymBSxnxeUphu8+bntQlx8GZV/A17deB2qBKdGXD6vDHOzAnFF02SGUylZ81lRuAS0c+mqH0QTH lZ0JS+TKGjHg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="175765756" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="175765756" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:15 -0800 IronPort-SDR: KLV50OGYvEgfvUFZopA3jZn2EwH3MxUG/BzT1pY8FL4CahLxo3h0u8H7gEJfQ8nAq76Gi5pDsV xb97GLZWlbRg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139780" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:14 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:47 +0000 Message-Id: <20210114110606.21142-2-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 01/20] eal: fix missing header inclusion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_reciprocal header file used standard __rte_always_inline from rte_common.h but does not include that header file, leading to compiler errors when the reciprocal header is included alone. Fixes: 6d45659eacb8 ("eal: add u64-bit variant for reciprocal divide") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_eal/include/rte_reciprocal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/include/rte_reciprocal.h b/lib/librte_eal/include/rte_reciprocal.h index 63e16fde0a..4a59be30a8 100644 --- a/lib/librte_eal/include/rte_reciprocal.h +++ b/lib/librte_eal/include/rte_reciprocal.h @@ -26,6 +26,7 @@ #define _RTE_RECIPROCAL_H_ #include +#include struct rte_reciprocal { uint32_t m; From patchwork Thu Jan 14 11:05:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86593 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07633A0A02; Thu, 14 Jan 2021 12:06:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D412F141153; Thu, 14 Jan 2021 12:06:22 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id EECE7141149; Thu, 14 Jan 2021 12:06:18 +0100 (CET) IronPort-SDR: xG8uyAR782N/ygXpftHZRhqnolbZGK42PmEcNzCj44rjD0JkoEOKa3odpylKwai7B5jsCDO8iJ YULYajE/3FWQ== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="175765758" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="175765758" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:17 -0800 IronPort-SDR: Uq8E/X2NDtqnhV1sPqIcUjr1OhIv9s0frea6tBEPbJyoiHos39dVOfBBQrtMQOlVEFklPTfWxt FFYy60I4AEgg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139787" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:15 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:48 +0000 Message-Id: <20210114110606.21142-3-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 02/20] telemetry: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The telemetry header file uses the rte_cpuset_t type, but does not include any header providing that type. Include rte_os.h to provide the necessary type. Fixes: febbebf7f255 ("telemetry: keep threads separate from data plane") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_telemetry/rte_telemetry.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_telemetry/rte_telemetry.h b/lib/librte_telemetry/rte_telemetry.h index 4693275c24..561c6b1658 100644 --- a/lib/librte_telemetry/rte_telemetry.h +++ b/lib/librte_telemetry/rte_telemetry.h @@ -5,6 +5,7 @@ #include #include #include +#include #ifndef _RTE_TELEMETRY_H_ #define _RTE_TELEMETRY_H_ From patchwork Thu Jan 14 11:05:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86594 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E056BA0A02; Thu, 14 Jan 2021 12:06:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 72C0214115D; Thu, 14 Jan 2021 12:06:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 34B6314114A; Thu, 14 Jan 2021 12:06:18 +0100 (CET) IronPort-SDR: yaEy2INagnT7jkN8Gkce3i6wIWuunQg4bPxuSsCR0Wj48dmWnQsvpeVMLChV3O7xPcjGExzkB5 kCswc0P/o3OQ== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="158122346" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="158122346" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:17 -0800 IronPort-SDR: BwDnM4HeDWVAqDQPoYc+QEzPE5yD38kUKbZN/9PToWAe74Ndv9IomIdu/W+CuzZpFhRJADpqOy bmXf3GpjXvKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139795" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:16 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:49 +0000 Message-Id: <20210114110606.21142-4-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 03/20] ethdev: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The define for RTE_ETH_FLOW_MAX is defined in rte_ethdev.h, so that header should be included in rte_eth_ctrl.h to allow it to be compiled independently. Fixes: 7fa96d696f2c ("ethdev: unification of flow types") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ethdev/rte_eth_ctrl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ethdev/rte_eth_ctrl.h b/lib/librte_ethdev/rte_eth_ctrl.h index 1cca522fa3..8a50dbfef9 100644 --- a/lib/librte_ethdev/rte_eth_ctrl.h +++ b/lib/librte_ethdev/rte_eth_ctrl.h @@ -9,6 +9,7 @@ #include #include #include "rte_flow.h" +#include "rte_ethdev.h" /** * @deprecated Please use rte_flow API instead of this legacy one. From patchwork Thu Jan 14 11:05:50 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86595 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DF44A0A02; Thu, 14 Jan 2021 12:06:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF8BE141164; Thu, 14 Jan 2021 12:06:25 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id A7BA214114D; Thu, 14 Jan 2021 12:06:19 +0100 (CET) IronPort-SDR: 2IQXgauvys1QQWhReIGbJssreLk4nNPEbIfqP/7nogFmqpvGDC6nEBXsFtiZ54rAuRvvCFNUfz GI6n7scy6L4g== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498502" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498502" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:18 -0800 IronPort-SDR: zTuXM13todfTl5cxnSbql/znnl2U079ZC8h2DSJQB2Thfa1q64w+gI3t/jKL9equn7h/2wzl9P oyVbcSfRSb1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139806" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:17 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:50 +0000 Message-Id: <20210114110606.21142-5-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 04/20] ring: fix missing includes for c11 model header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add in the missing includes into the header file for c11 memory model, so it can be compiled up independently of the other headers. Fixes: 39368ebfc606 ("ring: introduce C11 memory model barrier option") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ring/rte_ring_c11_mem.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h index 0fb73a3371..12caf06a31 100644 --- a/lib/librte_ring/rte_ring_c11_mem.h +++ b/lib/librte_ring/rte_ring_c11_mem.h @@ -10,6 +10,10 @@ #ifndef _RTE_RING_C11_MEM_H_ #define _RTE_RING_C11_MEM_H_ +#include +#include +#include + static __rte_always_inline void update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val, uint32_t single, uint32_t enqueue) From patchwork Thu Jan 14 11:05:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86596 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02716A0A02; Thu, 14 Jan 2021 12:06:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 04B5B14116D; Thu, 14 Jan 2021 12:06:27 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 8548F14114D; Thu, 14 Jan 2021 12:06:20 +0100 (CET) IronPort-SDR: UGuZ9QVjbrrkk3JUkD+1T790edMzIN9/Vs5xW8MsEkLP7bV3RbZkoREn3GjV+BfFvAApMwtoya 9Mwtm2oVc0lw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498508" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498508" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:19 -0800 IronPort-SDR: +MJVJq38MpjP3BnmZK0i6/ajpU/C1975ZoCCcqxwlNwmEK1iW+kzQtjftFJzlnPisRVs6oLP2F wRJg86b/W7dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139817" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:18 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:51 +0000 Message-Id: <20210114110606.21142-6-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 05/20] net: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The Geneve protocol header file is missing the rte_byteorder.h header. Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_net/rte_geneve.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_net/rte_geneve.h b/lib/librte_net/rte_geneve.h index bb67724c31..7c3d477dcb 100644 --- a/lib/librte_net/rte_geneve.h +++ b/lib/librte_net/rte_geneve.h @@ -11,6 +11,7 @@ * GENEVE-related definitions */ #include +#include #ifdef __cplusplus extern "C" { From patchwork Thu Jan 14 11:05:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86597 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48CFEA0A02; Thu, 14 Jan 2021 12:07:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BE72141173; Thu, 14 Jan 2021 12:06:28 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 57B86141153; Thu, 14 Jan 2021 12:06:21 +0100 (CET) IronPort-SDR: RCjLxhmO7VglQj1TQd+m/WAHNc/lamEZFafAjo3SCdUWPDdb8Se5bSnuXKLqtso6ZxXD1R6MjG pIpi2e1yWicg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498511" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498511" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:21 -0800 IronPort-SDR: 0l6aOE1LbKhN+MNYnskLlpfSO1C40LizBw6QTER/H1/TjiQZmceNck9c0eyVAOL9NinXerNky2 QSgCfpvnEAwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139822" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:20 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:52 +0000 Message-Id: <20210114110606.21142-7-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 06/20] mbuf: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_mbuf_dyn.h header file uses a number of types and macros without including the required header files to get the definitions of those macros/types. Similarly, the rte_mbuf_core.h file was missing an include for rte_byteorder.h header. Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") Fixes: 3eb860b08eb7 ("mbuf: move definitions into a separate file") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_mbuf/rte_mbuf_core.h | 1 + lib/librte_mbuf/rte_mbuf_dyn.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h index 567551deab..34e892f21b 100644 --- a/lib/librte_mbuf/rte_mbuf_core.h +++ b/lib/librte_mbuf/rte_mbuf_core.h @@ -18,6 +18,7 @@ #include #include +#include #include #ifdef __cplusplus diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h index d88e7bacc5..1286a5ccf7 100644 --- a/lib/librte_mbuf/rte_mbuf_dyn.h +++ b/lib/librte_mbuf/rte_mbuf_dyn.h @@ -66,7 +66,10 @@ * - any name that does not start with "rte_" in an application */ +#include +#include #include +#include /** * Maximum length of the dynamic field or flag string. */ From patchwork Thu Jan 14 11:05:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86598 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB575A0A02; Thu, 14 Jan 2021 12:07:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A84B014117B; Thu, 14 Jan 2021 12:06:29 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id E42F5141156; Thu, 14 Jan 2021 12:06:22 +0100 (CET) IronPort-SDR: p8EHeY5PIZ/pc3qidwsuIlzQSLsdiOEpB6qILq91tmIpVqP2/as/vVeFtUTofZhFvMthNT9bzp hGw2DUf3P4zw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498512" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498512" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:22 -0800 IronPort-SDR: bSHtecArg4AfO5jqHZIpnEkpO9zinCbgJPRplSoLGVwItiwMEXypIWSwpYTvVGKUw8DSbj9cQs Al1yJPtUZfnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139832" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:21 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:53 +0000 Message-Id: <20210114110606.21142-8-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 07/20] bitratestats: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_compat.h header file must be included to get the definition of __rte_experimental. Fixes: f030bff72f81 ("bitrate: add free function") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_bitratestats/rte_bitrate.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_bitratestats/rte_bitrate.h b/lib/librte_bitratestats/rte_bitrate.h index 4865929e8f..7e34529687 100644 --- a/lib/librte_bitratestats/rte_bitrate.h +++ b/lib/librte_bitratestats/rte_bitrate.h @@ -6,6 +6,7 @@ #define _RTE_BITRATE_H_ #include +#include #ifdef __cplusplus extern "C" { From patchwork Thu Jan 14 11:05:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86599 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFA7FA0A02; Thu, 14 Jan 2021 12:07:24 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F320C141183; Thu, 14 Jan 2021 12:06:30 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 20094141156; Thu, 14 Jan 2021 12:06:23 +0100 (CET) IronPort-SDR: McC3CZKkCW26hAwKOfr+nPLZTNHLeM4Cfb88V34cMeYUldRIaAvSPyNoUY40eU2ZCYsRY/iKVs /bzNsl+geOIg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498516" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498516" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:23 -0800 IronPort-SDR: HM0OB8JJYobqnU4/Ay+rV7M86vfFxj1hXN27Y8uo0mmDMJiuiReT/zKyvNFvAAnZ933ovTCbJ1 rfYPNmfG6+Tg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139837" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:22 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:54 +0000 Message-Id: <20210114110606.21142-9-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 08/20] rib: fix missing header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The standard integer types, and the size_t types are missing their required header includes in the rib header file. Fixes: 5a5793a5ffa2 ("rib: add RIB library") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rib/rte_rib.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_rib/rte_rib.h b/lib/librte_rib/rte_rib.h index f80752e5bd..6253860523 100644 --- a/lib/librte_rib/rte_rib.h +++ b/lib/librte_rib/rte_rib.h @@ -18,6 +18,8 @@ * Level compressed tree implementation for IPv4 Longest Prefix Match */ +#include +#include #include #ifdef __cplusplus From patchwork Thu Jan 14 11:05:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86600 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1307CA0A02; Thu, 14 Jan 2021 12:07:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 524A714118E; Thu, 14 Jan 2021 12:06:32 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 9A2FC141154; Thu, 14 Jan 2021 12:06:24 +0100 (CET) IronPort-SDR: VlIBM52J7irmF7Hopar0WyQikWiAKeOQqVkwCA91yNenzyUPbXCAWjkJVpG4WAQNrxP+BSOF1W C3wpsabPcqAg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498519" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498519" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:24 -0800 IronPort-SDR: iGIn9Zr01qW7Cj3XQLI8Ai0cFKXiqo3mH+hvwCEhjjZKq9P5ABdVvidqoo5u5e0fn2pLQj7DZ7 0cxIgHDDnVbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139842" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:23 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:55 +0000 Message-Id: <20210114110606.21142-10-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 09/20] vhost: fix missing header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The vhost header files were missing definitions from headers to allow them to be compiled up individually. Fixes: d7280c9fffcb ("vhost: support selective datapath") Fixes: a49f758d1170 ("vhost: split vDPA header file") Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_vhost/rte_vdpa.h | 2 ++ lib/librte_vhost/rte_vdpa_dev.h | 1 + lib/librte_vhost/rte_vhost_crypto.h | 7 +++++++ 3 files changed, 10 insertions(+) diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h index f074ec0c4a..1437f400bf 100644 --- a/lib/librte_vhost/rte_vdpa.h +++ b/lib/librte_vhost/rte_vdpa.h @@ -11,6 +11,8 @@ * Device specific vhost lib */ +#include + /** Maximum name length for statistics counters */ #define RTE_VDPA_STATS_NAME_SIZE 64 diff --git a/lib/librte_vhost/rte_vdpa_dev.h b/lib/librte_vhost/rte_vdpa_dev.h index a60183f780..bfada387b0 100644 --- a/lib/librte_vhost/rte_vdpa_dev.h +++ b/lib/librte_vhost/rte_vdpa_dev.h @@ -8,6 +8,7 @@ #include #include "rte_vhost.h" +#include "rte_vdpa.h" #define RTE_VHOST_QUEUE_ALL UINT16_MAX diff --git a/lib/librte_vhost/rte_vhost_crypto.h b/lib/librte_vhost/rte_vhost_crypto.h index c809c46a21..2a27a35892 100644 --- a/lib/librte_vhost/rte_vhost_crypto.h +++ b/lib/librte_vhost/rte_vhost_crypto.h @@ -5,6 +5,13 @@ #ifndef _VHOST_CRYPTO_H_ #define _VHOST_CRYPTO_H_ +#include +#include + +/* pre-declare structs to avoid including full headers */ +struct rte_mempool; +struct rte_crypto_op; + #define VHOST_CRYPTO_MBUF_POOL_SIZE (8192) #define VHOST_CRYPTO_MAX_BURST_SIZE (64) #define VHOST_CRYPTO_MAX_DATA_SIZE (4096) From patchwork Thu Jan 14 11:05:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86601 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3764A0A02; Thu, 14 Jan 2021 12:07:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EF8C14119D; Thu, 14 Jan 2021 12:06:34 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 2D83F141159; Thu, 14 Jan 2021 12:06:26 +0100 (CET) IronPort-SDR: VFfDcQjZ3zubqNFECt1dB/tD6b8Q69wt3qpPEPiKyahT+vSVZkv4TrdXZHI+tAOHTO1z6mWA3n Ag+InpQfEX/A== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498524" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498524" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:25 -0800 IronPort-SDR: iOhfx1WKx4WJlyZeCCo9iYfxWCHerYNvTdRJBe2TtnM/rkX7AbIwTAUd98Yq/Izg3JTqY7LIMi tBbevfpDiZ0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139850" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:24 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:56 +0000 Message-Id: <20210114110606.21142-11-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 10/20] ipsec: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_ipsec_sad.h header used the standard uintXX_t types, but did not include stdint.h header for them. Fixes: 401633d9c112 ("ipsec: add inbound SAD API") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_ipsec/rte_ipsec_sad.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ipsec/rte_ipsec_sad.h b/lib/librte_ipsec/rte_ipsec_sad.h index 3e67ab1e4b..66c703ff3a 100644 --- a/lib/librte_ipsec/rte_ipsec_sad.h +++ b/lib/librte_ipsec/rte_ipsec_sad.h @@ -7,6 +7,7 @@ #define _RTE_IPSEC_SAD_H_ #include +#include /** * @file rte_ipsec_sad.h From patchwork Thu Jan 14 11:05:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86602 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A2AEA0A02; Thu, 14 Jan 2021 12:07:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DE0C1411A1; Thu, 14 Jan 2021 12:06:35 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id F189714116B; Thu, 14 Jan 2021 12:06:26 +0100 (CET) IronPort-SDR: BvL6DC4G7583U4+OeA2bZeGMDM6E7gQQkhFBGTR6FRB5qQHYDoktkRnfFoQRNlSwXS/4sMeSra YCNvhZhTXFwg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498530" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498530" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:26 -0800 IronPort-SDR: Wd4fZCl51wK5ZV3X2/dRirBB+/qSo6C3gwrO87rT6w9xLRULKXDy8RJpt07e4SMQK4cPkaYJAL 5dhVvPnDNczw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139859" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:25 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:57 +0000 Message-Id: <20210114110606.21142-12-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 11/20] fib: fix missing header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add stdint.h to get definitions of standard integer types Fixes: 39e927248416 ("fib: add FIB library") Fixes: 40d41a8a7b34 ("fib: support IPv6") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_fib/rte_fib.h | 1 + lib/librte_fib/rte_fib6.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_fib/rte_fib.h b/lib/librte_fib/rte_fib.h index fef0749525..352c5e00ad 100644 --- a/lib/librte_fib/rte_fib.h +++ b/lib/librte_fib/rte_fib.h @@ -19,6 +19,7 @@ * for IPv4 Longest Prefix Match */ +#include #include #ifdef __cplusplus diff --git a/lib/librte_fib/rte_fib6.h b/lib/librte_fib/rte_fib6.h index 668bffb2ba..60213f3372 100644 --- a/lib/librte_fib/rte_fib6.h +++ b/lib/librte_fib/rte_fib6.h @@ -19,6 +19,7 @@ * for IPv6 Longest Prefix Match */ +#include #include #ifdef __cplusplus From patchwork Thu Jan 14 11:05:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86603 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F073A0A02; Thu, 14 Jan 2021 12:08:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 994751411A8; Thu, 14 Jan 2021 12:06:36 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 86085141169; Thu, 14 Jan 2021 12:06:28 +0100 (CET) IronPort-SDR: 4y25R/XfxVSjhUnoInt+8DZyIDXx0JoluRSUEzq4VIv+sxXa798u3/7v4fPwGkIvzAbZBHP8LU UglZow6Ii9/g== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498536" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498536" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:27 -0800 IronPort-SDR: MwPZ5eC/m9r2PXh/yUQJ9FH4ygHgJR0D9nnVlVYDFkb9S9QFeDBOtlP6viiukcYbCPPCryrdcP RzNnxxgdpovQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139867" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:26 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:58 +0000 Message-Id: <20210114110606.21142-13-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 12/20] table: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_lru_x86.h header, included from the main rte_lru.h header, uses the RTE_CC_IS_GNU macro from rte_common.h but fails to include that header file. Fixes: 0c9a5735a947 ("eal: fix compiler detection in public headers") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_table/rte_lru_x86.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_table/rte_lru_x86.h b/lib/librte_table/rte_lru_x86.h index 0e24906c2c..38476d956e 100644 --- a/lib/librte_table/rte_lru_x86.h +++ b/lib/librte_table/rte_lru_x86.h @@ -12,6 +12,7 @@ extern "C" { #include #include +#include #ifndef RTE_TABLE_HASH_LRU_STRATEGY #define RTE_TABLE_HASH_LRU_STRATEGY 2 From patchwork Thu Jan 14 11:05:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86604 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95C52A0A02; Thu, 14 Jan 2021 12:08:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1082D1411B2; Thu, 14 Jan 2021 12:06:38 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5821A141169; Thu, 14 Jan 2021 12:06:29 +0100 (CET) IronPort-SDR: HKmHGb2mdl0s5MfKhTkgfVW+oGbWrjTzM5cuKsz5F4YZIFHH2D59CsbRkrLuTHTRUC5Ni8impf 1Wn8lKh6sqpg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498542" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498542" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:28 -0800 IronPort-SDR: xQ3piSBRMYxGJE9XO/xeIJrwf58FjEP3KaWlFyaVPexEzG6OggYSVbjqGI+9ilI/ptAUMIgQpi IBsg4svMeVDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139876" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:27 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:05:59 +0000 Message-Id: <20210114110606.21142-14-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 13/20] pipeline: fix missing header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The stdio.h header needs to be included to get the definition of the FILE type. Fixes: b32c0a2c5e4c ("pipeline: add SWX table update high level API") Fixes: 3ca60ceed79a ("pipeline: add SWX pipeline specification file") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_pipeline/rte_swx_ctl.h | 1 + lib/librte_pipeline/rte_swx_pipeline.h | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_pipeline/rte_swx_ctl.h b/lib/librte_pipeline/rte_swx_ctl.h index bab1894944..32815b69e2 100644 --- a/lib/librte_pipeline/rte_swx_ctl.h +++ b/lib/librte_pipeline/rte_swx_ctl.h @@ -15,6 +15,7 @@ extern "C" { #include #include +#include #include diff --git a/lib/librte_pipeline/rte_swx_pipeline.h b/lib/librte_pipeline/rte_swx_pipeline.h index d0a3439edf..f0a2cef777 100644 --- a/lib/librte_pipeline/rte_swx_pipeline.h +++ b/lib/librte_pipeline/rte_swx_pipeline.h @@ -15,6 +15,7 @@ extern "C" { #include #include +#include #include From patchwork Thu Jan 14 11:06:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86605 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ABA2A0A02; Thu, 14 Jan 2021 12:08:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B7BD1411B9; Thu, 14 Jan 2021 12:06:39 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 24E75141180; Thu, 14 Jan 2021 12:06:29 +0100 (CET) IronPort-SDR: HiYcWhFpO/xmwkdO69XStex8ejRW09ZWtf5qrvlhYPXiBVmxSGF0M/PhBGUONb9yHRO53Vy+65 FGh9rXWFLHFw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498545" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498545" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:29 -0800 IronPort-SDR: 1Hhw7rM5V9xO1jQ0bGz6LRq/gtSgUrL8Vb/1XObo5au5CTMw/GFTwQg47zMUVA3dTfJCTY4bdy ANpH7ZzQ/J4Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139882" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:28 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:06:00 +0000 Message-Id: <20210114110606.21142-15-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 14/20] metrics: fix variable declaration in header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The global variable "tel_met_data" was declared in a header file, rather than in a C file, leading to duplicate definitions if more than one C file included the header. Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_metrics/rte_metrics_telemetry.c | 2 ++ lib/librte_metrics/rte_metrics_telemetry.h | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_metrics/rte_metrics_telemetry.c b/lib/librte_metrics/rte_metrics_telemetry.c index 901cbeb0a3..b8ee56ef01 100644 --- a/lib/librte_metrics/rte_metrics_telemetry.c +++ b/lib/librte_metrics/rte_metrics_telemetry.c @@ -13,6 +13,8 @@ #include "rte_metrics.h" #include "rte_metrics_telemetry.h" +struct telemetry_metrics_data tel_met_data; + int metrics_log_level; /* Logging Macros */ diff --git a/lib/librte_metrics/rte_metrics_telemetry.h b/lib/librte_metrics/rte_metrics_telemetry.h index 3435a55425..5dbb32ca0c 100644 --- a/lib/librte_metrics/rte_metrics_telemetry.h +++ b/lib/librte_metrics/rte_metrics_telemetry.h @@ -34,8 +34,6 @@ struct telemetry_metrics_data { int metrics_register_done; }; -struct telemetry_metrics_data tel_met_data; - __rte_experimental int32_t rte_metrics_tel_reg_all_ethdev(int *metrics_register_done, int *reg_index_list); From patchwork Thu Jan 14 11:06:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86606 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 179FFA0A03; Thu, 14 Jan 2021 12:08:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3F271411BE; Thu, 14 Jan 2021 12:06:40 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B47EA141189; Thu, 14 Jan 2021 12:06:31 +0100 (CET) IronPort-SDR: N72IZpf8eStKCMbAu+yHZ48jVmLRAod5IXN5jVkaQaMLN3EyqqJ1WVIweTtOZA0A4Ny2JRhnzy Ls3ym1TicGRg== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498550" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498550" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:30 -0800 IronPort-SDR: SJxLMftUf8coR/Fac28g1sWx0SYgYUikqJPuyFUy/k03tahszh4gpnU/IkoAE67xukK+BwzYTX gA/4iUF4TlSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139887" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:29 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:06:01 +0000 Message-Id: <20210114110606.21142-16-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 15/20] node: fix missing header include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_compat header file is needed for the '__rte_experimental' macro. Fixes: f00708c2aa53 ("node: add IPv4 rewrite and lookup control") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_node/rte_node_ip4_api.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_node/rte_node_ip4_api.h b/lib/librte_node/rte_node_ip4_api.h index eb9ebd5f89..46d0d8976b 100644 --- a/lib/librte_node/rte_node_ip4_api.h +++ b/lib/librte_node/rte_node_ip4_api.h @@ -21,6 +21,7 @@ extern "C" { #endif #include +#include /** * IP4 lookup next nodes. From patchwork Thu Jan 14 11:06:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86607 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5725A0A02; Thu, 14 Jan 2021 12:08:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F95B1411C5; Thu, 14 Jan 2021 12:06:42 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 83FAC141190; Thu, 14 Jan 2021 12:06:32 +0100 (CET) IronPort-SDR: rM4qcCfXddNa+7ARwxHpw5g/cLEJuG9B5tPfungz/Yve8ICsxf+jr2qxN0jKnxNh+xlVqt2TEC O/bGIbV0arBw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498553" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498553" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:32 -0800 IronPort-SDR: 39oPIohgvXkIKL/7h/cX+HrwwkSpvVxP+DvsIlpE4Qw03CB21b9/Lzg6ziNEr4yhA6oyYQT5Zc YShFu6aP7Pvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139890" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:31 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:06:02 +0000 Message-Id: <20210114110606.21142-17-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 16/20] app: fix extra include paths for app builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The "includes" variable in the app/meson.build file was ignored when building the executable, meaning that apps couldn't pass additional include paths directly back. Fix this to align with drivers and libs. Fixes: fa036e70d794 ("app: generalize meson build") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- app/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/app/meson.build b/app/meson.build index eb74f215a3..b6f2a6f56e 100644 --- a/app/meson.build +++ b/app/meson.build @@ -60,6 +60,7 @@ foreach app:apps c_args: cflags, link_whole: link_libs, dependencies: dep_objs, + include_directories: includes, install_rpath: join_paths(get_option('prefix'), driver_install_path), install: true) From patchwork Thu Jan 14 11:06:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86608 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F402A0A02; Thu, 14 Jan 2021 12:08:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 43F9D1411CA; Thu, 14 Jan 2021 12:06:43 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 3157F14119E for ; Thu, 14 Jan 2021 12:06:33 +0100 (CET) IronPort-SDR: 04FYuqNgwobCTo+5G5lCO435W+nI5b+ZS39qyvgN2QuzRJJes/m0+0Abetp2hwPve0PSOakPDU P8WK96HbPSEA== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498555" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498555" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:33 -0800 IronPort-SDR: PAp7yZseEWwd7H16p9K8o1YXm2OzQUDOW4bIjTAoS5/+qsTBWkYsn3FLdZxxAUi3r6/bYuCPej dexYsykvUGWA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139896" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:32 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Date: Thu, 14 Jan 2021 11:06:03 +0000 Message-Id: <20210114110606.21142-18-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 17/20] app/chkincs: add chkincs app to verify headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" To verify that all DPDK headers are ok for inclusion directly in a C file, and are not missing any other pre-requisite headers, we can auto-generate for each header an empty C file that includes that header. Compiling these files will throw errors if any header has unmet dependencies. Signed-off-by: Bruce Richardson --- app/chkincs/gen_c_file_for_header.py | 49 ++++++++++++++++++++++++++++ app/chkincs/main.c | 4 +++ app/chkincs/meson.build | 28 ++++++++++++++++ app/meson.build | 1 + lib/meson.build | 1 + meson.build | 1 + meson_options.txt | 2 ++ 7 files changed, 86 insertions(+) create mode 100755 app/chkincs/gen_c_file_for_header.py create mode 100644 app/chkincs/main.c create mode 100644 app/chkincs/meson.build -- 2.27.0 diff --git a/app/chkincs/gen_c_file_for_header.py b/app/chkincs/gen_c_file_for_header.py new file mode 100755 index 0000000000..f92f2b412c --- /dev/null +++ b/app/chkincs/gen_c_file_for_header.py @@ -0,0 +1,49 @@ +#! /usr/bin/env python3 +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2020 Intel Corporation + +from sys import argv +from os.path import abspath + +empty_contents = 'static const char *empty __attribute__((unused)) = "empty";' +# files which are not used directly, but included via others +exceptions = [ + 'rte_cmp_arm64.h', + 'rte_cmp_x86.h', + 'rte_crc_arm64.h', + 'rte_eal_interrupts.h', + 'rte_eth_ctrl.h', + 'rte_ethdev_core.h', + 'rte_ipsec_group.h', + 'rte_lpm_altivec.h', + 'rte_lpm_neon.h', + 'rte_lpm_sse.h', + 'rte_lpm_x86.h', + 'rte_lru_arm64.h', + 'rte_lru_x86.h', + 'rte_regexdev_core.h', + 'rte_ring_core.h', + 'rte_ring_generic.h', + 'rte_ring_hts_c11_mem.h', + 'rte_ring_hts.h', + 'rte_ring_peek_c11_mem.h', + 'rte_ring_peek.h', + 'rte_ring_peek_zc.h', + 'rte_ring_rts_c11_mem.h', + 'rte_ring_rts.h', + 'rte_stack_lf_c11.h', + 'rte_stack_lf_generic.h', + 'rte_stack_lf.h', + 'rte_stack_std.h', + 'rte_table_hash_func_arm64.h', + ] + +(h_file, c_file) = argv[1:] + +contents = '#include "' + abspath(h_file) + '"' +for ex in exceptions: + if h_file.endswith(ex): + contents = empty_contents + +with open(c_file, 'w') as cf: + cf.write(contents) diff --git a/app/chkincs/main.c b/app/chkincs/main.c new file mode 100644 index 0000000000..ecdf641954 --- /dev/null +++ b/app/chkincs/main.c @@ -0,0 +1,4 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * Copyright(c) 2020 Intel Corporation + */ +int main(void) { return 0; } diff --git a/app/chkincs/meson.build b/app/chkincs/meson.build new file mode 100644 index 0000000000..c16ca1f4fe --- /dev/null +++ b/app/chkincs/meson.build @@ -0,0 +1,28 @@ +# SPDX-License-Identifier: BSD-3-Clause +# Copyright(c) 2020 Intel Corporation + +if not get_option('test_includes') + build = false + subdir_done() +endif + +if is_windows + # for windows, the shebang line in the script won't work. + error('option "test_includes" is not supported on windows') +endif + +gen_c_file_for_header = find_program('gen_c_file_for_header.py') +gen_c_files = generator(gen_c_file_for_header, + output: '@BASENAME@.c', + arguments: ['@INPUT@', '@OUTPUT@']) + +cflags += '-Wno-unused-function' # needed if we include generic headers + +# some ethdev headers depend on bus headers +includes += include_directories('../../drivers/bus/pci', + '../../drivers/bus/vdev') + +sources += files('main.c') +sources += gen_c_files.process(dpdk_headers) + +deps = enabled_libs diff --git a/app/meson.build b/app/meson.build index b6f2a6f56e..8832ba8b17 100644 --- a/app/meson.build +++ b/app/meson.build @@ -6,6 +6,7 @@ if is_windows endif apps = [ + 'chkincs', 'pdump', 'proc-info', 'test-acl', diff --git a/lib/meson.build b/lib/meson.build index ed00f89146..7698e6749c 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -103,6 +103,7 @@ foreach l:libraries dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1) #old macro dpdk_conf.set('RTE_LIB_' + name.to_upper(), 1) # new macro install_headers(headers) + dpdk_headers += headers libname = 'rte_' + name includes += include_directories(dir_name) diff --git a/meson.build b/meson.build index 45d974cd2c..5c612fe93a 100644 --- a/meson.build +++ b/meson.build @@ -16,6 +16,7 @@ cc = meson.get_compiler('c') dpdk_conf = configuration_data() dpdk_libraries = [] dpdk_static_libraries = [] +dpdk_headers = [] dpdk_driver_classes = [] dpdk_drivers = [] dpdk_extra_ldflags = [] diff --git a/meson_options.txt b/meson_options.txt index e384e6dbb2..9214219444 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -32,5 +32,7 @@ option('enable_trace_fp', type: 'boolean', value: false, description: 'enable fast path trace points.') option('tests', type: 'boolean', value: true, description: 'build unit tests') +option('test_includes', type: 'boolean', value: false, + description: 'build "chkincs" to verify each header file can compile alone') option('use_hpet', type: 'boolean', value: false, description: 'use HPET timer in EAL') From patchwork Thu Jan 14 11:06:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86609 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ED40A0A02; Thu, 14 Jan 2021 12:09:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 986D41411D3; Thu, 14 Jan 2021 12:06:44 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 7BBE11411A1; Thu, 14 Jan 2021 12:06:34 +0100 (CET) IronPort-SDR: iprPcz8+EzytkfJwEHvgESnSYiCVeJbNyDlOBGRDu+NatqWyd5wKO93mv62uNoISM6Q8fks0Yl O52EyrdczqDw== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498558" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498558" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:34 -0800 IronPort-SDR: ZqrhO0lPRXT71+8Hstsn78VropmAbidEH5jaeB9wW6nm5Ddwo2PFOQ+KIT6gkkMbG0mxkGCXWO Z8VUslCPUe1Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139904" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:33 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson , stable@dpdk.org Date: Thu, 14 Jan 2021 11:06:04 +0000 Message-Id: <20210114110606.21142-19-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 18/20] eal: add missing include to mcslock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Include 'rte_branch_prediction.h' to get the likely/unlikely macro definitions. Fixes: 2173f3333b61 ("mcslock: add MCS queued lock implementation") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_eal/include/generic/rte_mcslock.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/include/generic/rte_mcslock.h b/lib/librte_eal/include/generic/rte_mcslock.h index d370bef17a..9f323bd2a2 100644 --- a/lib/librte_eal/include/generic/rte_mcslock.h +++ b/lib/librte_eal/include/generic/rte_mcslock.h @@ -22,6 +22,7 @@ #include #include #include +#include /** * The rte_mcslock_t type. From patchwork Thu Jan 14 11:06:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86610 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F505A0A02; Thu, 14 Jan 2021 12:09:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 32A961411DF; Thu, 14 Jan 2021 12:06:46 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id E72E51411A4 for ; Thu, 14 Jan 2021 12:06:35 +0100 (CET) IronPort-SDR: eE4fmWaRUc0uTE2Xyiq7lH9iiWHBs/D/z1bxrK7GLGgE8OrV0L0KNtsBoQ64qk+b0BjLotxAal MybpTtJ2jfTA== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498563" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498563" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:35 -0800 IronPort-SDR: DIvG+ErSlCGTFuj6jcC1xCkjSzOokbrzqrDFm9NwDS+3CkfSxohCUnEbhXaByTdQAzNl3A0Mms OS5w00+yTLYg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139907" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:34 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Date: Thu, 14 Jan 2021 11:06:05 +0000 Message-Id: <20210114110606.21142-20-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 19/20] eal/x86: add architecture-specific headers to chkincs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ensure the architecture-specific header files for x86 have all necessary includes in them. Signed-off-by: Bruce Richardson --- app/chkincs/gen_c_file_for_header.py | 4 ++++ lib/librte_eal/x86/include/meson.build | 1 + 2 files changed, 5 insertions(+) diff --git a/app/chkincs/gen_c_file_for_header.py b/app/chkincs/gen_c_file_for_header.py index f92f2b412c..d7e97b2ab4 100755 --- a/app/chkincs/gen_c_file_for_header.py +++ b/app/chkincs/gen_c_file_for_header.py @@ -8,6 +8,10 @@ empty_contents = 'static const char *empty __attribute__((unused)) = "empty";' # files which are not used directly, but included via others exceptions = [ + 'rte_atomic_32.h', + 'rte_atomic_64.h', + 'rte_byteorder_32.h', + 'rte_byteorder_64.h', 'rte_cmp_arm64.h', 'rte_cmp_x86.h', 'rte_crc_arm64.h', diff --git a/lib/librte_eal/x86/include/meson.build b/lib/librte_eal/x86/include/meson.build index 549cc21a42..b5aa2c71a5 100644 --- a/lib/librte_eal/x86/include/meson.build +++ b/lib/librte_eal/x86/include/meson.build @@ -23,3 +23,4 @@ arch_headers = files( 'rte_vect.h', ) install_headers(arch_headers, subdir: get_option('include_subdir_arch')) +dpdk_headers += arch_headers From patchwork Thu Jan 14 11:06:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 86611 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B451BA0A02; Thu, 14 Jan 2021 12:09:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 599701411E4; Thu, 14 Jan 2021 12:06:47 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 33434141163 for ; Thu, 14 Jan 2021 12:06:40 +0100 (CET) IronPort-SDR: G1X0QINFqhS5TX/nXpyhCvR6b+Fe+lHZ6emaNSKE+/6VOEVPzT3spTzP5Q8RziosBiTPPSfQj6 Co7tNF0C6nFA== X-IronPort-AV: E=McAfee;i="6000,8403,9863"; a="178498580" X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="178498580" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2021 03:06:38 -0800 IronPort-SDR: Kc9fRaX+ZJoFPlP/6TfV0AZbB+zT2QZFO25wINbvTC+srxJtsFr/3vLfpoTJ4hKN8KzoInWhES Umtc6ADc3hDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,347,1602572400"; d="scan'208";a="568139913" Received: from silpixa00399126.ir.intel.com ([10.237.222.4]) by orsmga005.jf.intel.com with ESMTP; 14 Jan 2021 03:06:35 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Date: Thu, 14 Jan 2021 11:06:06 +0000 Message-Id: <20210114110606.21142-21-bruce.richardson@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210114110606.21142-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 20/20] test-meson-builds: add includes check to default x86 build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Since the includes check is disabled by default, we need to explicitly enable it to have it run. To minimise any extra build time when running the test-meson-builds script, we just add it to the default x86 build. Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 7280b7a93d..d7ddd78791 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -215,7 +215,7 @@ default_machine='nehalem' if ! check_cc_flags "-march=$default_machine" ; then default_machine='corei7' fi -build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine $use_shared +build build-x86-default cc -Dlibdir=lib -Dmachine=$default_machine -Dtest_includes=true $use_shared # 32-bit with default compiler if check_cc_flags '-m32' ; then