From patchwork Wed Dec 23 08:51:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Yang X-Patchwork-Id: 85672 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5E2BA052A; Wed, 23 Dec 2020 09:54:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C428CA4D; Wed, 23 Dec 2020 09:54:54 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id EC90BCA4A for ; Wed, 23 Dec 2020 09:54:51 +0100 (CET) IronPort-SDR: t3Q27qjBzSfFGc0m/Z+j5VPUFYmS0dFDUzbRD9hZQV0RtH7H507weBqg5nIANvgGwvkFmDtAl1 rT+ifBhiOPzA== X-IronPort-AV: E=McAfee;i="6000,8403,9843"; a="163042980" X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="163042980" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2020 00:54:48 -0800 IronPort-SDR: oWuE3ddegFBV+229ym4Z4ifOfKRYvi4AQ4XRp0cyHgrc5pWPEN9xxZjGRYIL4Eis7yay59C8tm 3Z/YYl20i63g== X-IronPort-AV: E=Sophos;i="5.78,441,1599548400"; d="scan'208";a="344969914" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Dec 2020 00:54:46 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, xiaoyun.li@intel.com, qiming.yang@intel.com, Steve Yang Date: Wed, 23 Dec 2020 08:51:52 +0000 Message-Id: <20201223085152.20866-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201222081335.17419-1-stevex.yang@intel.com> References: <20201222081335.17419-1-stevex.yang@intel.com> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloads of 'dev_conf', it would cause the configuration invalid. For example: Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while rx_conf.offloads of each queue still kept the old value. It would cause the failure of offloads check in 'rte_eth_rx_queue_setup'. This patch applied tx/rx offloads configuration for each queue once it changed. Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") Signed-off-by: Steve Yang Acked-by: Xiaoyun Li Tested-by: Chen, BoX C --- v2: * moved the update logic to 'rxtx_port_config'; * added the 'tx_conf' part; * optimized the 'default' assignment; --- app/test-pmd/testpmd.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 33a060dffd..6ee28e3797 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3288,9 +3288,11 @@ rxtx_port_config(struct rte_port *port) for (qid = 0; qid < nb_rxq; qid++) { offloads = port->rx_conf[qid].offloads; - port->rx_conf[qid] = port->dev_info.default_rxconf; - if (offloads != 0) - port->rx_conf[qid].offloads = offloads; + if (offloads != port->dev_conf.rxmode.offloads) + port->rx_conf[qid].offloads = + port->dev_conf.rxmode.offloads; + if (!offloads) + port->rx_conf[qid] = port->dev_info.default_rxconf; /* Check if any Rx parameters have been passed */ if (rx_pthresh != RTE_PMD_PARAM_UNSET) @@ -3313,9 +3315,11 @@ rxtx_port_config(struct rte_port *port) for (qid = 0; qid < nb_txq; qid++) { offloads = port->tx_conf[qid].offloads; - port->tx_conf[qid] = port->dev_info.default_txconf; - if (offloads != 0) - port->tx_conf[qid].offloads = offloads; + if (offloads != port->dev_conf.txmode.offloads) + port->tx_conf[qid].offloads = + port->dev_conf.txmode.offloads; + if (!offloads) + port->tx_conf[qid] = port->dev_info.default_txconf; /* Check if any Tx parameters have been passed */ if (tx_pthresh != RTE_PMD_PARAM_UNSET)