From patchwork Wed Dec 9 15:11:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Dey, Souvik" X-Patchwork-Id: 84871 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B098A04E6; Wed, 9 Dec 2020 16:11:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC1A2C938; Wed, 9 Dec 2020 16:11:26 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [216.205.24.181]) by dpdk.org (Postfix) with ESMTP id 404A0C926 for ; Wed, 9 Dec 2020 16:11:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1607526682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J9vipuZgjwDcraf24usS6eOE/yVqLSZelbTxZWTUBS4=; b=MSLHf9jSBDUVheSDm2Di22pu6FeYXulIm9J7lVjfjMueTZNI+pugqlHkXCIs7Ki6KGpgdi 2vAvqGetwUTojH7+F2+V2fuxk9hSlFac1BHtS7eFT4UTNPYVlvowQgJdk0GEs2cLv6DZsG eeURrbzPI9N8MsVHH0j0ie/Gk2R1ut8= Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-547-DwJspit4NOC8sgJkQBBDmw-2; Wed, 09 Dec 2020 10:11:21 -0500 X-MC-Unique: DwJspit4NOC8sgJkQBBDmw-2 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM5PR03MB3323.namprd03.prod.outlook.com (2603:10b6:4:3e::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Wed, 9 Dec 2020 15:11:19 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4%6]) with mapi id 15.20.3654.013; Wed, 9 Dec 2020 15:11:19 +0000 From: Souvik Dey To: rasland@nvidia.com, matan@nvidia.com, shahafs@nvidia.com, viacheslavo@nvidia.com Cc: dev@dpdk.org, Souvik Dey Date: Wed, 9 Dec 2020 10:11:08 -0500 Message-Id: <20201209151108.12352-2-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: <20201209151108.12352-1-sodey@rbbn.com> References: <20201209151108.12352-1-sodey@rbbn.com> X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: MN2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:208:236::30) To DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by MN2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:208:236::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3654.7 via Frontend Transport; Wed, 9 Dec 2020 15:11:19 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9daabfee-40be-427d-fa9d-08d89c54aecc X-MS-TrafficTypeDiagnostic: DM5PR03MB3323: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: YU4riCH0kZSRBKvW/pJnaPoDGfnzehJDozqwuNI362fPBz7fx/30Cp+VkfqNDHVQEl3OEdBggLoQ/H8+8xq3YewuNnLRjxCSPZOx6bHYUpXUT1mK+OLyAbWqzTArsNERZkTokqj8J44xsB78kawSXjU9MlZ/ezl6pzuX9hjdEsUcOYuBPO9j6mGLb9TMjnfluJIdqaD4S61qRSxwRsK8kkjOQ459Th90Lu9q4xH6IPpfFXmx8Ypzla19bcnUCRfBszuVE/oVxRg9QtwjqTMjOoI0V7mbNirz7bojVcoTbCIaS8HveH0lHCcpEwXSSORUa4nPHx5mXzFy6tHlQ8ojZmaglEvAS/F4abFVzC2w2ex4mjpbh9W9nkQdl70XxIhI X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(346002)(956004)(36756003)(2616005)(6666004)(6506007)(16526019)(1076003)(83380400001)(52116002)(86362001)(66556008)(34490700003)(26005)(66476007)(4326008)(8676002)(5660300002)(107886003)(66946007)(186003)(6512007)(8936002)(2906002)(6486002)(508600001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: jdnWZExVgisWeY1GbjCK2G2MiX0luwevuplhgXDxkAT9isna2bY0S+ke6y03boRJllyX2E9MaBqhUA5E7DeCBdfdZ5lhV354NOg2ZDVABK6n8BMt9SXyJvjCUNmbG4FSPRURAjXYB6LcnLUQoQzxv7HmtX00U/OKCXNDyI6tyXci1uq7iQwXzwkK35kwwkzVyrygshvJdWnXA2fbHGWT4saQowmZMPVTiOJ0LG94uHhizmIe+9JBaD0Nn2urQY2kXCl2nlJlJ4Z+KJCK1R+sLLZ6eQd3B8UaYyDPblsVQuMd3u3UoJdpv2T7BBVbjvq26XgGpLfrbMf0OnakizjwVp2+a7ieUUhu+nt5wUwp3FGPw1g0FYgkZgooe/jgU/NyzYmJT9mR8a1hYdewT56T2TxmQ4dJMpWyiq1DT3mT5VPS4lENowt/Mi7Nkk95zDnud8DXJ7Z3k6+n03lsqUVrzfRsVmHjMMU/uWk6BQMkJW0+lCK9oSCkIobCsIClXkitBM0qlOxmBoGXXVYiB5dsplR8XFpOPSrOdA4fhosjgtVB8QvcoFNlLS1rg3+rwfAS04IFgeX2No441+eCdxB7Lh0TU/ItWzl41/NaonFuFU/tJQqw8+v3wCKq+9ENmPJslnv1KXFUzncWaC+Cy+qtpNbymN4gImG9WZKEkncztw12A5pYSx1MFd/Je9wn9fDZtREKhxawL7H81yfGXi2aYDKep8CDSe7H3cYnFxJqVqQiuE+FtgiPYh90ewzyZmz2Ho7lcaLwLJCdEH6eGF2uMxRwi68oBex8LywmtY7KMrwUwmb/DqRKN6C7m8hUOHm2G/Pn6cBwZc3ZG6H+Cn89OGorLtvNFrSVRhNrlthFcpTLGizTfuT7buszpTGnTXRPxbRo63SeEKLOV6QX8mbOnbnPiTHlj4Xbt9V06jX9yWUxJkSHQkhbjH6t9gaClbyEKpA6skK2oc6VjHeUb5K1uVIyknIeJj/3ffDQuOtUSf1up4yaqWvBBdju51FBcvSh X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2020 15:11:19.6470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-Network-Message-Id: 9daabfee-40be-427d-fa9d-08d89c54aecc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RBjds08IYEIm9XzzIopssEkps22vOCLurMZaCoejHzIyDhbrpQb8qqzB3b0XJxx/ X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB3323 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA81A106 smtp.mailfrom=sodey@rbbn.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Subject: [dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As the internal MAC table is divided into Unicast and Multicast address section, we should check the type of synced MAC address before storing it to the internal table. Currently the check is not done, and the synced MAC of 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) which causes all subsequent mlx5_set_mc_addr_list() to fail with error -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This denies adding of any new multicast address to the internal list and also fails to add the MAC address to the device in case of SR-IOV VF case. Signed-off-by: Souvik Dey --- drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 40d8620..ef7a521 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx, break; if (j != n) continue; - /* Find the first entry available. */ - for (j = 0; j != n; ++j) { - if (rte_is_zero_ether_addr(&mac_addrs[j])) { - mac_addrs[j] = macs[i]; - break; + if (rte_is_multicast_ether_addr(&macs[i])) { + /* Find the first entry available. */ + for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } + } + } else { + /* Find the first entry available. */ + for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) { + if (rte_is_zero_ether_addr(&mac_addrs[j])) { + mac_addrs[j] = macs[i]; + break; + } } } }