From patchwork Fri Nov 27 12:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Connolly X-Patchwork-Id: 84621 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80B9AA0524; Fri, 27 Nov 2020 13:07:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95989C93C; Fri, 27 Nov 2020 13:07:36 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id EA862C926 for ; Fri, 27 Nov 2020 13:07:33 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id e7so5340148wrv.6 for ; Fri, 27 Nov 2020 04:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mayadata-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w5msxpson6VQHNasdcwqul6Dh61wuN11maWRhYPh43k=; b=vmVub5Iict4Fc0O1ZcsOc2oJv4vO30/lp3ybTiV0/D/A4C3sBOOisao3cEsoQ0XHNi pWyAW9ArdgHO/14kUa/KJRVf+ThXU2PBEue6RxSvQfkjLauH6BfdU4Q+MhGkI0YcSDEh TMSEyrNsHChUpaYOivYLsp0tOdiO3O07Yr/kAjIlFdidtsnS34ucsyAMXQptLgTxwZWQ 6d8wPoAbQOHLGQu3r75Oedh4BVskRl9fxTIM4mmE4DVu0GtDRNwY2/A+ZZkTcs95H6dm ysA6gGsjY2AqJE6EO5Mr1yxzsiR5WP1ImbzmXetmGU3cndVTrU4kGFM1+YmIOeeOR2T8 3MEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w5msxpson6VQHNasdcwqul6Dh61wuN11maWRhYPh43k=; b=pyDy3AVfNOH+CgRe2y7f/ThHkbyi7MP50xevVbpSqKmLvyFL1YvhqoKSo37+PGEY1t MwC1QMBIY/gSb4yDna/cSRkQul7+kxNDEBZIr+bmjMjxpnf6pDR3JsWiW9VJe0lTI13Q 7AyiJhZgG9J4wk3MZpLt/bnPeDGc8NpHF/OVEn6WIyB8AWtNhSbaXUszGbULsuvtNM7D wRTXN07XJjkBv7go/uaHsBMtN3436gqoBYh5X7c/Tn2YfAWgteUXKiC9Uv4QG8LxYlGl blFqmhPxJEcStcc5KnA93NOvhZF8mmql2COuWVotSRqoWsR0Nk5o7LagJyYPCPEdH42J TrpA== X-Gm-Message-State: AOAM530oZlQdUyYVBZ2O41aK3AROUgsIyifaGm3PKBKhJgRyqrEerezn xNms3dCjrTkKv8Uxzyn3g81stQ== X-Google-Smtp-Source: ABdhPJyJsRlYwjU2M4dIdD2D1KSUnvvm7GBIgU8PyKgH1/NGGRdK51b0K49wtVQauU0RaLlumhYMPw== X-Received: by 2002:a5d:554a:: with SMTP id g10mr10427009wrw.253.1606478852698; Fri, 27 Nov 2020 04:07:32 -0800 (PST) Received: from FENIX.localdomain (cpc98320-croy25-2-0-cust77.19-2.cable.virginm.net. [80.235.134.78]) by smtp.gmail.com with ESMTPSA id 90sm14513243wra.95.2020.11.27.04.07.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Nov 2020 04:07:31 -0800 (PST) From: Nick Connolly To: Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Cc: dev@dpdk.org, David Marchand , Nick Connolly , stable@dpdk.org Date: Fri, 27 Nov 2020 12:07:11 +0000 Message-Id: <20201127120711.15703-1-nick.connolly@mayadata.io> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When building with clang (11.0,--buildtype=debug), eal_lcore.c produces a -Wformat-nonliteral warning from the vfprintf call in log_early. Disable the warning for log_early when building with clang. MinGW does not seem to detect the warning. Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection") Cc: stable@dpdk.org Signed-off-by: Nick Connolly --- lib/librte_eal/windows/eal_lcore.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c index d5ff721e0..d996b4f89 100644 --- a/lib/librte_eal/windows/eal_lcore.c +++ b/lib/librte_eal/windows/eal_lcore.c @@ -36,6 +36,11 @@ struct cpu_map { static struct cpu_map cpu_map = { 0 }; +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wformat-nonliteral" +#endif + /* eal_create_cpu_map() is called before logging is initialized */ static void log_early(const char *format, ...) @@ -47,6 +52,10 @@ log_early(const char *format, ...) va_end(va); } +#ifdef __clang__ +#pragma clang diagnostic pop +#endif + int eal_create_cpu_map(void) {