From patchwork Fri Nov 6 17:28:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Monjalon X-Patchwork-Id: 83821 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28487A04B5; Fri, 6 Nov 2020 18:29:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FD26100C; Fri, 6 Nov 2020 18:29:13 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 46CF7160 for ; Fri, 6 Nov 2020 18:29:12 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id D2F365C00F0; Fri, 6 Nov 2020 12:29:10 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 06 Nov 2020 12:29:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=PDfuV6KUFtU9yLJEWMJ8e3AtVV UdQf4ZJzDG9r2Vxq0=; b=g50NfTxAjDBsZGBwabyZcD/TT5gmEKG4ykQ27f/1e7 klxQDNCWKft+lEBqSaiVv0lwS0w9MO94NpfNqxltRE1XD64tfr4VTGwHSh4Qk+HY l+IVw39jzkbj2Wf2Zf94cotfUN3mpYeAAJhKSCv6lF4fDYB8kPypslV/YrQUaWik NqR1Q1MBSc2x5UpH+kFpoZ5iq+GX9mEeqeMZk55FYsvPntxX2f2YfhCGsGE3fc4g 0rUeclIH6MiEMJj9tWykSZLecv+qJCL2yHilPJWssYYQfW7KuM2Fs1oHNWrW+/6V ajPjWqyCmNdtVjrGApABxbsEX96dXC6uKZUvHZWDBc/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PDfuV6KUFtU9yLJEW MJ8e3AtVVUdQf4ZJzDG9r2Vxq0=; b=Xz4++21qeXeDPzGzNciJJ09sUhgvFFIed 7T2lVbP35ZL7lmwTamS+qfyM1AyJypdowPmleMp6hh3bAnFhpmKfKNQkWhD6rxVi zpzyy44GaM0IgHgehq71PWxARsEG2RnrBe6jBE0r941qTZIr0ozxpjNsnSvswIRu E+d31DuF7HxhD8BePnyHWpotQz4J9VzRPROsIspaJJFIWox1ktU/7I0nJ0ZIDZmU esPPNjqAq706MiW9LZqmYS83b0t5xA+4MAQDA6siaaSkafm4YBIrA+JqElpuKNPm VtZQoYZmr7EH7hkk8L6z7jmZ7kwXOSWLwx3R9LOmVZHoIq+7m+BWQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtledguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdelvdduhedvudduveeuvd evheegudelgeeigfejheduhedttdegudffjeeihffgnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ED8943060057; Fri, 6 Nov 2020 12:29:09 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com Date: Fri, 6 Nov 2020 18:28:54 +0100 Message-Id: <20201106172854.237384-1-thomas@monjalon.net> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 1/1] devtools: reduce build test verbosity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The default verbosity of test-meson-builds.sh is to be quiet. In order to better apply the verbosity policy, some file descriptors are open to redirect to stdout or /dev/null accordingly. The target variable and meson/ninja commands are printed in verbose modes. The installation commands are printed only in very verbose mode. The examples build commands are printed only in very verbose mode. Signed-off-by: Thomas Monjalon Acked-by: David Marchand Acked-by: Bruce Richardson --- devtools/test-meson-builds.sh | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 0c95d1cc98..469251b6ef 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -65,7 +65,7 @@ load_env () # else # toolchain not yet in PATH: its name should be enough DPDK_TARGET=$targetcc fi - echo "Using DPDK_TARGET $DPDK_TARGET" + echo "Using DPDK_TARGET $DPDK_TARGET" >&$verbose # config input: $DPDK_TARGET . $srcdir/devtools/load-devel-config # config output: $DPDK_MESON_OPTIONS, $PATH, $PKG_CONFIG_PATH, etc @@ -99,7 +99,7 @@ config () # options="$options -D$option" done options="$options $*" - echo "$MESON $options $dir $builddir" + echo "$MESON $options $dir $builddir" >&$verbose $MESON $options $dir $builddir } @@ -115,7 +115,6 @@ compile () # echo "$ninja_cmd -C $builddir | cat" $ninja_cmd -C $builddir | cat else - echo "$ninja_cmd -C $builddir" $ninja_cmd -C $builddir fi } @@ -123,13 +122,8 @@ compile () # install_target () # { rm -rf $2 - if [ -n "$TEST_MESON_BUILD_VERY_VERBOSE$TEST_MESON_BUILD_VERBOSE" ]; then - echo "DESTDIR=$2 $ninja_cmd -C $1 install" - DESTDIR=$2 $ninja_cmd -C $1 install - else - echo "DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null" - DESTDIR=$2 $ninja_cmd -C $1 install >/dev/null - fi + echo "DESTDIR=$2 $ninja_cmd -C $1 install" >&$verbose + DESTDIR=$2 $ninja_cmd -C $1 install >&$veryverbose } build () # @@ -186,6 +180,7 @@ build () # if [ "$1" = "-vv" ] ; then TEST_MESON_BUILD_VERY_VERBOSE=1 + TEST_MESON_BUILD_VERBOSE=1 elif [ "$1" = "-v" ] ; then TEST_MESON_BUILD_VERBOSE=1 fi @@ -194,6 +189,10 @@ if [ -z "$PIPEFAIL" -a -n "$TEST_MESON_BUILD_VERBOSE" ] ; then echo "# Missing pipefail shell option, changing VERBOSE to VERY_VERBOSE" TEST_MESON_BUILD_VERY_VERBOSE=1 fi +[ -n "$TEST_MESON_BUILD_VERBOSE" ] && exec 8>&1 || exec 8>/dev/null +verbose=8 +[ -n "$TEST_MESON_BUILD_VERY_VERBOSE" ] && exec 9>&1 || exec 9>/dev/null +veryverbose=9 # shared and static linked builds with gcc and clang for c in gcc clang ; do @@ -270,6 +269,7 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then export PKGCONF="pkg-config --define-prefix" for example in cmdline helloworld l2fwd l3fwd skeleton timer; do echo "## Building $example" - $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example clean shared static + $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example \ + clean shared static >&$veryverbose done fi